[wp-trac] [WordPress Trac] #56400: Rename is_admin() and related functions for clarity

[WordPress Trac]

#56400: Rename is_admin() and related functions for clarity
----------------------------+-----------------------------
 Reporter:  SergeyBiryukov  |       Owner:  SergeyBiryukov
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:
Component:  Bootstrap/Load  |     Version:
 Severity:  normal          |  Resolution:  wontfix
 Keywords:  2nd-opinion     |     Focuses:
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  2nd-opinion revert => 2nd-opinion
 * status:  accepted => closed
 * resolution:   => wontfix
 * milestone:  6.1 =>


Comment:

 Replying to [comment:22 azaozz]:
 > > I would like to finalize the naming of
 `is_login()`/`is_login_screen()`/`is_login_request()`,
 > > ...
 > > Should we rename it to `is_login()`?
 >
 > My preference there is for `is_login()` only because it matches
 `is_admin()`. The `is_login_request()` is a pretty good choice too, imho.
 It seems a little more descriptive and doesn't seem to have any
 possibility of confusion. I trust your judgement, go with whatever you
 think is best! :)
 >
 > In any case thinking that a better/expanded description in the docblock
 there would be great.

 Thanks! Let's follow up on that in #19898.

 Closing this ticket, for now at least. The `is_super_admin_user()` alias
 can be explored separately.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56400#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform