[wp-trac] [WordPress Trac] #56400: Rename is_admin() and related functions for clarity
WordPress Trac
noreply at wordpress.org
Fri Sep 23 20:50:59 UTC 2022
#56400: Rename is_admin() and related functions for clarity
--------------------------------+-----------------------------
Reporter: SergeyBiryukov | Owner: SergeyBiryukov
Type: enhancement | Status: accepted
Priority: normal | Milestone: 6.1
Component: Bootstrap/Load | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion revert | Focuses:
--------------------------------+-----------------------------
Comment (by azaozz):
Replying to [comment:20 SergeyBiryukov]:
> I'm happy to revert the aliases for now to allow for more discussion, or
even close as `wontfix`
Great, thanks!
> I would like to finalize the naming of
`is_login()`/`is_login_screen()`/`is_login_request()`,
> ...
> Should we rename it to `is_login()`?
My preference there is for `is_login()` only because it matches
`is_admin()`. The `is_login_request()` is a pretty good choice too, imho.
It seems a little more descriptive and doesn't seem to have any
possibility of confusion. Go with whatever you think is best!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56400#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list