[wp-trac] [WordPress Trac] #56468: sanitize_option() does not handle deprecated timezones correctly

[WordPress Trac]

#56468: sanitize_option() does not handle deprecated timezones correctly
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.1
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests commit                                   |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"54230" 54230]:
 {{{
 #!CommitTicketReference repository="" revision="54230"
 Tests: Add tests with deprecated timezone strings.

 This commit adds tests in select places to ensure that these date/time
 related functions continue to behave as expected when the
 `timezone_string` option is set to an outdated/deprecated timezone name.

 The timezone string used in these tests, `America/Buenos_Aires`, is a
 timezone string which was already deprecated in PHP 5.6.20 (the current
 minimum PHP version), so using this timezone string, we can safely test
 the handling of deprecated timezone names on all supported PHP versions.

 See: [https://3v4l.org/Holsr#v5.6.20 timezone_identifiers_list() output
 for PHP 5.6.20].

 Follow-up to [54207], [54217], [54227], [54229].

 Props jrf, costdev.
 See #56468.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56468#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform