[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
WordPress Trac
noreply at wordpress.org
Fri Sep 9 08:14:58 UTC 2022
#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
------------------------------------+-------------------------------
Reporter: hztyfoon | Owner: audrasjb
Type: defect (bug) | Status: closed
Priority: low | Milestone: 6.1
Component: Administration | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback | Focuses: coding-standards
------------------------------------+-------------------------------
Changes (by audrasjb):
* status: reviewing => closed
* resolution: => fixed
Comment:
In [changeset:"54113" 54113]:
{{{
#!CommitTicketReference repository="" revision="54113"
Coding Standards: Clarify time units for various timeout or expiration
values.
This changeset implements a clearer and more consistent
timeout/duration/expiration format. It updates time durations used in
various files, as per WordPress coding standards:
- If the value can be represented as an integer (not a fractional) number
of minutes (hours, etc.), use the appropriate constant (e.g.:
`MINUTE_IN_SECONDS`) multiplied by that number.
- Otherwise, keep the value as is and add a comment with the units for
clarity.
Follow-up to [11823], [13177], [21996], [37747], [53714].
Props hztyfoon, audrasjb, arrasel403, krupalpanchal, GaryJ,
SergeyBiryukov, peterwilsoncc, rudlinkon, costdev, robinwpdeveloper.
Fixes #56293.
See #55647.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list