[wp-trac] [WordPress Trac] #56222: Twenty Twenty-One: Remove spacer block styles

[WordPress Trac]

#56222: Twenty Twenty-One: Remove spacer block styles
---------------------------+---------------------
 Reporter:  poena          |       Owner:  poena
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  6.1
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:
---------------------------+---------------------
Changes (by SergeyBiryukov):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"54103" 54103]:
 {{{
 #!CommitTicketReference repository="" revision="54103"
 Twenty Twenty-One: Remove spacer block styles.

 The theme includes styles for the spacer block for the front which appears
 to be unnecessary:
 * It adds `display: block` even though that is the default.
 * It removes top and bottom margin, even though this is not needed in the
 post content because of collapsing margins between blocks.
 * It uses a custom CSS property to force a specific height on mobile. This
 affects the patterns in the theme negatively.

 It also causes styling problems:
 * When the spacer block has a height set to `0` in the navigation block,
 as the theme forces this to be larger on smaller screens.
 * When the block is horizontal. Horizontal was not an option when this
 style was added.

 Consequences of removal:
 * Removing the use of the custom CSS property will cause a style change
 for websites that have adjusted the spacing property.

 Follow-up to [49216], [49574].

 Props poena, mukesh27.
 Fixes #56222.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56222#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform