[wp-trac] [WordPress Trac] #53705: Plugin upgrade deletes files from other in-progress upgrades
WordPress Trac
noreply at wordpress.org
Tue Sep 6 19:28:50 UTC 2022
#53705: Plugin upgrade deletes files from other in-progress upgrades
--------------------------------+-----------------------------
Reporter: bpayton | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Upgrade/Install | Version: 5.8
Severity: normal | Resolution:
Keywords: needs-testing-info | Focuses:
--------------------------------+-----------------------------
Comment (by bpayton):
this issue still needs reliable reproduction steps
I fear that expecting pure, repeatable reproduction will lead this issue
not being resolved.
This bug involves a race condition, so it is naturally not reproducible in
the way that a pure function yields a consistent result given the same
arguments. To make the results of this bug exactly repeatable, we would
need to control all factors that determine which execution threads win and
lose the races, and we do not typically control those factors at the OS
and network level.
The existing (and certainly imperfect) reproduction instructions are
adequate to demonstrate that this issue is occurring, and others here have
observed plugin corruption when using them.
We have established that plugin corruption is occurring. (per my
experience and @afragen's here ticket:53705#comment:10)
Of course it would be great to be able to consistently reproduce an exact
broken result, but perhaps that is not 100% necessary to address this
problem.
We can reason about what is occurring based on the code, patch with some
fix based on our understanding, and re-run the repro instructions to see
whether corruption disappears. It's not perfect, but perhaps it is a
reasonable compromise.
Is there a reason exact reproducibility is needed here? Is there a reason
we should believe that exact reproducibility is possible in this case?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53705#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list