[wp-trac] [WordPress Trac] #39265: Missing @covers in the comment blocks in PHPUnit tests
WordPress Trac
noreply at wordpress.org
Fri Sep 2 00:11:43 UTC 2022
#39265: Missing @covers in the comment blocks in PHPUnit tests
-------------------------------------------+-----------------------------
Reporter: pbearne | Owner: hellofromTonya
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 6.1
Component: Build/Test Tools | Version: 4.8
Severity: normal | Resolution:
Keywords: php8 has-patch has-unit-tests | Focuses:
-------------------------------------------+-----------------------------
Comment (by SergeyBiryukov):
In [changeset:"54060" 54060]:
{{{
#!CommitTicketReference repository="" revision="54060"
Tests: Add `@coversNothing` tag for PHP polyfill tests in
`phpunit/tests/compat/`.
The `@covers` tags for these tests were previously removed to avoid
notices when generating the code coverage report on PHP versions where
these functions are natively available and not user-defined:
{{{
"@covers ::array_key_first" is invalid
"@covers ::array_key_last" is invalid
"@covers ::hash_hmac" is invalid
"@covers ::is_countable" is invalid
"@covers ::is_iterable" is invalid
"@covers ::mb_strlen" is invalid
"@covers ::mb_substr" is invalid
"@covers ::str_contains" is invalid
"@covers ::str_ends_with" is invalid
"@covers ::str_starts_with" is invalid
}}}
Explicitly including a `@coversNothing` annotation in this case appears to
be a more appropriate option than not including any annotation at all.
Follow-up to [51852], [52038], [52039], [52040], [54049].
See #39265, #55652.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39265#comment:112>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list