[wp-trac] [WordPress Trac] #41463: Improve REST API tests that don't perform any assertions

[WordPress Trac]

#41463: Improve REST API tests that don't perform any assertions
--------------------------------------------+-----------------------------
 Reporter:  johnbillion                     |       Owner:  johnbillion
     Type:  enhancement                     |      Status:  accepted
 Priority:  normal                          |   Milestone:  Future Release
Component:  REST API                        |     Version:  4.7
 Severity:  normal                          |  Resolution:
 Keywords:  needs-unit-tests needs-refresh  |     Focuses:  rest-api
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"54058" 54058]:
 {{{
 #!CommitTicketReference repository="" revision="54058"
 Tests: Explicitly mark empty REST API tests as not performing any
 assertions.

 WordPress core test suite uses PHPUnit's
 `beStrictAboutTestsThatDoNotTestAnything` option set to true, which marks
 a test as risky when no assertions are performed.

 REST API test classes have some empty tests for non-implemented methods
 because these test classes extend the abstract
 `WP_Test_REST_Controller_Testcase` class, which requires several methods
 to be implemented that don't necessarily make sense for all REST API
 routes.

 As these tests are intentionally empty, they were previously marked as
 skipped, so that they are not reported as risky.

 This commit aims to further reduce noise in the test suite and effectively
 ignores these empty tests altogether, which seems like a more appropriate
 option at this time.

 The `@doesNotPerformAssertions` annotation can be reconsidered in the
 future when the tests are either removed as unnecessary or updated to
 actually perform assertions related to their behavior.

 Follow-up to [40534], [41176], [41228], [53921].

 See #40538, #41463, #55652.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41463#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform