[wp-trac] [WordPress Trac] #42066: List tables: consider a new method to generate the views links markup

[WordPress Trac]

#42066: List tables: consider a new method to generate the views links markup
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  costdev
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.1
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests dev-feedback                             |
-------------------------------------------------+-------------------------

Comment (by costdev):

 I've updated the [https://github.com/WordPress/wordpress-develop/pull/2828
 PR 2828] with additional tests for BC as requested by @peterwilsoncc. I
 haven't pushed fixes for [https://github.com/WordPress/wordpress-
 develop/runs/8055672560?check_suite_focus=true the test failures] so that
 these can be reviewed:

 Types of test failure:
 1. Some of the classes use `href=""`, others use `href=''`. This could be
 fixed to `href=""` for all classes for consistency.
 2. `&` is not escaped in the `href`, but is escaped in the PR. The links
 still work, so I think this is an acceptable change and I can update the
 tests to account for it.
 3. For a multisite test, I mistakenly used a local user/superadmin count
 value, rather than getting the actual numbers, so locally it passes and on
 CI it fails. I have a fix for this ready to push once a decision is made
 about the two above types of failure.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42066#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform