[wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1
WordPress Trac
noreply at wordpress.org
Mon Oct 24 17:14:58 UTC 2022
#55652: Test tool and unit test improvements for 6.1
---------------------------------------------+-----------------------
Reporter: hellofromTonya | Owner: (none)
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 6.1
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+-----------------------
Comment (by desrosj):
In [changeset:"54681" 54681]:
{{{
#!CommitTicketReference repository="" revision="54681"
Build/Test Tools: Ensure PHPCS related workflows are properly marked as
failed.
When a ruleset error is encountered during a PHPCodeSniffer scan, an XML
report is not generated and `cs2pr` will exit with a `0`.
In this situation, a workflow run will be marked as passing (even though a
failure has occurred) due to the presence of `continue-on-error`.
This adjusts the logic in the Coding Standards and PHP Compatibility
workflows to remove the need for the `continue-on-error` option and
ensures all failures are accurately reflected within the GitHub Actions
UI.
Follow up to [54371].
Props jrf, TobiasBg.
Merges [54678] to the 6.1 branch.
See #55652.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55652#comment:224>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list