[wp-trac] [WordPress Trac] #56468: sanitize_option() does not handle deprecated timezones correctly

[WordPress Trac]

#56468: sanitize_option() does not handle deprecated timezones correctly
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.1
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by jrf):

 Replying to [comment:31 peterwilsoncc]:
 > I've created PRs for the 5.6 through 6.0 branches backporting [54217].
 Each of the PRs now have passing tests.

 Thanks for setting up these PRs @peterwilsoncc ! I've done a quick visual
 review of each of them and approved them all.


 > The 5.6, 5.7 and 5.8 branches required conflict resolutions so will need
 to be applied manually. I think this was due to the logic preventing the
 tests running on PHP 8.1.

 Actually, looks like it was due to the `public` visibility keyword having
 been added to a number of the test methods involved. All good though.


 > For the legacy branches I think the bug can remain but fixing the tests
 will ease the way for maintenance and security releases.

 Agreed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56468#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform