[wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1

[WordPress Trac]

#55652: Test tool and unit test improvements for 6.1
--------------------------------------+---------------------
 Reporter:  hellofromTonya            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.1
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by jrf):

 Replying to [comment:195 TobiasBg]:
 > @jrf and @desrosj:
 >
 > A note regarding `continue-on-error: true` in [54371], if issues arise:
 >
 > I've recently had issues with that `continue-on-error` (for the exact
 same use case of getting PHPCS output), as this apparently can lead to the
 "job" being marked as "passing" when the "step" however failed, and have
 since instead switched to using `if: success() || failure()` in the step
 that calls `cs2pr`.
 >


 @TobiasBg Could you provide a little more detail about the specific
 situation in which it caused you problems ?

 I mean, I have been using this two-step approach in dozens of projects and
 I have not seen any issues with it yet, so I'd like to understand if the
 issue you ran into applies to the WP workflow or not.

 Also note: `cs2pr` will exit with a non-zero exit code if the input file
 contains errors/warnings/notices. You ''can'' turn that off, but that's
 not being done in these workflows.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55652#comment:196>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform