[wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter (example: WebP output)
WordPress Trac
noreply at wordpress.org
Mon Oct 3 20:48:41 UTC 2022
#54476: Improve image engine detection when output format adjusted with filter
(example: WebP output)
--------------------------------------------+------------------------------
Reporter: adamsilverstein | Owner: adamsilverstein
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.1
Component: Media | Version: 5.8
Severity: normal | Resolution:
Keywords: has-patch needs-testing commit | Focuses:
--------------------------------------------+------------------------------
Comment (by adamsilverstein):
@ironprogrammer - fantastic, thanks for reproducing the testing!
> I still don't have an environment I can test this on, but I can do a
code review tomorrow.
@mikeschroder I couldn't reproduce either, hence the shim [attachment
:"shim-for-testing.diff"] which takes a platform with imagick and GD both
supporting WebP and hacks away support for WebP in Imagick only. You can
use this to simulate the failing environment.
> Is it 54476.4.diff​ that should be reviewed, or the most recent revision
of the PR?
Those should be the same, my preference is for you to review in GitHub -
that way you can leave comments inline directly on the code.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54476#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list