[wp-trac] [WordPress Trac] #54598: Site Health makes downright wrong and dangerous suggestions

[WordPress Trac]

#54598: Site Health makes downright wrong and dangerous suggestions
--------------------------+------------------------------
 Reporter:  peterhoegsg   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Site Health   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by pbiron):

 I won't comment on the `wrong and dangerous suggestions` aspect of this
 ticket.

 I will say, however, that I think that if the site admin has disabled all
 updates (e.g., by `define( 'AUTOMATIC_UPDATER_DISABLED', true );`) then
 the `Background updates are not working as expected` wording would only be
 "correct" if background updates actually happened!

 In such a case, I think wording such as `Background updates have been
 disabled` would be more appropriate for the test label and amend the test
 description to add an explanation of why admins _might_ want to enable
 them.

 I'm fine with the test still reporting it as a critical test
 failure...it's the "not working as expected" part that always bothers me.
 Since core explicitly provides several means for site admins to disable
 updates, then the fact that a site admin uses one of those methods to
 disable updates shouldn't be listed "not working as expected".

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54598#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform