[wp-trac] [WordPress Trac] #57139: Value type mismatch on is_site_meta_supported function

[WordPress Trac]

#57139: Value type mismatch on is_site_meta_supported function
--------------------------------+------------------------------
 Reporter:  lucascarvalhopl     |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:  5.1
 Severity:  minor               |  Resolution:
 Keywords:  reporter-feedback   |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by SergeyBiryukov):

 Introduced in [42836] / #37923.

 Replying to [ticket:57139 lucascarvalhopl]:
 > If for some reason the table was not created at multisite install and
 this functions runs, the function will start to retrieve false every time.

 Looking at the function description:
 > This function checks whether the 'blogmeta' database table exists. The
 result is saved as a setting for the main network, making it essentially a
 global setting. Subsequent requests will refer to this setting instead of
 running the query.
 It seems like this is indeed how it was intended to work.

 I suppose that when the `blogmeta` table is eventually created, the
 `site_meta_supported` network option should be cleared and updated, like
 it's done in [source:tags/6.1.1/src/wp-
 admin/includes/upgrade.php?marks=2434-2436#L2431 upgrade_network()].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57139#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform