[wp-trac] [WordPress Trac] #57052: Revise use of "we" in comments to second person point of view
WordPress Trac
noreply at wordpress.org
Wed Nov 16 22:28:43 UTC 2022
#57052: Revise use of "we" in comments to second person point of view
----------------------------+------------------------------
Reporter: ironprogrammer | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Text Changes | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
----------------------------+------------------------------
Comment (by ironprogrammer):
Thanks, [comment:3 jorbin]:
> Alot of the casual language is very intentional and should not be
removed.
Understood, and I agree. My saying "much too casual" in the PR description
was too euphemistic. So to better describe what I meant, here's an example
where the internal dialog-style may confuse things 😁:
Original ([https://github.com/WordPress/wordpress-
develop/commit/a7c3b23f1c8b8fc1e70120951bbbf54b358e1ae1 introduced]):
{{{
#!php
/*
* We're going to redirect to setup-config.php. While this
shouldn't result
* in an infinite loop, that's a silly thing to assume, don't you
think? If
* we're traveling in circles, our last-ditch effort is "Need more
help?"
*/
}}}
Revised ([https://github.com/WordPress/wordpress-
develop/pull/3593/commits/ba67ff25df66dee2b03fe5a92db1b8052d2dd0f7
ba67ff2]):
{{{
#!php
// Redirect to setup-config.php.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57052#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list