[wp-trac] [WordPress Trac] #56966: Updating plugins with WP6.1 creates .maintenance file and leaves it
WordPress Trac
noreply at wordpress.org
Thu Nov 10 02:38:25 UTC 2022
#56966: Updating plugins with WP6.1 creates .maintenance file and leaves it
-------------------------------------------------+-------------------------
Reporter: jsh4 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.1.1
Component: Upgrade/Install | Version: 6.1
Severity: normal | Resolution:
Keywords: has-testing-info needs-testing | Focuses:
needs-patch dev-feedback |
-------------------------------------------------+-------------------------
Comment (by dd32):
> For those unfamiliar, the aim of #51170 was to make
WP_Filesystem_FTPext::exists() compliant with RFC 959 (CTRL+F NAME LIST
(NLST) for ftp_nlist() - 6.0, LIST (LIST) for ftp_rawlist() - 6.1). The
current implementation, and the above code block, are compliant with RFC
959. The implementation up to WordPress 6.0 was not.
I believe `ftp_nlist()` was previously used here for a reason, because
being compliant with the specs and working with all FTP servers was
impossible. #28013 has some related commits where changing that `exists()`
method caused breakages on other servers.
Personally, I would err on the side of caution and recommend reverting the
changes in #51170 from 6.1.1, perform more testing, and try again in 6.2.
If you want to retain it, and use `-a` you can probably always send it,
https://github.com/wordpress/wordpress-
develop/blob/2dce57706fa56db2e931be853ee036049921884f/src/wp-
admin/includes/class-wp-filesystem-ftpext.php#L711-L725.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56966#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list