[wp-trac] [WordPress Trac] #57042: URL escaping added in 'about.php' file

[WordPress Trac]

#57042: URL escaping added in 'about.php' file
---------------------------+-----------------------------------------------
 Reporter:  monzuralam     |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  6.1.1
Component:  Help/About     |     Version:  6.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  administration, coding-standards
  close                    |
---------------------------+-----------------------------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch close


Comment:

 Changes have been requested on the pull request. But, it looks like it's
 fairly mixed throughout the code base for passing translated URLs through
 `esc_url()`.

 - There are currently 122 instances of `__( 'https://` in Core (excluding
 bundled themes).
 - 24 of them are passed through `esc_url()`.

 My recommended course of action is:
 - Closing this as a `wontfix` as the current code matches the majority of
 occurrences in Core today.
 - Opening a new ticket to confirm the correct way to handle these
 scenarios (which I am assuming will follow the "Core translations are
 trusted" policy)
 - Use that new ticket to correct all instances at once.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57042#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform