[wp-trac] [WordPress Trac] #42474: bulk_edit_posts should honor the show_in_quick_edit property of taxonomies

WordPress Trac noreply at wordpress.org
Fri May 27 15:49:38 UTC 2022


#42474: bulk_edit_posts should honor the show_in_quick_edit property of taxonomies
-----------------------------+-----------------------------
 Reporter:  Chouby           |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  6.1
Component:  Quick/Bulk Edit  |     Version:
 Severity:  normal           |  Resolution:  fixed
 Keywords:  commit           |     Focuses:  performance
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53449" 53449]:
 {{{
 #!CommitTicketReference repository="" revision="53449"
 Quick/Bulk Edit: Check the `show_in_quick_edit` taxonomy property when
 processing the data for bulk edited posts.

 Previously, setting the `show_in_quick_edit` property to `false` removed
 the taxonomy from the inline edit form, but several taxonomy-related
 database queries were still being performed in `bulk_edit_posts()` when
 building the arguments to pass to `wp_update_post()`, even though terms
 were not modified.

 This commit improves performance by avoiding unnecessary database queries
 when `show_in_quick_edit` is `false`, and mirrors a similar check in the
 `get_inline_data()` function.

 Follow-up to [13535], [14580], [31307], [52841], [53368].

 Props Chouby, sabernhardt, costdev, nalininonstopnewsuk, webcommsat,
 marybaum, meher, wparslan, SergeyBiryukov.
 Fixes #42474.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42474#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list