[wp-trac] [WordPress Trac] #55740: Coding standard issues

[WordPress Trac]

#55740: Coding standard issues
----------------------------+-------------------------------
 Reporter:  patelmohip      |       Owner:  (none)
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:  duplicate
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  new => closed
 * resolution:   => duplicate
 * component:  General => Filesystem API
 * milestone:  Awaiting Review =>


Comment:

 Hi there, welcome to WordPress Trac! Thanks for the ticket.

 The FTP classes (`class-ftp.php`, `class-ftp-pure.php`, `class-ftp-
 sockets.php`) can be considered an "adopted" external library which is no
 longer supported upstream, see comment:9:ticket:24780.

 That said, I think we should still minimize changes to them, as they don't
 need to follow WordPress coding standards and are
 [source:tags/5.9.3/phpcs.xml.dist?marks=106#L102 excluded from WPCS
 checks], see comment:8:ticket:45967.

 If that is ever reconsidered, they would need a lot more changes than just
 the two lines in [attachment:"55740.patch"].

 This was previously raised in #45967, let's continue the discussion there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55740#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform