[wp-trac] [WordPress Trac] #55664: WP post embed: missing labels and duplicate IDs

[WordPress Trac]

#55664: WP post embed: missing labels and duplicate IDs
---------------------------------------+----------------------------
 Reporter:  afercia                    |       Owner:  joedolson
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  6.1
Component:  Embeds                     |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------
Description changed by afercia:

Old description:

> The form fields in the sharing dialog of the WordPress post embed aren't
> labeled. Also, when there's more than one WordPress post embed on a page,
> there are duplicate IDs.
>
> To reproduce:
> - Add at least two WordPress post embeds on a page.
> - Click the 'share' icon on both the embeds to reveal the Sharing dialog.
> - Check the URL input field and the HTML textarea aren't labeled: there's
> no associated `<label>` element, no `aria-label` or any other labeling.
> - See the 'WordPress Embed' and 'HTML Embed' tab panels use the same IDs
> on both embeds.
> - See the input field and textarea descriptions use the same IDs on both
> embeds.
>
> These IDs are then used for some `aria-*` attributes e.g. `aria-
> controls`, `aria-describedby` thus referencing different elements with
> the same IDs.
>
> See attached screenshot for reference.

New description:

 The form fields in the sharing dialog of the WordPress post embed aren't
 labeled. Also, when there's more than one WordPress post embed on a page,
 there are duplicate IDs.

 To reproduce:
 - Add a WordPress post embed twice. Add a third embed to another post.
 - Click the 'share' icon on both the embeds to reveal the Sharing dialog.
 - Check the URL input field and the HTML textarea aren't labeled: there's
 no associated `<label>` element, no `aria-label` or any other labeling.
 - See the 'WordPress Embed' and 'HTML Embed' tab panels use the same IDs
 on both embeds.
 - See the input field and textarea descriptions use the same IDs on both
 embeds.

 These IDs are then used for some `aria-*` attributes e.g. `aria-controls`,
 `aria-describedby` thus referencing different elements with the same IDs.

 See attached screenshot for reference.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55664#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform