[wp-trac] [WordPress Trac] #55711: set_time_limit( 300 ); in Class WP_Upgrader causes crashes in PHP8 when hosting disables it

WordPress Trac noreply at wordpress.org
Thu May 12 22:31:57 UTC 2022


#55711: set_time_limit( 300 ); in Class WP_Upgrader causes crashes in PHP8 when
hosting disables it
-----------------------------+------------------------------
 Reporter:  theode           |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  5.9.3
 Severity:  critical         |  Resolution:
 Keywords:  php8             |     Focuses:  administration
-----------------------------+------------------------------

Comment (by costdev):

 @jrf Well actually... I stand corrected 😂. I spend most of my Core dev
 time on PHP 7.4, so that explains my results. It's surprising to me that
 PHP 7.4 returns a different result for `function_exists()`, but that's a
 discussion for another forum.

 I agree that wrapping these checks in a function would be a great addition
 to Core!

 On the name: I wonder, since we're checking `function_exists()` and such,
 would `wp_is_function_available()`, `wp_is_function_callable()` or even
 `wp_is_callable()` be more appropriate?

 Obligatory: `naming is hard`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55711#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list