[wp-trac] [WordPress Trac] #55712: Remove _copy_dir() as originally intended

[WordPress Trac]

#55712: Remove _copy_dir() as originally intended
------------------------------+---------------------
 Reporter:  afragen           |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  6.1
Component:  Upgrade/Install   |     Version:  3.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+---------------------
Changes (by costdev):

 * keywords:  has-patch => has-patch commit
 * version:   => 3.2
 * type:  defect (bug) => enhancement
 * milestone:  Awaiting Review => 6.1


Comment:

 This looks like a clean change.

 Regarding BC:
 - This is a private function marked with `@private`.
 - [https://wpdirectory.net/search/01G2TWQVBE04Z8BW7BG6KB321T Public
 extender usage] shows one instance, which is behind a `function_exists()`
 guard, and in a plugin that is now closed on the repository.


 I added the PR's changes to a local install and was able to upgrade to
 6.0-RC2 without issue. After searching for unit tests for this function,
 it looks like there's none to remove.

 Approved the PR and it looks good for `commit` consideration.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55712#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform