[wp-trac] [WordPress Trac] #55711: set_time_limit( 300 ); in Class WP_Upgrader causes crashes in PHP8 when hosting disables it

[WordPress Trac]

#55711: set_time_limit( 300 ); in Class WP_Upgrader causes crashes in PHP8 when
hosting disables it
-----------------------------+------------------------------
 Reporter:  theode           |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  5.9.3
 Severity:  critical         |  Resolution:
 Keywords:                   |     Focuses:  administration
-----------------------------+------------------------------

Comment (by johnbillion):

 I believe that @-suppressing this call will still cause a fatal with PHP 8
 because it no longer suppresses fatal errors. If it's common for hosts to
 disable this function then the calls need to be wrapped with
 `function_exists( 'set_time_limit' )`. I know WooCommerce for example
 wraps this in its `wc_set_time_limit()` function.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55711#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform