[wp-trac] [WordPress Trac] #55699: posts_join_request filter is broken

WordPress Trac noreply at wordpress.org
Mon May 9 13:35:28 UTC 2022

#55699: posts_join_request filter is broken
 Reporter:  5um17                     |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  6.0
Component:  Query                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:

Comment (by 5um17):

 Replying to [comment:5 SergeyBiryukov]:
 > I don't think we should rename the variable back to `$pieces` though, as
 using a consistent name was the point of [52974]. Just restoring the
 compact call, same as for the `posts_clauses` filter in [53175] would fix
 the issue.

 Thanks @SergeyBiryukov! I renamed the variable because `$clauses` is being
 used two times in the code. And its value is changed after `posts_clauses`

 I can see in 55699.2.diff you have reinitialized the variable which is
 good too. Thanks!

Ticket URL: <https://core.trac.wordpress.org/ticket/55699#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list