[wp-trac] [WordPress Trac] #55693: TinyMCE WordPress plugin contains unnecessary code

[WordPress Trac]

#55693: TinyMCE WordPress plugin contains unnecessary code
-------------------------+------------------------------
 Reporter:  MattyRob     |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  TinyMCE      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------
Changes (by sabernhardt):

 * version:  trunk =>
 * component:  Editor => TinyMCE


Old description:

> I hope I am correct here, I have been tracking through a long trail of
> changes, but...
>
> Changeset 43336 added some line breaks corrects implemented in the case
> that `hasWpautop` evaluated to false.
>
> This seems to have been linked to the
> `gutenberg_disable_editor_settings_wpautop` function in the Gutenberg
> plugin at version 2.7, but is seems this same function was removed in
> Gutenberg 5.2.0.
>
> A shim for this was added and then removed in Gutenberg itself, the
> removal once 4336 was merged to WordPress.
>
> So, my question / issue is, is it time to remove 43336 from the core
> WordPress code?
>
> References to some useful links that support the above are listed below.
>
> https://core.trac.wordpress.org/changeset/43336
> https://core.trac.wordpress.org/ticket/44308
> https://github.com/WordPress/gutenberg/issues/6385
> https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/deprecations.md
> https://github.com/WordPress/gutenberg/pull/7373/files
> https://github.com/WordPress/gutenberg/pull/8832/files

New description:

 I hope I am correct here, I have been tracking through a long trail of
 changes, but...

 Changeset r43336 added some line breaks corrects implemented in the case
 that `hasWpautop` evaluated to false.

 This seems to have been linked to the
 `gutenberg_disable_editor_settings_wpautop` function in the Gutenberg
 plugin at version 2.7, but is seems this same function was removed in
 Gutenberg 5.2.0.

 A shim for this was added and then removed in Gutenberg itself, the
 removal once r43336 was merged to WordPress.

 So, my question / issue is, is it time to remove r43336 from the core
 WordPress code?

 References to some useful links that support the above are listed below.

 - changeset:43336
 - ticket:44308
 - [https://github.com/WordPress/gutenberg/issues/6385 Gutenberg issue
 6385]
 -
 [https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/deprecations.md#520
 Gutenberg 5.2.0 deprecations]
 - [https://github.com/WordPress/gutenberg/pull/7373/files Gutenberg PR
 7373]
 - [https://github.com/WordPress/gutenberg/pull/8832/files Gutenberg PR
 8832]

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55693#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform