[wp-trac] [WordPress Trac] #55575: 6.0 Regression: Duplicate HTML id attribute in Quick/Bulk Edit
WordPress Trac
noreply at wordpress.org
Wed May 4 20:14:36 UTC 2022
#55575: 6.0 Regression: Duplicate HTML id attribute in Quick/Bulk Edit
-----------------------------------------------+---------------------------
Reporter: GregLone | Owner: joedolson
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.0
Component: Quick/Bulk Edit | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-testing-info commit | Focuses:
| accessibility
-----------------------------------------------+---------------------------
Comment (by azaozz):
Replying to [comment:20 peterwilsoncc]:
> With the patch applied, I notice the inline edit form's markup uses
aria-labelledby="quick-edit-legend".
This is some extremely old code, 14-15 years I think. There is something
like a template with `display:none` at the bottom of the page and some js
to copy (clone) half of it, either bulk or quick edit, and insert it as a
new row in the main list table. Then the data is added in that new row,
including classes/IDs.
Originally there were no HTML IDs in that template node, all were added
after cloning the node. As `aria-labelledby` requires IDs, it would be
proper to add them (or replace/fix them) after the cloning, as done in
this patch. The extra `aria-labelledby` are in the template node and not
used/not reachable.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55575#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list