[wp-trac] [WordPress Trac] #46122: Code cleanup on $role_links to follow precedent from 46112

WordPress Trac noreply at wordpress.org
Thu Mar 31 07:34:18 UTC 2022


#46122: Code cleanup on $role_links to follow precedent from 46112
-----------------------------------------+-------------------------------
 Reporter:  garrett-eclipse              |       Owner:  SergeyBiryukov
     Type:  enhancement                  |      Status:  reviewing
 Priority:  normal                       |   Milestone:  6.0
Component:  Users                        |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch close 2nd-opinion  |     Focuses:  coding-standards
-----------------------------------------+-------------------------------
Changes (by costdev):

 * keywords:  has-patch => has-patch close 2nd-opinion


Comment:

 Both of the current patches,
 [https://core.trac.wordpress.org/attachment/ticket/46122/46122.diff
 46122.diff] and
 [https://core.trac.wordpress.org/attachment/ticket/46122/46122.2.diff
 46122.2.diff] no longer apply cleanly against `trunk`.

 In addition, #42066 seeks to standardise the link generation for the
 `get_views()` method in list tables, which may make this ticket obsolete.

 Adding `close` and `2nd-opinion` to see what consensus is on closing this
 ticket in favour of #42066.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46122#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list