[wp-trac] [WordPress Trac] #54939: When a block theme is active, add Site Editor link and notice to the Customizer UI

WordPress Trac noreply at wordpress.org
Tue Mar 29 19:22:46 UTC 2022


#54939: When a block theme is active, add Site Editor link and notice to the
Customizer UI
-------------------------------------------------+-------------------------
 Reporter:  ironprogrammer                       |       Owner:  marybaum
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9.3
Component:  Customize                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch i18n-      |     Focuses:  ui, ui-
  change commit fixed-major                      |  copy
-------------------------------------------------+-------------------------

Comment (by antonvlasenko):

 @audrasjb
 > Links that open a new windows should be announced
 I can create another PR that will remove the `target="_blank"` attribute.
 It seemed logical to me to open this page in a new window.
 Users might want to continue editing their theme after learning about Full
 Site Editing. If the the `target="_blank"` attribute is not used, they
 would need to go to the WordPress admin section again to edit their theme.
 I didn't know such links had to be announced.

 > With `$switch_to_site_editor_label`, the same link is used for both the
 button text and its aria-label
 I don't exactly understand this issue.
 `$switch_to_site_editor_label` contains text that says `Use Site Editor`.
 Is there any issue with having this exact text in 2 different places?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54939#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list