[wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form
WordPress Trac
noreply at wordpress.org
Tue Mar 29 18:40:59 UTC 2022
#35483: Accessibility improvements for the Bulk Edit form
-------------------------------------+-------------------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.0
Component: Quick/Bulk Edit | Version:
Severity: normal | Resolution:
Keywords: has-screenshots title- | Focuses: ui, accessibility,
attribute has-patch 2nd-opinion | javascript
-------------------------------------+-------------------------------------
Changes (by joedolson):
* keywords: has-screenshots title-attribute has-patch needs-testing =>
has-screenshots title-attribute has-patch 2nd-opinion
Comment:
@afercia In the post title source that theTitle pulls, the emoji is an
`<img>` with an alt attribute containing the emoji character. As a result,
calling `.replace( /<.[^<>]*?>/g, '' )` removes the emoji. So I'm not sure
that problem is solved. Is this replacement necessary? If we can assume
that the source is already escaped in PHP, I'm not sure we need to do
this.
Other than that, this looks like it works well to me. I'd appreciate a
second opinion on the necessity of escaping the JS post title; but if we
end up still losing the emoji in the screen reader text, I'd still think
this can be committed.
Everything works well as far as I can see.
Tested in NVDA/Chrome, Jaws/Firefox, Jaws/Edge.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35483#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list