[wp-trac] [WordPress Trac] #55467: WP_REST_Meta_Fields::update_meta_value handles update_metadata return value incorrectly

[WordPress Trac]

#55467: WP_REST_Meta_Fields::update_meta_value handles update_metadata return value
incorrectly
--------------------------------+-----------------------
 Reporter:  wordpressscyt       |       Owner:  (none)
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:
Component:  Options, Meta APIs  |     Version:  5.9
 Severity:  normal              |  Resolution:  invalid
 Keywords:  needs-patch         |     Focuses:  rest-api
--------------------------------+-----------------------
Changes (by TimothyBlynJacobs):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Future Release =>


Comment:

 Hi @wordpressscyt,

 Welcome to trac! Yes, you are correct that `update_metadata` can return
 `false` in those instances which is why we first check whether the stored
 value is equal to the proposed new value before calling the function in
 the previous lines of the `WP_REST_Meta_Fields::update_meta_value` method.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55467#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform