[wp-trac] [WordPress Trac] #55456: Double escaping wp_user-settings
WordPress Trac
noreply at wordpress.org
Sat Mar 26 07:39:00 UTC 2022
#55456: Double escaping wp_user-settings
-------------------------------------------------+-------------------------
Reporter: phatkoala | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.0
Component: Users | Version: 2.7
Severity: normal | Resolution:
Keywords: has-patch dev-feedback has-testing- | Focuses:
info needs-testing |
-------------------------------------------------+-------------------------
Comment (by azouamauriac):
Hi thanks for test report, and thanks @phatkoala for the PR
Replying to [comment:3 costdev]:
> 2. [https://github.com/WordPress/wordpress-develop/pull/2458 PR 2458]
resolves the issue. ✅
He updated the PR, and when I tested it, here is the result:
[https://github.com/WordPress/wordpress-
develop/pull/2458/commits/11713240ed17512f5a792ee9194000bfc2400b72 before
the last PR: ][https://prnt.sc/Bej0-MVvbgSj] ;
[https://github.com/WordPress/wordpress-
develop/pull/2458/commits/11713240ed17512f5a792ee9194000bfc2400b72 after
the last PR ] : [https://prnt.sc/ZZ53foh-Xs3b]; So I think you should use
commit link instead of PR since it can be updated anytime and commiters
can be involved in mistakes. I think it is [https://github.com/WordPress
/wordpress-
develop/pull/2458/commits/3df1812b5e25121e8c45000f0fc7584459c352a2 this
commit] you have tested and agreed(I guess). I tested it too, and it fixes
the bug, but I am not so fan of the way, while I am still thinking about
how to fix it properly, I agree with the commit though.
> 1. Introduced in [8784].
IMO the bug is due to [https://prnt.sc/xNaBmE9cCBQA this line] in this
function
[https://prnt.sc/SZ75h7yPGkum WP_User::__get]
(if you comment [https://prnt.sc/xNaBmE9cCBQA this line] everything will
work fine) introduced in [18597].
Also, just for information, I've made some tests on 4.9.20 version and the
bug is not present there, while it's present in 5.8 where I've done some
tests too.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55456#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list