[wp-trac] [WordPress Trac] #37750: Cropping custom logo should preserve attachment properties
WordPress Trac
noreply at wordpress.org
Wed Mar 23 11:33:19 UTC 2022
#37750: Cropping custom logo should preserve attachment properties
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner: joedolson
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.0
Component: Media | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests has- | Focuses:
screenshots | accessibility
-------------------------------------------------+-------------------------
Comment (by antonvlasenko):
Just FYI: this PR has some breaking changes.
Currently, WordPress always overwrites `Title` and `Description`
properties (with `name` and `url` of the image file respectively) when we
crop an image.
If this PR gets merged, these properties will only be populated
(overwritten) if `Title` and `Description` properties of the original
image are empty.
I'm not sure if that's desired behaviour, but I can't think of a better
implementation.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37750#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list