[wp-trac] [WordPress Trac] #40927: Passing a float as the position in add_menu_page can override other menu items

WordPress Trac noreply at wordpress.org
Tue Mar 22 06:20:17 UTC 2022


#40927: Passing a float as the position in add_menu_page can override other menu
items
-------------------------------------------------+-------------------------
 Reporter:  justinbusa                           |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  6.0
Component:  Administration                       |     Version:  4.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------

Comment (by costdev):

 To clarify:

 The testing and feedback should be for the approach
 [https://core.trac.wordpress.org/attachment/ticket/40927/40927.2.patch
 40927.2.patch] uses to resolve the ticket's issue, as well as
 testing/giving feedback on the change in the `$submenu` sorting algorithm
 to confirm that it doesn't introduce a regression and improves efficiency
 as intended.

 Additionally, as the change to the sorting algorithm isn't strictly part
 of this ticket, this change might be worth committing separately to make
 the history clearer.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40927#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list