[wp-trac] [WordPress Trac] #55428: Improve cache priming in wp_get_nav_menu_items

WordPress Trac noreply at wordpress.org
Tue Mar 22 00:40:05 UTC 2022

#55428: Improve cache priming in wp_get_nav_menu_items
 Reporter:  spacedmonkey  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  6.0
Component:  Menus         |     Version:  3.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
Changes (by peterwilsoncc):

 * milestone:  Awaiting Review => 6.0


 The PR bot missed [https://github.com/WordPress/wordpress-
 develop/pull/2437#pullrequestreview-916529542 my review]. Linked for

 While testing the pull request, I discovered the current priming of the
 term cache misses and each term is queried individually. I've moved this
 to the 6.0 milestone as I think it warrants it for the potential
 performance boost.

 Unit test notes:

 * it would be good to make sure the caches continue to be hit during the
 fetching and rendering of menus. If tests currently exist, I suspect they
 are not testing a render, terms or both but this needs confirming.

 Manual testing notes:

 * REST API endpoint for FSE

Ticket URL: <https://core.trac.wordpress.org/ticket/55428#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list