[wp-trac] [WordPress Trac] #54477: wp-cli vague: "Warning: Could not create directory."

[WordPress Trac]

#54477: wp-cli vague: "Warning: Could not create directory."
----------------------------------------+---------------------
 Reporter:  gunterer                    |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  6.0
Component:  Upgrade/Install             |     Version:  5.8
 Severity:  minor                       |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+---------------------
Changes (by n8finch):

 * type:  enhancement => defect (bug)


Comment:

 @SergeyBiryukov I was testing this and can't replicate it.

 Here's what I did:
 - Changed the permissions on the `wp-plugins` directory to 444.
 - ran `wp plugin install gutenberg --activate` (and I tested several other
 plugins)
 - Got the following:


 {{{
 Installing the plugin...
 Warning: Could not create directory upgrader. "/Users/natefinch/Local
 Sites/wpcli-bug-fix/app/wordpress-develop/src/wp-
 content/plugins/gutenberg/"
 Plugin installation failed.
 Warning: The 'gutenberg' plugin could not be found.
 Error: No plugins installed.
 }}}


 Looking at the code for this particular notification, the directory is
 already in error notification with `$remote_destination`:
 https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/includes/class-wp-upgrader.php#L591

 This is also the case in the other files (wp-admin/includes/file.php and
 wp-admin/includes/update-core.php).

 These were added 8 years ago by Andrew Nacin:
 https://core.trac.wordpress.org/changeset/25780

 Since the error strings already exits with the $filenames, I think this
 ticket can be closed, or perhaps someone else can check it out.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54477#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform