[wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying

WordPress Trac noreply at wordpress.org
Fri Mar 18 18:13:01 UTC 2022

#54548: The Close on Escape "feature" on the admin comments page is annoying
 Reporter:  BettyJJ      |       Owner:  alexstine
     Type:  defect       |      Status:  closed
  (bug)                  |
 Priority:  normal       |   Milestone:  6.0
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:  ui, accessibility, javascript,
                         |  administration
Changes (by davidbaumwald):

 * status:  accepted => closed
 * resolution:   => fixed


 In [changeset:"52951" 52951]:
 #!CommitTicketReference repository="" revision="52951"
 Comments: Disable "close on escape" for inline replies when using an IME.

 When using an Input Method Editor(IME), pressing escape to perform actions
 in the IME is common.  However, if this was done while replying to a
 comment, the "close on escape" feature was also triggered which cleared
 the current textarea and closed it.

 This change checks if an IME is in use by binding the `compositionstart`
 event to the reply text box and setting a flag if it's triggered.  The
 "close on escape" feature will now only be triggered if this new flag is
 not set after typing a reply.

 Props BettyJJ, sabernhardt, alexstine, konradyoast, audrasjb, rafiahmedd,
 Fixes #54548.

Ticket URL: <https://core.trac.wordpress.org/ticket/54548#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list