[wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0

[WordPress Trac]

#55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
----------------------------+---------------------
 Reporter:  peterwilsoncc   |       Owner:  (none)
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  6.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  php80           |     Focuses:
----------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"52946" 52946]:
 {{{
 #!CommitTicketReference repository="" revision="52946"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 admin/includes/class-custom-image-header.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit renames the `$object` variable in `Custom_Image_Header` class
 methods to `$attachment` for clarity and consistency, as the variable type
 is actually an array, and updates the documentation accordingly.

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55327.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform