[wp-trac] [WordPress Trac] #54987: Check if 'user_nicename' is not too long after the 'pre_user_nicename' filter
WordPress Trac
noreply at wordpress.org
Sun Mar 13 20:58:25 UTC 2022
#54987: Check if 'user_nicename' is not too long after the 'pre_user_nicename'
filter
--------------------------------------+----------------------------
Reporter: SergeyBiryukov | Owner: davidbaumwald
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 6.0
Component: Users | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses:
--------------------------------------+----------------------------
Comment (by azouamauriac):
Replying to [comment:10 SergeyBiryukov]:
> * [https://github.com/WordPress/wordpress-develop/pull/2244 PR #2244]
introduces a new check that `$user_nicename` cannot be empty. I think this
would be better discussed in a separate ticket.
I don't think this worth another ticket, there is already a control above
to make sure the nicename won't be empty
[[Image(https://prnt.sc/B6DCuHPqSNDh)]]
> For this ticket, I was thinking of just moving the existing check after
the filter, like in [attachment:"54987.2.diff"].
Agree. This LGTM.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54987#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list