[wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file

WordPress Trac noreply at wordpress.org
Sun Mar 13 01:00:08 UTC 2022


#55338: Twenty Eleven: Invalid use of display and float together in style.css file
-------------------------------------------+---------------------
 Reporter:  kajalgohel                     |       Owner:  (none)
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  6.0
Component:  Bundled Theme                  |     Version:  3.2
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch needs-testing close  |     Focuses:  css
-------------------------------------------+---------------------

Comment (by sabernhardt):

 I lean toward closing, or at least I recommend against committing my
 earlier patch.

 The [https://jigsaw.w3.org/css-
 validator/validator?uri=https%3A%2F%2Fs0.wp.com%2Fwp-
 content%2Fthemes%2Fpub%2Ftwentyeleven%2Fstyle.css W3C CSS Validator] only
 labels the negative padding (#46771) and the `device-width` entries as
 errors, and the float/display combination does not appear in the warnings
 list either.

 Both [https://www.cssportal.com/css-validator/ CSS Portal] and
 [https://codebeautify.org/cssvalidate Code Beautify] alert about the
 floating under the message "Require properties appropriate for display"
 (one identifies it as an error, the other calls it a warning).

 I took another look at 55338.2.patch. As long as the vertical alignment is
 set, removing the float and reducing the width might be worth considering.
 Without floating, the two `inline-block` elements can have a slight space
 between them that is not always there on smaller screens (depending on
 content).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55338#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list