[wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying

WordPress Trac noreply at wordpress.org
Fri Mar 11 14:43:03 UTC 2022


#54548: The Close on Escape "feature" on the admin comments page is annoying
-------------------------+-------------------------------------------------
 Reporter:  BettyJJ      |       Owner:  alexstine
     Type:  defect       |      Status:  accepted
  (bug)                  |
 Priority:  normal       |   Milestone:  6.0
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, accessibility, javascript,
                         |  administration
-------------------------+-------------------------------------------------

Comment (by afercia):

 @BettyJJ thank you for testing, much appreciated.

 I was able to so some testing on macOS. Interestingly, seems to me the IME
 user interface reacts to keyboard events differently depending on the
 language. See the animated GIF attached below.

 Please consider I have no idea what I'm actually typing while using the
 IME :) I'm just trying to use it for testing purposes.

 Japanese:
 - The first Escape key does NOT close the comment textarea.
 - At that point, `isComposing` is still true.

 Chinese:
 - The first Escape key DOES close the comment textarea.
 - At that point, `isComposing` is false.

 More inconsistencies may occur across browsers and operating systems.
 Basically, detecting the start of a composition seems reliable. Instead,
 determining whether a `keyup` event on the Escape key happens before or
 after the composition end appears to be highly unreliable.

 Given the above, I'd tend to think the most sensible thing to do is to
 disable the 'Close on Escape' behavior when an IME is in use. Will upload
 a patch shortly. Any feedback and thoughts are very welcome.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54548#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list