[wp-trac] [WordPress Trac] #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data

WordPress Trac noreply at wordpress.org
Thu Mar 10 18:20:49 UTC 2022


#42916: Terms for taxonomy with show_in_quick_edit = false still load in inline
data
-------------------------------------+-----------------------------
 Reporter:  jazbek                   |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  6.0
Component:  Quick/Bulk Edit          |     Version:  4.9.1
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52841" 52841]:
 {{{
 #!CommitTicketReference repository="" revision="52841"
 Quick/Bulk Edit: Check the `show_in_quick_edit` taxonomy property when
 populating the data for the posts list table.

 Previously, setting the `show_in_quick_edit` property to `false` removed
 the taxonomy from the inline edit form, but the terms were still being
 populated in the data for each table row via the `get_inline_data()`
 function, which only checked the `$taxonomy->show_ui` property.

 This commit:
 * Improves performance by ensuring that taxonomy terms are not
 unnecessarily populated for each table row when `show_in_quick_edit` is
 `false`.
 * Properly populates the taxonomy terms when `show_in_quick_edit` is
 `true` and `show_ui` is `false`.

 Follow-up to [31307].

 Props jazbek, figureone, sabernhardt, ovidiul, webcommsat, SergeyBiryukov.
 Fixes #42916, #49701.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42916#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list