[wp-trac] [WordPress Trac] #53705: Plugin upgrade deletes files from other in-progress upgrades

[WordPress Trac]

#53705: Plugin upgrade deletes files from other in-progress upgrades
-----------------------------+---------------------
 Reporter:  bpayton          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  Upgrade/Install  |     Version:  5.8
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+---------------------

Comment (by bpayton):

 @peterwilsoncc yes, the patch was tested in production on a kind of
 standalone WP.com site (separate from the large multisite instance run by
 WP.com). The standalone sites, basically core WP plus a number of platform
 mu-plugins, are where we were seeing this issue. With the patch applied,
 we no longer experienced this issue, but because we prefer to run
 unaltered WP core releases, we did not apply the patch to all sites in
 production.

 In the meantime, we were able to reduce this issue enough to live with it.
 It is a core issue but was greatly exacerbated by Jetpack making
 concurrent plugin update attempts. Those attempts could conflict with
 other Jetpack-driven plugin update attempts or core auto update attempts.
 We addressed this by updating Jetpack to share WP's `auto_updater` lock
 and adding some other Jetpack-specific locking to avoid conflicts.

 This evening, I reran
 [https://core.trac.wordpress.org/ticket/53705#comment:7 the repro
 instructions] after you messaged and still encountered the errors
 mentioned in this ticket. After applying the patch, repeatedly rerunning
 the repro instructions yielded none of the errors.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53705#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform