[wp-trac] [WordPress Trac] #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data

[WordPress Trac]

#42916: Terms for taxonomy with show_in_quick_edit = false still load in inline
data
-------------------------------------+--------------------------
 Reporter:  jazbek                   |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  6.0
Component:  Quick/Bulk Edit          |     Version:  4.9.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+--------------------------
Description changed by SergeyBiryukov:

Old description:

> The show_in_quick_edit property was introduced for taxonomies in 4.2 with
> changeset:
>
> https://core.trac.wordpress.org/changeset/31307
>
> This changeset removed the taxonomy from the inline edit form, but the
> terms for the taxonomy are still being populated in the data for each row
> via the `get_inline_data()` function, which only respects
> `$taxonomy->show_ui`.
>
> One reason people may want to remove a taxonomy from quick edit is for
> performance reasons, when the number of terms fore each post are huge.
> However, the terms are still being loaded, and the page can take a huge
> performance hit.
>
> For example, I have a custom post type where each one is assigned
> thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to
> false on the taxonomy, but the post listing was still loading very slow.
> I looked at the source code, and saw thousands of zip codes being
> rendered in a hidden div on each row.

New description:

 The show_in_quick_edit property was introduced for taxonomies in 4.2 with
 changeset: [31307].

 This changeset removed the taxonomy from the inline edit form, but the
 terms for the taxonomy are still being populated in the data for each row
 via the `get_inline_data()` function, which only respects
 `$taxonomy->show_ui`.

 One reason people may want to remove a taxonomy from quick edit is for
 performance reasons, when the number of terms fore each post are huge.
 However, the terms are still being loaded, and the page can take a huge
 performance hit.

 For example, I have a custom post type where each one is assigned
 thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to
 false on the taxonomy, but the post listing was still loading very slow. I
 looked at the source code, and saw thousands of zip codes being rendered
 in a hidden div on each row.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42916#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform