[wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally

WordPress Trac noreply at wordpress.org
Mon Mar 7 00:15:01 UTC 2022


#36949: Term exists should use get_terms internally
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.0
Component:  Taxonomy                             |     Version:  2.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note needs-testing                             |  performance
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch has-unit-tests needs-dev-note => has-patch has-unit-
     tests needs-dev-note needs-testing


Comment:

 Replying to [comment:29 spacedmonkey]:
 > Thanks @peterwilsoncc . It is was a good spot. I have refactor the patch
 to remove usage of `get_term` and now everything uses `get_terms`. Unit
 tests are passing now

 Thanks, both for the updated code and taking my push of a broken test to
 your branch in the spirit intended.

 The code looks good to me, I've added the needs-testing keyword on this in
 the hope some of the testing folk can take a look at your branch before
 committing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36949#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list