[wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter

WordPress Trac noreply at wordpress.org
Thu Mar 3 00:54:38 UTC 2022

#54379: `get_comment_ID()` can cause a notice within the `comment_text` filter
 Reporter:  dd32                     |       Owner:  davidbaumwald
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  6.0
Component:  Comments                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
Changes (by davidbaumwald):

 * keywords:  has-patch => has-patch needs-refresh


 @dd32 After [52205], the
 54379.2.diff] doesn't apply cleanly.

 More importantly, the inline docs there were updated to have the
 `$comment_ID` param to expect a `string`.  Should this be corrected back
 to `int` while also casting the `$comment_ID` to an `(int)`?

 Is it your preference to handle the other related notices here as well, or
 should those be split off into separate tickets?

Ticket URL: <https://core.trac.wordpress.org/ticket/54379#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list