From noreply at wordpress.org Tue Mar 1 01:47:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 01:47:18 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) Message-ID: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+----------------------------- Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Keywords: Focuses: ui | -------------------------+----------------------------- Hey guys, we recently added oembed / embedly support but odysee.com links don’t work properly due to the iframe settings you are pulling in. Can they be setup to match youtube? Either need to remove the allow- scripts, or add: sandbox=’allow-scripts allow-same-origin allow-popups allow-presentation’ Example: https://tomzarebczan.wordpress.com/2022/02/28/test-odysee-post/ – you’ll see the errors in console. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 04:40:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 04:40:24 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html Message-ID: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+----------------------------- Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Keywords: Focuses: | --------------------------+----------------------------- In 5.9.0 this does not happen, however in 5.9.1 a bazillion in the html. With each refresh more are added. Logged in or not logged in. With zero plugins. [[Image()]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 04:40:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 04:40:41 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html In-Reply-To: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> References: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> Message-ID: <066.178389f17db9816f9040f8c163010ba2@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+------------------------------ Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by carasmo): * Attachment "Screen Shot 2022-02-28 at 11.17.39 PM.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 04:57:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 04:57:35 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html In-Reply-To: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> References: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> Message-ID: <066.d4ee56b9b803fe62f75bd47d430af5fc@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+------------------------------ Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by carasmo): * status: new => closed * resolution: => invalid -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 04:58:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 04:58:24 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html In-Reply-To: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> References: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> Message-ID: <066.c87a0328a31661ab2e61ff8a99a0b05a@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+------------------------------ Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Comment (by carasmo): It's Genesis framework. I have just checked with the 2022 theme and this bug is not there but as soon as I change the active theme to the Genesis parent theme, it's there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 05:41:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 05:41:20 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html In-Reply-To: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> References: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> Message-ID: <066.04aa390917841ab4ec93f33106eee175@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+------------------------------ Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Comment (by carasmo): Hopefully WPEngine/StudioPress will correct this. In my child theme functions I've added the following to correct this: `//Fixes 5.9.1 bug in Genesis` `remove_filter( 'render_block', 'wp_render_layout_support_flag', 10, 2 );` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 09:23:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 09:23:07 -0000 Subject: [wp-trac] [WordPress Trac] #52202: Block Editor interprets German gendering asterix as list sign In-Reply-To: <055.54edda8158c76777dd7f6b160779b860@wordpress.org> References: <055.54edda8158c76777dd7f6b160779b860@wordpress.org> Message-ID: <070.b8025980d6add0259810389665a10ff5@wordpress.org> #52202: Block Editor interprets German gendering asterix as list sign --------------------------+------------------------------ Reporter: pflanzenoma | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.6 Severity: normal | Resolution: worksforme Keywords: | Focuses: --------------------------+------------------------------ Changes (by zodiac1978): * status: new => closed * resolution: => worksforme Comment: Hi @pflanzenoma thank you for the report! I tried to reproduce the problem, but with the latest WordPress 5.9 I can't see it. I tried to paste the word and I tried to manually type it. I even tried it with a space before or after the asterisk and the block editor does not make a list out of it. If the problem is still valid for you, please re-open the ticket and share more details on how to reproduce the problem. Thank you again! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 09:30:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 09:30:26 -0000 Subject: [wp-trac] [WordPress Trac] #55280: Unsupported operand types in Site Health Message-ID: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> #55280: Unsupported operand types in Site Health ---------------------------------------+----------------------------- Reporter: lw5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.1 Severity: normal | Keywords: Focuses: administration, multisite | ---------------------------------------+----------------------------- I get the following error: AH01071: Got error 'PHP message: PHP Fatal error: Uncaught TypeError: Unsupported operand types: string - int in [..]/wp-admin/includes/class- wp-site-health.php:2521 Stack trace: 0 [..]/wp-admin/includes/class-wp-site-health.php(1728): WP_Site_Health->has_missed_cron() 1 [..]/wp-admin/includes/class-wp-site-health.php(192): WP_Site_Health->get_test_scheduled_events() 2 [..]/wp-admin/includes/class-wp-site-health.php(137): WP_Site_Health->perform_test() 3 [..]/wp-includes/class-wp-hook.php(307): WP_Site_Health->enqueue_scripts() 4 [..]/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters() 5 [..]/wp-includes/plugin.php(474): WP_Hook->do_action() 6 [..]/wp-admin/admin-header....', referer: https://[..]/wp-admin/ This is on a WordPress 5.9.1 multisite running on PHP 8.0.13 which was just upgraded from WP 5.5.8/PHP 7.3.33. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 09:54:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 09:54:24 -0000 Subject: [wp-trac] [WordPress Trac] #55280: Unsupported operand types in Site Health In-Reply-To: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> References: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> Message-ID: <062.929cf22c4b95973e130fe26e4bb2ee2b@wordpress.org> #55280: Unsupported operand types in Site Health --------------------------+---------------------------------------- Reporter: lw5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: administration, multisite --------------------------+---------------------------------------- Description changed by SergeyBiryukov: Old description: > I get the following error: > > AH01071: Got error 'PHP message: PHP Fatal error: Uncaught TypeError: > Unsupported operand types: string - int in [..]/wp-admin/includes/class- > wp-site-health.php:2521 > Stack trace: > 0 [..]/wp-admin/includes/class-wp-site-health.php(1728): > WP_Site_Health->has_missed_cron() > 1 [..]/wp-admin/includes/class-wp-site-health.php(192): > WP_Site_Health->get_test_scheduled_events() > 2 [..]/wp-admin/includes/class-wp-site-health.php(137): > WP_Site_Health->perform_test() > 3 [..]/wp-includes/class-wp-hook.php(307): > WP_Site_Health->enqueue_scripts() > 4 [..]/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters() > 5 [..]/wp-includes/plugin.php(474): WP_Hook->do_action() > 6 [..]/wp-admin/admin-header....', referer: https://[..]/wp-admin/ > > This is on a WordPress 5.9.1 multisite running on PHP 8.0.13 which was > just upgraded from WP 5.5.8/PHP 7.3.33. New description: I get the following error: {{{ AH01071: Got error 'PHP message: PHP Fatal error: Uncaught TypeError: Unsupported operand types: string - int in [..]/wp-admin/includes/class- wp-site-health.php:2521 Stack trace: 0 [..]/wp-admin/includes/class-wp-site-health.php(1728): WP_Site_Health->has_missed_cron() 1 [..]/wp-admin/includes/class-wp-site-health.php(192): WP_Site_Health->get_test_scheduled_events() 2 [..]/wp-admin/includes/class-wp-site-health.php(137): WP_Site_Health->perform_test() 3 [..]/wp-includes/class-wp-hook.php(307): WP_Site_Health->enqueue_scripts() 4 [..]/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters() 5 [..]/wp-includes/plugin.php(474): WP_Hook->do_action() 6 [..]/wp-admin/admin-header....', referer: https://[..]/wp-admin/ }}} This is on a WordPress 5.9.1 multisite running on PHP 8.0.13 which was just upgraded from WP 5.5.8/PHP 7.3.33. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 09:57:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 09:57:22 -0000 Subject: [wp-trac] [WordPress Trac] #55279: 5.9.1 introduced bug of numerious in html In-Reply-To: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> References: <051.e745794decbe73c1c916cff9612f5a6e@wordpress.org> Message-ID: <066.a4578152ca4bad003664d3bba748464a@wordpress.org> #55279: 5.9.1 introduced bug of numerious in html --------------------------+---------------------- Reporter: carasmo | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.1 Severity: major | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the follow-up! Glad you were able to identify and resolve the issue. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:08:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:08:37 -0000 Subject: [wp-trac] [WordPress Trac] #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity Message-ID: <054.2cd3b060f536076375e187aa82fd077d@wordpress.org> #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity ---------------------------+----------------------------------------- Reporter: orkunaybek | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.1 Severity: normal | Keywords: has-screenshots needs-patch Focuses: css | ---------------------------+----------------------------------------- There is a css selector that selects almost any a tags and applies white background on focus. This forces users to use at least 4 classes on elements to override by specificity and complicate the code. You can see mentioned selector and how it overrides the focus color of a button with 3 classes already in attached screenshots. Why such strong selector is used there, is it really necessary, can we remove it or decrease the specificity? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:09:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:09:13 -0000 Subject: [wp-trac] [WordPress Trac] #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity In-Reply-To: <054.2cd3b060f536076375e187aa82fd077d@wordpress.org> References: <054.2cd3b060f536076375e187aa82fd077d@wordpress.org> Message-ID: <069.231d570055300a704159c0185c5be7e4@wordpress.org> #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity -----------------------------------------+------------------------------ Reporter: orkunaybek | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: css -----------------------------------------+------------------------------ Changes (by orkunaybek): * Attachment "selector.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:09:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:09:21 -0000 Subject: [wp-trac] [WordPress Trac] #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity In-Reply-To: <054.2cd3b060f536076375e187aa82fd077d@wordpress.org> References: <054.2cd3b060f536076375e187aa82fd077d@wordpress.org> Message-ID: <069.50edcf7ed3d3cebed76548019a95104a@wordpress.org> #55281: Twenty Twenty One Theme: Consider decreasing the selector specificity -----------------------------------------+------------------------------ Reporter: orkunaybek | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: css -----------------------------------------+------------------------------ Changes (by orkunaybek): * Attachment "effect.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:36:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:36:50 -0000 Subject: [wp-trac] [WordPress Trac] #55282: Block Theme "Customize" and "Widgets" Menus have same $position Message-ID: <057.2189dcb1e78138c428cb708433c5cd90@wordpress.org> #55282: Block Theme "Customize" and "Widgets" Menus have same $position ----------------------------+----------------------------- Reporter: domainsupport | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Keywords: Focuses: administration | ----------------------------+----------------------------- Hello, On line 221 of **/wp-admin/menu.php** the "Customize" admin menu item is added if a plugin or theme is using **customize_register** hook ... {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:38:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:38:07 -0000 Subject: [wp-trac] [WordPress Trac] #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." In-Reply-To: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> References: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> Message-ID: <069.f14dfe08c3500c1b726cd06a9701f13e@wordpress.org> #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." --------------------------+----------------------- Reporter: webtechIMT | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Taxonomy | Version: 5.6 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+----------------------- Changes (by webtechIMT): * status: closed => reopened * resolution: duplicate => Comment: Hello, I still have the bug... No one is answering to #46297. Is there anybody out there ? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 10:57:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 10:57:24 -0000 Subject: [wp-trac] [WordPress Trac] #55283: Text not aligned properly in the mobile view Message-ID: <052.59dd929e29ac220c37e9249958cab8d0@wordpress.org> #55283: Text not aligned properly in the mobile view -------------------------+------------------------------------------------- Reporter: hilayt24 | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: needs-patch needs-design-feedback Focuses: ui, css | has-screenshots -------------------------+------------------------------------------------- The button text in the menu is not properly aligned in the smaller screens till 353px. Link to the issue: https://www.awesomescreenshot.com/image/23201555?key=8558a9d0ff72e5fab0e7a5428c4f270d -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 11:14:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 11:14:14 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue Message-ID: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> #55284: thumbnails issue ---------------------------------+----------------------------- Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 5.9.1 Severity: major | Keywords: Focuses: | ---------------------------------+----------------------------- After updating to the latest version of wordpress, the space between elements in the frontend is not respected. For example, the thumbnails of image galleries created with WordPress blocks are aligned abnormally, spaces are not respected. See Attachment. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 11:14:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 11:14:32 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.290b6e894a9c8d89b8f818fe9fdeaad5@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------------+------------------------------ Changes (by simobenedettidesign): * Attachment "Cattura.JPG" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 11:19:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 11:19:28 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.b60114103674e7134906a5e5f403bcf2@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------------+------------------------------ Comment (by hilayt24): Hi @simobenedettidesign, Can you please provide information regarding the enviorment in which this is appearing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 12:40:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 12:40:41 -0000 Subject: [wp-trac] [WordPress Trac] #55248: Ajax call has stop to work (single custom post content) In-Reply-To: <049.42f2c3f83990a87a3534d4e78e944cf2@wordpress.org> References: <049.42f2c3f83990a87a3534d4e78e944cf2@wordpress.org> Message-ID: <064.1a7be8d277ac85cb541da34ed07279eb@wordpress.org> #55248: Ajax call has stop to work (single custom post content) -------------------------------+------------------------------ Reporter: zak87 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Comment (by zak87): *Update I have fixed this (fixed my code - it can be closed). But the point is: I am using from WP 5.2 in all my themes this line of code: {{{ wp_body_open(); }}} but it looks like it has not working at all until WP 5.9.1. I will try to explain. I hade in the theme a Ajax call which was calling a full single (single- portfolio.php) page (header + content + footer) and than I have used jQuery to get just some content from that full/whole page. And all that was working until WP 5.9. Now, with latest update 5.9.1 that code has stop to work because of: {{{ wp_body_open(); }}} because I am calling/getting a full page (with header and footer - wrong way to do that). That has been fixed by calling/getting just a content part (without header/footer). So, it looks like the **wp_body_open();** has not been working correctly until WP 5.9.1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 12:55:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 12:55:37 -0000 Subject: [wp-trac] [WordPress Trac] #55282: Block Theme "Customize" and "Widgets" Menus have same $position In-Reply-To: <057.2189dcb1e78138c428cb708433c5cd90@wordpress.org> References: <057.2189dcb1e78138c428cb708433c5cd90@wordpress.org> Message-ID: <072.89bbd69a457403e255f80d94de958e64@wordpress.org> #55282: Block Theme "Customize" and "Widgets" Menus have same $position ----------------------------+------------------------------ Reporter: domainsupport | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Administration | Version: trunk Severity: normal | Resolution: duplicate Keywords: | Focuses: administration ----------------------------+------------------------------ Changes (by azouamauriac): * status: new => closed * resolution: => duplicate Comment: Duplicate of #54916. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 12:56:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 12:56:08 -0000 Subject: [wp-trac] [WordPress Trac] #51585: Make beta & RC releases available in Github In-Reply-To: <052.8470f79b374e5543a7a93fb2379d5123@wordpress.org> References: <052.8470f79b374e5543a7a93fb2379d5123@wordpress.org> Message-ID: <067.2d281d82e601d7628c360faebb07722e@wordpress.org> #51585: Make beta & RC releases available in Github -----------------------------+------------------------------ Reporter: malthert | Owner: (none) Type: feature request | Status: reopened Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by malthert): @priethor as release coordinator for 6.0, could you make this happen (starting with Beta 1 of 6.0)? I guess that there are some internal docs (since releases get tagged just fine), so we'd just need to amend them - to ensure that beta/RC releases are tagged the same way that releases are tagged. If these guidelines are public and open to contribution I'd do that myself, I just couldn't find anything anywhere. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:00:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:00:44 -0000 Subject: [wp-trac] [WordPress Trac] #55280: Unsupported operand types in Site Health In-Reply-To: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> References: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> Message-ID: <062.f1065420e6b4648ebd6762570266b0e0@wordpress.org> #55280: Unsupported operand types in Site Health -------------------------------+---------------------------------------- Reporter: lw5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: administration, multisite -------------------------------+---------------------------------------- Changes (by azouamauriac): * keywords: => reporter-feedback Comment: Hello there, welcome to WordPress trac and thanks for the report. Please can you confirm the issue when you downgrade PHP version under 8? Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:07:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:07:15 -0000 Subject: [wp-trac] [WordPress Trac] #55280: Unsupported operand types in Site Health In-Reply-To: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> References: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> Message-ID: <062.335e055d1bbe4c1595f8b17c1ab76f79@wordpress.org> #55280: Unsupported operand types in Site Health -------------------------------+---------------------------------------- Reporter: lw5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: administration, multisite -------------------------------+---------------------------------------- Comment (by lw5): When I downgrade the issue turn into a warning: {{{ Warning: A non-numeric value encountered in [..]/wp-admin/includes/class- wp-site-health.php on line 2521 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:21:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:21:40 -0000 Subject: [wp-trac] [WordPress Trac] #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed In-Reply-To: <058.658784bbdb049263899782fed472c729@wordpress.org> References: <058.658784bbdb049263899782fed472c729@wordpress.org> Message-ID: <073.481b3b7a14e565667c1cddb09d290a59@wordpress.org> #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed ----------------------------+--------------------- Reporter: helgatheviking | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: ----------------------------+--------------------- Changes (by pavanpatil1): * Attachment "55219.diff" added. Created patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:22:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:22:42 -0000 Subject: [wp-trac] [WordPress Trac] #55285: Add image brakes page Message-ID: <049.56dc316bdc3e69cacadbbad114d908f2@wordpress.org> #55285: Add image brakes page --------------------------+----------------------------- Reporter: Gugan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: blocker | Keywords: Focuses: | --------------------------+----------------------------- Hello there, i've problems with adding images using the default block and acf add image functions. After clicking no modal appears anche the page brokes and i have to reload the page. I did a downgrade to 5.9.0 and everything works greate. Hope this helps -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:23:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:23:14 -0000 Subject: [wp-trac] [WordPress Trac] #55285: Add image brakes page In-Reply-To: <049.56dc316bdc3e69cacadbbad114d908f2@wordpress.org> References: <049.56dc316bdc3e69cacadbbad114d908f2@wordpress.org> Message-ID: <064.e7fa28797230af3b3b4cfa7ccf1497d6@wordpress.org> #55285: Add image brakes page --------------------------+------------------------------ Reporter: Gugan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: blocker | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by Gugan): * Attachment "Screenshot 2022-03-01 at 14-21-51 Modifica pagina “Test Pagina Marco” ‹ Playground - Stage & Learn — WordPress.png" added. broken backend after clic to add image button -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:24:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:24:17 -0000 Subject: [wp-trac] [WordPress Trac] #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed In-Reply-To: <058.658784bbdb049263899782fed472c729@wordpress.org> References: <058.658784bbdb049263899782fed472c729@wordpress.org> Message-ID: <073.f403cbd72a82e6c4c128eb1318063ab1@wordpress.org> #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed ----------------------------+---------------------- Reporter: helgatheviking | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: ----------------------------+---------------------- Changes (by pavanpatil1): * keywords: needs-patch => has-patch * status: new => closed * resolution: => invalid -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:25:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:25:25 -0000 Subject: [wp-trac] [WordPress Trac] #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed In-Reply-To: <058.658784bbdb049263899782fed472c729@wordpress.org> References: <058.658784bbdb049263899782fed472c729@wordpress.org> Message-ID: <073.0f1437a21b0cae65663467e8bf8974ee@wordpress.org> #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed ----------------------------+----------------------- Reporter: helgatheviking | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------- Changes (by pavanpatil1): * status: closed => reopened * resolution: invalid => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 13:39:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 13:39:58 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.32897dab624447fb64fb9ac67e67fd87@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Post Thumbnails | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------------+------------------------------ Comment (by simobenedettidesign): Replying to [comment:1 hilayt24]: > Hi @simobenedettidesign, Can you please provide information regarding the enviorment in which this is appearing. Server Architecture Linux 3.10.0-862.2.3.el7.x86_64 x86_64 Server web Apache PHP Version 8.0.15 Do you need more information? Thanks -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:04:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:04:38 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.4c0b3740989080d1b15cc20eda19be77@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. -----------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early | Focuses: coding-standards -----------------------------+------------------------------- Changes (by johnregan3): * Attachment "54673-1.diff" added. Updated to fix merge conflicts -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:07:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:07:53 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.3aa444e161d07ddbe8e2a2edd523ad1c@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. -----------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early | Focuses: coding-standards -----------------------------+------------------------------- Changes (by johnregan3): * Attachment "54673-2.diff" added. Removed errant personal .gitignore changes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:09:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:09:59 -0000 Subject: [wp-trac] [WordPress Trac] #54775: Allow int/float for esc_ functions In-Reply-To: <052.d31d6f3ef2ab6e369a064d261311e94a@wordpress.org> References: <052.d31d6f3ef2ab6e369a064d261311e94a@wordpress.org> Message-ID: <067.65035c40aeafa753b6182af894583637@wordpress.org> #54775: Allow int/float for esc_ functions -------------------------+------------------------------- Reporter: malthert | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: Severity: normal | Resolution: Keywords: close | Focuses: coding-standards -------------------------+------------------------------- Comment (by chesio): > The type is not unknown, the type is int/float. In fact esc_html will convert those to string anyway. If you know that something is int/float, why would you want to pass it through `esc_html`? Escaping int/float values does not make any sense. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:17:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:17:49 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords Message-ID: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> #55286: Rest Cannot Create Application Passwords ----------------------------+----------------------------- Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Keywords: Focuses: docs, rest-api | ----------------------------+----------------------------- Hi! When an api call is made to create an application password, the response is: {{{ { "code": "rest_cannot_create_application_passwords", "message": "Sorry, you are not allowed to create application passwords for this user.", "data": { "status": 401 } } }}} Api call: https://example.com/wp-json/wp/v2/users/1/application-passwords?name=test The problem is in the file: /wp-includes/rest-api/endpoints/class-wp-rest-application-passwords- controller.php line 119 method "get_items_permissions_check" before this line the $user variable has all the information about the user but when the function "current_user_can" is called, another function "wp_get_current_user" retrieves the current user from the global variable $current_user, and is empty. Consequently, a non-existent user is assigned or created, different from the admin user, who has all the permissions to make the request to the api. Regards Note: WordPress Version 5.9.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:18:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:18:55 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords In-Reply-To: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> References: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> Message-ID: <067.dab5dbb0909cfddbcb5cedfd624f03b5@wordpress.org> #55286: Rest Cannot Create Application Passwords --------------------------+------------------------------ Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: docs, rest-api --------------------------+------------------------------ Changes (by gonza.ar): * Attachment "Imagen_1_3_22_11_15_pegada.jpg" added. Position when is using the global current user and not the user that is in the url -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:19:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:19:28 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords In-Reply-To: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> References: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> Message-ID: <067.773332df8f21405f600bae9bf33eaeda@wordpress.org> #55286: Rest Cannot Create Application Passwords --------------------------+------------------------------ Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: docs, rest-api --------------------------+------------------------------ Changes (by gonza.ar): * Attachment "Imagen_1_3_22_11_13_pegada.jpg" added. Here the user is assigned to the variable -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 14:20:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 14:20:48 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords In-Reply-To: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> References: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> Message-ID: <067.6e4fa72bfe56acd65fd2c5d6f97bbb98@wordpress.org> #55286: Rest Cannot Create Application Passwords --------------------------+------------------------------ Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: docs, rest-api --------------------------+------------------------------ Changes (by gonza.ar): * Attachment "Imagen_1_3_22_11_14_pegada.jpg" added. Here is when makes the validation if the admin user (insider args) has capabilities, but inside the destination function another variable is used -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:21:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:21:59 -0000 Subject: [wp-trac] [WordPress Trac] #51324: sitemap.xml and sitemap-xml headers return html as content type In-Reply-To: <057.3fcd6f1d7dc4a4b9596e7ef7e6392c11@wordpress.org> References: <057.3fcd6f1d7dc4a4b9596e7ef7e6392c11@wordpress.org> Message-ID: <072.a5db2a117df65cf61a4e53b838cf0a54@wordpress.org> #51324: sitemap.xml and sitemap-xml headers return html as content type ---------------------------+------------------------------ Reporter: superpoincare | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: normal | Resolution: wontfix Keywords: | Focuses: ---------------------------+------------------------------ Comment (by RavanH): @SergeyBiryukov you're right I did not read the last sentence of the ticket. The discussion would then be about whether a Content-Type header alongside a Location header makes any sense at all (there being no content sent) :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:29:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:29:35 -0000 Subject: [wp-trac] [WordPress Trac] #54010: Redirect from /sitemap.xml to /wp-sitemap.xml needs to be 301 and not 302 In-Reply-To: <053.48cf7c57e939295bd42cb467b20167de@wordpress.org> References: <053.48cf7c57e939295bd42cb467b20167de@wordpress.org> Message-ID: <068.3bb944d99870f5d9c748d57d1007f43b@wordpress.org> #54010: Redirect from /sitemap.xml to /wp-sitemap.xml needs to be 301 and not 302 --------------------------+------------------------------ Reporter: RedBMedia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by RavanH): I've tested on several sites and have seen no issues reported by GSC about the 302 redirect. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:33:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:33:53 -0000 Subject: [wp-trac] [WordPress Trac] #55250: Avoid sending empty script translations In-Reply-To: <051.c70c175c4cc365c6efdc917141cf72df@wordpress.org> References: <051.c70c175c4cc365c6efdc917141cf72df@wordpress.org> Message-ID: <066.69cc9f65082d199acd93ac6d16f80cdd@wordpress.org> #55250: Avoid sending empty script translations --------------------------+--------------------- Reporter: jsnajdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: I18N | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by ocean90): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:34:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:34:25 -0000 Subject: [wp-trac] [WordPress Trac] #55057: WebP EXIF data missing and images are not rotated in the same way JPEG images are rotated. (was: Uploaded WebP images are not rotated in the same way JPEG images are rotated.) In-Reply-To: <050.cb1caad48c4abb96a7d234f408387e2f@wordpress.org> References: <050.cb1caad48c4abb96a7d234f408387e2f@wordpress.org> Message-ID: <065.6f2518c077b50cbd263b23e1532ac76f@wordpress.org> #55057: WebP EXIF data missing and images are not rotated in the same way JPEG images are rotated. --------------------------+------------------------------ Reporter: mitogh | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: needs-patch | Focuses: performance --------------------------+------------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:38:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:38:14 -0000 Subject: [wp-trac] [WordPress Trac] #55280: Unsupported operand types in Site Health In-Reply-To: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> References: <047.c67a89e097654f10a542cad7a02b6cf7@wordpress.org> Message-ID: <062.9f2b806456a851b0fe88ccf63915a587@wordpress.org> #55280: Unsupported operand types in Site Health --------------------------+---------------------------------------- Reporter: lw5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: 5.9.1 Severity: normal | Resolution: Keywords: php8 | Focuses: administration, multisite --------------------------+---------------------------------------- Changes (by SergeyBiryukov): * keywords: reporter-feedback => php8 Comment: Hi there, thanks for the report. It looks like this can happen if one of the entries in the cron array is not an integer timestamp as it's supposed to be, but a non-numeric string instead. This was fixed in [33936] / #33475 for WordPress 4.4, and a descriptive error message was added in [50143] / #49961 for WordPress 5.7. However, the current fix just means that new events cannot be scheduled with a non- numeric timestamp. If there is already an existing event like that, it remains in the array. I'm open to suggestions on what a correct fix here would be. I think just hiding the notice in Site Health would not be ideal, we may need an upgrade routine to clean up the cron array and remove any events with an invalid timestamp. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:40:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:40:11 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.dd706c7fdb2b92bcd57d4ed0046796ae@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Changes (by afercia): * Attachment "54483.3.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:42:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:42:32 -0000 Subject: [wp-trac] [WordPress Trac] #51211: Implement a consistent function to obtain the sitemap location In-Reply-To: <055.0624876834d8c6a40e99f22d89bf4de8@wordpress.org> References: <055.0624876834d8c6a40e99f22d89bf4de8@wordpress.org> Message-ID: <070.3b2e994c4c3d727a98ec074534a73be3@wordpress.org> #51211: Implement a consistent function to obtain the sitemap location -------------------------+------------------------------ Reporter: GreatBlakes | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Sitemaps | Version: 5.5.1 Severity: trivial | Resolution: Keywords: has-patch | Focuses: -------------------------+------------------------------ Comment (by RavanH): Nice work on https://github.com/WordPress/wordpress-develop/pull/514 (consider this a +1) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:43:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:43:00 -0000 Subject: [wp-trac] [WordPress Trac] #51324: sitemap.xml and sitemap-xml headers return html as content type In-Reply-To: <057.3fcd6f1d7dc4a4b9596e7ef7e6392c11@wordpress.org> References: <057.3fcd6f1d7dc4a4b9596e7ef7e6392c11@wordpress.org> Message-ID: <072.6aeb42377199f9f3954078bbd361b997@wordpress.org> #51324: sitemap.xml and sitemap-xml headers return html as content type ---------------------------+---------------------- Reporter: superpoincare | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Sitemaps | Version: 5.5 Severity: normal | Resolution: wontfix Keywords: | Focuses: ---------------------------+---------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => Comment: Forgot to remove the milestone in my previous comment; discussion can continue on a closed ticket until there is any interest in reopening it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:44:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:44:30 -0000 Subject: [wp-trac] [WordPress Trac] #54483: On logout input fields have aria described login_error In-Reply-To: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> References: <056.5f153943b56f0aa9c5ef66da1cbf5e6b@wordpress.org> Message-ID: <071.dc3c26e8a1cca1df59079f9dea2f4a86@wordpress.org> #54483: On logout input fields have aria described login_error ------------------------------------+-------------------------------- Reporter: patrickgroot | Owner: alexstine Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.8.2 Severity: trivial | Resolution: Keywords: has-patch | Focuses: ui, accessibility ------------------------------------+-------------------------------- Comment (by afercia): Given that the value of `aria-describedby` should point to the ID of an element present on the page, I'd like to propose a different approach in [attachment:"54483.3.diff"]. This updated patch should cover the case of the login and logout. Worth noting there are at least 3 more cases where input fields aren't connected to messages displayed on the page: - lost password: this page shows a default message and potential errors, however the input field is not connected to any description. - reset password: the password field is connected to the password strength meter, which is also an aria-live region. - register: this page shows a default message and potential errors, however the two input fields are not connected to any description. I'm not sure these cases should be addressed in the context of this ticket though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:55:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:55:09 -0000 Subject: [wp-trac] [WordPress Trac] #55287: Allow for DISTINCT in WP_Query method Message-ID: <054.50212460af26f10a8457cc3c6e422e1a@wordpress.org> #55287: Allow for DISTINCT in WP_Query method -------------------------------+----------------------------- Reporter: simbaclaws | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: trunk Severity: normal | Keywords: needs-patch Focuses: | -------------------------------+----------------------------- Dear wordpress developers, Currently I'm working with a plugin to create designs. This plugin has an element called a repeater element that basically makes use of the core WP_Query method in order to fetch custom post types or normal post types. However, since I'm using this page builder or theme builder, I am in no way capable of using DISTINCT within the filter https://developer.wordpress.org/reference/hooks/posts_distinct/ Because this requires me to send the WP_Query instance, which is basically only used within the repeater element and can not be set to a variable in this particular case. This means I'll have to rebuild everything through code, instead of being able to use my page or theme builder. Now I get the idea of saying this is a bug with the page or theme builder plugin. But in fact, what I want to know is why are we using a filter to create a DISTINCT query inside of WP_Query? Isn't it possible to implement this inside of the WP_Query arguments instead? I basically want to say: fetch posts with unique titles. This seems much more logical as the SQL query is build from WP_Query... I've already looked through the entire codex, and couldn't find any possible parameter that could be used for this... My question to you is: Can this please be added to wordpress core? I find it highly frustrating that WP_Query doesn't have this sort of capabilities out of the box. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:56:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:56:38 -0000 Subject: [wp-trac] [WordPress Trac] #55247: SVG logos generate warnings from _wp_get_image_size_from_meta() In-Reply-To: <055.dded4e2c58bc7e8ccc9f58ab7706cd9e@wordpress.org> References: <055.dded4e2c58bc7e8ccc9f58ab7706cd9e@wordpress.org> Message-ID: <070.2974e1ca315290a67821221517978207@wordpress.org> #55247: SVG logos generate warnings from _wp_get_image_size_from_meta() --------------------------+------------------------------ Reporter: gillespieza | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by gillespieza): Ah, thanks. No, I'm not using a plugin for that, but a code snippet that filters `upload_mimes` and `wp_check_filetype_and_ext`. You wouldn't happen to know, off-hand, what filter I should use to set a height/width? I'm guessing `wp_update_attachment_metadata`? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 15:57:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 15:57:46 -0000 Subject: [wp-trac] [WordPress Trac] #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed In-Reply-To: <058.658784bbdb049263899782fed472c729@wordpress.org> References: <058.658784bbdb049263899782fed472c729@wordpress.org> Message-ID: <073.9243f4f76022fe6def17c557f65a0bfb@wordpress.org> #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed ----------------------------+----------------------------- Reporter: helgatheviking | Owner: SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: reopened => reviewing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:01:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:01:57 -0000 Subject: [wp-trac] [WordPress Trac] #55239: Filter hook wp_sitemaps_taxonomies_entry passes Term ID not Object In-Reply-To: <050.d931e8ac6d10c2579ccf77882f678437@wordpress.org> References: <050.d931e8ac6d10c2579ccf77882f678437@wordpress.org> Message-ID: <065.062e56455664e2ea2e62c3ef43dd8a8f@wordpress.org> #55239: Filter hook wp_sitemaps_taxonomies_entry passes Term ID not Object -------------------------------------+--------------------- Reporter: RavanH | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Sitemaps | Version: 5.9.1 Severity: minor | Resolution: Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+--------------------- Comment (by RavanH): During testing, I just noticed that setting `$args['fields'] = 'all'` (back to its original intended value?) reduces the number of DB queries by a huge number on large taxonomy term sitemaps. Just as an added bonus :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:05:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:05:29 -0000 Subject: [wp-trac] [WordPress Trac] #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed In-Reply-To: <058.658784bbdb049263899782fed472c729@wordpress.org> References: <058.658784bbdb049263899782fed472c729@wordpress.org> Message-ID: <073.3fdeaf55cec1c11949af2d0df8db2dff@wordpress.org> #55219: "current_theme_supports-{$feature}" filter doesn't run if no $args are passed ----------------------------+----------------------------- Reporter: helgatheviking | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ----------------------------+----------------------------- Changes (by SergeyBiryukov): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52812" 52812]: {{{ #!CommitTicketReference repository="" revision="52812" Themes: Make sure the `current_theme_supports-{$feature}` filter is consistently applied. Previously, the filter was not applied if there are no arguments passed to `current_theme_supports()`. Follow-up to [12350], [19682]. Props helgatheviking, azouamauriac, pavanpatil1, SergeyBiryukov. Fixes #55219. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:06:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:06:24 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.ea3e6b8bff984b967aa4379e4011ed4b@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Changes (by johnregan3): * Attachment "55078.diff" added. Initial patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:08:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:08:35 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.12c8e35a429efeffc40c5fee9a5c0c31@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Comment (by johnregan3): Added initial patch. I'm not satisfied with the naming ("data_is_success_message"), but for now I wanted to use something clear while evaluating this approach to a solution for this ticket. Definitely open to input. @SergeyBiryukov -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:11:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:11:53 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.1d1be81451b1dab3134f20f966869bbf@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Comment (by johnregan3): Also, I think I'd like to replace the `compact()` on line 1120 and replace it with something more readable. {{{ 'supplemental' => array( 'parents' => $parents, 'noparents' => $noparents, 'data_is_success_message' => true, ) }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:31:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:31:17 -0000 Subject: [wp-trac] [WordPress Trac] #55247: SVG logos generate warnings from _wp_get_image_size_from_meta() In-Reply-To: <055.dded4e2c58bc7e8ccc9f58ab7706cd9e@wordpress.org> References: <055.dded4e2c58bc7e8ccc9f58ab7706cd9e@wordpress.org> Message-ID: <070.f443714f71c0207e8c39061a41e12fd3@wordpress.org> #55247: SVG logos generate warnings from _wp_get_image_size_from_meta() --------------------------+------------------------------ Reporter: gillespieza | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9 Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by nosilver4u): The two plugins I've looked at recently hook into wp_generate_attachment_metadata. Here's one example: https://plugins.trac.wordpress.org/browser/safe-svg/trunk/safe- svg.php#L371 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 16:56:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 16:56:22 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.9def73bebac60f005df40f96a043231b@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): I have actioned feedback from @peterwilsoncc. If now uses `$_wp_suspend_cache_invalidation` global. This makes the code a lot cleaner and means I could add a unit test. If now means if you want an uncached term_exists call you can do this. {{{#!php wp_suspend_cache_invalidation( true ); $term = term_exists( 'thing' ); wp_suspend_cache_invalidation( false ); }}} Which might be useful for devs. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 17:03:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 17:03:18 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords In-Reply-To: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> References: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> Message-ID: <067.53fbbfde22827212fe4fa4947f42c534@wordpress.org> #55286: Rest Cannot Create Application Passwords --------------------------+----------------------------- Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: REST API | Version: 5.7 Severity: normal | Resolution: invalid Keywords: | Focuses: docs, rest-api --------------------------+----------------------------- Changes (by TimothyBlynJacobs): * status: new => closed * version: 5.9.1 => 5.7 * resolution: => invalid * milestone: Awaiting Review => Comment: Hi gonza.ar, Welcome to Trac and thanks for the ticket! This is intentional and is behaving as expected, you can see it covered by unit tests here: https://github.com/WordPress/wordpress- develop/blob/f0dfa682a5cf2004f468c18ba8d5c87c463cdeea/tests/phpunit/tests /rest-api/rest-application-passwords-controller.php#L313 The context provided to the `current_user_can` check is the user that the Application Password is being created for. This allows for using `map_meta_cap` to further customize the capabilities required, see #51703. If the global current user is empty, that means you aren't authenticated. You'll need to authenticate before creating Application Passwords, typically using cookies and a nonce: https://developer.wordpress.org/rest- api/using-the-rest-api/authentication/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 17:29:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 17:29:55 -0000 Subject: [wp-trac] [WordPress Trac] #55286: Rest Cannot Create Application Passwords In-Reply-To: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> References: <052.d816772d80d6b22f7c6e03987bf7cd8a@wordpress.org> Message-ID: <067.4d2d94bebff860eaa948e5b935863cca@wordpress.org> #55286: Rest Cannot Create Application Passwords --------------------------+----------------------------- Reporter: gonza.ar | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: REST API | Version: 5.7 Severity: normal | Resolution: invalid Keywords: | Focuses: docs, rest-api --------------------------+----------------------------- Comment (by gonza.ar): Hi Timothy! Ok Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 17:46:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 17:46:03 -0000 Subject: [wp-trac] [WordPress Trac] #54878: Don't show links to the Customizer when installing themes using api.wordpress.org In-Reply-To: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> References: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> Message-ID: <072.e3dd88a78c92305a40dde4eb5494d3b0@wordpress.org> #54878: Don't show links to the Customizer when installing themes using api.wordpress.org -------------------------------------+--------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by antonvlasenko): Thank you so much for testing, @ironprogrammer! I've fixed the issue you mentioned. @costdev Would it be possible to move this track ticket to the 5.9.2 milestone, please? This trac issue and https://core.trac.wordpress.org/ticket/54578 (which is in the 5.9.2 milestone) are related, and both of them fix similar issues. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 18:32:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 18:32:04 -0000 Subject: [wp-trac] [WordPress Trac] #4476: Delete Cache by Group In-Reply-To: <052.9c32d35acb1b4c9e1b3f760350cee416@wordpress.org> References: <052.9c32d35acb1b4c9e1b3f760350cee416@wordpress.org> Message-ID: <067.dc96b44759cb58e47bd029047417a5c2@wordpress.org> #4476: Delete Cache by Group --------------------------------------+------------------------------ Reporter: filosofo | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Cache API | Version: 2.2 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------------ Comment (by spacedmonkey): I understand the desire for this ticket to go into core. But apart from the redis examples seen in this ticket, how would this work in other object cache drop-ins. How would this work for a memcache implementation? If someone could link to or provide a code snippet for a memcache or other object cache implement, that would be helpful. If we can reliably have a way for keys in a group to be in core, then sadly, this function can not live core. The worry is that someone calls `wp_cache_delete_group` and it simply does not work. If this function existing in core, we could need some way to backfill / pollyfil, like done in wp_cache_get_multiple patch. Again, a can't think of a good way to do this without massively refactoring the internals of the object cache. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 18:47:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 18:47:29 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation Message-ID: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------------------+----------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: major | Keywords: Focuses: administration, template | --------------------------------------+----------------------------- I'm getting an error when launching the site editor on 5.9.1, stating “The editor is unable to find a block template for the homepage”. This happens on both Twenty-Twenty-Two and a custom FSE theme (otherwise functional, has templates/single.html and templates/index.html). **My WP installation is in a subdirectory**, using the [[https://github.com/roots/bedrock|Bedrock]] site structure, so the editor URL is `https://example.test/wp/wp-admin/themes.php?page=gutenberg-edit- site` I've tried it on PHP 7.4.25 and 8.0.14. I've confirmed it still happens with all plugins deactivated. Notably, activating the Gutenberg plugin version 12.6.1 eliminates the error and the editor loads correctly. There are several other reports of the same error in this Twenty-Twenty- Two forum thread: https://wordpress.org/support/topic/the-editor-is- unable-to-find-a-block-template-for-the-homepage/ The error code output from the copy button is {{{ Error: `getHomepageParams`: HTTP status error, 404 at https://example.test/wp/wp-includes/js/dist/edit- site.js?ver=403e01f2b098b6a656118a51787581cb:8766:13 at async getHomepageParams (https://example.test/wp/wp- includes/js/dist/edit- site.js?ver=403e01f2b098b6a656118a51787581cb:8762:20) at async redirectToHomepage (https://example.test/wp/wp- includes/js/dist/edit- site.js?ver=403e01f2b098b6a656118a51787581cb:8797:28) at async reinitializeEditor (https://example.test/wp/wp- includes/js/dist/edit-site.js?ver=403e01f2b098b6a656118a51787581cb:9067:5) }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 19:06:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 19:06:30 -0000 Subject: [wp-trac] [WordPress Trac] #54878: Don't show links to the Customizer when installing themes using api.wordpress.org In-Reply-To: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> References: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> Message-ID: <072.e2c0e5f7a7f4b6e608218f6ff7f7d215@wordpress.org> #54878: Don't show links to the Customizer when installing themes using api.wordpress.org ---------------------------------------+--------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-screenshots | Focuses: ---------------------------------------+--------------------- Changes (by ironprogrammer): * keywords: has-patch needs-testing => has-patch has-screenshots Comment: 👍🏻 LGTM! The PR update has addressed the removal of the preview button immediately following installation of a block theme. == Test Report [https://github.com/WordPress/wordpress-develop/pull/2349 PR 2349] === Env * WordPress 6.0-alpha-52448-src * Safari 15.3 (w/ cleared cache) * Chrome 98.0.4758.109 * macOS 12.2.1 (Monterey) * Theme: Twenty Twenty-Two * Gutenberg DISABLED 🔴 === Steps to Test 1. On ''Appearance > Themes'' activate "Twenty Twenty-Two" theme. 2. Click **Add New** and search for "tt1" ("TT1 Blocks" theme). 3. Click **Install** for "TT1 Blocks" theme. 4. Observe the **Preview** button is removed, and not replaced with **Live Preview**. ✅ 5. Refresh page (Reload or repeat Steps 1-3). 6. Observe **Live Preview** button is removed. ✅ === Screenshots [[Image(https://cldup.com/MOQIYHJAfW.gif)]] ''On `theme-install.php`, **Preview** and **Live Preview** buttons are removed after block theme installation.'' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 20:03:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 20:03:02 -0000 Subject: [wp-trac] [WordPress Trac] #54843: Add end to end test case for Trash a single post and restore post from trash In-Reply-To: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> References: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> Message-ID: <070.e4124b997da9950cd1674ae32c1c3f74@wordpress.org> #54843: Add end to end test case for Trash a single post and restore post from trash --------------------------------------+--------------------- Reporter: pavanpatil1 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 21:10:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 21:10:31 -0000 Subject: [wp-trac] [WordPress Trac] #54775: Allow int/float for esc_ functions In-Reply-To: <052.d31d6f3ef2ab6e369a064d261311e94a@wordpress.org> References: <052.d31d6f3ef2ab6e369a064d261311e94a@wordpress.org> Message-ID: <067.88037a0f6b7aa03382e8f965a10c6919@wordpress.org> #54775: Allow int/float for esc_ functions -------------------------+------------------------------- Reporter: malthert | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Security | Version: Severity: normal | Resolution: wontfix Keywords: close | Focuses: coding-standards -------------------------+------------------------------- Changes (by johnbillion): * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: This conversation isn't really going anywhere so I'll close off this ticket. As mentioned a few times, if you know the type is an integer or float then it can be handled accordingly, no need to pass it through `esc_html()`. Cheers! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 21:41:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 21:41:41 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes Message-ID: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+----------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When uploading a large image into WordPress it fails to create the `scaled` version, due to the usage of too many resources, because the `-scaled` resized version can't be created, no additional subsize is created. The resize fails with the following error message: > cache resources exhausted Even with the resized failure, only the full-size image is uploaded and no additional image sizes are generated. Steps to recreate the problem: 1. Upload the provided image. 2. Inspect the metadata of the image and observe no `-scaled` version was created and no subsizes was created either. Observe how only the full image size is uploaded, no `-scaled` version can't be found. == Problems 1. As described before the full size image is uploaded and no `scaled` version is created. 2. When loading the media library the full image size is loaded due no subsizes were created. 3. No subsizes are created for this image due to the resized image failing to be created. == Setup Sharing the details of my current setup: {{{ ### wp-core ### version: 5.9.1 site_language: en_US user_language: en_US timezone: +00:00 permalink: /%year%/%monthnum%/%day%/%postname%/ https_status: true multisite: false user_registration: 0 blog_public: 1 default_comment_status: open environment_type: production user_count: 1 dotorg_communication: true ### wp-paths-sizes ### wordpress_path: /app wordpress_size: 152.90 MB (160327567 bytes) uploads_path: /app/wp-content/uploads uploads_size: 22.75 MB (23851112 bytes) themes_path: /app/wp-content/themes themes_size: 6.47 MB (6780262 bytes) plugins_path: /app/wp-content/plugins plugins_size: 208.42 MB (218539593 bytes) database_size: 3.96 MB (4149380 bytes) total_size: 394.49 MB (413647914 bytes) ### wp-active-theme ### name: Twenty Twenty-Two (twentytwentytwo) version: 1.0 (latest version: 1.1) author: the WordPress team author_website: https://wordpress.org/ parent_theme: none theme_features: core-block-patterns, post-thumbnails, responsive-embeds, editor-styles, html5, automatic-feed-links, block-templates, widgets- block-editor, wp-block-styles, editor-style theme_path: /app/wp-content/themes/twentytwentytwo auto_update: Disabled ### wp-themes-inactive (3) ### Twenty Nineteen: version: 2.2, author: the WordPress team, Auto-updates disabled Twenty Twenty: version: 1.9, author: the WordPress team, Auto-updates disabled Twenty Twenty-One: version: 1.5, author: the WordPress team, Auto-updates disabled ### wp-plugins-inactive (1) ### Performance Lab: version: 1.0.0-beta.1, author: WordPress Performance Group, Auto-updates disabled ### wp-media ### image_editor: WP_Image_Editor_Imagick imagick_module_version: 1691 imagemagick_version: ImageMagick 6.9.11-60 Q16 x86_64 2021-01-25 https://imagemagick.org imagick_version: 3.7.0 file_uploads: File uploads is turned off post_max_size: 100M upload_max_filesize: 100M max_effective_size: 100 MB max_file_uploads: 20 imagick_limits: imagick::RESOURCETYPE_AREA: 122 MB imagick::RESOURCETYPE_DISK: 1073741824 imagick::RESOURCETYPE_FILE: 786432 imagick::RESOURCETYPE_MAP: 512 MB imagick::RESOURCETYPE_MEMORY: 256 MB imagick::RESOURCETYPE_THREAD: 1 imagemagick_file_formats: 3FR, 3G2, 3GP, AAI, AI, APNG, ART, ARW, AVI, AVIF, AVS, BGR, BGRA, BGRO, BIE, BMP, BMP2, BMP3, BRF, CAL, CALS, CANVAS, CAPTION, CIN, CIP, CLIP, CMYK, CMYKA, CR2, CR3, CRW, CUR, CUT, DATA, DCM, DCR, DCX, DDS, DFONT, DJVU, DNG, DOT, DPX, DXT1, DXT5, EPDF, EPI, EPS, EPS2, EPS3, EPSF, EPSI, EPT, EPT2, EPT3, ERF, EXR, FAX, FILE, FITS, FRACTAL, FTP, FTS, G3, G4, GIF, GIF87, GRADIENT, GRAY, GRAYA, GROUP4, GV, H, HALD, HDR, HEIC, HISTOGRAM, HRZ, HTM, HTML, HTTP, HTTPS, ICB, ICO, ICON, IIQ, INFO, INLINE, IPL, ISOBRL, ISOBRL6, J2C, J2K, JBG, JBIG, JNG, JNX, JP2, JPC, JPE, JPEG, JPG, JPM, JPS, JPT, JSON, K25, KDC, LABEL, M2V, M4V, MAC, MAGICK, MAP, MASK, MAT, MATTE, MEF, MIFF, MKV, MNG, MONO, MOV, MP4, MPC, MPG, MRW, MSL, MSVG, MTV, MVG, NEF, NRW, NULL, ORF, OTB, OTF, PAL, PALM, PAM, PANGO, PATTERN, PBM, PCD, PCDS, PCL, PCT, PCX, PDB, PDF, PDFA, PEF, PES, PFA, PFB, PFM, PGM, PGX, PICON, PICT, PIX, PJPEG, PLASMA, PNG, PNG00, PNG24, PNG32, PNG48, PNG64, PNG8, PNM, POCKETMOD, PPM, PREVIEW, PS, PS2, PS3, PSB, PSD, PTIF, PWP, RADIAL-GRADIENT, RAF, RAS, RAW, RGB, RGBA, RGBO, RGF, RLA, RLE, RMF, RW2, SCR, SCT, SFW, SGI, SHTML, SIX, SIXEL, SPARSE-COLOR, SR2, SRF, STEGANO, SUN, SVG, SVGZ, TEXT, TGA, THUMBNAIL, TIFF, TIFF64, TILE, TIM, TTC, TTF, TXT, UBRL, UBRL6, UIL, UYVY, VDA, VICAR, VID, VIDEO, VIFF, VIPS, VST, WBMP, WEBM, WEBP, WMF, WMV, WMZ, WPG, X, X3F, XBM, XC, XCF, XPM, XPS, XV, XWD, YCbCr, YCbCrA, YUV gd_version: bundled (2.1.0 compatible) gd_formats: GIF, JPEG, PNG, WebP, BMP ghostscript_version: 9.53.3 ### wp-server ### server_architecture: Linux 5.15.12-1-MANJARO x86_64 httpd_software: nginx/1.17.10 php_version: 7.4.28 64bit php_sapi: fpm-fcgi max_input_variables: 10000 time_limit: 3 memory_limit: 1G max_input_time: 900 upload_max_filesize: 100M php_post_max_size: 100M curl_version: 7.74.0 OpenSSL/1.1.1k suhosin: false imagick_availability: true pretty_permalinks: true ### wp-database ### extension: mysqli server_version: 10.3.27-MariaDB client_version: mysqlnd 7.4.28 max_allowed_packet: 33554432 max_connections: 151 ### wp-constants ### WP_HOME: undefined WP_SITEURL: undefined WP_CONTENT_DIR: /app/wp-content WP_PLUGIN_DIR: /app/wp-content/plugins WP_MEMORY_LIMIT: 40M WP_MAX_MEMORY_LIMIT: 1G WP_DEBUG: true WP_DEBUG_DISPLAY: true WP_DEBUG_LOG: true SCRIPT_DEBUG: false WP_CACHE: false CONCATENATE_SCRIPTS: undefined COMPRESS_SCRIPTS: undefined COMPRESS_CSS: undefined WP_ENVIRONMENT_TYPE: Undefined DB_CHARSET: utf8mb4 DB_COLLATE: undefined ### wp-filesystem ### wordpress: writable wp-content: writable uploads: writable plugins: writable themes: writable mu-plugins: writable }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 21:42:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 21:42:03 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.f2cf019e85e00b69acc72fcd803dcb4c@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by mitogh): * Attachment "photo-1644433329707-2b528437a7e7.jpg" added. Media picture to test the failure -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 22:05:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 22:05:28 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes Message-ID: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> #55290: Not all image edits are applied to all subsizes -----------------------------------------+----------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Keywords: Focuses: administration, performance | -----------------------------------------+----------------------------- When editing an image using the admin editor, not all edits are applied correctly to all image subsizes. Specifically, the problem occurs when an edit results in a smaller size than the defined image size. Given the following image subsizes, and the attached image. {{{ => array(6) { ["thumbnail"]=> array(3) { ["width"]=> int(150) ["height"]=> int(150) ["crop"]=> bool(true) } ["medium"]=> array(3) { ["width"]=> int(300) ["height"]=> int(300) ["crop"]=> bool(false) } ["medium_large"]=> array(3) { ["width"]=> int(768) ["height"]=> int(0) ["crop"]=> bool(false) } ["large"]=> array(3) { ["width"]=> int(1024) ["height"]=> int(1024) ["crop"]=> bool(false) } ["1536x1536"]=> array(3) { ["width"]=> int(1536) ["height"]=> int(1536) ["crop"]=> bool(false) } ["2048x2048"]=> array(3) { ["width"]=> int(2048) ["height"]=> int(2048) ["crop"]=> bool(false) } } }}} ''The defined sizes above are the ones coming by default with the setting provided below. '' == Steps to replicate the problem: 1. Upload the image into your installation. 2. After the image is uploaded, click on edit to open the image editor or go to the image editor from within the media library. 3. Click on Edit image 4. Click on rotate image (either right or left) only once. 5. Make sure the changes are applied to all images by checking that the setting Apply changes to: All image sizes is set 6. Click on save After the image is saved observe the changes were applied only to the following image sizes: - `thumbnail` - `medium` - `large` - `full` The only size that was not updated as expected was: - `medium_large` == Setup {{{ ### wp-core ### version: 5.9.1 site_language: en_US user_language: en_US timezone: +00:00 permalink: /%year%/%monthnum%/%day%/%postname%/ https_status: true multisite: false user_registration: 0 blog_public: 1 default_comment_status: open environment_type: production user_count: 1 dotorg_communication: true ### wp-paths-sizes ### wordpress_path: /app wordpress_size: 152.90 MB (160327567 bytes) uploads_path: /app/wp-content/uploads uploads_size: 22.75 MB (23851112 bytes) themes_path: /app/wp-content/themes themes_size: 6.47 MB (6780262 bytes) plugins_path: /app/wp-content/plugins plugins_size: 208.42 MB (218539593 bytes) database_size: 3.96 MB (4149380 bytes) total_size: 394.49 MB (413647914 bytes) ### wp-active-theme ### name: Twenty Twenty-Two (twentytwentytwo) version: 1.0 (latest version: 1.1) author: the WordPress team author_website: https://wordpress.org/ parent_theme: none theme_features: core-block-patterns, post-thumbnails, responsive-embeds, editor-styles, html5, automatic-feed-links, block-templates, widgets- block-editor, wp-block-styles, editor-style theme_path: /app/wp-content/themes/twentytwentytwo auto_update: Disabled ### wp-themes-inactive (3) ### Twenty Nineteen: version: 2.2, author: the WordPress team, Auto-updates disabled Twenty Twenty: version: 1.9, author: the WordPress team, Auto-updates disabled Twenty Twenty-One: version: 1.5, author: the WordPress team, Auto-updates disabled ### wp-plugins-inactive (1) ### Performance Lab: version: 1.0.0-beta.1, author: WordPress Performance Group, Auto-updates disabled ### wp-media ### image_editor: WP_Image_Editor_Imagick imagick_module_version: 1691 imagemagick_version: ImageMagick 6.9.11-60 Q16 x86_64 2021-01-25 https://imagemagick.org imagick_version: 3.7.0 file_uploads: File uploads is turned off post_max_size: 100M upload_max_filesize: 100M max_effective_size: 100 MB max_file_uploads: 20 imagick_limits: imagick::RESOURCETYPE_AREA: 122 MB imagick::RESOURCETYPE_DISK: 1073741824 imagick::RESOURCETYPE_FILE: 786432 imagick::RESOURCETYPE_MAP: 512 MB imagick::RESOURCETYPE_MEMORY: 256 MB imagick::RESOURCETYPE_THREAD: 1 imagemagick_file_formats: 3FR, 3G2, 3GP, AAI, AI, APNG, ART, ARW, AVI, AVIF, AVS, BGR, BGRA, BGRO, BIE, BMP, BMP2, BMP3, BRF, CAL, CALS, CANVAS, CAPTION, CIN, CIP, CLIP, CMYK, CMYKA, CR2, CR3, CRW, CUR, CUT, DATA, DCM, DCR, DCX, DDS, DFONT, DJVU, DNG, DOT, DPX, DXT1, DXT5, EPDF, EPI, EPS, EPS2, EPS3, EPSF, EPSI, EPT, EPT2, EPT3, ERF, EXR, FAX, FILE, FITS, FRACTAL, FTP, FTS, G3, G4, GIF, GIF87, GRADIENT, GRAY, GRAYA, GROUP4, GV, H, HALD, HDR, HEIC, HISTOGRAM, HRZ, HTM, HTML, HTTP, HTTPS, ICB, ICO, ICON, IIQ, INFO, INLINE, IPL, ISOBRL, ISOBRL6, J2C, J2K, JBG, JBIG, JNG, JNX, JP2, JPC, JPE, JPEG, JPG, JPM, JPS, JPT, JSON, K25, KDC, LABEL, M2V, M4V, MAC, MAGICK, MAP, MASK, MAT, MATTE, MEF, MIFF, MKV, MNG, MONO, MOV, MP4, MPC, MPG, MRW, MSL, MSVG, MTV, MVG, NEF, NRW, NULL, ORF, OTB, OTF, PAL, PALM, PAM, PANGO, PATTERN, PBM, PCD, PCDS, PCL, PCT, PCX, PDB, PDF, PDFA, PEF, PES, PFA, PFB, PFM, PGM, PGX, PICON, PICT, PIX, PJPEG, PLASMA, PNG, PNG00, PNG24, PNG32, PNG48, PNG64, PNG8, PNM, POCKETMOD, PPM, PREVIEW, PS, PS2, PS3, PSB, PSD, PTIF, PWP, RADIAL-GRADIENT, RAF, RAS, RAW, RGB, RGBA, RGBO, RGF, RLA, RLE, RMF, RW2, SCR, SCT, SFW, SGI, SHTML, SIX, SIXEL, SPARSE-COLOR, SR2, SRF, STEGANO, SUN, SVG, SVGZ, TEXT, TGA, THUMBNAIL, TIFF, TIFF64, TILE, TIM, TTC, TTF, TXT, UBRL, UBRL6, UIL, UYVY, VDA, VICAR, VID, VIDEO, VIFF, VIPS, VST, WBMP, WEBM, WEBP, WMF, WMV, WMZ, WPG, X, X3F, XBM, XC, XCF, XPM, XPS, XV, XWD, YCbCr, YCbCrA, YUV gd_version: bundled (2.1.0 compatible) gd_formats: GIF, JPEG, PNG, WebP, BMP ghostscript_version: 9.53.3 ### wp-server ### server_architecture: Linux 5.15.12-1-MANJARO x86_64 httpd_software: nginx/1.17.10 php_version: 7.4.28 64bit php_sapi: fpm-fcgi max_input_variables: 10000 time_limit: 3 memory_limit: 1G max_input_time: 900 upload_max_filesize: 100M php_post_max_size: 100M curl_version: 7.74.0 OpenSSL/1.1.1k suhosin: false imagick_availability: true pretty_permalinks: true ### wp-database ### extension: mysqli server_version: 10.3.27-MariaDB client_version: mysqlnd 7.4.28 max_allowed_packet: 33554432 max_connections: 151 ### wp-constants ### WP_HOME: undefined WP_SITEURL: undefined WP_CONTENT_DIR: /app/wp-content WP_PLUGIN_DIR: /app/wp-content/plugins WP_MEMORY_LIMIT: 40M WP_MAX_MEMORY_LIMIT: 1G WP_DEBUG: true WP_DEBUG_DISPLAY: true WP_DEBUG_LOG: true SCRIPT_DEBUG: false WP_CACHE: false CONCATENATE_SCRIPTS: undefined COMPRESS_SCRIPTS: undefined COMPRESS_CSS: undefined WP_ENVIRONMENT_TYPE: Undefined DB_CHARSET: utf8mb4 DB_COLLATE: undefined ### wp-filesystem ### wordpress: writable wp-content: writable uploads: writable plugins: writable themes: writable mu-plugins: writable }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 22:05:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 22:05:50 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.55f0466b0f73c0e809816db6e6640f83@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: administration, performance --------------------------+------------------------------------------ Changes (by mitogh): * Attachment "leafs.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 22:26:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 22:26:58 -0000 Subject: [wp-trac] [WordPress Trac] #50284: A fix to the CPT-no-create-when-submenu-child problem. In-Reply-To: <052.1a795aee56423f1d425da148db4dbd38@wordpress.org> References: <052.1a795aee56423f1d425da148db4dbd38@wordpress.org> Message-ID: <067.8286fdca3b5a269874ebaaf65ae35267@wordpress.org> #50284: A fix to the CPT-no-create-when-submenu-child problem. ----------------------------+--------------------------------- Reporter: mort1305 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.5 Severity: normal | Resolution: Keywords: | Focuses: ui, administration ----------------------------+--------------------------------- Comment (by lovecomm): Ditto what @mort1305 says. Would be intereseted in the status of this as well, and also have no idea how core development works. Ran into this issue with a clients site. Running 5.9.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 22:30:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 22:30:40 -0000 Subject: [wp-trac] [WordPress Trac] #53450: [WP_Meta_Query] Add faster LIKE based 'STARTSWITH' and 'ENDSWITH' compare modes for value query In-Reply-To: <052.221d7b56bb4342e1eb298b920051d5d7@wordpress.org> References: <052.221d7b56bb4342e1eb298b920051d5d7@wordpress.org> Message-ID: <067.3aeb24aa35a28bf71e2dfaf93ca9b00f@wordpress.org> #53450: [WP_Meta_Query] Add faster LIKE based 'STARTSWITH' and 'ENDSWITH' compare modes for value query -------------------------------------------------+------------------------- Reporter: janthiel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Query | Version: 5.7.2 Severity: trivial | Resolution: Keywords: dev-feedback has-patch needs-docs | Focuses: needs-codex has-unit-tests early early-like- | performance actually-early needs-testing | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * keywords: dev-feedback has-patch needs-docs needs-codex has-unit-tests early early-like-actually-early => dev-feedback has-patch needs-docs needs-codex has-unit-tests early early-like-actually-early needs-testing Comment: Making sure this bubbles up in test circles.. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 1 23:50:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 01 Mar 2022 23:50:27 -0000 Subject: [wp-trac] [WordPress Trac] #54878: Don't show links to the Customizer when installing themes using api.wordpress.org In-Reply-To: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> References: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> Message-ID: <072.46a302e83be5089c1b36a15d889b5937@wordpress.org> #54878: Don't show links to the Customizer when installing themes using api.wordpress.org ----------------------------------------------+--------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-screenshots commit | Focuses: ----------------------------------------------+--------------------- Changes (by costdev): * keywords: has-patch has-screenshots => has-patch has-screenshots commit * milestone: 6.0 => 5.9.2 Comment: Thanks for the test reports @ironprogrammer! @antonvlasenko Moving to the 5.9.2 milestone and flagging for `commit` consideration. For committers: This ticket's issue has been identified, reproduced, patched, tested, improved, tested and confirmed. No outstanding issues or newly introduced regressions have been identified. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 05:58:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 05:58:57 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.f1a18389197e64875ce0302c9ec5eb6f@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by sharjeelkhanvmi): Hello I did not get your first point. Yes, it Looks good in smaller windows as well. Yes, right I need to rearrange elements but I do not know where to change them. Yes if we add more description lines to show then it mismatches the alignment of the boxes yes it will be great to show the version number below the description as well. Replying to [comment:4 joyously]: > Does the new look account for the error messages that can be shown? The plugin can have a message about mismatched versions. > Also, does this still look good on smaller windows? > Also, if you want to rearrange the elements, change the HTML instead of using CSS, for accessibility reasons. > > My own opinion is that the short description should not be chopped midsentence since it is already so short. I would rather see the version number in addition to what is already shown. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 05:59:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 05:59:37 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.2b5411f374e0d9e0fd317c4628e7dcc6@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by sharjeelkhanvmi): What's that? Replying to [comment:5 SergeyBiryukov]: -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 07:57:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 07:57:44 -0000 Subject: [wp-trac] [WordPress Trac] #55291: Can't access Custom CSS with theme Twenty Twenty-Two Message-ID: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> #55291: Can't access Custom CSS with theme Twenty Twenty-Two --------------------------+----------------------------- Reporter: DeveloperWil | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- The TT2 theme hides the customizer because the block theme replicates (most) of the functionality, however, if I switch from an existing theme to TT2 I lose access to all my Custom CSS that I previously had in Customizer. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 08:39:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 08:39:53 -0000 Subject: [wp-trac] [WordPress Trac] #55292: Custom REST Endpoints without Regex Message-ID: <053.48cf4ce289a9f2343520900eb4ab9307@wordpress.org> #55292: Custom REST Endpoints without Regex -------------------------------------+----------------------------- Reporter: encoredev | Owner: (none) Type: feature request | Status: assigned Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Keywords: 2nd-opinion Focuses: accessibility, rest-api | -------------------------------------+----------------------------- The current way of defining the path for the REST endpoints requires regex expressions to define the route variables. That feels like a very convoluted way for such a simple and a common task. Here is the example from the docs: {{{ /author/(?P\d+) }}} What I am suggesting is to allow a second way of defining the path which will look like that: {{{ /author/{id} }}} Then this can be parsed and all of the sections in curly braces can be replaced with regex expressions matching a string value like that: {{{ /author/(?P\S+). }}} Which worked fine even with more complicated examples like: {{{ "/author/{category}/{subcategory}/{id}" turns into "/author/(?P\S+)/(?P\S+)/(?P\S+)" }}} And here is the implementation of the parsing function: {{{#!php \S+)"; } } $path = implode( '', $path_elements ); return $path; } }}} So far I have got around 40 routes defined in the suggested way. They are of various complexity and I have never needed to use regex for any of them. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 08:52:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 08:52:00 -0000 Subject: [wp-trac] [WordPress Trac] #54953: Custom css variables in theme.json have different keys in 5.9 In-Reply-To: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> References: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> Message-ID: <064.a06bc4639f911ab3814d64ffa5dbab14@wordpress.org> #54953: Custom css variables in theme.json have different keys in 5.9 --------------------------+--------------------- Reporter: walbo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by Clorith): * milestone: Awaiting Review => 5.9.2 Comment: Upstream report to the Gutenberg repo at https://github.com/WordPress/gutenberg/issues/39155 Adding to the 5.9.2 milestone for tracking until we have a clear direction here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 10:28:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 10:28:19 -0000 Subject: [wp-trac] [WordPress Trac] #55292: Custom REST Endpoints without Regex In-Reply-To: <053.48cf4ce289a9f2343520900eb4ab9307@wordpress.org> References: <053.48cf4ce289a9f2343520900eb4ab9307@wordpress.org> Message-ID: <068.eebcb62ef6729890c04dc86ba0ce12f3@wordpress.org> #55292: Custom REST Endpoints without Regex -----------------------------+-------------------------------------- Reporter: encoredev | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Awaiting Review Component: REST API | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: 2nd-opinion | Focuses: accessibility, rest-api -----------------------------+-------------------------------------- Changes (by encoredev): * status: assigned => closed * resolution: => invalid Comment: Please delete this ticket -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 10:41:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 10:41:09 -0000 Subject: [wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter In-Reply-To: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> References: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> Message-ID: <063.f47d42e1e72b72fe39f2063e621faec7@wordpress.org> #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter --------------------------+--------------------- Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:25:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:25:14 -0000 Subject: [wp-trac] [WordPress Trac] #22176: Cache the results of the posts_request_ids query In-Reply-To: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> References: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> Message-ID: <063.7794c8c086f5aa6e37ca1309673668ff@wordpress.org> #22176: Cache the results of the posts_request_ids query -------------------------------------------------+------------------------- Reporter: ryan | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Query | Version: 3.4.2 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:25:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:25:24 -0000 Subject: [wp-trac] [WordPress Trac] #22176: Cache the results of the posts_request_ids query In-Reply-To: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> References: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> Message-ID: <063.bff422460451f17d0a4f722a9e4c9127@wordpress.org> #22176: Cache the results of the posts_request_ids query -------------------------------------------------+------------------------- Reporter: ryan | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Query | Version: 3.4.2 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * milestone: Future Release => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:26:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:26:10 -0000 Subject: [wp-trac] [WordPress Trac] #22176: Cache the results of the posts_request_ids query In-Reply-To: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> References: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> Message-ID: <063.c86413a98fd82e350c38b6c8a815f2bf@wordpress.org> #22176: Cache the results of the posts_request_ids query -------------------------------------------------+------------------------- Reporter: ryan | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Query | Version: 3.4.2 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * milestone: 6.0 => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:30:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:30:39 -0000 Subject: [wp-trac] [WordPress Trac] #55283: Text not aligned properly in the mobile view In-Reply-To: <052.59dd929e29ac220c37e9249958cab8d0@wordpress.org> References: <052.59dd929e29ac220c37e9249958cab8d0@wordpress.org> Message-ID: <067.a0ca3fc17f68ab4ae8c2369a0dc53615@wordpress.org> #55283: Text not aligned properly in the mobile view -------------------------------------------------+------------------------- Reporter: hilayt24 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: needs-patch needs-design-feedback | Focuses: ui, css has-screenshots | -------------------------------------------------+------------------------- Comment (by aezazshekh): Hello @hilayt24 You create this ticket in meta ticket. Because this issue is of meta. Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:44:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:44:10 -0000 Subject: [wp-trac] [WordPress Trac] #36907: Improved sticky post query In-Reply-To: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> References: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> Message-ID: <071.02f98d91fd299f0e2a5c913c31fbb876@wordpress.org> #36907: Improved sticky post query ----------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Query | Version: 3.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: performance ----------------------------------------+--------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey * status: new => assigned * milestone: => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:50:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:50:21 -0000 Subject: [wp-trac] [WordPress Trac] #22174: _get_non_cached_ids() should use wp_cache_get_multi(), if available. In-Reply-To: <048.9654c1c67804027a34cb6daee918bb2f@wordpress.org> References: <048.9654c1c67804027a34cb6daee918bb2f@wordpress.org> Message-ID: <063.70dd2f9e049f76e4134000eaf7707bba@wordpress.org> #22174: _get_non_cached_ids() should use wp_cache_get_multi(), if available. --------------------------+------------------------ Reporter: ryan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Cache API | Version: 3.4.2 Severity: normal | Resolution: duplicate Keywords: has-patch | Focuses: --------------------------+------------------------ Changes (by spacedmonkey): * status: reopened => closed * resolution: => duplicate Comment: Duplicate of #50352. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 11:51:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 11:51:14 -0000 Subject: [wp-trac] [WordPress Trac] #22174: _get_non_cached_ids() should use wp_cache_get_multi(), if available. In-Reply-To: <048.9654c1c67804027a34cb6daee918bb2f@wordpress.org> References: <048.9654c1c67804027a34cb6daee918bb2f@wordpress.org> Message-ID: <063.631a8efe1d6b699cb0e6ff0aafc43816@wordpress.org> #22174: _get_non_cached_ids() should use wp_cache_get_multi(), if available. --------------------------+------------------------ Reporter: ryan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Cache API | Version: 3.4.2 Severity: normal | Resolution: duplicate Keywords: has-patch | Focuses: --------------------------+------------------------ Comment (by spacedmonkey): Fixed in [48055] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 12:08:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 12:08:53 -0000 Subject: [wp-trac] [WordPress Trac] #36905: Add caching to get_page_by_title In-Reply-To: <056.ef040fcd3b1e628ea8b55361c56dd2ea@wordpress.org> References: <056.ef040fcd3b1e628ea8b55361c56dd2ea@wordpress.org> Message-ID: <071.d64d06f1f547ea0ffba1194f4a8386a7@wordpress.org> #36905: Add caching to get_page_by_title -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: igmoweb Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Posts, Post Types | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch good-first-bug has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): @igmoweb Are you willing to work on this patch still? I am willing to pick it up otherwise. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 12:54:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 12:54:05 -0000 Subject: [wp-trac] [WordPress Trac] #55294: Origin theme's Infinite Scroll does not work properly Message-ID: <060.4a179ceeefacc3eb60689e39bc2ec046@wordpress.org> #55294: Origin theme's Infinite Scroll does not work properly ------------------------------+----------------------------- Reporter: benflooringgroup | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | ------------------------------+----------------------------- Hello there For our website, www.theflooringgroup.co.uk, the Infinite Scroll does not always work properly - for example, on this page; https://www.theflooringgroup.co.uk/category/portfolio/portfolio-carpets/, the scroll does not go down further at the moment then it should do. We have found this to be very temperamental - sometimes it does scroll all the way down and sometimes it doesn't. Thereby, can you assist in this please? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 13:21:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 13:21:06 -0000 Subject: [wp-trac] [WordPress Trac] #55220: Legacy widgets lack access to some usual server-side globals In-Reply-To: <054.43d150aa3ca3b7b75495953f66eec8e4@wordpress.org> References: <054.43d150aa3ca3b7b75495953f66eec8e4@wordpress.org> Message-ID: <069.799b7a02b162e9b4eecf2aa450330bd0@wordpress.org> #55220: Legacy widgets lack access to some usual server-side globals --------------------------+----------------------------- Reporter: noisysocks | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Widgets | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: => needs-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 13:24:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 13:24:16 -0000 Subject: [wp-trac] [WordPress Trac] #55291: Can't access Custom CSS with theme Twenty Twenty-Two In-Reply-To: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> References: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> Message-ID: <071.948a37aac668bde325626ebaa9445786@wordpress.org> #55291: Can't access Custom CSS with theme Twenty Twenty-Two -------------------------------+------------------------------ Reporter: DeveloperWil | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9.1 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by audrasjb): * keywords: => reporter-feedback Comment: Hello and welcome back to WordPress Core Trac @DeveloperWil, I'm not sure I completely understand you point, but as far as I know (and even before block themes appeared), you always loose Custom CSS added with the customizer when you switch theme. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 13:24:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 13:24:35 -0000 Subject: [wp-trac] [WordPress Trac] #55291: Can't access Custom CSS with theme Twenty Twenty-Two In-Reply-To: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> References: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> Message-ID: <071.aba82aaf9e453dad5a0e45c29f60ffb5@wordpress.org> #55291: Can't access Custom CSS with theme Twenty Twenty-Two -------------------------------+------------------------------ Reporter: DeveloperWil | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by audrasjb): * version: 5.9.1 => 5.9 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 14:36:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 14:36:53 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.343360098ead2f89f553ce96b9d0e68d@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: Keywords: has-unit-tests early has-patch | Focuses: needs-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * owner: (none) => spacedmonkey -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 14:48:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 14:48:01 -0000 Subject: [wp-trac] [WordPress Trac] #55295: Child Thema can't export templates Message-ID: <051.01327736193964661bf3f8f42b1c4b01@wordpress.org> #55295: Child Thema can't export templates --------------------------+----------------------------- Reporter: emeldir | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I added a child theme for twenty twenty-two. When I tried to export the template part I was working on, it failed. It either produced a zip you could not open or gave a generic error message "An error occurred while creating the site export." Switching back to the parent theme resolves the issue, export is working fine there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 14:58:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 14:58:25 -0000 Subject: [wp-trac] [WordPress Trac] #55212: PHP Notice: Array to string conversion in admin ajax points. In-Reply-To: <048.1eddc1f78fdac1ef1b1389f7d6a0dfd0@wordpress.org> References: <048.1eddc1f78fdac1ef1b1389f7d6a0dfd0@wordpress.org> Message-ID: <063.018c9cd55eebb49f8ebb8c545d6be738@wordpress.org> #55212: PHP Notice: Array to string conversion in admin ajax points. ----------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: lowest | Milestone: 6.0 Component: Administration | Version: Severity: trivial | Resolution: fixed Keywords: has-patch | Focuses: ----------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52813" 52813]: {{{ #!CommitTicketReference repository="" revision="52813" Administration: Require a valid action parameter to be set for `admin- ajax.php` requests. This avoids `Array to string conversion` PHP notices when an array is passed as the `action` parameter. Additionally, send an appropriate HTTP response status code when an invalid action is passed to `admin-post.php`. Follow-up to [13175], [19738], [41120], [41926]. Props dd32. Fixes #55212. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 15:00:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 15:00:58 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.284dead2bc3d089548d4d66aea2bdcf9@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by joyously): > I did not get your first point. The mismatched version error is shown at the top of the box. This alone can make the boxes uneven. ''(This screenshot is my normal window width.)'' [[Image(https://i.postimg.cc/8zsLdQjp/Add-Plugins.jpg)]] ------ > Yes if we add more description lines to show then it mismatches the alignment of the boxes I think it's more important to see the complete sentence of the description than to have even boxes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 15:11:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 15:11:03 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.cec9e95b7b7a7a5d79309e87c67cc5f2@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: fixed Keywords: has-unit-tests early has-patch | Focuses: needs-dev-note | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"52814" 52814]: {{{ #!CommitTicketReference repository="" revision="52814" Bootstrap/Load: Stop unnecessary queries when using the `do_parse_request` filter. Developers of plugins and themes can use the `do_parse_request` filter to hot-wire requests and hook in early to render custom pages. However, even through these request may not need post queries and 404 lookups to be run, they run anyway. This can results in unnecessary SQL queries running on these requests. By adding a return value to the `parse_request` method of the `WP` class, these queries can now be skipped. Props junsuijin, ryan, westi, sivel, dd32, wonderboymusic, arnee, tyxla, DrewAPicture, lukecavanagh, SergeyBiryukov, davidbaumwald, Spacedmonkey, pbearne. Fixes #10886. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 15:38:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 15:38:41 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.16cd64f96f24a6b05b09f58240bf5ca2@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: fixed Keywords: has-unit-tests early has-patch | Focuses: needs-dev-note | performance -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): In [changeset:"52815" 52815]: {{{ #!CommitTicketReference repository="" revision="52815" Docs: Add a `@since` note for `WP::parse_request()` about the new return value. Includes minor code layout fixes for consistency. Additionally, this moves a more general unit test above the more specific one. Follow-up to [52814]. See #10886. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 15:44:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 15:44:38 -0000 Subject: [wp-trac] [WordPress Trac] #55295: Editor: Child Theme can't export templates (was: Child Thema can't export templates) In-Reply-To: <051.01327736193964661bf3f8f42b1c4b01@wordpress.org> References: <051.01327736193964661bf3f8f42b1c4b01@wordpress.org> Message-ID: <066.7332d307e3bedaea764d73efb4c54c43@wordpress.org> #55295: Editor: Child Theme can't export templates --------------------------+------------------------------ Reporter: emeldir | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by emeldir): * component: Themes => Editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 16:03:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 16:03:40 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.17d2cbd9880f03eae1aed6dcfa9026d9@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by SergeyBiryukov): Replying to [comment:7 sharjeelkhanvmi]: > What's that? Just editing the keywords and focus for better visibility, see [https://make.wordpress.org/core/handbook/contribute/trac/keywords/ Trac Workflow Keywords]. Replying to [comment:8 joyously]: > I think it's more important to see the complete sentence of the description than to have even boxes. I tend to agree, even boxes may look nice at a glance but it seems like they are not really feasible if we take full descriptions and plugin compatibility notices into account. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 16:05:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 16:05:29 -0000 Subject: [wp-trac] [WordPress Trac] #55294: Origin theme's Infinite Scroll does not work properly In-Reply-To: <060.4a179ceeefacc3eb60689e39bc2ec046@wordpress.org> References: <060.4a179ceeefacc3eb60689e39bc2ec046@wordpress.org> Message-ID: <075.bdd50a647923ffec62b6ca858387bc6e@wordpress.org> #55294: Origin theme's Infinite Scroll does not work properly ------------------------------+---------------------- Reporter: benflooringgroup | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: ------------------------------+---------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi there, welcome to WordPress Trac! Thanks for the ticket. I'm sorry to hear you are having issues with your website. Please note that this Trac is used for enhancements and bug reporting for the WordPress core software, not for individual support questions. Please try the support forums to get help with your site: https://wordpress.org/support/forums/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 16:43:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 16:43:49 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.02b3eb75eed3ff6779546c5d34e6b9d0@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by adamsilverstein): * Attachment "Media Library ‹ test — WordPress 2022-03-02 09-43-29.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 16:45:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 16:45:34 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.99e403bbe0836673fab3300b04c3f3f2@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): @mitogh thanks for raising this issue. in my testing, when I uploaded a VERY large image, I got an error "{file} exceeds the maximum upload size for this site." when I tested with your image, I got a server error that at least suggested I try a smaller image: "The server cannot process the image. This can happen if the server is busy or does not have enough resources to complete the task. Uploading a smaller image may help. Suggested maximum size is 2560 pixels." How would you propose improving this? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 16:47:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 16:47:31 -0000 Subject: [wp-trac] [WordPress Trac] #55295: Editor: Child Theme can't export templates In-Reply-To: <051.01327736193964661bf3f8f42b1c4b01@wordpress.org> References: <051.01327736193964661bf3f8f42b1c4b01@wordpress.org> Message-ID: <066.82c41b470241616cc2d18968dbd8f732@wordpress.org> #55295: Editor: Child Theme can't export templates --------------------------+------------------------------ Reporter: emeldir | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+------------------------------ Changes (by emeldir): * status: new => closed * resolution: => invalid Comment: Added this over at the Gutenberg repro. Prob fits better there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:04:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:04:17 -0000 Subject: [wp-trac] [WordPress Trac] #36905: Add caching to get_page_by_title In-Reply-To: <056.ef040fcd3b1e628ea8b55361c56dd2ea@wordpress.org> References: <056.ef040fcd3b1e628ea8b55361c56dd2ea@wordpress.org> Message-ID: <071.44cd12acf94779a0bd23b055e8518c80@wordpress.org> #36905: Add caching to get_page_by_title -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: igmoweb Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Posts, Post Types | Version: 2.1 Severity: normal | Resolution: Keywords: has-patch good-first-bug has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Comment (by igmoweb): @spacedmonkey Feel free to take it again, thanks :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:13:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:13:15 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.6a6cb386f5149272e750367977331279@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by adamsilverstein): Good catch @mitogh! Looks like some conditional checks for in image- edit.php aren't working as expected. In my testing this happened when the i rotated to the vertical position. rotating again and saving my medium_large size was correctly edited. flipping images always seemed to work. cropping worked until i tried a vertical thin crop, then some sizes were saved and others not. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:22:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:22:19 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images Message-ID: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> #55296: Issue with Images --------------------------+----------------------------- Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Keywords: needs-patch Focuses: | --------------------------+----------------------------- Hello, I've have two clients report to me there websites are missing image links. I've spoken to my host and they think it could be a cache issue. Images are on the media library but on the website they have all broken links? https://i0.wp.com/smoothssecrets.co.uk/wp- content/uploads/2020/11/rsz_1lady.png?w=1019&ssl=1 Why would my client, have images coming from that address when the images are hosted directly on the server? I have tried fixing the database and no php errors are showing apart from this. I had to restore the last clients website and will have to do the same thing. Can you please look into this, both websites are running the latest version of WordPress and I do not know when this happened apart from the last 6 months. It has also been ruled out as a plugin -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:24:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:24:27 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.dcc006bb50b484fe98c8fb6ee960a253@wordpress.org> #55296: Issue with Images --------------------------+------------------------------ Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by lyntreeio): * Attachment "Screenshot 2022-03-02 at 17.23.19.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:24:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:24:37 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.94edd89d6226751a110e8bf49d509246@wordpress.org> #55296: Issue with Images --------------------------+------------------------------ Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by lyntreeio): * Attachment "Screenshot 2022-03-02 at 17.23.27.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:24:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:24:45 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.fe8ff0b9af15d20141c733e2a158cf0a@wordpress.org> #55296: Issue with Images --------------------------+------------------------------ Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by lyntreeio): * Attachment "Screenshot 2022-03-02 at 17.23.36.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:26:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:26:44 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. Message-ID: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> #55297: The $is_edge global returns false. -------------------------+------------------------------------------------- Reporter: costdev | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Keywords: good-first-bug needs-patch needs- Focuses: | testing has-testing-info -------------------------+------------------------------------------------- `$is_edge` is `true` when "Edge" is detected. However, user agents for Edge have changed such that "Edg" is the only consistent substring across devices. As a result, `$is_edge` returns `false`. Changing the substring to "Edg" in `src/wp-includes/vars.php:68` seems to fix this. Steps to reproduce and test the solution: 1. Add this to `functions.php`: {{{#!php global $is_edge; die( var_export( $is_edge, true ) ); }}} 2. Load any page. `false` should be displayed. 3. Change "Edge" to "Edg" in `src/wp-includes/vars.php:68`. 4. Reload the page. `true` should now be displayed. Reference: [https://docs.microsoft.com/en-us/microsoft-edge/web-platform /user-agent-guidance#identifiers-for-microsoft-edge-on-various-platforms Microsoft Docs - Identifiers for Microsoft Edge on various platforms] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:35:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:35:54 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.6d9eda8ba69cf4bbb947101aab2ecdaa@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by mitogh): Right, it seems like the issue happens for rotation specifically on images that do not have dimensions like a landscape or portrait image if is rotated the dimensions are different, flip works normally on my end due to the image dimensions are not modified from the original image. Let me know in case you have any additional questions. @adamsilverstein, thanks for taking a look and replicating the steps for this issue. ''If time allows I can try to find a patch for this one as well.'' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:55:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:55:17 -0000 Subject: [wp-trac] [WordPress Trac] #55298: How do I turn off this mandatory verification for new users accessing the site? Message-ID: <053.c0dd536325457d2abae6a247b525c107@wordpress.org> #55298: How do I turn off this mandatory verification for new users accessing the site? ---------------------------+----------------------------- Reporter: jason7912 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- **Our system thinks you might be a robot! We're really sorry about this, but it's getting harder and harder to tell the difference between humans and bots these days. Please complete the captcha below to prove you're a human and proceed to the page you're trying to reach. This page requires cookies to be enabled in your browser settings. Please check this setting and enable cookies (if disabled). sid:343---** Why do buyers get this message when they visit my website? In between, the visiting user is also required to enter a verification code. What is the best way to turn off this mandatory input? Please help! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 17:56:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 17:56:26 -0000 Subject: [wp-trac] [WordPress Trac] #55298: How do I turn off this mandatory verification for new users accessing the site? In-Reply-To: <053.c0dd536325457d2abae6a247b525c107@wordpress.org> References: <053.c0dd536325457d2abae6a247b525c107@wordpress.org> Message-ID: <068.0a7e170997dba1cbef5c6085b8884519@wordpress.org> #55298: How do I turn off this mandatory verification for new users accessing the site? --------------------------+------------------------------ Reporter: jason7912 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: accessibility --------------------------+------------------------------ Changes (by jason7912): * Attachment "微信图片_20220303015535.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:01:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:01:27 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.4cb0883313d77819b2932fd96fb9656a@wordpress.org> #55296: Issue with Images --------------------------+------------------------------ Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Resolution: Keywords: close | Focuses: --------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: needs-patch => close Comment: Replying to [ticket:55296 lyntreeio]: > https://i0.wp.com/smoothssecrets.co.uk/wp- content/uploads/2020/11/rsz_1lady.png?w=1019&ssl=1 > > Why would my client, have images coming from that address when the images are hosted directly on the server? Hi there, welcome to WordPress Trac! Thanks for the ticket. I'm sorry to hear you are having issues with your website. The site appears to use the [https://jetpack.com/support/site-accelerator/ Jetpack Site Accelerator] module (formerly Photon). Opening the linked image URL displays an error message: {{{ We cannot complete this request, remote server returned an unexpected status code (400) }}} WordPress core does not have a CDN module like that, so I would suggest trying the support forums to get help with your site: https://wordpress.org/support/forums/, or the [https://wordpress.org/support/plugin/jetpack/ Jetpack support forums] specifically. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:01:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:01:55 -0000 Subject: [wp-trac] [WordPress Trac] #48634: Images disappeared after updating to 5.3 In-Reply-To: <058.860d3673e341d8451f5823d2c4db7c10@wordpress.org> References: <058.860d3673e341d8451f5823d2c4db7c10@wordpress.org> Message-ID: <073.9778261fa57daf999378ece602f5d1c0@wordpress.org> #48634: Images disappeared after updating to 5.3 ----------------------------+---------------------- Reporter: bluerootsradio | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.3 Severity: major | Resolution: invalid Keywords: | Focuses: ----------------------------+---------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:07:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:07:41 -0000 Subject: [wp-trac] [WordPress Trac] #55298: How do I turn off this mandatory verification for new users accessing the site? In-Reply-To: <053.c0dd536325457d2abae6a247b525c107@wordpress.org> References: <053.c0dd536325457d2abae6a247b525c107@wordpress.org> Message-ID: <068.eaed4deb17498657cecb38720226597d@wordpress.org> #55298: How do I turn off this mandatory verification for new users accessing the site? --------------------------+---------------------------- Reporter: jason7912 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: | Focuses: accessibility --------------------------+---------------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi there, welcome to WordPress Trac! Thanks for the ticket. I'm sorry to hear you are having issues with your website. WordPress core does not have a verification page like that, it may be created by a plugin or your hosting provider. Please note that this Trac is used for enhancements and bug reporting for the WordPress core software, not for individual support questions. Please try the support forums to get help with your site: https://wordpress.org/support/forums/. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:11:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:11:01 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.2e79e601d7d247e2d4c18c88efcf3cc8@wordpress.org> #55296: Issue with Images --------------------------+------------------------------ Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: critical | Resolution: worksforme Keywords: close | Focuses: --------------------------+------------------------------ Changes (by lyntreeio): * status: new => closed * resolution: => worksforme Comment: Hi, Thank you for letting me know this, I'll take it up directly with JetPack and see what can be done to resolve this issue. Kindest Regards, Bridget -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:43:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:43:25 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.198d7f73afdf0b93cec45d2612b7c509@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by mitogh): @adamsilverstein interesting I was not able to face any of those errors and the image was uploaded, the problem was that the subsizes where not created, my current size limit is 100MB tho, in my setup Imagemagick is used to process the images. Looking into more detail (specifically into the Imagemagick implementation) looks like the problem is because it creates a larger image 5 times larger actually than the uploaded image, which for larger images like the one from this issue consumes large portion of memory. - https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp- includes/class-wp-image-editor-imagick.php#L363 From my point of view, when a large image is uploaded or when the image is bigger than the threshold there's no real need/benefit in resampling as images are going to be created in smaller sizes instead. I can explore a bit more for imagemagick, but just commenting that line of code makes the rest of the subsizes work as expected. Maybe some additional logic can be added in place to consider the scenario when the resampling is not required. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:51:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:51:25 -0000 Subject: [wp-trac] [WordPress Trac] #55299: website shutdown Message-ID: <058.1bf21ea580d37b4be203eb8d7c598bab@wordpress.org> #55299: website shutdown ----------------------------+----------------------------- Reporter: arnaudtexier64 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: blocker | Keywords: Focuses: | ----------------------------+----------------------------- Hi, my website is down due to a problem I can't fix. I updated my PHP to 7.4 (stable64) but impossible to find a solution, and access to my recovery mode) Can you help me ? cheers, Arnaud -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 18:57:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 18:57:47 -0000 Subject: [wp-trac] [WordPress Trac] #55300: tests for WP_List_Util::pluck and WP_List_Util::sort Message-ID: <051.dd5ff02912bce1bb03a5640324c5d38c@wordpress.org> #55300: tests for WP_List_Util::pluck and WP_List_Util::sort ------------------------------+----------------------------- Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Keywords: Focuses: | ------------------------------+----------------------------- I created so test for the WP_List_Util::pluck and WP_List_Util::sort function and fixed a couple of edge cases -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:01:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:01:36 -0000 Subject: [wp-trac] [WordPress Trac] #55299: website shutdown In-Reply-To: <058.1bf21ea580d37b4be203eb8d7c598bab@wordpress.org> References: <058.1bf21ea580d37b4be203eb8d7c598bab@wordpress.org> Message-ID: <073.eddcc9b1573260beb4e60b0065d3f3bf@wordpress.org> #55299: website shutdown ----------------------------+---------------------- Reporter: arnaudtexier64 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: ----------------------------+---------------------- Changes (by costdev): * status: new => closed * resolution: => invalid * component: Plugins => General * severity: blocker => normal * milestone: Awaiting Review => Comment: Hi @arnaudtexier64, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:13:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:13:41 -0000 Subject: [wp-trac] [WordPress Trac] #55293: Getting malware attack per day In-Reply-To: <054.69fd4c507263fa6692f6b4e6859b9f3e@wordpress.org> References: <054.69fd4c507263fa6692f6b4e6859b9f3e@wordpress.org> Message-ID: <069.d63d3800b021e31b9104d068136f718d@wordpress.org> #55293: Getting malware attack per day --------------------------+---------------------- Reporter: ravipaswan | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * focuses: performance, privacy => * severity: critical => normal * component: Security => General * version: 5.9.1 => * milestone: Awaiting Review => * resolution: => invalid Comment: Hi @ravipaswan, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:45:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:45:42 -0000 Subject: [wp-trac] [WordPress Trac] #54915: Username, email and password fields must be ltr in rtl locale In-Reply-To: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> References: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> Message-ID: <068.b5cfccadf9b5cb7f5f42d6c09ec0a653@wordpress.org> #54915: Username, email and password fields must be ltr in rtl locale -------------------------------------+------------------------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: normal | Resolution: Keywords: needs-patch has- | Focuses: ui, css, rtl, screenshots has-testing-info | administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * Attachment "54915.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:47:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:47:40 -0000 Subject: [wp-trac] [WordPress Trac] #54915: Username, email and password fields must be ltr in rtl locale In-Reply-To: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> References: <053.4f38abea21a29f9eb209358027b8e501@wordpress.org> Message-ID: <068.6a2407445420e69e56d35a6ce3dce7f2@wordpress.org> #54915: Username, email and password fields must be ltr in rtl locale -------------------------------------+------------------------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-screenshots has- | Focuses: ui, css, rtl, testing-info has-patch | administration -------------------------------------+------------------------------------- Changes (by sabernhardt): * keywords: needs-patch has-screenshots has-testing-info => has- screenshots has-testing-info has-patch * milestone: Awaiting Review => 6.0 Comment: The common.css file has had a `.ltr` class for this, but that is not included on the login screen. I added the class to forms.css and included password-type inputs. {{{ /* rtl:ignore */ .ltr, input[type="password"], input[type="email"], input[type="url"] { direction: ltr; } }}} The patch adds the `ltr` class to several inputs. **Login:** username, password **Install:** username, password **User Edit (Profile):** username, password, application password **New User:** username, password I expect I missed at least one more input that needs the class, too. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:52:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:52:09 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.4681f3f101b8fcb1706a374625d9a6a6@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by adamsilverstein): Interesting! The comment there implies this makes resizing more efficient.. This was introduced in https://github.com/WordPress/wordpress- develop/commit/e2d2c45c6b7ed013139be7ab8f3833750684e28d maybe we can skip doing this when the original file is already so large? cc: @mikeschroder -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 19:54:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 19:54:58 -0000 Subject: [wp-trac] [WordPress Trac] #9883: Password shows under Settings / Writing In-Reply-To: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> References: <051.e255d5d4a3c9798d3dd132222867f489@wordpress.org> Message-ID: <066.0a11d3f53a3740f8d16d5ad652b932e2@wordpress.org> #9883: Password shows under Settings / Writing -------------------------------------------------+------------------------- Reporter: mastrup | Owner: (none) Type: enhancement | Status: assigned Priority: low | Milestone: 6.0 Component: Administration | Version: 2.7.1 Severity: trivial | Resolution: Keywords: has-patch needs-testing has- | Focuses: ui, testing-info | accessibility -------------------------------------------------+------------------------- Comment (by sabernhardt): The updated patch has a problem with password managers, just as the login screen does (#48222). The previous version of the PR used code from the Profile screen's New Password visibility button instead of the login's icon-only style. I also have these concerns with the latest version: 1. When the page loads, it automatically focuses on the password field, but there are important fields before that. 2. The `ltr` class should not be removed from the text/password input. See #54915. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 20:30:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 20:30:19 -0000 Subject: [wp-trac] [WordPress Trac] #53965: Legacy widgets used inside a normal block fail when salts are changed In-Reply-To: <055.b722b642096472f6051cf9982a1f780f@wordpress.org> References: <055.b722b642096472f6051cf9982a1f780f@wordpress.org> Message-ID: <070.d370e86e96fcad15cf4e980ea64fb565@wordpress.org> #53965: Legacy widgets used inside a normal block fail when salts are changed --------------------------+--------------------------------------- Reporter: Enchiridion | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Widgets | Version: 5.8 Severity: major | Resolution: Keywords: | Focuses: administration, rest-api --------------------------+--------------------------------------- Comment (by CockpitSeeker): +1 This is big and was unavoidable here after switching to the block system with pre-existing legacy widgets. I would go as far as saying this is a major deterrent against the whole block paradigm adoption. Suffice to say, at this date the "Classic Widgets" plugin has 900,000+ installs... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 21:24:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 21:24:14 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.957eb22afabfd317d782e95f3a9a93e0@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug needs-patch needs- | Focuses: testing has-testing-info | -------------------------------------------------+------------------------- Changes (by abdullahramzan): * Attachment "55297-03032022.diff" added. Fix for 55297 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 21:27:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 21:27:12 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.7b83d2525e136e872b241442b8699e44@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch | -------------------------------------------------+------------------------- Changes (by abdullahramzan): * keywords: good-first-bug needs-patch needs-testing has-testing-info => good-first-bug has-testing-info has-patch Comment: Hi @costdev, Thanks for submitting the ticket with a useful guide & test information. I have created a patch & tested it locally. It looks good to me. Webpage returning true when opening in Microsoft Edge. Best Regards, -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 21:46:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 21:46:56 -0000 Subject: [wp-trac] [WordPress Trac] #54042: Extending wpdb::prepare() to support table/field names, and IN() operator In-Reply-To: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> References: <056.f04485e63ca681f362f38671080f1fa1@wordpress.org> Message-ID: <071.946387c8b149b5a8b5957e894e386283@wordpress.org> #54042: Extending wpdb::prepare() to support table/field names, and IN() operator -------------------------------------------------+------------------------- Reporter: craigfrancis | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: testing early has-unit-tests | -------------------------------------------------+------------------------- Changes (by craigfrancis): * milestone: Future Release => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 22:21:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 22:21:44 -0000 Subject: [wp-trac] [WordPress Trac] #42952: Add comments about JS removal of message query_arg In-Reply-To: <054.9aa6fe6f3265ee6371064cceb1a710a2@wordpress.org> References: <054.9aa6fe6f3265ee6371064cceb1a710a2@wordpress.org> Message-ID: <069.0abe71b93c62e1f7f3cf1a5f4c156198@wordpress.org> #42952: Add comments about JS removal of message query_arg ----------------------------+----------------------------------- Reporter: davidsword | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 4.9.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: docs, administration ----------------------------+----------------------------------- Changes (by davidbaumwald): * keywords: => needs-patch * component: Comments => Administration Comment: @davidsword Thanks for the ticket! This technically is not related to the `Comments` component and pertains to docs-type comments, which I think is what you're requesting. Setting the component to `Administration` so it can be picked up by that group. Specifically looking at this issue, it seems the needs to document this a bit better was realized back in [25819]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 22:23:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 22:23:22 -0000 Subject: [wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter In-Reply-To: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> References: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> Message-ID: <063.c5d56a639989087893b05039ce97915f@wordpress.org> #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter --------------------------+---------------------------- Reporter: dd32 | Owner: davidbaumwald Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+---------------------------- Changes (by davidbaumwald): * owner: (none) => davidbaumwald * status: new => reviewing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 2 23:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 02 Mar 2022 23:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) In-Reply-To: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> References: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> Message-ID: <070.d74d0c0109f13984350972fb7289ee89@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+------------------------------ Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -------------------------+------------------------------ Comment (by peterwilsoncc): Can you please answer each of the questions of the [https://make.wordpress.org/core/handbook/contribute/design-decisions /#adding-new-oembed-providers checklist for adding new oEmbed providers] to the allow list? The quickest way to get embeds working for your site would be to limit the HTML to the allowed list of tags for auto-discovery, this includes links, blockquotes and iframes with a limited set of attributes. See https://github.com/WordPress/wordpress- develop/blob/107050f7a34d0b728e4c38bfc946e3339578ea6f/src/wp- includes/embed.php#L921-L936 For iframes, you'd also need to ensure any JavaScript and other code within the embed can be run in iframes with the attributes `sandbox ="allow-scripts" security="restricted"`. By enabling auto-discovery, your site's embeds will work on both WordPress versions below 6.0 and you won't need to go through the checklist above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 00:54:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 00:54:38 -0000 Subject: [wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter In-Reply-To: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> References: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> Message-ID: <063.53f609fcca0acd74cc3b0c3cd7fa811f@wordpress.org> #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter -------------------------------------+---------------------------- Reporter: dd32 | Owner: davidbaumwald Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+---------------------------- Changes (by davidbaumwald): * keywords: has-patch => has-patch needs-refresh Comment: @dd32 After [52205], the [https://core.trac.wordpress.org/attachment/ticket/54379/54379.2.diff 54379.2.diff] doesn't apply cleanly. More importantly, the inline docs there were updated to have the `$comment_ID` param to expect a `string`. Should this be corrected back to `int` while also casting the `$comment_ID` to an `(int)`? Is it your preference to handle the other related notices here as well, or should those be split off into separate tickets? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 02:03:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 02:03:34 -0000 Subject: [wp-trac] [WordPress Trac] #55289: Large image fails to create a `scaled` version and subsizes In-Reply-To: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> References: <050.475807dd2487e5fcc54fab63c254fe95@wordpress.org> Message-ID: <065.07e4f994c6d2a683d20ccc730069b01f@wordpress.org> #55289: Large image fails to create a `scaled` version and subsizes --------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by mikeschroder): Replying to [comment:3 adamsilverstein]: > Interesting! The comment there implies this makes resizing more efficient.. > > This was introduced in https://github.com/WordPress/wordpress- develop/commit/e2d2c45c6b7ed013139be7ab8f3833750684e28d maybe we can skip doing this when the original file is already so large? cc: @mikeschroder Thanks for the ping! I can't remember why it would make it more efficient off the top of my head, unless maybe there was more multi-sampling going on if it's not set. I'll look into this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 02:05:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 02:05:12 -0000 Subject: [wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter In-Reply-To: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> References: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> Message-ID: <063.4ab925efacff2384d38d47632055bf37@wordpress.org> #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter --------------------------+---------------------------- Reporter: dd32 | Owner: davidbaumwald Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+---------------------------- Comment (by dd32): Replying to [comment:6 davidbaumwald]: > More importantly, the inline docs there were updated to have the `$comment_ID` param to expect a `string`. Should this be corrected back to `int` while also casting the `$comment_ID` to an `(int)`? While I don't agree with the whole `A numeric string, for compatibility reasons.` stuff, I don't see any benefit in casting to an int here, might as well just continue the status-quo of a numeric string. > Is it your preference to handle the other related notices here as well, or should those be split off into separate tickets? I don't see the harm in fixing multiple similar things in a singular ticket. I'd just manually apply the diff if I was committing this.. but happy to refresh it for you. Looks like [attachment:"54379.comments_open.diff"] was handled in [52223]. https://github.com/WordPress/wordpress-develop/pull/2373 should be the remaining diffs from the attachments here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 03:39:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 03:39:16 -0000 Subject: [wp-trac] [WordPress Trac] #55301: Provide an API to prevent certain blocks being shown in Widget Areas Message-ID: <054.c9987188ae18b3032cf99143e88d3151@wordpress.org> #55301: Provide an API to prevent certain blocks being shown in Widget Areas -------------------------+------------------------- Reporter: noisysocks | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Keywords: needs-patch Focuses: | -------------------------+------------------------- Copied from https://github.com/WordPress/gutenberg/issues/28517. See discussion there. --- ## What problem does this address? With the introduction of Widget Areas, Gutenberg assumes all existing blocks will work in this context. We have a use case where some blocks may not work as widgets, or may conflict with legacy widgets or things such as shortcodes. https://github.com/woocommerce/woocommerce-gutenberg-products- block/pull/3737 Gutenberg does provide the `widgets_to_exclude_from_legacy_widget_block ` filter, but this only works on widgets. Unlike in the post editor screen (which provides `allowed_block_types `) there doesn't appear to be an filter, supports variable, or any API we can use to state that a block should not appear in this context. ## What is your proposed solution? Some form of supports flag when the block is registered, or an allow/denylist where the block can be excluded from the widget area block inserter. Our current solution/workaround is to check if `'themes.php' === $pagenow` and not register the block. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 03:53:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 03:53:58 -0000 Subject: [wp-trac] [WordPress Trac] #55301: Provide an API to prevent certain blocks being shown in Widget Areas In-Reply-To: <054.c9987188ae18b3032cf99143e88d3151@wordpress.org> References: <054.c9987188ae18b3032cf99143e88d3151@wordpress.org> Message-ID: <069.95f822f2560f908b25d9cb19a4d47951@wordpress.org> #55301: Provide an API to prevent certain blocks being shown in Widget Areas -----------------------------------------------------+--------------------- Reporter: noisysocks | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev-note | Focuses: -----------------------------------------------------+--------------------- Changes (by noisysocks): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- dev-note -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 04:56:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 04:56:51 -0000 Subject: [wp-trac] [WordPress Trac] #55302: Improve media library upload progress indicator Message-ID: <059.94226db16681b851e6132e94d124d7cc@wordpress.org> #55302: Improve media library upload progress indicator -----------------------------+----------------------------- Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- When uploading in the media library, the progress bar shows the ''upload progress'' of the image. Once the image is fully uploaded WordPress creates the sub-sized images used to serve images on the front end. Depending on your configuration (theme, plugins, server), and the upload size this can take quite a while to complete. During sub-sized image creation, the progress bar for the image shows as "full". Finally, when the image sub size generation completes, the image changes from a gray box to the thumbnail of the uploaded image and if multiple images have been uploaded, the uploader moves on to the next image. Screencast attached. The problem here is that no progress is shown for the image regeneration phase. Uploading in the block editor works a bit differently: as soon as the image is dropped onto the editor to upload, a grayed out version of the image is shown with a spinner. The spinner spins during the upload and continues spinning during sub-size creation. Finally, when all sub sizes are created, the image becomes fully saturated and the spinner goes away. **Looks like this is changing to a progress bar though**, see https://github.com/WordPress/gutenberg/issues/13984 & https://github.com/WordPress/gutenberg/tree/trunk/packages/block- editor/src/components/media-upload-progress Two potential improvements we could make in the media library: 1. immediately show the thumbnail of the dropped image instead of the gray box 2. switch to a spinner entirely, or for the image regeneration phase or try to show actual progress. The challenge with showing progress is we don't know how long the request will take on the server. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 04:57:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 04:57:15 -0000 Subject: [wp-trac] [WordPress Trac] #55302: Improve media library upload progress indicator In-Reply-To: <059.94226db16681b851e6132e94d124d7cc@wordpress.org> References: <059.94226db16681b851e6132e94d124d7cc@wordpress.org> Message-ID: <074.73eb791f0f7cb3e1d68b821a9a3440a9@wordpress.org> #55302: Improve media library upload progress indicator -----------------------------+------------------------------ Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by adamsilverstein): * Attachment "media-uploads.mp4" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 04:57:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 04:57:25 -0000 Subject: [wp-trac] [WordPress Trac] #55302: Improve media library upload progress indicator In-Reply-To: <059.94226db16681b851e6132e94d124d7cc@wordpress.org> References: <059.94226db16681b851e6132e94d124d7cc@wordpress.org> Message-ID: <074.b47bddbcb8e2079b1527b8a392b14eaf@wordpress.org> #55302: Improve media library upload progress indicator -----------------------------+------------------------------ Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Changes (by adamsilverstein): * Attachment "cat.mp4" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 05:57:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 05:57:53 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) In-Reply-To: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> References: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> Message-ID: <070.04ad81149cac4c01be05ca1d20df2660@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+------------------------------ Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -------------------------+------------------------------ Comment (by tomatodysee): Replying to [comment:2 peterwilsoncc]: > Can you please answer each of the questions of the [https://make.wordpress.org/core/handbook/contribute/design-decisions /#adding-new-oembed-providers checklist for adding new oEmbed providers] to the allow list? > > The quickest way to get embeds working for your site would be to limit the HTML to the allowed list of tags for auto-discovery, this includes links, blockquotes and iframes with a limited set of attributes. See https://github.com/WordPress/wordpress- develop/blob/107050f7a34d0b728e4c38bfc946e3339578ea6f/src/wp- includes/embed.php#L921-L936 > > For iframes, you'd also need to ensure any JavaScript and other code within the embed can be run in iframes with the attributes `sandbox ="allow-scripts" security="restricted"`. > > By enabling auto-discovery, your site's embeds will work on both WordPress versions below 6.0 and you won't need to go through the checklist above. Hey Peter, thanks so much for the reply! From our research about how "allow same origin" works with sandboxing, it should be safe to use if site A and embed site B are on different domains. Source: https://stackoverflow.com/questions/28332829/can-an-iframe- release-itself-from-allow-same-origin / https://www.html5rocks.com/en/tutorials/security/sandboxed-iframes/ "Note, however, that you need to be very careful when dealing with framed content that comes from the same origin as the parent. If a page on https://example.com/ frames another page on the same origin with a sandbox that includes both the allow-same-origin and allow-scripts flags, then the framed page can reach up into the parent, and remove the sandbox attribute entirely." I have read other places that say it's not recommended, but they usually don't mention the same origin caveat. Do you have any more information on this? Right now our iframes fail with: ```Uncaught DOMException: Failed to read the 'cookie' property from 'Document': The document is sandboxed and lacks the 'allow-same-origin' flag.``` since we use cookies on the site. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 06:07:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 06:07:29 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.258a9c4244b26a9ef29bac9ec9f8a53b@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by sharjeelkhanvmi): Okay, Then I need to fix the boxes sizes with the error message okay let me check what I can do then I update here. Replying to [comment:8 joyously]: > > I did not get your first point. > > The mismatched version error is shown at the top of the box. This alone can make the boxes uneven. > ''(This screenshot is my normal window width.)'' > [[Image(https://i.postimg.cc/8zsLdQjp/Add-Plugins.jpg)]] > ------ > > > Yes if we add more description lines to show then it mismatches the alignment of the boxes > > I think it's more important to see the complete sentence of the description than to have even boxes. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 07:00:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 07:00:43 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.f2b5b1d159803292448d03106ca83bd7@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: invalid Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Changes (by sharjeelkhanvmi): * status: new => closed * resolution: => invalid Comment: Here is the Updated Code And New Fixes You can check the errors and all the description is showing and all the layout will be now responsive it will be grid base now. here is the Screenshot: https://snipboard.io/fJvOE2.jpg [[Image(https://i.snipboard.io/fJvOE2.jpg)]] /*CSS CODE*/ div#the-list { display: grid; grid-template-columns: repeat(auto-fill,minmax(30rem,1fr)); grid-gap: 20px 10px; } .plugin-card .name { min-height: 30px; height: auto; margin-right: 0; } .widefat p { margin-top: 0; margin-bottom: 60px; } .plugin-card { border-radius: 6px; position: relative; display: grid; margin: 0 !important; } .plugin-card .desc { margin-right: 00; } .plugin-card .action-links { position: absolute; bottom: 0; left: auto; top: auto; width: 300px; } .plugin-action-buttons { display: flex; flex-direction: row-reverse; vertical-align: bottom; } .plugin-action-buttons li { margin: 0px 8px; position: relative; vertical-align: bottom; } .plugin-action-buttons .thickbox.open-plugin-details-modal { position: relative; top: 10px; } .plugin-card .desc { display: flex; flex-direction: column-reverse; } .plugin-icon { border-radius: 6px; border: 1px solid #dcdcde; } .plugin-card-bottom { border-radius: 0px 0px 6px 6px; position: relative; order: 3; } .plugin-card h3 { margin-bottom: 0; } .widefat p.authors { height: auto; margin-top: 8px; margin-bottom: 10px; } .plugin-card .notice p { margin: 0; height: auto; overflow: initial; width: 100%; } .plugin-card .notice { display: flex; vertical-align: middle; margin: 0; margin-top: 0px; order: 1; border: unset; } .plugin-card { width: 100%; } -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 08:28:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 08:28:08 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.0629b7de5314d67b0db6123bbc7a5e5f@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch needs-testing | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: good-first-bug has-testing-info has-patch => good-first-bug has-testing-info has-patch needs-testing Comment: Thanks for the patch @abdullahramzan! I'm confident that this solution works, but let's add `needs-testing` so that the original issue is reproduced and the solution is tested by someone other than myself as the reporter and yourself as the patcher. I'll post in the `core-test` Slack channel to help move this ticket along more quickly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 09:34:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 09:34:16 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.fa24567ea62ad711ccf3f4b883258469@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------------+------------------------------ Changes (by costdev): * component: Post Thumbnails => Editor Comment: Hi @simobenedettidesign, welcome to Trac! Please provide the following additional information: - What theme are you using? - How are you setting the space between elements? - Are you using one Gallery block? If not, please tell us the blocks that you're using. - What browser(s) does this issue appear in? - Is the Gutenberg plugin installed and activated, or not? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 10:03:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 10:03:00 -0000 Subject: [wp-trac] [WordPress Trac] #55291: Can't access Custom CSS with theme Twenty Twenty-Two In-Reply-To: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> References: <056.1ac2611b59cebcd2a6941a3ceb32d710@wordpress.org> Message-ID: <071.2788dbeb4db69ffcb06efb77c7185c36@wordpress.org> #55291: Can't access Custom CSS with theme Twenty Twenty-Two -------------------------------------+------------------------------ Reporter: DeveloperWil | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: reporter-feedback close | Focuses: -------------------------------------+------------------------------ Changes (by costdev): * keywords: reporter-feedback => reporter-feedback close Comment: Hi @DeveloperWil, welcome to Trac! @audrasjb is correct. - Additional CSS is theme-specific. - If you add Additional CSS to Twenty Eleven then switch to Twenty Twelve, the Additional CSS that you added will not be available. - If you switch back to Twenty Eleven, the Additional CSS that you added will be available again. For block themes, if you do not wish to create a child theme and add your custom CSS there, you can access some styling options in the Editor by clicking the Styles icon at the top right of the Editor. If you are using a block theme and you still want access to Additional CSS via the Customizer: 1. Create a folder called `enable-customizer` in `wp-content/plugins`. 2. Inside this folder, create a new file called `enable-customizer.php`. 3. Paste the following code into the file and save. {{{#!php Installed Plugins` and activate the Enable Customizer plugin. You should now be able to navigate to `Appearance > Customize` and access the Additional CSS panel. This doesn't appear to be a valid bug, but is actually the intended behaviour of the Additional CSS panel. I'll add the `close` keyword for now, pending `reporter-feedback`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:05:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:05:54 -0000 Subject: [wp-trac] [WordPress Trac] #17025: wp_list_authors() is not filterable In-Reply-To: <050.d34f9cbe54586689fc5b43e8aeb543db@wordpress.org> References: <050.d34f9cbe54586689fc5b43e8aeb543db@wordpress.org> Message-ID: <065.ecda54021a1c2aa78489fda43a5d2b5e@wordpress.org> #17025: wp_list_authors() is not filterable -------------------------------------------+----------------------------- Reporter: kevinB | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Query | Version: Severity: normal | Resolution: Keywords: has-patch early needs-refresh | Focuses: -------------------------------------------+----------------------------- Comment (by Mte90): Just checking this ticket has two patch one to add the filter by the ticket name and another one to change the user name. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:06:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:06:57 -0000 Subject: [wp-trac] [WordPress Trac] #55303: Update WP_Block_Patterns_Registry::register() docs to include the blockTypes property Message-ID: <054.5a2b39867af933a35c3aa88c756a9bd9@wordpress.org> #55303: Update WP_Block_Patterns_Registry::register() docs to include the blockTypes property -------------------------+----------------------------- Reporter: vlad.olaru | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: docs | -------------------------+----------------------------- Since WordPress 5.8, block patterns can declare a `blockTypes` property to allow blocks to use those patterns in other contexts, besides the inserter. The `WP_Block_Patterns_Registry::register()` function is missing the documentation about this logic. Here is the discussion related to `blockTypes` https://github.com/WordPress/gutenberg/pull/30471 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:07:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:07:24 -0000 Subject: [wp-trac] [WordPress Trac] #17019: add hooks for Media Library attachment counts In-Reply-To: <050.e810527b0b849d77615783c435c285b6@wordpress.org> References: <050.e810527b0b849d77615783c435c285b6@wordpress.org> Message-ID: <065.e5f6975aeefd0c651e4b19f3c6f30153@wordpress.org> #17019: add hooks for Media Library attachment counts -------------------------------------------------+------------------------- Reporter: kevinB | Owner: | SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: Future | Release Component: Query | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests early needs-testing-info | -------------------------------------------------+------------------------- Comment (by Mte90): @SergeyBiryukov there are updates for this patch? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:07:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:07:34 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.7fcebcff37fed151b45f614204d7c837@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): @boonebgorges Is there any chance you could take a look at my PR [https://github.com/WordPress/wordpress-develop/pull/2346 #2346]. It is very close to being mergeable. Working noting, in my testing, this PR does increase the number of SQL queries. The use of `_prime_term_caches`, means one query for getting the ids and another for get term data. This is likely to be a benefit in my cases. Get term data via `_prime_term_caches` and `get_term` means that any term loaded into cache on a request will not be reloaded again. This is an expected behaviour. The key goal of this ticket is not to store massive term objects in cache. There are limits to what can be stored in object caches. Not to mention, the fact if terms are updated, these caches may not be correctly invalidated. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:13:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:13:47 -0000 Subject: [wp-trac] [WordPress Trac] #55303: Update WP_Block_Patterns_Registry::register() docs to include the blockTypes property In-Reply-To: <054.5a2b39867af933a35c3aa88c756a9bd9@wordpress.org> References: <054.5a2b39867af933a35c3aa88c756a9bd9@wordpress.org> Message-ID: <069.9478cc94d38405cc466deebf9fcc5425@wordpress.org> #55303: Update WP_Block_Patterns_Registry::register() docs to include the blockTypes property -------------------------+--------------------- Reporter: vlad.olaru | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs -------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:22:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:22:07 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.75488236630b51813aa6ff6d12daafd3@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch needs-testing | -------------------------------------------------+------------------------- Comment (by mukesh27): Hi there! The patch looks good to me. The latest user agents for Edge - https://www.whatismybrowser.com/guides /the-latest-user-agent/edge -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:30:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:30:43 -0000 Subject: [wp-trac] [WordPress Trac] #55300: tests for WP_List_Util::pluck and WP_List_Util::sort In-Reply-To: <051.dd5ff02912bce1bb03a5640324c5d38c@wordpress.org> References: <051.dd5ff02912bce1bb03a5640324c5d38c@wordpress.org> Message-ID: <066.e6261aa5f3082f56def6ea2e979cef5c@wordpress.org> #55300: tests for WP_List_Util::pluck and WP_List_Util::sort --------------------------------------+--------------------- Reporter: pbearne | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:38:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:38:01 -0000 Subject: [wp-trac] [WordPress Trac] #55304: Remove error logging in sanitize_post Message-ID: <052.ec02ef13047a37b27a4e9486ec206bd7@wordpress.org> #55304: Remove error logging in sanitize_post -------------------------------+----------------------------- Reporter: legalweb | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- There is a error_log call in the method sanitize_post in post.php which is not needed in generall. it only spams the debug.log file {{{#!php ID.")"); $post->$field = sanitize_post_field( $field, $post->$field, $post->ID, $context ); } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:44:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:44:37 -0000 Subject: [wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying In-Reply-To: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> References: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> Message-ID: <066.48401677b7f4dc68a6658c7f9f2cbdd5@wordpress.org> #54548: The Close on Escape "feature" on the admin comments page is annoying -------------------------+------------------------------------------------- Reporter: BettyJJ | Owner: alexstine Type: defect | Status: accepted (bug) | Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, javascript, | administration -------------------------+------------------------------------------------- Comment (by afercia): Testing a bit the latest patch, I noticed a couple issues: - The close on Escape feature works also for the 'Quick Edit' textarea so the text of the JavaScript confirmation wouldn't be fully appropriate, as it refers only to 'Reply'. - More importantly: when editing multiple comments, there will be multiple JavaScript confirmation dialog. I think this is because of the way the JS event is currently attached to the textarea, which doesn't seem ideal. This would need some more refactoring to be solved, which is something I'd not recommend. To reproduce: - Apply the latest patch and build. - Reply to (or Quick Edit) a comment. - Enter some text. - Press the Escape key. - Click OK in the JavaScript confirm dialog. - Reply to another comment (or even to the same comment). - Enter some text. - Press the Escape key. - Click OK in the JavaScript confirm dialog. - At this point, you will get one more confirm dialog. - Repeat the steps above a few times and you will get as many confirm dialog as the amount of times you replied to a comment. Thinking a bit at the patch approach, I'd like to propose a new direction. After all, pressing Escape is generally used in software to 'cancel' the current operation. In this context, it does the same thing the 'Cancel' button (the one placed after the textarea) does. I'm not sure we should change this behavior. Instead, I'd say the actual problem that needs to be solved is the issue with Input Method Editor (IME) converters. Will submit a patch shortly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:45:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:45:06 -0000 Subject: [wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying In-Reply-To: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> References: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> Message-ID: <066.bc9a62dac886b569ea441d0fa6de08d8@wordpress.org> #54548: The Close on Escape "feature" on the admin comments page is annoying -------------------------+------------------------------------------------- Reporter: BettyJJ | Owner: alexstine Type: defect | Status: accepted (bug) | Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, javascript, | administration -------------------------+------------------------------------------------- Changes (by afercia): * Attachment "54548.2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:52:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:52:39 -0000 Subject: [wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying In-Reply-To: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> References: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> Message-ID: <066.aeabc3ef0f2e8f645fafbf1753b9d21d@wordpress.org> #54548: The Close on Escape "feature" on the admin comments page is annoying -------------------------+------------------------------------------------- Reporter: BettyJJ | Owner: alexstine Type: defect | Status: accepted (bug) | Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, javascript, | administration -------------------------+------------------------------------------------- Comment (by afercia): [attachment:"54548.2.diff"] prevents the textarea from closing when pressing the escape key and while characters are being composed with an Input Method Editor. I can't test this with a real IME so this would need to be tested by someone else. For some background on this approach, see the discussion on https://core.trac.wordpress.org/ticket/45371 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:53:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:53:00 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.6cf34e0522871b23be60f5ed2c8cde3c@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, performance --------------------------+------------------------------------------ Changes (by SergeyBiryukov): * keywords: => needs-patch * milestone: Awaiting Review => Future Release Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket. Just noting that I was able to reproduce the issue with the steps described. I was also able to confirm comment:1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:53:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:53:08 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.11b3087cb5dbdf2086152b86e9a63333@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch commit | -------------------------------------------------+------------------------- Changes (by costdev): * keywords: good-first-bug has-testing-info has-patch needs-testing => good-first-bug has-testing-info has-patch commit Comment: Thanks @mukesh27! Marking for `commit` consideration. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:54:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:54:42 -0000 Subject: [wp-trac] [WordPress Trac] #55305: request Message-ID: <051.a829ec910d2685382707429de4c168b0@wordpress.org> #55305: request --------------------------+----------------------------- Reporter: egyreda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- hello every one http://balawi-group.ml/?i=1 could you check plz this is my first website everytime i try to access appears message (There has been a critical error on this website.) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 11:56:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 11:56:20 -0000 Subject: [wp-trac] [WordPress Trac] #55305: request In-Reply-To: <051.a829ec910d2685382707429de4c168b0@wordpress.org> References: <051.a829ec910d2685382707429de4c168b0@wordpress.org> Message-ID: <066.7de6044f1496aee142477b8366ec4822@wordpress.org> #55305: request --------------------------+---------------------- Reporter: egyreda | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by costdev): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Old description: > hello every one > > http://balawi-group.ml/?i=1 > could you check plz this is my first website > everytime i try to access appears message > (There has been a critical error on this website.) New description: hello every one **link removed** could you check plz this is my first website everytime i try to access appears message (There has been a critical error on this website.) -- Comment: Hi @egyreda, welcome to Trac! Sorry to hear that you're having trouble with your website. Trac is for the development of WordPress Core rather than providing WordPress support. You can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. Best of luck! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:14:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:14:45 -0000 Subject: [wp-trac] [WordPress Trac] #54878: Don't show links to the Customizer when installing themes using api.wordpress.org In-Reply-To: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> References: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> Message-ID: <072.3fa99ebe9fe97d7add0c6f8884064b7d@wordpress.org> #54878: Don't show links to the Customizer when installing themes using api.wordpress.org ----------------------------------------------+--------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-screenshots commit | Focuses: ----------------------------------------------+--------------------- Description changed by SergeyBiryukov: Old description: > I found this while working on > https://core.trac.wordpress.org/ticket/54578 > > Steps to reproduce the bug: > 1. Go to `Appearance -> Themes` page. > 2. Click on the `Add New` button, then find the `TT1` theme using the > search functionality. > 3. Install the theme. > > Expected result: > The `Live Preview` button is not displayed for block-based themes. > > Actual result: > The `Live Preview` button is displayed for block-based themes. > > Also, the `Customize` button is displayed for installed block themes when > browsing the available themes. It also has to be removed. New description: I found this while working on #54578. Steps to reproduce the bug: 1. Go to `Appearance -> Themes` page. 2. Click on the `Add New` button, then find the `TT1` theme using the search functionality. 3. Install the theme. Expected result: The `Live Preview` button is not displayed for block-based themes. Actual result: The `Live Preview` button is displayed for block-based themes. Also, the `Customize` button is displayed for installed block themes when browsing the available themes. It also has to be removed. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:21:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:21:43 -0000 Subject: [wp-trac] [WordPress Trac] #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. Message-ID: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. -------------------------------------+----------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Keywords: Focuses: ui, css, administration | -------------------------------------+----------------------------- While working on multiple drop-downs for particular post type, I came to find this bug when there is pagination is involved, UI is slightly damaged. Check the attachments for more details. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:22:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:22:52 -0000 Subject: [wp-trac] [WordPress Trac] #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. In-Reply-To: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> References: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> Message-ID: <071.3a962726bbcda874eed0d0a164a89120@wordpress.org> #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. -------------------------------+-------------------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ui, css, administration -------------------------------+-------------------------------------- Changes (by haritpanchal): * Attachment "WP Margin Issue for Pagination.png" added. What issue is -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:30:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:30:22 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.92c6e54486e5867c93508f76726db05e@wordpress.org> #55230: Release 5.9.1 breaks administration login. ------------------------------------+----------------------------- Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Login and Registration | Version: 5.9.1 Severity: blocker | Resolution: Keywords: needs-patch | Focuses: administration ------------------------------------+----------------------------- Comment (by SergeyBiryukov): Hi there, welcome to WordPress Trac! Thanks for the report. Could you share the steps to reproduce the issue on a clean install? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:39:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:39:32 -0000 Subject: [wp-trac] [WordPress Trac] #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. In-Reply-To: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> References: <056.8adbf93b287eda30c45b130923837f18@wordpress.org> Message-ID: <071.fa8dc46f3c6408184095566aa69dce5c@wordpress.org> #55306: Before posts/pages listing if there multiple filter drop-downs, view of pagination buttons are not better looking. -------------------------------+-------------------------------------- Reporter: haritpanchal | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: ui, css, administration -------------------------------+-------------------------------------- Changes (by haritpanchal): * keywords: => needs-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 12:56:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 12:56:04 -0000 Subject: [wp-trac] [WordPress Trac] #55189: Automatic removal of "Zero-width non-joiner" in URL In-Reply-To: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> References: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> Message-ID: <068.f9e6e95c4cd07fa40e7d4c2a62fc3063@wordpress.org> #55189: Automatic removal of "Zero-width non-joiner" in URL --------------------------+--------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Permalinks | Version: 5.9 Severity: critical | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+--------------------- Comment (by SergeyBiryukov): Thanks for the follow-up! I was able to reproduce the issue with the steps from comment:3, and [51984] indeed appears to be the related changeset. It's worth noting this only happens with pages, because the old slug redirect feature does not work for them yet, see #4328 for that. In testing with posts, the old slug does redirect as expected to the new slug. Related: #50924, which is apparently now fixed as of [51984] / #47912. I'm not quite sure how to proceed here, as #50924 suggested this character should be removed from URLs, while this one suggests that it should not (if I understand correctly). Maybe fixing #4328 would be the way to go here, so that the old slug redirect feature works for pages too? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 13:23:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 13:23:13 -0000 Subject: [wp-trac] [WordPress Trac] #55304: Remove error logging in sanitize_post In-Reply-To: <052.ec02ef13047a37b27a4e9486ec206bd7@wordpress.org> References: <052.ec02ef13047a37b27a4e9486ec206bd7@wordpress.org> Message-ID: <067.d1219b8fc5837dcd6477c8898bd97be3@wordpress.org> #55304: Remove error logging in sanitize_post -------------------------------+---------------------- Reporter: legalweb | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: | Focuses: -------------------------------+---------------------- Changes (by swissspidy): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi there, welcome to WordPress Trac! Could it be that this file was manually edited on your site? This function does not include any `error_log()` call in WordPress. See https://github.com/WordPress/wordpress- develop/blob/b28dcfd83243459e9cc08f46f70418ebfde9dde8/src/wp- includes/post.php#L2711-L2723 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 13:27:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 13:27:16 -0000 Subject: [wp-trac] [WordPress Trac] #55304: Remove error logging in sanitize_post In-Reply-To: <052.ec02ef13047a37b27a4e9486ec206bd7@wordpress.org> References: <052.ec02ef13047a37b27a4e9486ec206bd7@wordpress.org> Message-ID: <067.ea6ba8ab338ac83c57736e920ffd9b1e@wordpress.org> #55304: Remove error logging in sanitize_post -------------------------------+---------------------- Reporter: legalweb | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: | Focuses: -------------------------------+---------------------- Comment (by legalweb): hi! i've checked it and have this line on 2 different installations on the same hoster. but if i check the lastet wordpress zip package, it's not present. seems that the hoster added this. sorry for this false positive. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 13:31:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 13:31:16 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP Message-ID: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+----------------------------- Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Keywords: Focuses: | -----------------------------+----------------------------- I upgraded my production server from Debian 10 (Buster) to Debian 11 (Bullseye) a few days ago. At first, none of the hosted WordPress sites worked. All gave me an error about a missing mysql module. As it turned out, I needed to install php7.4-mysqli. But then when I wanted to update the WordPress sites from v5.9.0 to v5.9.1, all failed: {{{ Downloading update from https://downloads.wordpress.org/release/wordpress-5.9.1-no-content.zip… The authenticity of wordpress-5.9.1-no-content.zip could not be verified as no signature was found. Unpacking the update… Verifying the unpacked files… The update could not be unpacked. Installation failed. }}} I took me quite a while to figure out what actually was going on. Now I know, I have no idea if this is a bug in WordPress, or caused by something else. The error message WP is giving, is actually ''incorrect''. As it turns out, it is able to unpack the update just fine in the wp-content/upgrade folder. But it’s when it checks if the files have actually unpacked, where it goes wrong. The problem lies in this piece of code in update-core.php: {{{#!php exists( $from . $root . 'readme.html' ) && $wp_filesystem->exists( $from . $root . 'wp- includes/version.php' ) ) { $distro = $root; break; } } if ( ! $distro ) { $wp_filesystem->delete( $from, true ); return new WP_Error( 'insane_distro', __( 'The update could not be unpacked.' ) ); } }}} What it does here, is simply check if two files exists in the folder it has just unpacked the zip file to. This fails. And the reason is as follows: I use FTP method for installing updates. So when I tell it to update, it first figures out the folder it should download the zipfile to. This folder is stored in **$working_dir** in {{{wp-admin/includes/class-wp- upgrader.php -> unpack_package()}}}. The full path on the server is **/domains/domainname.com/htdocs/wp-content/upgrade/** but since FTP users are chrooted, WP finds and stores **/htdocs/wp-content/upgrade/** instead. The update file is downloaded to this folder and then unpacked. Next it does the above check in {{{wp-admin/includes/update-core.php -> update_core()}}}. And that failes because it tries to find a file in **/htdocs/wp-content/upgrade/** while the true location is **/domains/domainname.com/htdocs/wp-content/upgrade/**. Updating through FTP used to work fine in Debian 10 but in Debian 11, something broke... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 14:15:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 14:15:49 -0000 Subject: [wp-trac] [WordPress Trac] #55308: Update WordPress version URL target Message-ID: <053.b8de66dd15e6204fc2c92a329b0c3c45@wordpress.org> #55308: Update WordPress version URL target -------------------------------+----------------------------- Reporter: gazthink3 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: 2nd-opinion Focuses: ui, accessibility | -------------------------------+----------------------------- It's always frustrating when the WordPress version URL opens up in the same tab; we can open the `$version_url` in a new tab by changing the target. It's a small change but will be helpful for some people. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 14:36:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 14:36:00 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.6ba533cfc49b6ad0b06aefeeae89cb6b@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Changes (by costdev): * keywords: => needs-testing Comment: Hi @zippy1970, welcome to Trac! I'll add `needs-testing` so that we can try to get the issue reproduced and see where the problem should be resolved. In the meantime, would you be able to set up a website using [https://wordpress.org/download/releases/ WordPress 5.7.5] on Debian 11 and try to upgrade to 5.8? This would let us confirm that the issue only lies within Debian 11, and not a mixture of Debian 11 and WordPress 5.9, and allow us to assign the `Version` property of the ticket accurately. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 14:39:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 14:39:56 -0000 Subject: [wp-trac] [WordPress Trac] #55308: Update WordPress version URL target In-Reply-To: <053.b8de66dd15e6204fc2c92a329b0c3c45@wordpress.org> References: <053.b8de66dd15e6204fc2c92a329b0c3c45@wordpress.org> Message-ID: <068.5e4d80aa0993958b28f95f2646bd1a9f@wordpress.org> #55308: Update WordPress version URL target -----------------------------------+-------------------------------- Reporter: gazthink3 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: minor | Resolution: Keywords: 2nd-opinion has-patch | Focuses: ui, accessibility -----------------------------------+-------------------------------- Changes (by gazthink3): * severity: normal => minor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 15:11:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 15:11:44 -0000 Subject: [wp-trac] [WordPress Trac] #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 In-Reply-To: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> References: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> Message-ID: <064.ece3a063923fc4a27419a8dab72ac733@wordpress.org> #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 --------------------------+---------------------------------- Reporter: enps5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.1 Severity: major | Resolution: Keywords: | Focuses: multisite, rest-api --------------------------+---------------------------------- Changes (by webtechIMT): * severity: normal => major Comment: Hello, I'm trying to edit a category and at line 39 of wp-admin/term.php : the function current_user_can( 'edit_term', $tag->term_id ) returns false. I'm yet logged with administrator capabilities (as I can see in the database in wp_usermeta, key wp_capabilities and value : a:3:{s:13:"administrator";b:1;s:19:"manage_translations";b:1;s:9:"translate";b:1;})... Could you help me please ? PS : WP version is the latest : 5.9.1 Thank you, Olivier. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 15:22:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 15:22:13 -0000 Subject: [wp-trac] [WordPress Trac] #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. In-Reply-To: <055.59b98c6521117940d257195c928551f9@wordpress.org> References: <055.59b98c6521117940d257195c928551f9@wordpress.org> Message-ID: <070.87696ad92516f19f81f46cd120d1d60f@wordpress.org> #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. --------------------------------+------------------------------ Reporter: asaquzzaman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Networks and Sites | Version: Severity: normal | Resolution: Keywords: | Focuses: multisite --------------------------------+------------------------------ Comment (by MadtownLems): I've been cleaning up old plugins of wpmu_new_blog, and came here to make this exact request. Suggesting wp_insert_site is NOT a good replacement. The suggestion should absolutely be wp_initialize_site instead! (or at least mention both and let people see which makes sense for their specific case) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 15:55:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 15:55:54 -0000 Subject: [wp-trac] [WordPress Trac] #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. In-Reply-To: <055.59b98c6521117940d257195c928551f9@wordpress.org> References: <055.59b98c6521117940d257195c928551f9@wordpress.org> Message-ID: <070.e57222e9c51e126ed47f76d587320a8e@wordpress.org> #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. --------------------------------+------------------------ Reporter: asaquzzaman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: Keywords: | Focuses: multisite --------------------------------+------------------------ Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 15:56:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 15:56:22 -0000 Subject: [wp-trac] [WordPress Trac] #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. In-Reply-To: <055.59b98c6521117940d257195c928551f9@wordpress.org> References: <055.59b98c6521117940d257195c928551f9@wordpress.org> Message-ID: <070.0b7627d934958e44ac95b10f4fad6ecc@wordpress.org> #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. --------------------------------+----------------------------- Reporter: asaquzzaman | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: multisite --------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52816" 52816]: {{{ #!CommitTicketReference repository="" revision="52816" Networks and Sites: Suggest `wp_initialize_site` as an alternative for the deprecated `wpmu_new_blog` action. The previously suggested alternative, `wp_insert_site`, does not get passed enough arguments and runs before the new site initialization routine is actually executed. Follow-up to [43654]. Props asaquzzaman, henry.wright, MadtownLems. Fixes #49612. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 16:01:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 16:01:17 -0000 Subject: [wp-trac] [WordPress Trac] #49349: wpmu_new_blog deprecated notice In-Reply-To: <056.718ddc9c84290ab7e9886de7ab4a2bff@wordpress.org> References: <056.718ddc9c84290ab7e9886de7ab4a2bff@wordpress.org> Message-ID: <071.8612a9fee40f8b34b5ff972459001cfa@wordpress.org> #49349: wpmu_new_blog deprecated notice --------------------------------+------------------------ Reporter: henry.wright | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Networks and Sites | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: multisite --------------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Thanks for the ticket! This is now fixed in [52816] / #49612. The other ticket had a patch and a bit more traction, so I think this one can be closed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 16:11:58 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 16:11:58 -0000 Subject: [wp-trac] [WordPress Trac] #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. In-Reply-To: <055.59b98c6521117940d257195c928551f9@wordpress.org> References: <055.59b98c6521117940d257195c928551f9@wordpress.org> Message-ID: <070.14c9487c1ef74f530d71a66217799b47@wordpress.org> #49612: wpmu_new_blog hook has been deprecated. Use wp_initialize_site instead. --------------------------------+----------------------------- Reporter: asaquzzaman | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Networks and Sites | Version: Severity: normal | Resolution: fixed Keywords: | Focuses: multisite --------------------------------+----------------------------- Comment (by SergeyBiryukov): In [changeset:"52817" 52817]: {{{ #!CommitTicketReference repository="" revision="52817" Docs: Update the DocBlock for the `wpmu_new_blog` action to suggest `wp_initialize_site` as an alternative. Follow-up to [43654], [52816]. See #49612. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 16:29:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 16:29:07 -0000 Subject: [wp-trac] [WordPress Trac] #55309: Incorrect post comment count after deleting comment with replies Message-ID: <047.ce61b02f20ee5d83afb18a2cd1b37113@wordpress.org> #55309: Incorrect post comment count after deleting comment with replies --------------------------+----------------------------- Reporter: jwz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- If you move a comment to the trash, and that comment has sub-comments, none of those comments are visible (which is desired) but post->comment_count is reduced by 1 rather than by the total number of comments that have now been hidden. For example: post has 1 comment with 3 replies. Comment count is 4. Delete the first comment. Now no comments are visible but comment count is 3. The first comment has comment_approved set to 'trash' but the other 3 comments are still '1'. Perhaps the right fix is that when trashing a comment, all of its sub-comments are also trashed explicitly rather than implicitly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 17:44:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 17:44:29 -0000 Subject: [wp-trac] [WordPress Trac] #55310: Multi-date scheduled content blocks don't work as expected Message-ID: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> #55310: Multi-date scheduled content blocks don't work as expected ----------------------------+----------------------------- Reporter: shawnwrightres | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- I have a page where I want each month to show a different block, so each block I've created has two dates, basically a start (visible) and stop (hidden) date, so that each month the content will change, but no intervention will be needed that whole time by an author. However, it doesn't seem to be working as expected for future dates. See screenshot which shows the settings for the April content block (visible on 4/1, hidden on 5/1), except that it's March and it's showing. I tried inverting the logic (hidden 4/1, visible 5/1) in case I have it backwards but that didn't change the behavior. Single dates work fine. I can have each block appear in its proper month, but I want the previous month's block to then disappear. IMO something is wrong here. Either my use of the block in this way is as intended and it's not working, OR, the intent of multiple dates is not clear and it needs to be made more clear. I may have miscategorized this ticket by choosing the wrong component, but wasn't sure which to use, please correct. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 17:46:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 17:46:09 -0000 Subject: [wp-trac] [WordPress Trac] #55310: Multi-date scheduled content blocks don't work as expected In-Reply-To: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> References: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> Message-ID: <073.7d2044c75a446b0b6d91bf13a37a5a41@wordpress.org> #55310: Multi-date scheduled content blocks don't work as expected ----------------------------+------------------------------ Reporter: shawnwrightres | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Changes (by shawnwrightres): * Attachment "Screenshot 2022-03-03 113418.jpg" added. Web page showing both March and April scheduled content blocks even though April is set for April 1st visibility and May 1st hidden. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 17:47:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 17:47:49 -0000 Subject: [wp-trac] [WordPress Trac] #55310: Multi-date scheduled content blocks don't work as expected In-Reply-To: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> References: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> Message-ID: <073.409112f8fae7b74737942eab4673c2fe@wordpress.org> #55310: Multi-date scheduled content blocks don't work as expected ----------------------------+------------------------------ Reporter: shawnwrightres | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Changes (by shawnwrightres): * Attachment "Screenshot 2022-03-03 113425.jpg" added. Scheduled content block settings showing April 1 visible, May 1 hidden, yet the block is currently visible. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 17:50:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 17:50:55 -0000 Subject: [wp-trac] [WordPress Trac] #55309: Incorrect post comment count after deleting comment with replies In-Reply-To: <047.ce61b02f20ee5d83afb18a2cd1b37113@wordpress.org> References: <047.ce61b02f20ee5d83afb18a2cd1b37113@wordpress.org> Message-ID: <062.ccc8af02200a54178375b2579416a64c@wordpress.org> #55309: Incorrect post comment count after deleting comment with replies --------------------------+------------------------------ Reporter: jwz | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Comments | Version: 5.9.1 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by davidbaumwald): * keywords: => dev-feedback Comment: @jwz I'm going to tag this for `dev-feedback` to see if a conversation can be sparked to determine _if_ this should be done. I agree, it seems reasonable since those comments are no longer visible. In the interim, you could always filter the number of comments for each post when the count is updated by using the [https://developer.wordpress.org/reference/hooks/pre_wp_update_comment_count_now/ pre_wp_update_comment_count_now] hook and checking the parent comment of each child comment's status. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 18:02:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 18:02:48 -0000 Subject: [wp-trac] [WordPress Trac] #43936: Settings: Warn when open registration and new user default is privileged In-Reply-To: <051.6cb6d8867fe37496c3fb9d274b59f535@wordpress.org> References: <051.6cb6d8867fe37496c3fb9d274b59f535@wordpress.org> Message-ID: <066.0f49f596634e62d59fb19f25c45e8a1d@wordpress.org> #43936: Settings: Warn when open registration and new user default is privileged -------------------------------------+----------------------------- Reporter: kraftbj | Owner: SergeyBiryukov Type: feature request | Status: reviewing Priority: normal | Milestone: Future Release Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Comment (by verygoode): Checking in on this one. Ideally, we'd prevent any privileged role from being set as `default_role`. However, for now, perhaps a site health warning might help. @SergeyBiryukov -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 18:43:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 18:43:28 -0000 Subject: [wp-trac] [WordPress Trac] #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix Message-ID: <052.71705d312df930659699caa7e0d22c46@wordpress.org> #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix --------------------------+----------------------------- Reporter: pgpagely | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: major | Keywords: Focuses: | --------------------------+----------------------------- Both CSS and JS URLs are totally broken for some of the newer blocks (the most obvious one being the navigation block in the 2022 theme) when WP core is outside of the current directory in a different prefix. The issue happens because of the use of `realpath()` when trying to detect these paths which results in `$is_core_block` being false and then generating a weird URL because of that. The simplest reproduction case is as follows: - Install WP 5.9.1 - Execute `mv wp-includes ../wp-includes-test` - Execute `ln -s ../wp-includes-test wp-includes` - The navigation styles/JS will now be broken on the 2022 theme For us, we are running WP inside docker, and our WP core files exist at `/wordpress-versions/5.9/` in the container, but the web root is at `/httpdocs`, we have the use the following to make things work: {{{#!php add_filter("block_type_metadata", function ($meta) { if (!empty($meta["file"])) { $meta["file"] = preg_replace("#/wordpress-versions/[0-9.]+/#", ABSPATH, $meta["file"]); } return $meta; }); }}} If we don't do this then an example URI that is generated for one of the styles is this: `/wp-content/plugins/wordpress-versions/5.9/wp- includes/blocks/navigation/view.min.js?ver=3776ea67846b3bb10fe8f7cdd486b0ba` -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 18:54:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 18:54:31 -0000 Subject: [wp-trac] [WordPress Trac] #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix In-Reply-To: <052.71705d312df930659699caa7e0d22c46@wordpress.org> References: <052.71705d312df930659699caa7e0d22c46@wordpress.org> Message-ID: <067.53e20e6f11f6f577bf85e9ff3d2198d1@wordpress.org> #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix ---------------------------+------------------------------ Reporter: pgpagely | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Changes (by pgpagely): * component: General => Script Loader -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 19:31:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 19:31:17 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.5d050c2848805dbaea08ff971ec1be13@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by afragen): Is there some reason you must use the FTP option to upgrade? Does upgrading work if you set the following in your `wp-config.php`? {{{ define('FS_METHOD','direct'); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 20:32:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 20:32:36 -0000 Subject: [wp-trac] [WordPress Trac] #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter In-Reply-To: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> References: <048.a5a43ec46ccd37ba92f364c4ec0e8156@wordpress.org> Message-ID: <063.0060efe3dd57e3be38cbe41fd153c8c4@wordpress.org> #54379: `get_comment_ID()` can cause a notice within the `comment_text` filter --------------------------+---------------------------- Reporter: dd32 | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+---------------------------- Changes (by davidbaumwald): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52818" 52818]: {{{ #!CommitTicketReference repository="" revision="52818" Comments: Guard against potential PHP notices in `get_comment_author` and `get_comment_ID`. In both `get_comment_author` and `get_comment_ID`, it's possible that these functions are called without a comment context. Specifically, `get_comment_author` can be called without passing the `$comment_ID` parameter, and `get_comment_ID` relies on the `comment` global if there's no `$comment` parameter supplied. This leads to a PHP notice of "Trying to get property of a non-object." This change adds a check to both functions to ensure the `$comment->comment_ID` property is not empty before actually using its value. Follow-up to [52223]. Props dd32. Fixes #54379. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 20:35:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 20:35:33 -0000 Subject: [wp-trac] [WordPress Trac] #55310: Multi-date scheduled content blocks don't work as expected In-Reply-To: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> References: <058.66f5aca6d80a01e8025caa4e4654b51f@wordpress.org> Message-ID: <073.57d94175285fe61429a0b58b26a6e13d@wordpress.org> #55310: Multi-date scheduled content blocks don't work as expected ----------------------------+---------------------- Reporter: shawnwrightres | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Administration | Version: 5.9.1 Severity: normal | Resolution: invalid Keywords: | Focuses: ----------------------------+---------------------- Changes (by swissspidy): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Hi there and welcome to WordPress Trac! Please note that this bug tracker is used to discuss issues in WordPress core itself. For issues with the [https://wordpress.org/plugins/schedule-content-block/ Schedule Content Block plugin], you'll need to report this to that plugin directly, for example on [https://github.com/goiblas/Schedule-Content- Block its GitHub repo] or [https://wordpress.org/support/plugin/schedule- content-block/ support forum]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:06:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:06:13 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly Message-ID: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> #55312: Image not rendering properly --------------------------+----------------------------- Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- We noticed that our hero images weren't rendering properly on mobile & tablet sizes. When we rolled back to the version 5.9.0, the issue was resolved. Please take a look at the screenshots of the image and the details in the web inspector. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:06:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:06:55 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly In-Reply-To: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> References: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> Message-ID: <066.a0e40cefa4cf0eb66d528ccf359b59af@wordpress.org> #55312: Image not rendering properly --------------------------+------------------------------ Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by rthaena): * Attachment "img-container.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:07:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:07:02 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly In-Reply-To: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> References: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> Message-ID: <066.1c36714489bd210daa2699995c8a1d3d@wordpress.org> #55312: Image not rendering properly --------------------------+------------------------------ Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by rthaena): * Attachment "back.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:08:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:08:04 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly In-Reply-To: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> References: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> Message-ID: <066.ea15ec4bade29788dc6513e8de7a3a25@wordpress.org> #55312: Image not rendering properly --------------------------+------------------------------ Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by rthaena): Replying to [ticket:55312 rthaena]: > We noticed that our hero images weren't rendering properly on mobile & tablet sizes. When we rolled back to the version 5.9.0, the issue was resolved. Please take a look at the screenshots of the image and the details in the web inspector. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:08:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:08:43 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly In-Reply-To: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> References: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> Message-ID: <066.df03538ed4863f26a14aa2e70049face@wordpress.org> #55312: Image not rendering properly --------------------------+------------------------------ Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by rthaena): You can refer to https://kiddieacademy.com/ to see how the hero images are rendering in WP core version 5.9.0. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:26:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:26:57 -0000 Subject: [wp-trac] [WordPress Trac] #55312: Image not rendering properly In-Reply-To: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> References: <051.276550cf49bb97bbba7cd34047c505e7@wordpress.org> Message-ID: <066.68a4ae905873d1a3adcd054d283abe88@wordpress.org> #55312: Image not rendering properly --------------------------+------------------------------ Reporter: rthaena | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by tflight): Hi @rthaena , I believe you are likely seeing what is being discussed in these locations: https://core.trac.wordpress.org/ticket/55229 https://github.com/WordPress/gutenberg/issues/39021 https://github.com/WordPress/gutenberg/pull/39045 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:40:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:40:43 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.026bc9cf03cb29cf0f9f9bca36faba7c@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Replying to [comment:2 afragen]: > Is there some reason you must use the FTP option to upgrade? If I use the direct method, I first get this: {{{ Downloading update from https://downloads.wordpress.org/release/wordpress-5.9.1-no-content.zip… The authenticity of wordpress-5.9.1-no-content.zip could not be verified as no signature was found. Unpacking the update… Could not create directory. Installation failed. }}} So next I do {{{chmod 0777 wp-content/upgrade}}} and then I get this: {{{ Downloading update from https://downloads.wordpress.org/release/wordpress-5.9.1-no-content.zip… The authenticity of wordpress-5.9.1-no-content.zip could not be verified as no signature was found. Unpacking the update… Verifying the unpacked files… Preparing to install the latest version… The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.: wp-includes /block-supports/elements.php, wp-includes/block-supports/duotone.php, wp- includes/block-supports/layout.php, wp-includes/default-filters.php, wp- includes/block-template.php, wp-includes/css/dist/edit-site/style- rtl.min.css, wp-includes/css/dist/edit-site/style.min.css, wp- includes/css/dist/edit-site/style-rtl.css, wp-includes/css/dist/edit- site/style.css, wp-includes/css/dist/block-library/editor.min.css, wp- includes/css/dist/block-library/style-rtl.min.css, wp-includes/css/dist /block-library/common-rtl.min.css, wp-includes/css/dist/block- library/editor.css, wp-includes/css/dist/block-library/common.css, wp- includes/css/dist/block-library/style.min.css, wp-includes/css/dist/block- library/editor-rtl.css, wp-includes/css/dist/block-library/editor- rtl.min.css, wp-includes/css/dist/block-library/style-rtl.css, wp- includes/css/dist/block-library/common.min.css, wp-includes/css/dist /block-library/common-rtl.css, wp-includes/css/dist/block- library/style.css, wp-includes/css/dist/components/style-rtl.min.css, wp- includes/css/dist/components/style.min.css, wp- includes/css/dist/components/style-rtl.css, wp- includes/css/dist/components/style.css, wp-includes/css/dist/block-editor /style-rtl.min.css, wp-includes/css/dist/block-editor/style.min.css, wp- includes/css/dist/block-editor/style-rtl.css, wp-includes/css/dist/block- editor/style.css, wp-includes/class-wp-theme-json.php, wp-includes/script- loader.php, wp-includes/assets/script-loader-packages.php, wp- includes/blocks/gallery/style-rtl.min.css, wp- includes/blocks/gallery/style.min.css, wp-includes/blocks/gallery/style- rtl.css, wp-includes/blocks/gallery/style.css, wp-includes/blocks/site- title.php, wp-includes/blocks/page-list/editor.min.css, wp-includes/blocks /page-list/editor.css, wp-includes/blocks/page-list/editor-rtl.css, wp- includes/blocks/page-list/editor-rtl.min.css, wp-includes/blocks/page- list.php, wp-includes/blocks/search.php, wp-includes/blocks/post-template /style-rtl.min.css, wp-includes/blocks/post-template/style.min.css, wp- includes/blocks/post-template/style-rtl.css, wp-includes/blocks/post- template/style.css, wp-includes/blocks/post-featured-image/editor.min.css, wp-includes/blocks/post-featured-image/editor.css, wp-includes/blocks /post-featured-image/editor-rtl.css, wp-includes/blocks/post-featured- image/editor-rtl.min.css, wp-includes/blocks/index.php, wp- includes/blocks/image/style-rtl.min.css, wp- includes/blocks/image/style.min.css, wp-includes/blocks/image/style- rtl.css, wp-includes/blocks/image/style.css, wp-includes/blocks/cover /style-rtl.min.css, wp-includes/blocks/cover/style.min.css, wp- includes/blocks/cover/style-rtl.css, wp-includes/blocks/cover/style.css, wp-includes/blocks/site-logo.php, wp- includes/blocks/spacer/editor.min.css, wp- includes/blocks/spacer/block.json, wp-includes/blocks/spacer/editor.css, wp-includes/blocks/spacer/editor-rtl.css, wp-includes/blocks/spacer /editor-rtl.min.css, wp-includes/deprecated.php, wp-includes/version.php, wp-includes/class-wp-theme-json-resolver.php, wp-includes/rest- api/endpoints/class-wp-rest-global-styles-controller.php, wp-includes /block-editor.php, wp-includes/post.php, wp-includes/global-styles-and- settings.php, wp-includes/js/dist/core-data.js, wp- includes/js/dist/components.js, wp-includes/js/dist/edit-site.min.js, wp- includes/js/dist/block-library.min.js, wp-includes/js/dist/edit- post.min.js, wp-includes/js/dist/block-editor.min.js, wp-includes/js/dist /core-data.min.js, wp-includes/js/dist/components.min.js, wp- includes/js/dist/editor.min.js, wp-includes/js/dist/edit-site.js, wp- includes/js/dist/block-editor.js, wp-includes/js/dist/block-library.js, wp-includes/js/dist/editor.js, wp-includes/js/dist/edit-post.js, wp- includes/js/wp-ajax-response.min.js, wp-includes/js/jquery/ui/effect- fade.js, wp-includes/js/jquery/ui/controlgroup.min.js, wp- includes/js/jquery/ui/effect-highlight.min.js, wp-includes/js/jquery/ui /effect-clip.js, wp-includes/js/jquery/ui/effect-highlight.js, wp- includes/js/jquery/ui/button.js, wp-includes/js/jquery/ui/tabs.min.js, wp- includes/js/jquery/ui/selectable.min.js, wp- includes/js/jquery/ui/draggable.js, wp- includes/js/jquery/ui/droppable.min.js, wp- includes/js/jquery/ui/effect.js, wp-includes/js/jquery/ui/spinner.js, wp- includes/js/jquery/ui/effect-explode.min.js, wp- includes/js/jquery/ui/accordion.js, wp-includes/js/jquery/ui/core.min.js, wp-includes/js/jquery/ui/effect-pulsate.min.js, wp- includes/js/jquery/ui/mouse.min.js, wp-includes/js/jquery/ui/effect- puff.min.js, wp-includes/js/jquery/ui/effect-shake.js, wp- includes/js/jquery/ui/menu.js, wp-includes/js/jquery/ui/draggable.min.js, wp-includes/js/jquery/ui/selectmenu.js, wp- includes/js/jquery/ui/sortable.js, wp-includes/js/jquery/ui/core.js, wp- includes/js/jquery/ui/effect-slide.min.js, wp-includes/js/jquery/ui /effect-drop.js, wp-includes/js/jquery/ui/effect-size.js, wp- includes/js/jquery/ui/autocomplete.js, wp- includes/js/jquery/ui/menu.min.js, wp-includes/js/jquery/ui/tabs.js, wp- includes/js/jquery/ui/effect-bounce.min.js, wp-includes/js/jquery/ui /effect-drop.min.js, wp-includes/js/jquery/ui/selectable.js, wp- includes/js/jquery/ui/dialog.js, wp-includes/js/jquery/ui/effect- fold.min.js, wp-includes/js/jquery/ui/checkboxradio.min.js, wp- includes/js/jquery/ui/effect-puff.js, wp- includes/js/jquery/ui/autocomplete.min.js, wp- includes/js/jquery/ui/slider.js, wp-includes/js/jquery/ui/tooltip.min.js, wp-includes/js/jquery/ui/sortable.min.js, wp- includes/js/jquery/ui/droppable.js, wp-includes/js/jquery/ui/effect- blind.min.js, wp-includes/js/jquery/ui/effect-pulsate.js, wp- includes/js/jquery/ui/resizable.min.js, wp- includes/js/jquery/ui/datepicker.js, wp-includes/js/jquery/ui/effect- scale.js, wp-includes/js/jquery/ui/checkboxradio.js, wp- includes/js/jquery/ui/spinner.min.js, wp- includes/js/jquery/ui/button.min.js, wp- includes/js/jquery/ui/progressbar.min.js, wp- includes/js/jquery/ui/tooltip.js, wp-includes/js/jquery/ui/effect.min.js, wp-includes/js/jquery/ui/effect-transfer.js, wp- includes/js/jquery/ui/accordion.min.js, wp-includes/js/jquery/ui/effect- fade.min.js, wp-includes/js/jquery/ui/effect-fold.js, wp- includes/js/jquery/ui/effect-transfer.min.js, wp- includes/js/jquery/ui/mouse.js, wp-includes/js/jquery/ui/controlgroup.js, wp-includes/js/jquery/ui/progressbar.js, wp-includes/js/jquery/ui/effect- clip.min.js, wp-includes/js/jquery/ui/effect-scale.min.js, wp- includes/js/jquery/ui/selectmenu.min.js, wp-includes/js/jquery/ui/effect- blind.js, wp-includes/js/jquery/ui/effect-explode.js, wp- includes/js/jquery/ui/resizable.js, wp- includes/js/jquery/ui/dialog.min.js, wp-includes/js/jquery/ui/effect- slide.js, wp-includes/js/jquery/ui/slider.min.js, wp-includes/js/jquery/ui /effect-bounce.js, wp-includes/js/jquery/ui/effect-size.min.js, wp- includes/js/jquery/ui/datepicker.min.js, wp-includes/js/jquery/ui/effect- shake.min.js, wp-includes/js/wp-ajax-response.js, wp-includes/option.php, wp-admin/css/dashboard-rtl.css, wp-admin/css/dashboard-rtl.min.css, wp- admin/css/dashboard.min.css, wp-admin/css/dashboard.css, wp- admin/about.php, wp-admin/update-core.php, wp-admin/includes/upgrade.php, wp-admin/includes/update-core.php, wp-admin/includes/class-core- upgrader.php, wp-admin/includes/file.php, wp-admin/edit-form-blocks.php Installation failed. }}} I'm sure I can get this to work by setting the proper file permissions, but I remember now why I chose FTP: security. Can't remember exactly what the security concern was, but this is a webserver with multiple virtual hosts all running WordPress. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 21:42:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 21:42:14 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.99335abc7093e0fe0b68e6b048757431@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Replying to [comment:1 costdev]: > In the meantime, would you be able to set up a website using [https://wordpress.org/download/releases/ WordPress 5.7.5] on Debian 11 and try to upgrade to 5.8? This would let us confirm that the issue only lies within Debian 11, and not a mixture of Debian 11 and WordPress 5.9, and allow us to assign the `Version` property of the ticket accurately. I'll try setting up a website using 5.7.5 and try to upgrade it to 5.8. Will return with the results. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 22:37:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 22:37:27 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.bf4e0be0c64e36d74b44bd15a89ad3c7@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Ok, I installed WordPress 5.7.5 and tried to update it to 5.9.1. Got the exact same error: {{{ Downloading update from https://downloads.wordpress.org/release/wordpress-5.9.1-new-bundled.zip… The authenticity of wordpress-5.9.1-new-bundled.zip could not be verified as no signature was found. Unpacking the update… Verifying the unpacked files… The update could not be unpacked Installation failed. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 22:38:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 22:38:28 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.31f832d1719ba17627706ff897a80d87@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Oh wait, did you want me to try to update to 5.8 or 5.9? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 23:31:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 23:31:00 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) In-Reply-To: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> References: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> Message-ID: <070.fbdb49e11625222716647d20741e4fed@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+------------------------------ Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -------------------------+------------------------------ Comment (by peterwilsoncc): The [https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe #attr-sandbox sandbox attribute documentation] on MDN is pretty clear about this: > When the embedded document has the same origin as the embedding page, it is strongly discouraged to use both allow-scripts and allow-same-origin, **as that lets the embedded document remove the sandbox attribute** — making it no more secure than not using the sandbox attribute at all. (my emphasis) Locking down access to `window.parent` within auto-discovered embeds is quite intentional. The `sandbox` attribute's settings were discussed in #32522 but it's quite lengthy. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 23:54:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 23:54:33 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.e95ad8560deb88c2f94afa42f15f31b5@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------------+------------------------------ Comment (by simobenedettidesign): Hi there, - I am using Divi theme - The spacing between thumbnails is automatically set (I am using WP Gallery block). I have no issues with my current WordPress installation (5.8.3), the spacing between elements is respected but if I try to upgrade to the latest version (5.9.1) the spacing is lost - I have tested with Chrome, Firefox, Opera and Edge, the issue occurs with every browser - Gutenberg? I only have the WordPress editor, I have no extra plugins installed with this name Thanks for your help Replying to [comment:3 costdev]: > Hi @simobenedettidesign, welcome to Trac! > > Please provide the following additional information: > > - What theme are you using? > - How are you setting the space between elements? > - Are you using one Gallery block? If not, please tell us the blocks that you're using. > - What browser(s) does this issue appear in? > - Is the Gutenberg plugin installed and activated, or not? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 3 23:57:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 03 Mar 2022 23:57:57 -0000 Subject: [wp-trac] [WordPress Trac] #55313: Fix PHP Plugin Message-ID: <053.c6421cf766a1fb9860c631944634d9b1@wordpress.org> #55313: Fix PHP Plugin --------------------------+----------------------------- Reporter: ppatel821 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: blocker | Keywords: Focuses: | --------------------------+----------------------------- Since the most recent Word Press update, I am receiving multiple errors on my site: Deprecated: Required parameter $args follows optional parameter $depth in /home4/parasand/public_html/wp- content/themes/grandwedding/lib/menu.lib.php on line 22 Deprecated: Required parameter $output follows optional parameter $depth in /home4/parasand/public_html/wp- content/themes/grandwedding/lib/menu.lib.php on line 22 Warning: Cannot modify header information - headers already sent by (output started at /home4/parasand/public_html/wp- content/themes/grandwedding/lib/menu.lib.php:22) in /home4/parasand/public_html/wp-includes/pluggable.php on line 1355 Warning: Cannot modify header information - headers already sent by (output started at /home4/parasand/public_html/wp- content/themes/grandwedding/lib/menu.lib.php:22) in /home4/parasand/public_html/wp-includes/pluggable.php on line 1358 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 00:09:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 00:09:24 -0000 Subject: [wp-trac] [WordPress Trac] #55314: When saving edits to the footer in editor (beta), saving fails Message-ID: <056.753a6a76dc6ce66f94beaaf18dd3993e@wordpress.org> #55314: When saving edits to the footer in editor (beta), saving fails --------------------------+----------------------------- Reporter: garnitchique | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When editing the page template, saving changes made to the footer fails while saving changes to other blocks works. When saving changes to the footer, this request {{{ POST https://apgtest.dreamhosters.com/wp-json/wp/v2/template- parts/twentytwentytwo//footer?_locale=user }}} {{{

Proudly powered by WordPress

}}} results in this response {{{ 418 I'm a teapot }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 00:11:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 00:11:38 -0000 Subject: [wp-trac] [WordPress Trac] #55315: SVGs in editor (beta) Message-ID: <056.f77e6c1530c05f415f8c8b819ea0ee15@wordpress.org> #55315: SVGs in editor (beta) --------------------------+----------------------------- Reporter: garnitchique | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When adding an SVG to the header as logo or image, it uploads fine (after installing an SVG plugin) and is displayed when viewing the site, but it disappears in the editor. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 00:40:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 00:40:57 -0000 Subject: [wp-trac] [WordPress Trac] #55313: Fix PHP Plugin In-Reply-To: <053.c6421cf766a1fb9860c631944634d9b1@wordpress.org> References: <053.c6421cf766a1fb9860c631944634d9b1@wordpress.org> Message-ID: <068.a266dc59b8fcf3cc1c9a19e54d97acfb@wordpress.org> #55313: Fix PHP Plugin --------------------------+------------------------------ Reporter: ppatel821 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: blocker | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by joyously): The problem is in the theme. Due to the deprecation notice being output, the "headers already sent" warning is output. Fix the theme, and turn off the error display so this isn't a problem later. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 01:20:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 01:20:26 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted Message-ID: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted --------------------------------+----------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.1 Severity: normal | Keywords: Focuses: ui, administration | --------------------------------+----------------------------- == Context When a plugin is deleted, the total count is updated correctly on the left count, however, the total count is not updated correctly on the right count (as you can see on the screenshot) and by following the steps to replicate this problem. == Steps to replicate. 1. Install any plugin 2. Activate the plugin 3. Go to the plugin lists 4. Deactivate the plugin 5. Observe the total count of active plugins 6. Click on Delete and accept the prompt to remove it. 7. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 01:20:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 01:20:36 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.e43f4a311ef68deff6fae4efb8225f73@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted --------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ui, administration --------------------------+--------------------------------- Changes (by mitogh): * Attachment "2022-03-03_19-17.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 01:24:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 01:24:42 -0000 Subject: [wp-trac] [WordPress Trac] #53685: Update the `caniuse` database when running `grunt precommit:css` In-Reply-To: <051.13fbecdfcc2de797d45f32da538db2f7@wordpress.org> References: <051.13fbecdfcc2de797d45f32da538db2f7@wordpress.org> Message-ID: <066.2843a57e54ce9224d8180f06f876eff4@wordpress.org> #53685: Update the `caniuse` database when running `grunt precommit:css` ------------------------------+------------------------------ Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ------------------------------+------------------------------ Comment (by ironprogrammer): Hi, @desrosj 👋🏻: In my testing with npm v6.14.16, it is still an issue where `package- lock.json` indentation is converted to 2 spaces. This can be worked around by first deleting the lock file, where the `browserslist` update will copy the indentation from `package.json` (as expected) while regenerating the lock file. (See "Short Term Maintenance" below.) On the other hand, in npm v7-8, the indentation issue appears to have been fixed. During the lock file update, tabs are preserved, but v7 introduced `"lockFileVersion": 2` to `package.json`. It would seem that in order to support a pre-commit check for the latest `caniuse-lite` data, it would need to happen ''after'' migrating npm to a higher version. === Short Term Maintenance I've prepared a patch ([https://core.trac.wordpress.org/ticket/53685 PR 2379]) for the `caniuse-lite` DB with npm 6.14.16, if we ''only'' wanted to bring the browsers list up to date. Here is the list of changes as of today: {{{ Target browser changes: - and_chr 91 + and_chr 98 - and_uc 12.12 - android 91 + android 98 - chrome 91 - chrome 90 + chrome 98 + chrome 97 + chrome 96 - edge 91 - edge 90 + edge 98 + edge 97 + edge 96 - firefox 90 - firefox 89 + firefox 97 + firefox 96 + firefox 95 - ios_saf 14.5-14.7 - ios_saf 14.0-14.4 + ios_saf 15.2-15.3 + ios_saf 15.0-15.1 + ios_saf 14.5-14.8 - opera 77 - opera 76 + opera 83 + opera 82 - safari 14 + safari 15.2-15.3 + safari 15.1 - samsung 14.0 + samsung 16.0 }}} I know this doesn't address the need to update `precommit:css`, but offers some additional time while an update to npm is considered. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 01:28:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 01:28:35 -0000 Subject: [wp-trac] [WordPress Trac] #53685: Update the `caniuse` database when running `grunt precommit:css` In-Reply-To: <051.13fbecdfcc2de797d45f32da538db2f7@wordpress.org> References: <051.13fbecdfcc2de797d45f32da538db2f7@wordpress.org> Message-ID: <066.70825a4c93bf2ea157b42c2a16fe446d@wordpress.org> #53685: Update the `caniuse` database when running `grunt precommit:css` ------------------------------+------------------------------ Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: css ------------------------------+------------------------------ Comment (by ironprogrammer): > {{{#!comment > 1058732087 > }}} > [https://github.com/dream-encode dream-encode] commented on [https://github.com/WordPress/wordpress- develop/pull/2379#issuecomment-1058732087 PR #2379]: Hi, @dream-encode: Yes, sorry my explanation of why this might be a short-term maintenance item was taking a bit long to compose 😅 I do understand what the underlying objective is. This would be purely short term maintenance. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 01:43:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 01:43:47 -0000 Subject: [wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying In-Reply-To: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> References: <051.7f976d4b19f9f1b8dacdd8f98070a8a5@wordpress.org> Message-ID: <066.9a485fa9c7ffe5e428041a3b761f2211@wordpress.org> #54548: The Close on Escape "feature" on the admin comments page is annoying -------------------------+------------------------------------------------- Reporter: BettyJJ | Owner: alexstine Type: defect | Status: accepted (bug) | Priority: normal | Milestone: 6.0 Component: Comments | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, accessibility, javascript, | administration -------------------------+------------------------------------------------- Comment (by BettyJJ): Replying to [comment:9 afercia]: Thanks for your effort. I tried your patch and it does not seem to work. It seems that `event.isComposing` will become false when `esc` is pressed. See a minimal demo here: https://jsfiddle.net/Lgv7sayq/1/ Tested with the default Chinese IME shipped with Windows 10. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:04:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:04:30 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.3925bd293a4fffce766e72929d755967@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch commit | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): This code may need to be more specific. Via a [http://useragentstring.com/pages/useragentstring.php?name=All list of user agents chosen at random], I discovered there is an old version of Ubuntu called `Edgy Eft`. It's an edge case (pun intended) but the change should probably account for the version of Firefox that include the OS name. Maybe check for `Edg/`, `EdgiOS/` and `EdgA/`. The annoyance here is that you'll probably need to include the previous check for `edge` for older versions. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:04:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:04:45 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.0027805dd83c596733b82d3ef9651a2c@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-testing-info has-patch commit => good- first-bug has-testing-info has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:09:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:09:13 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.d769ddd5b328761d8fca3c986eab0ece@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-dev-note commit => has-patch has-unit-tests needs-dev-note Comment: I pushed an intentionally broken test to [https://github.com/WordPress /wordpress-develop/pull/2318 PR#2318] earlier today to demonstrate a question I had about `get_term()` -- ie, the singular. I'll remove the commit keyword for now. Do yell out if I am highlighting something that is intentionally out of scope. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:30:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:30:03 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.5f0b194f692f8ef76b16a6362ce87e23@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch | -------------------------------------------------+------------------------- Comment (by costdev): `Edgy Eft` uses `Ubuntu-edgy`: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20060601 Firefox/2.0.0.1 (Ubuntu-edgy) Since `strpos()` is case sensitive, it returns `false`: [https://3v4l.org/LVH3U 3v4l] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:50:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:50:11 -0000 Subject: [wp-trac] [WordPress Trac] #54770: The term "Current Theme" is ambiguous In-Reply-To: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> References: <053.98abc1a7fac13c318ce11d048f7e3568@wordpress.org> Message-ID: <068.964b1a30da3cbc62bf887c5476e4b427@wordpress.org> #54770: The term "Current Theme" is ambiguous -------------------------+--------------------------------- Reporter: Presskopp | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, administration -------------------------+--------------------------------- Changes (by peterwilsoncc): * keywords: has-patch commit => has-patch Comment: To keep the report accurate, I am removing the commit keyword while discussion ensues. FWIW, I think "active" is a fine term. The number of items permitted to be active at any one time doesn't affect whether they are active. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 02:51:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 02:51:39 -0000 Subject: [wp-trac] [WordPress Trac] #54878: Don't show links to the Customizer when installing themes using api.wordpress.org In-Reply-To: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> References: <057.58d6b8a0356e7d8352dbbb7dc92773a9@wordpress.org> Message-ID: <072.089cc51a559048aeebd872d21a35f7d9@wordpress.org> #54878: Don't show links to the Customizer when installing themes using api.wordpress.org -------------------------------------------------+------------------------- Reporter: antonvlasenko | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch has-screenshots commit | Focuses: fixed-major | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-screenshots commit => has-patch has-screenshots commit fixed-major Comment: Committed in [52819] but waiting for trac to catch up: > Themes: Hide block themes' live preview link following installation. > > Prevent the Customizer/Live Preview button from showing for installed block themes when on the theme installation page. > > Props antonvlasenko, costdev, ironprogrammer. > Fixes #54878. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 03:01:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 03:01:12 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.338d71f4dfaf226d54087dcb2d44bb23@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. -----------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early | Focuses: coding-standards -----------------------------+------------------------------- Changes (by peterwilsoncc): * Attachment "trunk-edit-user.png" added. Edit user screen (trunk) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 03:01:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 03:01:34 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.0e41f164959c1177c0019a05ff78acf1@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. -----------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early | Focuses: coding-standards -----------------------------+------------------------------- Changes (by peterwilsoncc): * Attachment "pr-edit-user.png" added. Edit user screen (pull request) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 03:11:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 03:11:54 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.a7838b5dad1605255eff68537b58f6a7@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. ------------------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early commit | Focuses: coding-standards ------------------------------------+------------------------------- Changes (by peterwilsoncc): * keywords: has-patch early => has-patch early commit Comment: Reviewed linked pull request with white space suppressed. The changes look good to me. Screenshots comparing the screens between the proposed changes and trunk show no apparent difference. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 04:56:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 04:56:43 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) In-Reply-To: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> References: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> Message-ID: <070.1b45d1250a561dd56f6b4344f566bc88@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+------------------------------ Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -------------------------+------------------------------ Comment (by tomatodysee): Replying to [comment:4 peterwilsoncc]: > The [https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe #attr-sandbox sandbox attribute documentation] on MDN is pretty clear about this: > > > When the embedded document has the same origin as the embedding page, it is strongly discouraged to use both allow-scripts and allow-same- origin, **as that lets the embedded document remove the sandbox attribute** — making it no more secure than not using the sandbox attribute at all. > > (my emphasis) > > Locking down access to `window.parent` within auto-discovered embeds is quite intentional. The `sandbox` attribute's settings were discussed in #32522 but it's quite lengthy. My emphasis: > **When the embedded document has the same origin as the embedding page**, it is strongly discouraged to use both allow-scripts and allow- same-origin, as that lets the embedded document remove the sandbox attribute — making it no more secure than not using the sandbox attribute at all. So since wordpress and odysee are not the same origin (domain), this doesn't apply from what I understand. From https://core.trac.wordpress.org/changeset/34903, it also sounds like it's possible to embed wordpress on other sites, and that embed has the proper security restrictions. Is the concern that someone may embed a wordpress page on odysee, and then that is embedded on another wordpress site? Or someone embedding a wordpress site that has an odysee embed, on Odysee? The first isn't possible because we don't support iframes/oembed consumers, and the 2nd would be protected by the wordpress iframe security settings. I don't mean to stir up confusion or rehashing of an old decision about this, it's just that iframes + iframe security are fairly complicated, and hence, misunderstood. All my research has shown similar findings to the above arguement about it being on different domains. Our embeds also work via iframes if users have a paid wordpress account, so we'd have the same security vulnerability there if this were true (and it would also apply to other, more malicious sites/actors). We're just trying to make it easier out of the box by using the Odysee URLs vs embed code. If going down the oembed provider path is the only way, we can try to do that, but it sounds overkill + will take quite a bit of time. Appreciate your time and feedback once again! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 05:50:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 05:50:48 -0000 Subject: [wp-trac] [WordPress Trac] #46907: Pass current request object to rest_authentication_errors filter In-Reply-To: <051.b14ce9f322f5118cf8a2e0feff3db4d6@wordpress.org> References: <051.b14ce9f322f5118cf8a2e0feff3db4d6@wordpress.org> Message-ID: <066.f5794a761782161b002b3d5836fe48b0@wordpress.org> #46907: Pass current request object to rest_authentication_errors filter -------------------------+----------------------- Reporter: ocean90 | Owner: ocean90 Type: enhancement | Status: closed Priority: normal | Milestone: Component: REST API | Version: Severity: normal | Resolution: wontfix Keywords: needs-patch | Focuses: rest-api -------------------------+----------------------- Comment (by kakomap): Hi here, I've followed this and I'd like to add a use-case where the `$request` might be useful. A plugin might, like in my case, want to have the REST API restricted for all API requests except some particular endpoints. The plugin needs to hook into `rest_authentication_errors` but needs to return `WP_Error|null|true` based on the request being processed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 06:28:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 06:28:10 -0000 Subject: [wp-trac] [WordPress Trac] #36907: Improved sticky post query In-Reply-To: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> References: <056.3d869f6613968a9b112cc6108cfa738f@wordpress.org> Message-ID: <071.e0c6f493cd71cf6b8d8113a43efd4c03@wordpress.org> #36907: Improved sticky post query ----------------------------------------+--------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Query | Version: 3.5 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests | Focuses: performance ----------------------------------------+--------------------------- Changes (by rehanali): * Attachment "#36907.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 06:48:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 06:48:57 -0000 Subject: [wp-trac] [WordPress Trac] #17851: Wrapping Sections with add_settings_section In-Reply-To: <053.ac36c57cc64378fd983a2bf637f0d159@wordpress.org> References: <053.ac36c57cc64378fd983a2bf637f0d159@wordpress.org> Message-ID: <068.1b508226951285d8ecc39c8ba38e1464@wordpress.org> #17851: Wrapping Sections with add_settings_section -------------------------------------------------+------------------------- Reporter: griffinjt | Owner: chriscct7 Type: enhancement | Status: reviewing Priority: normal | Milestone: Component: Administration | Version: 3.1.3 Severity: normal | Resolution: Keywords: has-patch good-first-bug needs- | Focuses: unit-tests needs-testing | -------------------------------------------------+------------------------- Changes (by rehanali): * Attachment "#17851.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 06:55:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 06:55:12 -0000 Subject: [wp-trac] [WordPress Trac] #41594: Edit tag form limited to 800px width In-Reply-To: <054.392b0b5071a914217061e13ae2e3d37c@wordpress.org> References: <054.392b0b5071a914217061e13ae2e3d37c@wordpress.org> Message-ID: <069.f15353ad2d2f823d60d8c2237187bde6@wordpress.org> #41594: Edit tag form limited to 800px width -------------------------------------+------------------------------------- Reporter: fabienlege | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.8.1 Severity: normal | Resolution: Keywords: has-patch has- | Focuses: ui, administration, screenshots | template -------------------------------------+------------------------------------- Changes (by rehanali): * Attachment "#41594.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 07:09:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 07:09:19 -0000 Subject: [wp-trac] [WordPress Trac] #55317: get_header() function does not work with block based themes Message-ID: <062.58263221eb1cd35a6d4cc3b2c0b3bc71@wordpress.org> #55317: get_header() function does not work with block based themes --------------------------------+----------------------------- Reporter: randhirexpresstech | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: blocker | Keywords: Focuses: template | --------------------------------+----------------------------- Block based themes like Twenty Twenty-Two do not contain php templates. Since,get_header() function use php header templates, it generate a warning "Deprecated: Theme without header.php is deprecated since version 3.0.0 with no alternative available. Please include a header.php template in your theme." -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 09:27:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 09:27:25 -0000 Subject: [wp-trac] [WordPress Trac] #55318: Do Something of site hack.. Message-ID: <052.62632ab68275c6017968b4bc3b7a4306@wordpress.org> #55318: Do Something of site hack.. -----------------------------+----------------------------- Reporter: hkdhvani | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: dev-feedback Focuses: | -----------------------------+----------------------------- I have made too many sites using WordPress , every time my E-Commerce site get hacked and its hacked like , I have to add old backup which leads my clients to loss.. Please solve this hacking issues in WordPress Site and provide something that can secure WordPress like other CMS Platforms.. Because of often site hacking , Users are changing their CMS Platform from WordPress to another.. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 09:43:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 09:43:51 -0000 Subject: [wp-trac] [WordPress Trac] #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix In-Reply-To: <052.71705d312df930659699caa7e0d22c46@wordpress.org> References: <052.71705d312df930659699caa7e0d22c46@wordpress.org> Message-ID: <067.888a631a97ec83adc22c623a1b7d55d1@wordpress.org> #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix ---------------------------+------------------------------ Reporter: pgpagely | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by pgpagely): An additional finding is that if the `gutenberg` plugin is enabled then the following hack is needed so that the `view.min.js` URL is not broken (with `gutenberg` disabled only the hack in the original message is needed): {{{#!php add_filter("script_loader_src", function ($src) { return preg_replace("#/wp-includes/wordpress-versions/[0-9.]+/#", "/", $src); }); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:12:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:12:26 -0000 Subject: [wp-trac] [WordPress Trac] #55318: Do Something of site hack.. In-Reply-To: <052.62632ab68275c6017968b4bc3b7a4306@wordpress.org> References: <052.62632ab68275c6017968b4bc3b7a4306@wordpress.org> Message-ID: <067.6abbd59a6331390a36d697abeae7db20@wordpress.org> #55318: Do Something of site hack.. --------------------------------+------------------------------ Reporter: hkdhvani | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: dev-feedback close | Focuses: --------------------------------+------------------------------ Changes (by costdev): * keywords: dev-feedback => dev-feedback close * version: 5.9.1 => trunk Comment: Hi @hkdhvani, welcome to Trac! Sorry to hear that you've been experiencing attacks on your clients' websites. If you have a specific potential security vulnerability to report, please read [https://make.wordpress.org/core/handbook/testing/reporting-security- vulnerabilities/ Reporting Security Vulnerabilities]. Otherwise, please take a look at [https://wordpress.org/support/article /hardening-wordpress/ Hardening WordPress]. You may particularly benefit from the [https://wordpress.org/support/article/hardening- wordpress/#firewall Firewall] section. As Trac is for the development of WordPress Core rather than for support or resolving security vulnerabilities, you can get some help from the folks over on [https://wordpress.org/support/forums/ the support forums]. I'll leave this ticket open for another core developer to give their feedback, but I propose that this ticket is closed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:12:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:12:48 -0000 Subject: [wp-trac] [WordPress Trac] #55318: Do Something of site hack.. In-Reply-To: <052.62632ab68275c6017968b4bc3b7a4306@wordpress.org> References: <052.62632ab68275c6017968b4bc3b7a4306@wordpress.org> Message-ID: <067.652f5fc148a8941bbed636aed3a25e98@wordpress.org> #55318: Do Something of site hack.. --------------------------------+------------------------------ Reporter: hkdhvani | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: trunk Severity: normal | Resolution: Keywords: dev-feedback close | Focuses: --------------------------------+------------------------------ Changes (by costdev): * component: General => Security -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:19:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:19:44 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.5ec000d041aec10ecfa661c41761f1d5@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, administration -------------------------+--------------------------------- Changes (by costdev): * version: 5.9.1 => * type: defect (bug) => enhancement * milestone: Awaiting Review => 6.0 Comment: == Reproc Report === Env * Web Server: Apache (Linux) * WordPress: 6.0-alpha-52448-src * Browser: Chrome * OS: Windows 10 * Theme: Twenty Twenty-Two * Plugins: Enable Customizer === Steps to test 1. Navigate to `Plugins > Installed Plugins`. 2. Observe the total count of "All" plugins. 3. Click on Delete and accept the prompt to remove it. 4. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted. === Results 1. The count on the right is not updated. Issue reproduced. ✅ Milestoning for 6.0 and removing the version as this will have existed for quite some time. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:23:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:23:45 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.99b81e2ba7167bc1cedc1a57770929f4@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: | Focuses: ui, administration -------------------------+--------------------------------- Changes (by costdev): * Attachment "55316.diff" added. Update item count upon plugin deletion. Do not commit this patch - it needs review for i18n. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:26:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:26:24 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.0241a6410f974c793820ecd9f43790ee@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by costdev): * keywords: => needs-testing has-testing-info needs-refresh Comment: Patch [https://core.trac.wordpress.org/attachment/ticket/55316/55316.diff 55316.diff] should update the item count when a plugin is deleted. However, this does not account for i18n/rtl and will need some input from a developer familiar with this. Steps to test: 1. Navigate to `Plugins > Installed Plugins`. 2. Observe the total count of "All" plugins. 3. Click on Delete and accept the prompt to remove it. 4. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted. 5. Apply [https://core.trac.wordpress.org/attachment/ticket/55316/55316.diff 55316.diff]. 6. Run `npm run build:dev`. 7. Navigation to `Plugins > Installed Plugins`. 8. Do a hard refresh to ensure that scripts have been refreshed. 9. Repeat steps 2-4. This time, the item count should decrease by 1 as expected. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:34:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:34:30 -0000 Subject: [wp-trac] [WordPress Trac] #55319: Add filter to get_block_wrapper_attributes function Message-ID: <055.c3dd2dc2cdc0efb693ac3992b1d4f938@wordpress.org> #55319: Add filter to get_block_wrapper_attributes function -------------------------+----------------------------- Reporter: fabiankaegy | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- **What problem does this address?** It is currently possible to add custom classnames to static blocks using the blocks.getSaveContent.extraProps filter in JS. This is super useful when working with custom block supports. And even core uses this system in js to add the classnames generated for for example the color classes. In PHP however, for custom blocks this is all hardcoded in the get_block_wrapper_attributes function. Specifically inside the WP_Block_Supports Class here: https://github.com/WordPress/WordPress/blob/92f0b0cb48a3de660655cc658fc739695a393096 /wp-includes/class-wp-block-supports.php#L93-L128 This approach makes it impossible for custom supports that plugins develop to apply to custom blocks. **What is your proposed solution?** This could be solved by adding a new hook in PHP to the get_block_wrapper_attributes function which should work the same as the blocks.getSaveContent.extraProps hook in js. This ticket was first created in GitHub on the Gutenberg repository in [#38830](https://github.com/WordPress/gutenberg/issues/38830) but as the code no longer exists in Gutenberg since it was moved to core in 5.8 it was suggested that the change needs to happen in core directly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:35:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:35:43 -0000 Subject: [wp-trac] [WordPress Trac] #55319: Add filter to get_block_wrapper_attributes function In-Reply-To: <055.c3dd2dc2cdc0efb693ac3992b1d4f938@wordpress.org> References: <055.c3dd2dc2cdc0efb693ac3992b1d4f938@wordpress.org> Message-ID: <070.d4b31bc3bae716d73fc4c0b84eebf4dd@wordpress.org> #55319: Add filter to get_block_wrapper_attributes function -------------------------+------------------------------ Reporter: fabiankaegy | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by fabiankaegy): This ticket and how it should be approached was discussed in slack here: https://wordpress.slack.com/archives/C02QB2JS7/p1646070868485339 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:50:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:50:21 -0000 Subject: [wp-trac] [WordPress Trac] #55023: get_header() notice: Theme without header.php is deprecated (was: deprecated issue on multisite reqgister page.) In-Reply-To: <049.8ae3174727f1c07ec2b6f7b68ce06010@wordpress.org> References: <049.8ae3174727f1c07ec2b6f7b68ce06010@wordpress.org> Message-ID: <064.0a9c504f6964eeeb679d00feda6552ee@wordpress.org> #55023: get_header() notice: Theme without header.php is deprecated --------------------------+------------------------ Reporter: kpdaa | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: needs-patch | Focuses: multisite --------------------------+------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 10:51:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 10:51:00 -0000 Subject: [wp-trac] [WordPress Trac] #55317: get_header() function does not work with block based themes In-Reply-To: <062.58263221eb1cd35a6d4cc3b2c0b3bc71@wordpress.org> References: <062.58263221eb1cd35a6d4cc3b2c0b3bc71@wordpress.org> Message-ID: <077.86c1fd7de23e889c465814a53d482659@wordpress.org> #55317: get_header() function does not work with block based themes --------------------------------+------------------------ Reporter: randhirexpresstech | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Themes | Version: 5.9.1 Severity: blocker | Resolution: duplicate Keywords: | Focuses: template --------------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * component: General => Themes * milestone: Awaiting Review => Comment: Hi there, welcome to WordPress Trac! Thanks for the report, we're already tracking this issue in #55023. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 11:05:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 11:05:16 -0000 Subject: [wp-trac] [WordPress Trac] #50924: Do not use ZWNJ and ZWJ in post name (slug and url) In-Reply-To: <053.89897d2f271d4c2edcec77b3858b6ff9@wordpress.org> References: <053.89897d2f271d4c2edcec77b3858b6ff9@wordpress.org> Message-ID: <068.168cef77a02f190fd234dfa9d0877859@wordpress.org> #50924: Do not use ZWNJ and ZWJ in post name (slug and url) -------------------------------------------------+------------------------- Reporter: behzadian | Owner: | SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Permalinks | Version: Severity: normal | Resolution: duplicate Keywords: has-patch has-unit-tests needs- | Focuses: testing-info | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => duplicate * milestone: Future Release => Comment: This appears to be resolved as part of [51984] / #47912. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 11:22:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 11:22:24 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.f7f9f7a716fb7c1736165e5a76e07b1c@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. ------------------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch early commit | Focuses: coding-standards ------------------------------------+------------------------------- Comment (by audrasjb): Alright, let's commit this PR. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 11:28:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 11:28:09 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.eac293f29aaab2f27bb62d32b5cf6c2a@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. ------------------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch early commit | Focuses: coding-standards ------------------------------------+------------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52820" 52820]: {{{ #!CommitTicketReference repository="" revision="52820" Coding Standards: Improve formatting in `/wp-admin/user-edit.php`. This change improves the formatting of `/wp-admin/user-edit.php` to avoid PHPCS failures when adding new code, which previously required new code to be indented multiple times, breaking alignment of the HTML parts. This change avoids disabling/enabling PHPCS for failing sniffs. Props costdev, johnregan3, peterwilsoncc. Fixes #54673. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 13:29:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 13:29:33 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.d65f33b69999fc59c233b636eaffaa73@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch dev-feedback => has-patch dev-feedback needs-refresh * milestone: Future Release => 6.0 Comment: Moving for 6.0 consideration Also marking as `needs-refresh` since it doesn't apply anymore against trunk. (see https://wordpress.slack.com/archives/C02RQBWTW/p1646400165837319). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 13:39:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 13:39:24 -0000 Subject: [wp-trac] [WordPress Trac] #55320: Twenty Twenty-Two Message-ID: <051.3c0096ce451f3d88c60ff2d61518c871@wordpress.org> #55320: Twenty Twenty-Two ---------------------------+----------------------------- Reporter: daveydo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- The monitor of the Twenty Twenty-Two forum asked me to relay this information to you: t-p wrote: If the theme is to be as flexible as suggested by the authors then the Drop cap as an option should be set true from the start so that all users can benefit, irrespective of technical knowledge. Please report that via https://core.trac.wordpress.org/newticket Please use the “Bundled Theme” component and start the Summary field with Twenty Twenty-Two Post Link: https://wordpress.org/support/topic/theme-upgrades- please/?view=all#post-15424860 ----------- Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 13:42:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 13:42:29 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.7a81d685f6a04c39de7b9764104b7aae@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch | -------------------------------------------------+------------------------- Comment (by Boniu91): == Test Report === Env * WordPress 5.9 with patch applied * Edge 98.0.1108.62 * Theme: Twenty Twenty One === Steps to test 1. Added the following code to functions.php: {{{#!php global $is_edge; die( var_export( $is_edge, true ) ); }}} 2. Visited the page using Edge 3. `true` is displayed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 13:51:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 13:51:41 -0000 Subject: [wp-trac] [WordPress Trac] #55320: Twenty Twenty-Two: Add Drop cap feature and the ability to change color of individual words other than links (was: Twenty Twenty-Two) In-Reply-To: <051.3c0096ce451f3d88c60ff2d61518c871@wordpress.org> References: <051.3c0096ce451f3d88c60ff2d61518c871@wordpress.org> Message-ID: <066.89b4facacc8b89fa193d7cf6aa5948d4@wordpress.org> #55320: Twenty Twenty-Two: Add Drop cap feature and the ability to change color of individual words other than links ---------------------------+------------------------------ Reporter: daveydo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 14:10:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 14:10:15 -0000 Subject: [wp-trac] [WordPress Trac] #47912: Non-visible chars in title creates some encoded values in permalink In-Reply-To: <054.413ca78da8b94d51590f3a3095f7726f@wordpress.org> References: <054.413ca78da8b94d51590f3a3095f7726f@wordpress.org> Message-ID: <069.ebae7a48afad5933371edf8951942787@wordpress.org> #47912: Non-visible chars in title creates some encoded values in permalink -------------------------------------+------------------------------------- Reporter: dhanendran | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.9 Component: Permalinks | Version: 5.2.2 Severity: major | Resolution: fixed Keywords: has-patch has-unit- | Focuses: ui, rtl, tests commit has-testing-info | administration -------------------------------------+------------------------------------- Comment (by SergeyBiryukov): In [changeset:"52821" 52821]: {{{ #!CommitTicketReference repository="" revision="52821" Docs: Add inline comments for non-visible characters in `sanitize_title_with_dashes()`. This aims to clarify the list of characters that are stripped from URLs or converted to a hyphen. Follow-up to [51984]. See #47912, #54729. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 14:10:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 14:10:15 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.1c8391e86a7af8917ffa90dea8b6e5b9@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: docs ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"52821" 52821]: {{{ #!CommitTicketReference repository="" revision="52821" Docs: Add inline comments for non-visible characters in `sanitize_title_with_dashes()`. This aims to clarify the list of characters that are stripped from URLs or converted to a hyphen. Follow-up to [51984]. See #47912, #54729. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 14:16:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 14:16:09 -0000 Subject: [wp-trac] [WordPress Trac] #55313: Fix PHP Plugin In-Reply-To: <053.c6421cf766a1fb9860c631944634d9b1@wordpress.org> References: <053.c6421cf766a1fb9860c631944634d9b1@wordpress.org> Message-ID: <068.fee840896547b68e9d57405832de34ff@wordpress.org> #55313: Fix PHP Plugin --------------------------+------------------------------ Reporter: ppatel821 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Resolution: Keywords: close | Focuses: --------------------------+------------------------------ Changes (by azouamauriac): * keywords: => close * severity: blocker => normal -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:19:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:19:30 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.532ff1baf2336cce1e3cbc3f7bd86be0@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "Screenshot at Mar 04 15-32-01 before patch.png" added. before patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:20:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:20:14 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.0c5f43e2fff1edf10a6ee05050fa1daa@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "Screenshot at Mar 04 15-52-01 after_patch_55316.png" added. After patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:22:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:22:54 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.acbd88423b91ffa237036a108c823f51@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "Screenshot at Mar 04 15-55-36 after_patch_not_work_for_recent_active.png" added. After patch 'Recently Active' tab (it seems like patch does not work there ) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:24:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:24:31 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.7b62c0b902eccb5dab7cb183e85dde70@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "Screenshot at Mar 04 15-55-36 after_patch_working_for_auto_disable.png" added. After patch; 'Auto-updates Disabled' tab (patch works) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:32:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:32:25 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.d8548ebcc48030b5f495423bbd4f225b@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by azouamauriac): Above some test result. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:38:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:38:13 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.1df59db113115764f7ac475fc7a86646@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by costdev): Thanks for the tests @azouamauriac! The patch is changing the value to `plugins.all.length`. That's why it looked like the patch worked in your second test, when in fact it was a coincedence that **All** and **Auto-updates Disabled** were the same number. I've have another look at the patch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:53:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:53:16 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.4528ac88d17974bac11ebb4640462e58@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "55316.2.diff" added. Patch updated to use the count of the current view. Still needs a refresh for i18n if anyone is familiar with this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 15:56:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 15:56:05 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.ba5e6d14d43bf2e31ddf30c111a6ff37@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by costdev): Patch updated if you have time to run more tests @azouamauriac -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:04:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:04:43 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.a1712a84c5a086b1904c1f0627ba56af@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by swissspidy): For proper i18n you'll need to use `wp.i18n._n()` together with `wp.i18n.sprintf`. Make sure `wp-i18n` is a dependency of the `updates.js` script if not already the case. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:18:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:18:30 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.f28e43a81e11a20fa7fadb028fcee46c@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): Thanks @peterwilsoncc . It is was a good spot. I have refactor the patch to remove usage of `get_term` and now everything uses `get_terms`. Unit tests are passing now -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:18:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:18:48 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.39f300d92bb6bbf8ca2d0416d6c2a41b@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by costdev): Thanks @swissspidy! I'll take a look at this now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:22:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:22:49 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.c208f7b6138661399cd699c8e3368689@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by azouamauriac): * Attachment "Screenshot at Mar 04 17-16-45 after_patch_2_recently_active_works.png" added. after patch 55316.2.diff; same result for following tab: 'Inactive', 'Auto-updates Disabled'. The patch works -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:27:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:27:34 -0000 Subject: [wp-trac] [WordPress Trac] #55196: Twenty Twenty-Two - Search Magnifying SVG icon In-Reply-To: <050.906544f38ac4c2f87c212c7e1f45cbe1@wordpress.org> References: <050.906544f38ac4c2f87c212c7e1f45cbe1@wordpress.org> Message-ID: <065.7f9158a496ee9bd6bb84939ec425a7d5@wordpress.org> #55196: Twenty Twenty-Two - Search Magnifying SVG icon --------------------------+-------------------------------- Reporter: utz119 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: reported-upstream Keywords: | Focuses: accessibility --------------------------+-------------------------------- Changes (by ryokuhi): * status: new => closed * resolution: => reported-upstream * milestone: 5.9.2 => Comment: We reviewed this ticket today during the Accessibility Team's bug-scrub. As the problem has been solved (and, as such, reported) in Gutenberg, we think this ticket might be closed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:28:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:28:03 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.bd7b8018eb50ae274bdf42c42160a008@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by azouamauriac): Replying to [comment:5 costdev]: > Patch updated if you have time to run more tests @azouamauriac Done! Patch works on my side. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:34:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:34:14 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.85846dcc8256499038c490358a34fdec@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Comment (by costdev): Thanks @azouamauriac! I'll work on i18n and try to get this patch ready for further testing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 16:47:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 16:47:02 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.374451f89969c17e8045cf015bed6a29@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by costdev): * Attachment "55316.3.diff" added. Patch updated with i18n. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 18:00:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 18:00:00 -0000 Subject: [wp-trac] [WordPress Trac] #55308: Update WordPress version URL target In-Reply-To: <053.b8de66dd15e6204fc2c92a329b0c3c45@wordpress.org> References: <053.b8de66dd15e6204fc2c92a329b0c3c45@wordpress.org> Message-ID: <068.c661bcb288a3e2031280d6a78bf22182@wordpress.org> #55308: Update WordPress version URL target --------------------------+------------------------------------------------ Reporter: gazthink3 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: | Version: Upgrade/Install | Severity: minor | Resolution: Keywords: 2nd-opinion | Focuses: ui, accessibility, administration has-patch | --------------------------+------------------------------------------------ Changes (by sabernhardt): * type: defect (bug) => enhancement * focuses: ui, accessibility => ui, accessibility, administration * component: General => Upgrade/Install * version: trunk => Comment: Changing to enhancement, to consider the modal implementation (or something else other than `target="_blank"`) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 18:24:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 18:24:38 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.98fa0245016ba2483eaa6ea3e16910c9@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted --------------------------------------------+------------------------------ Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, | administration --------------------------------------------+------------------------------ Changes (by costdev): * keywords: needs-testing has-testing-info needs-refresh => needs-testing has-testing-info -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 19:24:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 19:24:42 -0000 Subject: [wp-trac] [WordPress Trac] #55316: Counter for total plugins is not updated after a plugin is deleted In-Reply-To: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> References: <050.1150621b36fd5ab38c23cf605c504dee@wordpress.org> Message-ID: <065.8a0f73398ef70aa0c5bcea888c0c8b22@wordpress.org> #55316: Counter for total plugins is not updated after a plugin is deleted -------------------------------------------------+------------------------- Reporter: mitogh | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: Severity: normal | Resolution: Keywords: needs-testing has-testing-info | Focuses: ui, needs-refresh | administration -------------------------------------------------+------------------------- Changes (by kebbet): * keywords: needs-testing has-testing-info => needs-testing has-testing- info needs-refresh Comment: Perhaps use {{{_nx()}}} in combination with {{{number_format_i18n()}}} instead of just {{{_n()}}}? That way a comment can be added that the items word in this case means plugins, and the counter is displayed in the locales number format. https://developer.wordpress.org/reference/functions/_nx/ https://developer.wordpress.org/reference/functions/number_format_i18n/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 20:32:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 20:32:41 -0000 Subject: [wp-trac] [WordPress Trac] #51805: Clarify the prerequisites for updating the .htaccess file in flush_rewrite_rules() In-Reply-To: <058.c9c541e7ab5b975da6eb6b33eee08d39@wordpress.org> References: <058.c9c541e7ab5b975da6eb6b33eee08d39@wordpress.org> Message-ID: <073.fdce5435343113a3d1b85d6661148a9e@wordpress.org> #51805: Clarify the prerequisites for updating the .htaccess file in flush_rewrite_rules() ----------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Rewrite Rules | Version: Severity: normal | Resolution: Keywords: | Focuses: docs ----------------------------+----------------------------- Comment (by bwmarkle): +1 Usually it's Stack Overflow that answers all my questions, but today it was this trac ticket! I'm creating a REST call to allow changing of a siteurl, and flush_rewrite_rules() wasn't working as expected. I ended up writing a wrapper function. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 21:27:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 21:27:49 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.7a02e98ed4f9e4f94b4ca61ce6d791c5@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by afragen): Did you need to setup the chroot after your Debian upgrade? It seems that might be where your issue is, especially as downloaded file are in the expected locations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 21:41:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 21:41:52 -0000 Subject: [wp-trac] [WordPress Trac] #33566: Keyboard shortcuts for all functionality on the dashboard In-Reply-To: <048.074625b96bd37e525488ae07b55f8a58@wordpress.org> References: <048.074625b96bd37e525488ae07b55f8a58@wordpress.org> Message-ID: <063.8334334a54bafa42ea6f9d8a60c8c862@wordpress.org> #33566: Keyboard shortcuts for all functionality on the dashboard ----------------------------+-------------------------------- Reporter: tady | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future Release Component: Administration | Version: 4.3 Severity: normal | Resolution: Keywords: | Focuses: ui, accessibility ----------------------------+-------------------------------- Comment (by iandunn): GitHub [https://docs.github.com/en/get-started/using-github/github- command-palette recently launched an intent-driven interface]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 4 22:35:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 04 Mar 2022 22:35:16 -0000 Subject: [wp-trac] [WordPress Trac] #55264: Twenty Twenty-Two Looks Bad on Firefox In-Reply-To: <052.c49ea7b317e9670bf4de4997faf4f168@wordpress.org> References: <052.c49ea7b317e9670bf4de4997faf4f168@wordpress.org> Message-ID: <067.eed80a5503aa2897673318ed2a4853b5@wordpress.org> #55264: Twenty Twenty-Two Looks Bad on Firefox -------------------------------+------------------------------ Reporter: aichedvs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: 5.9 Severity: critical | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by aichedvs): Replying to [comment:6 aichedvs]: > Replying to [comment:4 audrasjb]: > > Hello and welcome to WordPress Core Trac @aichedvs, > > > > Replying to [comment:2 aichedvs]: > > > But the other issue I reported, with the pages loading first in plain text before quickly becoming formatted, is also occurring with Firefox (as well as Chrome and Edge). This I consider an annoyance rather than a show stopper, but it should be addressed by the WordPress/Gutenberg folks. > > > > Does it also occur on a fresh install without any plugin? I can't reproduce the issue on my side in any browser. > > Removing plugins does not help. The same issue has been posted by others in the Twenty Twenty-Two Support Forum with the title "Website content flickers when loaded". The site has been updated to WP 5.9.1 and the flicker problem appears to have gone away. The site now looks good on the three browsers (Chrome, Edge, and Firefox), and the iPhone. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 00:36:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 00:36:20 -0000 Subject: [wp-trac] [WordPress Trac] #55189: Automatic removal of "Zero-width non-joiner" in URL In-Reply-To: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> References: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> Message-ID: <068.60d15bb18b5d2ddd0fe0941b4e3a6f09@wordpress.org> #55189: Automatic removal of "Zero-width non-joiner" in URL --------------------------+--------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Permalinks | Version: 5.9 Severity: critical | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+--------------------- Comment (by ironprogrammer): #50924 focused on the unsightly encoding of ZWNJ in the sample paths (e.g. `/پیامک%e2%80%8cها/`). The update provided by #47912 addresses that, but does so in a heavy-handed way: it strips them all out, disregarding context. As @SergeyBiryukov noted, #4328 has the potential to address the SEO/redirect concern reported. Though the age of that ticket isn't encouraging 😔 A simpler short-term fix could help impacted site owners. Also, apart from the [important] redirect concern, is there a concern about how this change to slugs may impact the "meaning" of paths in URLs? How important is it that the intended word(s) be maintained in the slug? [https://www.searchenginejournal.com/technical-seo/url-structure/ It's suggested that keywords in URLs these days don't impact SERPs], but that doesn't mean the words in paths should be inaccurate. ---- For example, to expand on @man4toman's report, removing ZWNJ from slugs (or a `-` replacement) can change the meaning of the words used*: "Word" کلمه‌ای Removal of ZWNJ: "Cabbages" کلمهای In a post: [[Image(https://cldup.com/0OmYevLiq0.thumb.jpg, 50%)]] ''Post title is changed to a different word in slug.'' This can also impact categories and tags, for example: [[Image(https://cldup.com/5kjEmgVY0Q.png, 75%)]] ''Potentially misleading category slug.'' ''(*My apologies to Persian speakers for any translation inaccuracies above 😅. I used DuckDuckGo's translator for the meanings to illustrate this point.)'' ---- Related: According to Iran's NIC, [https://www.nic.ir/idn/#Rules_and_Restrictions IRNIC], the use of ZWNJ is acceptable in Persian domain names. I couldn't find domain rules related to ZWNJ in Arabic, but understand its use is less common than in Persian. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 00:58:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 00:58:31 -0000 Subject: [wp-trac] [WordPress Trac] #55189: Automatic removal of "Zero-width non-joiner" in URL In-Reply-To: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> References: <053.3e9eb622a7f5219df8181821b4d758f9@wordpress.org> Message-ID: <068.96d5f4203a56e249fd45281800c24b6b@wordpress.org> #55189: Automatic removal of "Zero-width non-joiner" in URL --------------------------+--------------------- Reporter: man4toman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Permalinks | Version: 5.9 Severity: critical | Resolution: Keywords: 2nd-opinion | Focuses: --------------------------+--------------------- Comment (by SergeyBiryukov): Replying to [comment:5 ironprogrammer]: > Also, apart from the [important] redirect concern, is there a concern about how this change to slugs may impact the "meaning" of paths in URLs? How important is it that the intended word(s) be maintained in the slug? [https://www.searchenginejournal.com/technical-seo/url-structure/ It's suggested that keywords in URLs these days don't impact SERPs], but that doesn't mean the words in paths should be inaccurate. Good point, we might need to check the locale and keep the character in certain locales if it changes the meaning of a post slug. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 01:11:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 01:11:03 -0000 Subject: [wp-trac] [WordPress Trac] #30580: wp_extract_urls not returning full URL with & query separator In-Reply-To: <051.51c6e567e72b36f7a4c97869788883ee@wordpress.org> References: <051.51c6e567e72b36f7a4c97869788883ee@wordpress.org> Message-ID: <066.ffc02109a3f0554262110253421a44a4@wordpress.org> #30580: wp_extract_urls not returning full URL with & query separator ----------------------------------------------------+--------------------- Reporter: trex005 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Component: Formatting | Version: 3.7 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-testing | Focuses: ----------------------------------------------------+--------------------- Changes (by ironprogrammer): * keywords: has-patch has-unit-tests => has-patch has-unit-tests needs- testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 01:17:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 01:17:12 -0000 Subject: [wp-trac] [WordPress Trac] #53218: Make apply_filters() variadic In-Reply-To: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> References: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> Message-ID: <070.a615b8c49908c7b23192c0fb75a78e53@wordpress.org> #53218: Make apply_filters() variadic ------------------------------------------+--------------------- Reporter: johnbillion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.3 Severity: normal | Resolution: Keywords: has-patch early dev-feedback | Focuses: ------------------------------------------+--------------------- Changes (by johnbillion): * keywords: has-patch early => has-patch early dev-feedback Comment: I'd like to get this in. Any objections? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 01:23:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 01:23:28 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure Message-ID: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure ---------------------------+----------------------------- Reporter: bertvandepoel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: Focuses: ui | ---------------------------+----------------------------- I'm a member of a student organisation offering hosting to other student organisations at a Belgian university. Thanks to WordPress, organisation with a complete lack of technical ability are able to maintain a website, largely through enabling automatic updates of WordPress, its plugins and its themes. I understand it's a conscious choice of WordPress to add a theme every year through its releases. While I'm personally not a huge fan of these themes being added, I understand there isn't much we can do about that. However, many of our organisations assume that once they have enabled auto-updates, they're largely safe from maintenance issues. This isn't the case however since our a twentytwentytwo has only been installed a few months ago and very recently received its first update. There doesn't seem to be a global setting to enable all auto-updates or auto-updating for all themes anywhere in the web interface of WordPress. This will mean that we will have to email each organisation to try to explain what they have to do and how. This seems contradictory to the idea of WordPress being very user-friendly even for those with little technical skills. I would therefore either recommend a global setting concerning auto- updates, or ending the practise of adding a new theme every year without user consent. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 02:54:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 02:54:39 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure In-Reply-To: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> References: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> Message-ID: <072.5ba1e81acb597a8e26056b9abccfdf59@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure -------------------------------+------------------------------ Reporter: bertvandepoel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+------------------------------ Changes (by costdev): * keywords: => reporter-feedback * type: defect (bug) => enhancement Comment: Hi @bertvandepoel, welcome to Trac! There are numerous plugins to enable automatic updates. However, these tend to offer additional options that you may simply not need. You can alternatively save this code to a file called `enable-automatic- updates.php`, ZIP it and distribute it to the other organisations to install via the `Plugins > Add New > Upload`. {{{#!php '; $notice .= "

AUTOMATIC_UPDATER_DISABLED is set and can't be overridden. Please delete the line from wp- config.php.

"; $notice .= ''; echo $notice; } ); } else { add_filter( 'auto_update_theme', '__return_true' ); } }}} However, you can also simply disable the installation of themes bundled in upgrades if that is your preference. Add this to `wp-config.php`: {{{#!php define( 'CORE_UPGRADE_SKIP_NEW_BUNDLED', true ); }}} Or create a plugin like the above if you want it to be easier for the organisations to make the change themselves. Note: If adding to a plugin, use: {{{#!php if ( ! defined( 'CORE_UPGRADE_SKIP_NEW_BUNDLED' ) ) { define( 'CORE_UPGRADE_SKIP_NEW_BUNDLED', true ); } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 05:36:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 05:36:31 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.04745d5273e27932755018d0f9c7568c@wordpress.org> #55230: Release 5.9.1 breaks administration login. ------------------------------------+----------------------------- Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Login and Registration | Version: 5.9.1 Severity: blocker | Resolution: Keywords: needs-patch | Focuses: administration ------------------------------------+----------------------------- Comment (by kapilpaul): Could not reproduced it. Please share the reproduce steps as @SergeyBiryukov mentioned. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 08:30:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 08:30:14 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' Message-ID: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' ----------------------------+-------------------------------------- Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Keywords: dev-feedback needs-patch Focuses: administration | ----------------------------+-------------------------------------- The Class WP-Post-List-Table has a method 'Column_Default' which contains a 'return' statement that prevents hooks from being fired like(hooks:- manage_pages_custom_column, manage_posts_custom_column, manage_{$post->post_type}_posts_custom_column). The return statement is on line number 1302, File-Name:- class-wp-posts-list-table.php. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 11:22:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 11:22:20 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.2ec750e7a064ef6e88990d4329430066@wordpress.org> #55230: Release 5.9.1 breaks administration login. -------------------------------------------+----------------------------- Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Login and Registration | Version: 5.9.1 Severity: blocker | Resolution: Keywords: needs-patch reporter-feedback | Focuses: administration -------------------------------------------+----------------------------- Changes (by SergeyBiryukov): * keywords: needs-patch => needs-patch reporter-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 12:05:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 12:05:20 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.ce905b92b0691eb0c6ae5ce497205cb3@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: major | Resolution: Keywords: needs-testing | Focuses: ---------------------------------+------------------------------ Changes (by costdev): * keywords: => needs-testing Comment: Thanks very much for this additional information @simobenedettidesign! I was unable to reproduce the issue on 5.9.1 with a bundled theme and a gallery block. Does the issue occur for newly inserted Gallery blocks, or only those that existed prior to upgrading to 5.9? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 13:42:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 13:42:18 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' In-Reply-To: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> References: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> Message-ID: <064.dead04a6b2bc9617c2baafd25fcf3fb5@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' --------------------------------------+------------------------------ Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 3.5 Severity: normal | Resolution: Keywords: dev-feedback needs-patch | Focuses: administration --------------------------------------+------------------------------ Changes (by SergeyBiryukov): * version: 5.9.1 => 3.5 * component: Administration => Posts, Post Types Comment: Hi there, welcome back to WordPress Trac! Thanks for the report. For reference, the `return` statement was technically added in [32740] / #29881, but it replaced an earlier `break` statement added in [21788] / #21240, so WordPress 3.5 appears to be the earliest affected version here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 15:33:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 15:33:20 -0000 Subject: [wp-trac] [WordPress Trac] #55100: `get_queried_object()` doesn't work for `author_name` before `WP_Query::get_posts()` In-Reply-To: <048.4819f7a15a5e5209e8e95acef483b158@wordpress.org> References: <048.4819f7a15a5e5209e8e95acef483b158@wordpress.org> Message-ID: <063.8abe60fa48f13f428cefffa742f235dc@wordpress.org> #55100: `get_queried_object()` doesn't work for `author_name` before `WP_Query::get_posts()` --------------------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Query | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52822" 52822]: {{{ #!CommitTicketReference repository="" revision="52822" Query: Make sure `WP_Query::get_queried_object()` works for `author_name` before `::get_posts()` is run. Previously, the queried object with author data was not available before the posts loop when `author_name` is used in the query instead of `author`. With block themes, this use case appears to be more common to display the author name in the header. This commit adjusts the logic in `WP_Query::get_queried_object()` to fall back to the `author_name` field if `author` is not present, similar to how taxonomy slugs are handled. Follow-up to [1728], [3290], [10992]. Props dd32, swissspidy, SergeyBiryukov. Fixes #55100. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 15:42:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 15:42:40 -0000 Subject: [wp-trac] [WordPress Trac] #55323: Ei buyog Message-ID: <052.b815ac36bddb316160dcf84a6ddafff3@wordpress.org> #55323: Ei buyog -------------------------------------------------+------------------------- Reporter: underwer | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: trunk Severity: normal | Keywords: reporter- Focuses: ui, css, docs, multisite, coding- | feedback standards | -------------------------------------------------+------------------------- bug tracker//https://org.com issue 1 2 3 imp: time running 01/05 enpt error 02/03/04 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 15:43:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 15:43:48 -0000 Subject: [wp-trac] [WordPress Trac] #55323: Ei buyog In-Reply-To: <052.b815ac36bddb316160dcf84a6ddafff3@wordpress.org> References: <052.b815ac36bddb316160dcf84a6ddafff3@wordpress.org> Message-ID: <067.7de1c933a55d890b778604c4de4c3374@wordpress.org> #55323: Ei buyog -------------------------------------+------------------------------------- Reporter: underwer | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: duplicate Keywords: reporter-feedback has- | Focuses: ui, css, docs, patch | multisite, coding-standards -------------------------------------+------------------------------------- Changes (by underwer): * keywords: reporter-feedback => reporter-feedback has-patch * status: new => closed * resolution: => duplicate Comment: Duplicate of #1. Replying to [ticket:55323 underwer]: > bug tracker//https://org.com > > issue > 1 > 2 > 3 > > imp: time running 01/05 > enpt error 02/03/04 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 16:46:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 16:46:43 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.849f9f95a49be316bdb6d013cc2259c1@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): No, FTP users have always been chrooted. Nothing changed there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 19:27:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 19:27:51 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.d0fca930a2e59dceeb402ea74a3ca266@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Changes (by costdev): * version: 5.9 => trunk Comment: Ok so we can be sure that it's not a 5.9 issue as the error occurs when upgrading from 5.7.5 to 5.8. Changing version to `trunk` for now while we determine if something needs to change in Core, your permissions, or if it's a Debian 11 issue. From [https://wordpress.org/support/article/changing-file-permissions/ Changing File Permissions]: > If WordPress is running as the FTP account, that account needs to have write access, i.e., be the owner of the files, or belong to a group that has write access. In the latter case, that would mean permissions are set more permissively than default (for example, 775 rather than 755 for folders, and 664 instead of 644). Let's see if the issue still occurs if you use 775 for folders and 664 for files: {{{#!bash cd /path/to/wordpress find . -type d -exec chmod 775 {} \; find . -type f -exec chmod 664 {} \; }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 19:35:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 19:35:52 -0000 Subject: [wp-trac] [WordPress Trac] #27111: Turning off global comments should include existing content In-Reply-To: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> References: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> Message-ID: <066.16b8cc9be97e7fc58e0e01b23a6e7694@wordpress.org> #27111: Turning off global comments should include existing content -------------------------+----------------------------- Reporter: jenmylo | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Component: Comments | Version: 3.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration -------------------------+----------------------------- Comment (by jb510): Two plugin solutions for disabling comments https://wordpress.org/plugins /disable-comments/ and https://wordpress.org/plugins/disable-comments-rb/ have been taken over by new developers and quickly turned into a bloated mess. Nobody needs a web app built into their dashboard just to "disable comments". Usually, these ancient tickets seem like a lost cause though. Is there any hope for a patch for this actually making its way into core at this point? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 20:09:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 20:09:31 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.4f0c1984fc598390f3c65bbcd6ce96d8@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Actually, I've done some testing and I now know exactly what is causing the problem. ftp_nlist() ''**always**'' returns false when the second parameter is a file instead of a directory on my system. {{{#!php }}} On my server, the output is: {{{ Connected. /. /.. /htdocs /cgi-bin /logs /ftptest.php Not found. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 20:29:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 20:29:26 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' In-Reply-To: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> References: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> Message-ID: <064.3f6dbe5dfd5050fe5b634db9ee5c6d16@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' --------------------------------------+------------------------------ Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 3.5 Severity: normal | Resolution: Keywords: dev-feedback needs-patch | Focuses: administration --------------------------------------+------------------------------ Comment (by joyously): The return isn't irrelevant. That if statement handles only taxonomy columns, and it runs the appropriate filter. The actions further down are for custom columns, which the taxonomy column is not, so they should not be run in that case. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 20:36:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 20:36:57 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.31e6d5e9171ae052343e74ee6f421aac@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by costdev): In `WP_Filesystem_FTPext::exists()`[https://developer.wordpress.org/reference/classes/wp_filesystem_ftpext/exists/ Docs], it calls `$list = ftp_nlist( $this->link, $file )`, which returns `false`. The result is checked against `empty( $list ) && $this->is_dir( $file )`, which passes the first condition and fails the second. Then the `WP_Filesystem_FTPext::exists()` returns `! empty( $list );`. `! false` === `true` === the file exists, so this shouldn't be causing the problem here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 20:46:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 20:46:16 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.c7e32465404d4c16b6e97436675b2af4@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by costdev): Does adding this before the call to `ftp_pasv()` change the result for you? {{{ ftp_set_option( $ftp, FTP_USEPASVADDRESS, false ); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 21:07:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 21:07:09 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.8590da92f6d6e4bbc59dd82b89d73ee7@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Replying to [comment:12 costdev]: > Does adding this before the call to `ftp_pasv()` change the result for you? > > {{{ > ftp_set_option( $ftp, FTP_USEPASVADDRESS, false ); > }}} No, ftp_nlist() (in **class-wp-filesystem-ftpext.php**) still returns false on a file. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Mar 5 22:27:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 05 Mar 2022 22:27:11 -0000 Subject: [wp-trac] [WordPress Trac] #55284: thumbnails issue In-Reply-To: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> References: <063.e399559b1f6ad4fa66f589f48f6f9bd1@wordpress.org> Message-ID: <078.25a790988b39b7a00a545b906425ac3f@wordpress.org> #55284: thumbnails issue ---------------------------------+------------------------------ Reporter: simobenedettidesign | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: major | Resolution: Keywords: needs-testing | Focuses: ---------------------------------+------------------------------ Comment (by simobenedettidesign): Replying to [comment:5 costdev]: > Thanks very much for this additional information @simobenedettidesign! > > I was unable to reproduce the issue on 5.9.1 with a bundled theme and a gallery block. > > Does the issue occur for newly inserted Gallery blocks, or only those that existed prior to upgrading to 5.9? It does not occur in old entries that have already been published prior to 5.9.1 upgrading. However, it occurs in old posts if I open them in the WP editor and click on 'post preview'. As for the new entries, it occurs in new posts both in preview mode and after their publication. That's weird but hope this helps! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 01:31:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 01:31:01 -0000 Subject: [wp-trac] [WordPress Trac] #55323: When an image is edited the URL of the image is not updated Message-ID: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> #55323: When an image is edited the URL of the image is not updated --------------------------------+----------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Keywords: Focuses: ui, administration | --------------------------------+----------------------------- When an image is edited from the image editor, after an edit has been applied, the URL of the image is not updated due it always references back to the original image instead of referencing the image to the updated image (when the edit has been applied to all images sizes). == Steps to replicate the problem. 1. Upload an image into the media library 2. After the image is uploaded into the media library click on Edit image 3. Apply an edit to the image, either rotate, flip or crop, 4. Make sure that the option is applied to all images sizes. 5. Click on Save 6. Observe how the URL of the image (see attached image), by clicking on Copy URL to the clipboard 7. Open the copied URL into a new tab the copied URL still references to the original image, and not the edited image instead. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 01:31:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 01:31:13 -0000 Subject: [wp-trac] [WordPress Trac] #55323: When an image is edited the URL of the image is not updated In-Reply-To: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> References: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> Message-ID: <065.df0d0d64a6f42c3af5ffe8e28e4d484a@wordpress.org> #55323: When an image is edited the URL of the image is not updated --------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ui, administration --------------------------+--------------------------------- Changes (by mitogh): * Attachment "2022-03-05_19-24.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 03:09:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 03:09:16 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' In-Reply-To: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> References: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> Message-ID: <064.bf36d2133dd9101e50dc6a4d209f3639@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' --------------------------------------+------------------------------ Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 3.5 Severity: normal | Resolution: Keywords: dev-feedback needs-patch | Focuses: administration --------------------------------------+------------------------------ Comment (by cu121): I see I was checking for taxonomy basically. I guess this ticket can be closed. Thank You For The Explaination -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 03:49:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 03:49:15 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' In-Reply-To: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> References: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> Message-ID: <064.27b82bfe8fd94134b19cb1039f336cb8@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' -------------------------------+----------------------------- Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 3.5 Severity: normal | Resolution: invalid Keywords: | Focuses: administration -------------------------------+----------------------------- Changes (by costdev): * keywords: dev-feedback needs-patch => * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Thanks for opening this ticket @cu121! As @joyously explained: - When the column is `categories`, `post_tags`, or starts with `taxonomy-`: - Handle the taxonomy and return. - Otherwise: - Run an appropriate action hook depending on whether the post type is hierarchical (yes = Pages hook, no = Posts hook). - Finally, run the action hook for the specific post type. I'll close this ticket as `invalid`, as the method returns at an appropriate time. Thanks to all for their insight on this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 03:51:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 03:51:27 -0000 Subject: [wp-trac] [WordPress Trac] #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' In-Reply-To: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> References: <049.d17a527bafb33c93e80ff7088b5d9c4f@wordpress.org> Message-ID: <064.13e340b1e0c0e101ec3b4dbdd50e9187@wordpress.org> #55322: The Class WP-Post List Table(Method - Column_Default) Contains Irrelevant Keyword 'return' -------------------------------+----------------------------- Reporter: cu121 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 3.5 Severity: normal | Resolution: invalid Keywords: | Focuses: administration -------------------------------+----------------------------- Comment (by cu121): @costdev thank you so much for the explanation :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 08:56:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 08:56:27 -0000 Subject: [wp-trac] [WordPress Trac] #55324: Twenty Twenty: Scroll to top not working Message-ID: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> #55324: Twenty Twenty: Scroll to top not working ---------------------------+----------------------------- Reporter: Presskopp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- For whatever reason, in my installation the scroll to top arrow doesn't work. I changed {{{#!php }}} to {{{#!php }}} and it was working again. Maybe worth patching? Another alternative would be {{{#!php }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 11:01:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 11:01:45 -0000 Subject: [wp-trac] [WordPress Trac] #10886: WordPress should not unnecessarily query posts at page load In-Reply-To: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> References: <053.931185c546a0edbf3024f49b87a08e43@wordpress.org> Message-ID: <068.b98c9be4365e9c7a1a27899bbc3867aa@wordpress.org> #10886: WordPress should not unnecessarily query posts at page load -------------------------------------------------+------------------------- Reporter: junsuijin | Owner: | spacedmonkey Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Bootstrap/Load | Version: 2.8.4 Severity: normal | Resolution: fixed Keywords: has-unit-tests early has-patch | Focuses: needs-dev-note | performance -------------------------------------------------+------------------------- Comment (by lkraav): Was there also some commit in core that demonstrates using `$parsed`? For example, to optimize the infamous [https://twitter.com/kovshenin/status/1466732748517822464?ref_src=twsrc%5Etfw robots.txt loading process], or something else? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 12:04:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 12:04:34 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.465b32a06366b25dec49d0e5506ff667@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Ok, it turns out to be a "problem" with the new version of Pure-FTPd that was installed with Debian 11. It installs v1.0.49 (previously installed version was v1.0.47) and according to their changelog [https://www.pureftpd.org/project/pure-ftpd/news/#version-1048-released here], globbing was removed from the NLST command in v1.0.48 (which makes sense since it's actually not allowed according to the RFC). So it's weird that this problem hasn't been reported numerous times before since everybody who uses the FTP method to update and also uses Pure- FTPd,will have this problem... The only solution is a rewrite of the code in class-wp-filesystem- ftpext.php, or switching to the direct method of updating. Which sucks because that opens a whole can of worms of secutiry issues. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 12:46:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 12:46:03 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.a990a18f0ef806a75f95e396463c9b40@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by ocean90): Replying to [comment:14 zippy1970]: > So it's weird that this problem hasn't been reported numerous times before since everybody who uses the FTP method to update and also uses Pure-FTPd, will have this problem... Sounds like we already have report for it in #51170. Can you confirm? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 12:47:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 12:47:26 -0000 Subject: [wp-trac] [WordPress Trac] #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 In-Reply-To: <053.464f3453501834c73527d32600b297e3@wordpress.org> References: <053.464f3453501834c73527d32600b297e3@wordpress.org> Message-ID: <068.cb8c54c8af2cf89c7e06df8e95f31712@wordpress.org> #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 --------------------------------------+----------------------------- Reporter: javorszky | Owner: johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: Future Release Component: Database | Version: Severity: major | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+----------------------------- Comment (by misterwebdeveloper): Hi, Experienced software developer of 20 years here. I just want to start by saying MySQL is a crazy good open source platform and kudos to everyone involved building it. Sorry if I'm posting this in the wrong place... Let me play devil's advocate. As far as I can see the recommendation is to break DRY and duplicate SELECT statements. Presumably this feature was orignally added to prevent that. The MYSQL recommendation: duplicate the original query. So a SQL statement using SQL_CALC_FOUND_ROWS is 150 lines, most of those lines should be duplicated? This isn't a pragmatic solution. What if an existing system is using 50k lines? Is there something I'm missing here? Another suggestion is to rewrite systems to use lazy loading. Not all systems are lazily loaded social media platforms. Pagination still has it's place and isn't going anywhere long term. Is it possible to fix/improve the performance issues in this feature? How about MySQL re-runs the proc in the background without the LIMIT code when it encounters SQL_CALC_FOUND_ROWS? That way there the dev doesn't need to duplicate the code. My regards -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 13:06:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 13:06:43 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.5cdeeb6453108b1f0b41ebf6eb7356bf@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): In **class-wp-filesystem-ftpext.php** I replaced the ''exists()'' function with my own version (below) and the update succeeded without a hitch. {{{#!php link, $file ); if( ! empty( $list ) ) { // if ftp_nlist returns *something*, the file or directory exists, on any FTP server $retval = true; } else { // if ftp_nlist returns nothing, either the file/dir doesn't exist or it's a file and // the FTP server's NLST command doesn't support globbing (i.e. Pure-FTPD > v1.0.47) // Check if it'a file if( ftp_size( $this->link, $file ) >= 0 ) { $retval = true; } } return $retval; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 13:27:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 13:27:29 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.dc3ec6592cab5f0db2a4bb89c9967b9e@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: trunk Severity: major | Resolution: Keywords: needs-testing | Focuses: -----------------------------+------------------------------ Comment (by zippy1970): Replying to [comment:15 ocean90]: > Sounds like we already have report for it in #51170. Can you confirm? Yes, that's it. If they would have made a comment that this causes updates to fail, that would have saved me a lot of trouble. :) Apparently they changed the exists() function in the exact same way I did. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 14:41:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 14:41:24 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.601e2cdd95f0765ddd96c78a59861b78@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: trunk Severity: major | Resolution: duplicate Keywords: needs-testing | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Thanks for the confirmation! Let's continue in #51170 then, as it already has a patch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 14:42:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 14:42:01 -0000 Subject: [wp-trac] [WordPress Trac] #51170: FTP automatic updates are not RFC 959 compliant for NLST command In-Reply-To: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> References: <051.09b6bf2c60c82933c8667a9375698057@wordpress.org> Message-ID: <066.f80bcec89ce4624cb5f67b8708ef6e67@wordpress.org> #51170: FTP automatic updates are not RFC 959 compliant for NLST command -------------------------------------------------+------------------------- Reporter: giox069 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Filesystem API | Version: 3.7 Severity: normal | Resolution: Keywords: reporter-feedback dev-feedback has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 14:48:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 14:48:36 -0000 Subject: [wp-trac] [WordPress Trac] #55307: After upgrading Debian, WordPress sites no longer update through FTP In-Reply-To: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> References: <053.758b8f5288fccbf09c38e68a6aafd535@wordpress.org> Message-ID: <068.8e43d6b43484284dd2094c66e002026d@wordpress.org> #55307: After upgrading Debian, WordPress sites no longer update through FTP -----------------------------+------------------------ Reporter: zippy1970 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: trunk Severity: major | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by costdev): * keywords: needs-testing => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 15:13:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 15:13:39 -0000 Subject: [wp-trac] [WordPress Trac] #55325: Theme Editor: Add file description for theme.json Message-ID: <051.9b415a9f143e2ed1e9bda377b1fab3ad@wordpress.org> #55325: Theme Editor: Add file description for theme.json ----------------------------+---------------------------------------- Reporter: ocean90 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Themes | Version: Severity: normal | Keywords: needs-patch good-first-bug Focuses: administration | ----------------------------+---------------------------------------- It would be nice to show a description for `theme.json` in the theme editor instead of only `theme.json`. The current list of file descriptions: https://core.trac.wordpress.org/browser/tags/5.9.1/src/wp- admin/includes/file.php?marks=14-65#L14 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 15:14:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 15:14:38 -0000 Subject: [wp-trac] [WordPress Trac] #55325: Theme Editor: Add file description for theme.json In-Reply-To: <051.9b415a9f143e2ed1e9bda377b1fab3ad@wordpress.org> References: <051.9b415a9f143e2ed1e9bda377b1fab3ad@wordpress.org> Message-ID: <066.fc5bc4afae1bd851ff49f15a917fa07d@wordpress.org> #55325: Theme Editor: Add file description for theme.json ----------------------------------------+----------------------------- Reporter: ocean90 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch good-first-bug | Focuses: administration ----------------------------------------+----------------------------- Changes (by ocean90): * Attachment "55325.png" added. File tree of Twenty Twenty-Two -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 16:08:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 16:08:05 -0000 Subject: [wp-trac] [WordPress Trac] #54164: Consistently fire user role hooks In-Reply-To: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> References: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> Message-ID: <063.bab5f04fae8580621208190b89b9b033@wordpress.org> #54164: Consistently fire user role hooks -------------------------+--------------------- Reporter: dd32 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: 4.3 Severity: normal | Resolution: Keywords: has-patch | Focuses: -------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 16:09:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 16:09:21 -0000 Subject: [wp-trac] [WordPress Trac] #54164: Consistently fire user role hooks In-Reply-To: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> References: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> Message-ID: <063.5b3f68d298ef558664a0b495bd902883@wordpress.org> #54164: Consistently fire user role hooks -------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.3 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: -------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52823" 52823]: {{{ #!CommitTicketReference repository="" revision="52823" Users: Bring some consistency to user role hooks. This standardizes the actions that one needs to hook to for tracking user role changes: * `add_user_role` is only fired when the user has actually gained a new role. * `remove_user_role` is only fired when the role was actually removed. Both actions are now fired in `WP_User::set_role()` as appropriate. Props dd32, SergeyBiryukov. Fixes #54164. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 16:37:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 16:37:00 -0000 Subject: [wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates In-Reply-To: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> References: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> Message-ID: <065.249079fd3411b1b17575fabfcd8e20dd@wordpress.org> #51857: Add rollback for failed plugin/theme updates -------------------------------------------------+------------------------- Reporter: pbiron | Owner: pbiron Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: early has-testing-info needs-unit- | Focuses: tests needs-testing has-patch | -------------------------------------------------+------------------------- Changes (by pbiron): * Attachment "pr-2225.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 16:41:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 16:41:29 -0000 Subject: [wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates In-Reply-To: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> References: <050.28fc9181b285acd253041ad0e732946d@wordpress.org> Message-ID: <065.bb5ce9185082212e36e4c2a794024d0a@wordpress.org> #51857: Add rollback for failed plugin/theme updates -------------------------------------------------+------------------------- Reporter: pbiron | Owner: pbiron Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: early has-testing-info needs-unit- | Focuses: tests needs-testing has-patch | -------------------------------------------------+------------------------- Comment (by pbiron): For some reason, I'm not able to push changes to the [https://github.com/WordPress/wordpress- develop/pull/2225#issuecomment-1027369433 latest PR] (get a "permission denied" error). So, I'm uploading them here as patch. Could @afragen or @SergeyBiryukov please update the PR accordingly. The patch doesn't change the rollback functionality, it just fixes some things with the changes to `site health` in the PR: 1. fixes minor HTML errors in 2 of the new site health tests 2. adds `WP_RUNTIME_ENVIRONMENT` to the `WordPress Constants` section of the site health `debug data` screen -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 17:10:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 17:10:05 -0000 Subject: [wp-trac] [WordPress Trac] #55276: :where is easily being overridden In-Reply-To: <056.93699acdb4e9548e4b4c0571a260c817@wordpress.org> References: <056.93699acdb4e9548e4b4c0571a260c817@wordpress.org> Message-ID: <071.3420298efda4437be32699d4a9be837b@wordpress.org> #55276: :where is easily being overridden --------------------------+------------------------------ Reporter: vijayhardaha | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Resolution: worksforme Keywords: | Focuses: css --------------------------+------------------------------ Changes (by vijayhardaha): * status: new => closed * resolution: => worksforme -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 18:01:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 18:01:43 -0000 Subject: [wp-trac] [WordPress Trac] #55326: Conditional classes directives in formatting Message-ID: <056.5d933fd28bb30679974960b53abccade@wordpress.org> #55326: Conditional classes directives in formatting ------------------------------+----------------------------- Reporter: vijayhardaha | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.1 Severity: normal | Keywords: Focuses: coding-standards | ------------------------------+----------------------------- Hey people, I am here with a suggestion and core feature request for conditional classes directive for HTML class attribute. Similar to [Laraval conditional-classes](https://laravel.com/docs/9.x/blade#conditional- classes) If this function is already available in WP then please let me know about it, I wasn't able to find a similar function. There are many cases in development where we're creating a `$clasess` array variable and then with if-else or using conditional statements adding classes into it. While working with PHP code the code/file format in files look good and it's easy to manage but sometimes with HTML and PHP combination writing inline if-else make the code/file format ugly. and we also have to repeat the escape and echo things again n again if we have a couple of conditional CSS to write. I have created this custom code to use in my custom development, which allows passing set or array or single sting or strings with comma/space and then it conditional validate and output the string. {{{#!php $class_name ) { // Check if array has integer key, which means no conditions // are set for this class, if class is not empty then keep it. if ( is_int( $key ) && is_string( $class_name ) && ! empty( $class_name ) ) { $class_set[] = trim( $class_name ); } elseif ( ! empty( $class_name ) && ! empty( $key ) ) { $class_set[] = trim( $key ); } } /** * Filter array with empty values. * Make array unique. * Sanitize class name. * Implode by space. */ $output = implode( ' ', array_map( 'sanitize_html_class', array_unique( array_filter( $class_set ) ) ) ); } } if ( $echo ) { echo esc_attr( $output ); } else { return esc_attr( $output ); } } }}} so using this function we could save time to not write a few lines of if- else and keep the code look clean and simple as well, e.g. {{{#!php '; }}} this will convert into this. {{{#!php has_post_thumbnail(), 'is-featured' => has_term( 'featured', 'category' ), ), ); echo '
; // false is for returning the values. }}} however, it does not save too many lines but we are repeating things less and I feel it looks clean in code reading. :) But this function can be very useful while writing mixed HTML and php. {{{#!php ">
}}} {{{#!php is_sidebar_active( 'right-sidebar' ) && is_sidebar_active( 'righleft-sidebar' ), 'col-md-8' => ! is_sidebar_active( 'right-sidebar' ) && is_sidebar_active( 'righleft-sidebar' ), 'col-md-8 md-offset-4' => is_sidebar_active( 'right-sidebar' ) && ! is_sidebar_active( 'righleft-sidebar' ), 'col-md-8 md-offset-2' => ! ( is_sidebar_active( 'right-sidebar' ) && is_sidebar_active( 'righleft-sidebar' ) ), ); ?>
}}} Please let me know what you people think about having a directive function for classes. Thanks, -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 18:09:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 18:09:40 -0000 Subject: [wp-trac] [WordPress Trac] #55230: Release 5.9.1 breaks administration login. In-Reply-To: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> References: <057.1670da42e118d9d1a8fcb4ffc1415dc9@wordpress.org> Message-ID: <072.ec284cb78c4350f637c87c74eb920d92@wordpress.org> #55230: Release 5.9.1 breaks administration login. -------------------------------------------+----------------------------- Reporter: carlduranleau | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Login and Registration | Version: 5.9.1 Severity: blocker | Resolution: Keywords: needs-patch reporter-feedback | Focuses: administration -------------------------------------------+----------------------------- Comment (by carlduranleau): To reproduce this error, I only had to access the admin login page: /wp- login.php. With the DEBUG flag set, I had many warnings showing at he top of the login page. All warnings were the same: "Cannot modify header information – headers already sent by...". Even if I was able to enter my username and password, the login button was always returning me back to the same page. Maybe I should have added my configuration in the ticket. Our website is using Corpera 1.0.2 theme with these plugins: - Elementor 3.1.1 - LiteSpeed Cache 4.4.1 - WP Google Maps 8.1.11 - Wpazure Kit 1.1.2 - WPForms Lite 1.6.7 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 19:37:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 19:37:25 -0000 Subject: [wp-trac] [WordPress Trac] #54164: Consistently fire user role hooks In-Reply-To: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> References: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> Message-ID: <063.6d39523376cf97f3ddd30565e7a39825@wordpress.org> #54164: Consistently fire user role hooks -------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.3 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: -------------------------+----------------------------- Comment (by azouamauriac): Replying to [comment:2 SergeyBiryukov]: > In [changeset:"52823" 52823] Hi can we merge these two if controle [https://prnt.sc/VLGhGiND77NH] ? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 19:47:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 19:47:06 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.c0733c4ce7538e3b54bc2f532cee6528@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: docs ----------------------------+--------------------- Changes (by azouamauriac): * Attachment "54729.diff" added. in src/wp-includes/class-wp-user.php use third person in function docblock -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 22:35:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 22:35:52 -0000 Subject: [wp-trac] [WordPress Trac] #54164: Consistently fire user role hooks In-Reply-To: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> References: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> Message-ID: <063.cb85ed367cec8b340ccf3ed4bd3fd64c@wordpress.org> #54164: Consistently fire user role hooks -------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Users | Version: 4.3 Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+----------------------------- Changes (by peterwilsoncc): * keywords: has-patch => needs-patch * status: closed => reopened * resolution: fixed => Comment: Reopening as the Multisite [https://github.com/WordPress/wordpress- develop/actions?query=branch%3Atrunk tests started failing] following this commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 23:02:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 23:02:26 -0000 Subject: [wp-trac] [WordPress Trac] #54164: Consistently fire user role hooks In-Reply-To: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> References: <048.73bcce5eb7d3a2a2a40d4e1f3a611ec4@wordpress.org> Message-ID: <063.3a9b028e9342aaa416f15465e775d9c4@wordpress.org> #54164: Consistently fire user role hooks -------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Users | Version: 4.3 Severity: normal | Resolution: fixed Keywords: needs-patch | Focuses: -------------------------+----------------------------- Changes (by SergeyBiryukov): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"52824" 52824]: {{{ #!CommitTicketReference repository="" revision="52824" Tests: Restore the original user role in the `(add|remove)_user_role` hooks test. This makes sure the test does not unintentionally affect other tests. Follow-up to [52823]. Fixes #54164. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Mar 6 23:18:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 06 Mar 2022 23:18:12 -0000 Subject: [wp-trac] [WordPress Trac] #27111: Turning off global comments should include existing content In-Reply-To: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> References: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> Message-ID: <066.b28700e641906d96a6939473e441379e@wordpress.org> #27111: Turning off global comments should include existing content -------------------------+----------------------------- Reporter: jenmylo | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Comments | Version: 3.9 Severity: normal | Resolution: wontfix Keywords: has-patch | Focuses: administration -------------------------+----------------------------- Changes (by peterwilsoncc): * status: new => closed * resolution: => wontfix Comment: Replying to [comment:31 jb510]: > [snip] > Usually, these ancient tickets seem like a lost cause though. Is there any hope for a patch for this actually making its way into core at this point? Honestly, I think it unlikely. My view is that the option is fairly clear that the setting is the default for new posts. Changing how the option works to apply to all posts would break backward compatibility and become problematic for sites deliberately choosing to enable comments on some posts. My specific thought is news-type sites which enable comments on analysis articles but not general news articles. Adding an additional "all posts" option seems unhelpful for a couple of lines of code. I'll see if I can get [https://github.com/peterwilsoncc /rapid-disable-comments this in the repo] to leave neglected and forget to update the supported version for. ;) I'm going to close this as ''wontfix'' to match the reality given there has been no movement for seven years. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 00:15:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 00:15:01 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.be54953863f8fc22c5afbcaec0be6cbc@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-testing | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-dev-note => has-patch has-unit- tests needs-dev-note needs-testing Comment: Replying to [comment:29 spacedmonkey]: > Thanks @peterwilsoncc . It is was a good spot. I have refactor the patch to remove usage of `get_term` and now everything uses `get_terms`. Unit tests are passing now Thanks, both for the updated code and taking my push of a broken test to your branch in the spirit intended. The code looks good to me, I've added the needs-testing keyword on this in the hope some of the testing folk can take a look at your branch before committing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 00:51:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 00:51:26 -0000 Subject: [wp-trac] [WordPress Trac] #27111: Turning off global comments should include existing content In-Reply-To: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> References: <051.58cfc992f6ca783003cd41478fc733ed@wordpress.org> Message-ID: <066.a31b98ae6ec408a61695f41c6d5bff32@wordpress.org> #27111: Turning off global comments should include existing content -------------------------+----------------------------- Reporter: jenmylo | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Comments | Version: 3.9 Severity: normal | Resolution: wontfix Keywords: has-patch | Focuses: administration -------------------------+----------------------------- Comment (by jb510): @peterwilsoncc this was marked a duplicate of https://core.trac.wordpress.org/ticket/32375 and https://core.trac.wordpress.org/ticket/53185 which is why I commented here. Although those tickets are a bit more clear about what I think is generally needed: A check box to disable all comment functionality sitewide. The point here is there ought to be a core method to completely disable comments on a site (brand new site or otherwise) and not rely on the increasingly spammy plugins to do so. The other tickets were a bit more clear about this need than this ticket. I think we all understand a huge number of sites these days have zero need for comments at all. This means no need to accept comment spam requests to the API, no need to count comments, no need really to load even 1 line of comment-related code or make queries looking for comments. On many sites, comments are more of an attractive nuisance than something anyone wants to manage. Or they're disabling WP comments in favor of sass solutions like Disqus. Comments were unquestionably a unique and huge benefit in the early blog- focused days of WordPress. They're not obsolete on all sites (like links became), just obsolete on a lot of sites. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 01:44:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 01:44:22 -0000 Subject: [wp-trac] [WordPress Trac] #55326: Conditional classes directives in formatting In-Reply-To: <056.5d933fd28bb30679974960b53abccade@wordpress.org> References: <056.5d933fd28bb30679974960b53abccade@wordpress.org> Message-ID: <071.3ed9b3317934fc5461280bd6233cb59f@wordpress.org> #55326: Conditional classes directives in formatting -----------------------------+------------------------------- Reporter: vijayhardaha | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: coding-standards -----------------------------+------------------------------- Comment (by SergeyBiryukov): Hi there, welcome back to WordPress Trac! Thanks for the ticket. Just linking to a related ticket here: #50867. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 01:45:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 01:45:17 -0000 Subject: [wp-trac] [WordPress Trac] #50867: An API which encourages automatic escaping of HTML In-Reply-To: <054.c2c4be12d3b282e664a3ec46964ce574@wordpress.org> References: <054.c2c4be12d3b282e664a3ec46964ce574@wordpress.org> Message-ID: <069.4c1535bd23d7e0469e93cf0f09746fda@wordpress.org> #50867: An API which encourages automatic escaping of HTML -------------------------------------------------+------------------------- Reporter: noisysocks | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: General | Version: Severity: normal | Resolution: Keywords: has-patch needs-unit-tests needs- | Focuses: docs dev-feedback 2nd-opinion | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Related: #55326 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 02:02:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 02:02:56 -0000 Subject: [wp-trac] [WordPress Trac] #55326: Conditional classes directives in formatting In-Reply-To: <056.5d933fd28bb30679974960b53abccade@wordpress.org> References: <056.5d933fd28bb30679974960b53abccade@wordpress.org> Message-ID: <071.9e604182741288790126975df46d04c3@wordpress.org> #55326: Conditional classes directives in formatting -----------------------------+------------------------------- Reporter: vijayhardaha | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: coding-standards -----------------------------+------------------------------- Comment (by vijayhardaha): Replying to [comment:1 SergeyBiryukov]: > Hi there, welcome back to WordPress Trac! Thanks for the ticket. > > Just linking to a related ticket here: #50867. Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 02:18:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 02:18:54 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.c0155bf59ef6661b1e1c7ecd13b78bfb@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: Keywords: good-first-bug has-testing-info | Focuses: has-patch commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-testing-info has-patch => good-first-bug has-testing-info has-patch commit Comment: Thanks @costdev and @Boniu91 > Since strpos() is case sensitive, it returns false Yes, indeed, excellent point. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 02:36:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 02:36:17 -0000 Subject: [wp-trac] [WordPress Trac] #55297: The $is_edge global returns false. In-Reply-To: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> References: <051.29214e1e9bc4c759af0f30a0367db32f@wordpress.org> Message-ID: <066.27a927e8d7bfb86bb99f6ed2f3578d9d@wordpress.org> #55297: The $is_edge global returns false. -------------------------------------------------+------------------------- Reporter: costdev | Owner: | peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: General | Version: trunk Severity: normal | Resolution: fixed Keywords: good-first-bug has-testing-info | Focuses: has-patch commit | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"52825" 52825]: {{{ #!CommitTicketReference repository="" revision="52825" General: Improve MS Edge user-agent sniff. Update the `$is_edge` global to be `true` if the browser's user-agent contains `Edg` rather than `Edge`. Microsoft have dropped an E from the UA string. Refer to [https://docs.microsoft.com/en-us/microsoft-edge/web-platform /user-agent-guidance#identifiers-for-microsoft-edge-on-various-platforms Microsoft's documentation on detecting edge]. Props costdev, abdullahramzan, mukesh27, Boniu91. Fixes #55297. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 04:11:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 04:11:52 -0000 Subject: [wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 Message-ID: <057.dcc49bb86c8fa8cf2894927282c1e076@wordpress.org> #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0 ----------------------------+-------------------- Reporter: peterwilsoncc | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Keywords: Focuses: | ----------------------------+-------------------- Follow up to #51553, quoted in full below: > PHP 8.0 introduces the ability to pass named parameters to function calls. > Ref: https://wiki.php.net/rfc/named_params > > Code example: > {{{#!php > // Using positional arguments: > array_fill(0, 100, 50); > > // Using named arguments: > array_fill(start_index: 0, num: 100, value: 50); > > // Named arguments do not have to follow the same order as positional arguments: > array_fill(value: 50, num: 100, start_index: 0); > }}} > > **More than anything, this means that, as of PHP 8.0, renaming a parameter in a function declaration is a backward-compatibility break! ** > > This should most definitely get prominent mention in the PHP8 dev-note as a lot of Core/plugin/theme developers will not be aware of this at this time. > > > I'm opening this ticket to address a number of issues this brings up for WordPress Core. > > I've so far identified three tasks which should be executed ASAP to prepare for named parameters in function calls. > > == Task 1: Review Function Signatures of methods in child classes > > Methods in child classes may use different parameter names than those used for the same method by its parent. Similarly, classes implementing an interface do not have to use the same parameter names. > > While this does not change in PHP 8, it could create problems when the method is called using named parameters. > > To quote from [https://wiki.php.net/rfc/named_params#parameter_name_changes_during_inheritance the RFC]: > > > If an inheriting class changes a parameter name, calls using named arguments might fail, thus violating the Liskov substitution principle (LSP). > > > PHP will silently accept parameter name changes during inheritance, which may result in call-time exceptions when methods with renamed parameters are called > > Code sample: > {{{#!php > interface I { > public function test($foo, $bar); > } > > class C implements I { > public function test($a, $b) {} > } > > $obj = new C; > > // Pass params according to I::test() contract > $obj->test(foo: "foo", bar: "bar"); // ERROR! > }}} > > > **Note: For variadic functions this will not cause an error, but will move the unrecognized names to be part of the variadic argument, which can cause all sorts of problems.** > Code sample [https://twitter.com/giveupalready/status/1312139952776306688 courtesy of Chris Riley] illustrating the problem: https://3v4l.org/MhJ79 > > With regards to WordPress, I'd like to propose making the parameter names in child classes/classes implementing an interface consistent to prevent such issues. > > > > > == Task 2: Review Other Function Signatures > > 1. The function signatures of existing functions and methods of all WordPress code should be examined and non-descriptive parameter names should be fixed (renamed) **NOW** as later will no longer be an option without creating a BC-break. > 2. While using reserved keywords as parameter name labels is allowed, in the context of function calls using named parameters, this will easily lead to confusion. I'd like to recommend to rename function parameters which use reserved keywords to remove this confusion. > {{{#!php > function array_foobar($toggle = false, $array = []) {} > > array_foobar(array: $value); > }}} > > > == Task 3: Review all uses of `call_user_func_array()` > > Named parameters cause a BC-break for `call_user_func_array()` when passing an associative array. > In previous PHP versions, the array keys would have been ignored. In PHP 8, string keys will be interpreted as parameter name labels. > > For more detail, see: https://wiki.php.net/rfc/named_params#call_user_func_and_friends > > Basically, we need to make sure that any array passed to `call_user_func_array()` does NOT have string keys. If it does or if the format of the array is unknown (like when it is passed in via a function parameter), we need to add extra safeguards to make the code cross-version compatible. > A typical way to do this would be to use `array_values()` on the array before passing it to `call_user_func_array()`, though beware that ''**will**'' break code written for PHP 8 which actually expects the label to be used. > > > > > > > == Other references: > > * https://twitter.com/CiaranMcNulty/status/1312087225857970182 > > > Related Trac tickets: #50913, #50531 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 04:13:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 04:13:06 -0000 Subject: [wp-trac] [WordPress Trac] #51553: PHP 8.0: code improvements to allow for named parameters in function calls In-Reply-To: <047.9c6819ebb0901d74d5899f7d01667014@wordpress.org> References: <047.9c6819ebb0901d74d5899f7d01667014@wordpress.org> Message-ID: <062.c066160c6ff3e43401ddb79a4542f607@wordpress.org> #51553: PHP 8.0: code improvements to allow for named parameters in function calls -------------------------------------------------+------------------------- Reporter: jrf | Owner: | hellofromTonya Type: task (blessed) | Status: closed Priority: normal | Milestone: 5.9 Component: General | Version: Severity: normal | Resolution: fixed Keywords: php8 needs-codex early needs-dev- | Focuses: coding- note needs-patch | standards -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * status: reviewing => closed * resolution: => fixed * milestone: 6.0 => 5.9 Comment: There were a bunch of commits made to this ticket in the 5.9 milestone. So the commits don't get misplaced during `git bisect/blame` excursions I'm going to move this ticket back to 5.9, close it and create a follow up ticket. For the follow up work in WP 6.0, please refer to #55327. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 10:17:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 10:17:07 -0000 Subject: [wp-trac] [WordPress Trac] #55328: Vepament Message-ID: <054.695f3ec1e10e8bc0c353b7f85e6717e6@wordpress.org> #55328: Vepament ------------------------------------+----------------------------- Reporter: mahdi10458 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Keywords: needs-refresh Focuses: accessibility | ------------------------------------+----------------------------- موقع ثبت نام با اشکال مهم روبرو میشم -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 12:34:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 12:34:54 -0000 Subject: [wp-trac] [WordPress Trac] #55328: PHP warning on rename() inside download_url() in /wp-admin/includes/file.php Message-ID: <049.27f741c9d9e05d7605195a9120b52d68@wordpress.org> #55328: PHP warning on rename() inside download_url() in /wp- admin/includes/file.php ----------------------------+----------------------------- Reporter: devbd | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Filesystem API | Version: 5.9 Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- Hi, I struggle with the following warning on my WordPress site (version 5.9.0 and currently 5.9.1) whenever I update the plugins: {{{ PHP Warning: rename(/tmp/plugin-name.tmp,plugin-name.plugin-version.zip): Permission denied in /wp-admin/includes/file.php on line 1201, referer: siteURL/wp-admin/plugins.php }}} The warning is triggered by rename() function inside download_url()in /wp- admin/includes/file.php on line 1201. It's been logged on the site since support for Content-Disposition filename was added in WP 5.9: developer.wordpress.org/reference/functions/download_url/ The warning is also getting logged in WP 5.9.1. My site uses ftpext filesystem and I believe this is why 'permission denied' warning is triggered. The plugins update successfully, with no other issues, however, the above warning is logged every single time. Would it be possible to exclude Content-Disposition filename support if website uses ftpext filesystem method? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 12:39:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 12:39:22 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.cbd59944caf9b7c81221a234fb750010@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): Thanks @azouamauriac, I'll commit this patch right now 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 12:56:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 12:56:12 -0000 Subject: [wp-trac] [WordPress Trac] #54673: Improve formatting in `/wp-admin/user-edit.php`. In-Reply-To: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> References: <051.47d1f662ecfd8b9a5732f68c3237f001@wordpress.org> Message-ID: <066.1a3e80c22be68491c95f17c159f73cad@wordpress.org> #54673: Improve formatting in `/wp-admin/user-edit.php`. ------------------------------------+------------------------------- Reporter: costdev | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Administration | Version: 5.9 Severity: normal | Resolution: fixed Keywords: has-patch early commit | Focuses: coding-standards ------------------------------------+------------------------------- Comment (by audrasjb): In [changeset:"52826" 52826]: {{{ #!CommitTicketReference repository="" revision="52826" Docs: Correct the indentation in `delete_term_relationships` filter. See #54673. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 13:06:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 13:06:07 -0000 Subject: [wp-trac] [WordPress Trac] #54729: Docblock improvements for WP 6.0 In-Reply-To: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> References: <058.e97648b36f9e1c40d59d78da529f4b69@wordpress.org> Message-ID: <073.ed07e25481c77994b5b4efba58a827a6@wordpress.org> #54729: Docblock improvements for WP 6.0 ----------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: docs ----------------------------+--------------------- Comment (by audrasjb): In [changeset:"52827" 52827]: {{{ #!CommitTicketReference repository="" revision="52827" Docs: Use third-person singular verbs for function descriptions in `wp- includes/class-wp-user.php`. Props azouamauriac. See #54729. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 13:59:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 13:59:36 -0000 Subject: [wp-trac] [WordPress Trac] #55329: add_clean_index function throws PHP notice error Message-ID: <056.15bb84f0857f77dfff6c09fd584c15c1@wordpress.org> #55329: add_clean_index function throws PHP notice error -----------------------------+----------------------------- Reporter: gvgvgvijayan | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Keywords: Focuses: administration | -----------------------------+----------------------------- When I tried to add index for newly created column my error log filled with php notice 25 times because of the function `drop_index` which is called inside the function `add_clean_index`. Sample snippet: {{{#!php base_prefix . 'defender_lockout_log'; $column_name = 'country_iso_code'; $create_ddl = "ALTER TABLE {$table_name} ADD {$column_name} CHAR(2) DEFAULT NULL"; maybe_add_column( $table_name, $column_name, $create_ddl ); add_clean_index( $table_name, $column_name ); } }}} Error: {{{ [Mon Mar 07 18:45:40.809008 2022] [php:notice] [pid 1167] [client 127.0.0.1:48886] WordPress database error Can't DROP 'country_iso_code_1'; check that column/key exists for query ALTER TABLE `wp_defender_lockout_log` DROP INDEX `country_iso_code_1` made by require_once('wp-admin/network/admin.php'), require_once('wp- admin/admin.php'), require_once('wp-load.php'), require_once('wp- config.php'), require_once('wp-settings.php'), do_action('init'), WP_Hook->do_action, WP_Hook->apply_filters, WP_Defender\\Upgrader->run, WP_Defender\\Upgrader->upgrade_2_8_1, WP_Defender\\Upgrader->add_country_iso_code_column, add_clean_index, drop_index, referer: http://multi.test/wp-admin/network/update.php?action =upload-plugin&package=55&overwrite=update-plugin&_wpnonce=c8b371f5b8 }}} ---- Error log screenshot: [https://i.postimg.cc/2jqsb3Z4/bug-report.png] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:18:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:18:55 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.93418d3f56528ce1897ef36e02942a9b@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch dev-feedback has-unit- | Focuses: tests needs-testing | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch dev-feedback has-unit-tests => has-patch dev- feedback has-unit-tests needs-testing Comment: The above PR refreshes the last patch proposed by @johnbillion. Adding `needs-testing` keyword. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:36:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:36:00 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.f4aa5b9a51d39e15e7f6d99d234da41c@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch dev-feedback has-unit- | Focuses: tests needs-testing | -------------------------------------------------+------------------------- Comment (by audrasjb): > One test fails: http://example.mp3 incorrectly results in an extension of mp3, but this isn't strictly related to this change and AFAIK none of the extensions in wp_get_mime_types() are valid TLDs anyway. 👆 this is still an issue with the current PR. @johnbillion should we just remove the failing test? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:42:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:42:29 -0000 Subject: [wp-trac] [WordPress Trac] #43716: Not work "option_active_plugins" filter in front-end In-Reply-To: <054.1b96fa5f3f024717a48e63207d879f49@wordpress.org> References: <054.1b96fa5f3f024717a48e63207d879f49@wordpress.org> Message-ID: <069.6e0974d9a1871d1292256920397c7ff1@wordpress.org> #43716: Not work "option_active_plugins" filter in front-end -------------------------------+------------------------------ Reporter: hamedmoodi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 4.9.5 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by azouamauriac): * keywords: => reporter-feedback Comment: Hi there, welcome to WordPress Trac, thanks for the report! I'm not able to reproduce the issue, so can you provide more detail about how to reproduce it? Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:42:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:42:38 -0000 Subject: [wp-trac] [WordPress Trac] #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) In-Reply-To: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> References: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> Message-ID: <073.1fe273b7f35ad80e50c2275f9e96cfa3@wordpress.org> #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: dev-note needs-refresh needs-unit-tests | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * milestone: Future Release => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:43:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:43:04 -0000 Subject: [wp-trac] [WordPress Trac] #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) In-Reply-To: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> References: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> Message-ID: <073.c7a3f6925eaba42f43b5de9e19bccf6c@wordpress.org> #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has-patch needs- | Focuses: dev-note needs-refresh needs-unit-tests | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"52828" 52828]: {{{ #!CommitTicketReference repository="" revision="52828" Themes: Correct the logic for displaying a `_doing_it_wrong()` notice for `add_theme_support( 'html5' )`. * Calling `add_theme_support( 'html5' )` without passing an array of supported types should throw a `_doing_it_wrong()` notice: "You need to pass an array of types". * If the second parameter is not specified, it should fall back to an array of `comment-list`, `comment-form`, and `search-form` for backward compatibility. * If the second parameter is not an array, the function should return `false`. The latter two points are covered by existing unit tests. The first one is now addressed by `@expectedIncorrectUsage`. Follow-up to [25193], [25235], [25785]. Props audrasjb, peterwilsoncc, SergeyBiryukov. Fixes #51657. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 14:43:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 14:43:22 -0000 Subject: [wp-trac] [WordPress Trac] #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) In-Reply-To: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> References: <058.e8ff2e7a9c63b3b4ccf47937ea402cbd@wordpress.org> Message-ID: <073.a9a3acc763dc1127bcbd1f0dfb913e27@wordpress.org> #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' ) -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Themes | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has-patch needs- | Focuses: dev-note | -------------------------------------------------+------------------------- Changes (by SergeyBiryukov): * keywords: has-screenshots has-patch needs-dev-note needs-refresh needs-unit- tests => has-screenshots has-patch needs-dev-note -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 15:37:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 15:37:45 -0000 Subject: [wp-trac] [WordPress Trac] #45853: Videos embedded in a plugins readme.txt does not load while searching for a plugin in an actual WP install (not wp.org) In-Reply-To: <054.efae7ef8699cc0a2ca018b7115a6047d@wordpress.org> References: <054.efae7ef8699cc0a2ca018b7115a6047d@wordpress.org> Message-ID: <069.9beabb0852af54e39330a7257f7987e9@wordpress.org> #45853: Videos embedded in a plugins readme.txt does not load while searching for a plugin in an actual WP install (not wp.org) --------------------------+------------------------------ Reporter: thememason | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.0.2 Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration --------------------------+------------------------------ Changes (by azouamauriac): * keywords: => needs-patch * focuses: => administration Comment: Hi there welcome to wordpress trac! thanks for the report. Replying to [ticket:45853 thememason]: > videos do not load when you're searching for a plugin via an actual WordPress install. I don't really get this one, can you explain more? > In addition, if you install a plugin and click on "View Details" to learn more about the plugin, the video also does not load here either. Inspect element shows an empty span tag: > > {{{ > > }}} > > This should either embed the video or at the least display a link to the video. > > Here's an example plugin for reference: https://wordpress.org/plugins /simple-icons/ I'm able to reproduce this one. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 16:26:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 16:26:50 -0000 Subject: [wp-trac] [WordPress Trac] #55324: Twenty Twenty: Scroll to top not working In-Reply-To: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> References: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> Message-ID: <068.4ca4ad0578323b1176710fb8e83510d4@wordpress.org> #55324: Twenty Twenty: Scroll to top not working -------------------------------+------------------------------ Reporter: Presskopp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by sabernhardt): * keywords: => reporter-feedback Comment: The `header` element has `id="site-header"` in [https://core.trac.wordpress.org/browser/trunk/src/wp- content/themes/twentytwenty/header.php?rev=52013#L33 Twenty Twenty's header.php]. Does a plugin (or child theme) change that ID? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 17:36:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 17:36:35 -0000 Subject: [wp-trac] [WordPress Trac] #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix In-Reply-To: <052.71705d312df930659699caa7e0d22c46@wordpress.org> References: <052.71705d312df930659699caa7e0d22c46@wordpress.org> Message-ID: <067.d1ac217e38ee43367a4b2d6566baf81a@wordpress.org> #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix ---------------------------+------------------------------ Reporter: pgpagely | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by Mamaduka): I was able to reproduce the issue. Based on my quick tests, the issue is fixed if I update the following code to use `realpath`. {{{ $wpinc_path_norm = wp_normalize_path( realpath( ABSPATH . WPINC ) ); }}} Cc. @aristath and @gziolo, since you're more familiar with this part of the codebase. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 17:48:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 17:48:17 -0000 Subject: [wp-trac] [WordPress Trac] #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix In-Reply-To: <052.71705d312df930659699caa7e0d22c46@wordpress.org> References: <052.71705d312df930659699caa7e0d22c46@wordpress.org> Message-ID: <067.cbc06ce504ed9bf37f458238da5f3e75@wordpress.org> #55311: Style and JS URLs for some blocks are broken when using WP outside of the current prefix ---------------------------+------------------------------ Reporter: pgpagely | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Script Loader | Version: 5.9.1 Severity: major | Resolution: Keywords: | Focuses: ---------------------------+------------------------------ Comment (by pgpagely): I can confirm this looks like it fixes the issue on our side when applied like this as well. It would be great to get this out in the next maintenance release if it is passing tests because right now it is a breaking change as far as I can tell. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 18:14:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 18:14:13 -0000 Subject: [wp-trac] [WordPress Trac] #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode Message-ID: <060.aaacdb7d2decfa020f9284bbed451de7@wordpress.org> #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode ------------------------------+----------------------------- Reporter: aliakseyenkaihar | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: trivial | Keywords: Focuses: | ------------------------------+----------------------------- WordPress 5.9.1 PHP 8.0.15 When I set `global_styles_svg_filters` to return true (to prevent from being set - I don't use `theme.json` but request is sending so I want to disable it) it renders `1` at the top of the website Steps to reproduce on TwentyTwentyTwo theme: 1. Paste these lines in `functions.php` {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 18:17:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 18:17:37 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.6808f0a719b4c5c43c2c62173edb6b6f@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by johnbillion): * keywords: has-patch dev-feedback has-unit-tests needs-testing => has- patch has-unit-tests needs-testing Comment: Yes let's remove that test please and get this in 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 19:14:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 19:14:33 -0000 Subject: [wp-trac] [WordPress Trac] #55323: When an image is edited the URL of the image is not updated In-Reply-To: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> References: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> Message-ID: <065.cc168091f9c9ba00396f32893ed228b3@wordpress.org> #55323: When an image is edited the URL of the image is not updated --------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ui, administration --------------------------+--------------------------------- Comment (by adamsilverstein): Should the URL show the edited image url, or should the header for the field be updated to indicate it is the "original" image (if that is what it is)? So instead of "File URL" maybe "Original file URL"? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 19:16:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 19:16:43 -0000 Subject: [wp-trac] [WordPress Trac] #55324: Twenty Twenty: Scroll to top not working In-Reply-To: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> References: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> Message-ID: <068.8c49f38a14e5b4e640edafa225885a32@wordpress.org> #55324: Twenty Twenty: Scroll to top not working -------------------------------+------------------------------ Reporter: Presskopp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by Presskopp): It has the ID, but - don't ask me why - it's not working as is -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 19:34:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 19:34:24 -0000 Subject: [wp-trac] [WordPress Trac] #55323: When an image is edited the URL of the image is not updated In-Reply-To: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> References: <050.79ed9f05007caabff54b42e46b07c848@wordpress.org> Message-ID: <065.8e83fc01d73b13fe3680ebb12bbacf16@wordpress.org> #55323: When an image is edited the URL of the image is not updated --------------------------+--------------------------------- Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: ui, administration --------------------------+--------------------------------- Comment (by mitogh): > Should the URL show the edited image url, or should the header for the field be updated to indicate it is the "original" image (if that is what it is)? So instead of "File URL" maybe "Original file URL"? The URL should use the rotated version as the URL as when you reload the page after the edit has been completed the URL now uses the rotated version. Same for the File URL when the page is refreshed the File URL now references the rotated version, so in this case both fields should be updated to reflect the new values for: - File URL - Filename - File size - Dimensions From my perspective, the expected result is the same as if you refresh the page and new values are populated in the areas described above. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 19:38:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 19:38:35 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.ccf725abd2c93286765854e27b999869@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: has-patch has-unit-tests needs-testing => has-patch has-unit- tests needs-dev-note commit Comment: Alright the tests are passing now and I tested the patch successfully. Marking for a mention in the Misc changes devnote. Self assigning for `commit`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 19:38:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 19:38:43 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.e755785ef37fc4fe304d4b7e7c1dff93@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: accepted Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * owner: johnbillion => audrasjb * status: reviewing => accepted -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 20:20:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 20:20:56 -0000 Subject: [wp-trac] [WordPress Trac] #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode In-Reply-To: <060.aaacdb7d2decfa020f9284bbed451de7@wordpress.org> References: <060.aaacdb7d2decfa020f9284bbed451de7@wordpress.org> Message-ID: <075.28a380bb1284f07936abbdbc51658da8@wordpress.org> #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode ------------------------------+------------------------------ Reporter: aliakseyenkaihar | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: trivial | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Comment (by vijayhardaha): Hey @aliakseyenkaihar, May I ask why `__return_true` instead of setting `__return_false` ? as you mentioned **to prevent from being set** that can be done by setting false, since you're setting it true that's validated the if condition and you returned content is being printed as 1. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:11:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:11:25 -0000 Subject: [wp-trac] [WordPress Trac] #55324: Twenty Twenty: Scroll to top not working In-Reply-To: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> References: <053.fa149de27f743cf9d574f331ee5a4827@wordpress.org> Message-ID: <068.c89ea275e7b0a08886150cd85fac9774@wordpress.org> #55324: Twenty Twenty: Scroll to top not working -------------------------------+------------------------------ Reporter: Presskopp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Comment (by sabernhardt): 1. Which browser(s) and operating system do you use when it does not work? 2. If you look at the browser console, does it show any errors? (this might relate to the JavaScript scroll effect) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:36:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:36:42 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.fb168452999adede9da3ebc803e2ad62@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Changes (by johnregan3): * Attachment "55078-1.diff" added. Updated version of previous patch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:37:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:37:44 -0000 Subject: [wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js In-Reply-To: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> References: <058.ad9ebf29f9a2167068d32b7d638bef84@wordpress.org> Message-ID: <073.190dc9a06c82b47512182499e20d74b7@wordpress.org> #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Administration | Version: Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript ----------------------------+---------------------------------------- Comment (by johnregan3): This new patch (55078-1) fixes an error in the original patch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:39:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:39:22 -0000 Subject: [wp-trac] [WordPress Trac] #21077: Add support for custom ports in multisite site addresses In-Reply-To: <050.da44ba80528d7e12580241ce17e26436@wordpress.org> References: <050.da44ba80528d7e12580241ce17e26436@wordpress.org> Message-ID: <065.97a4afef99f369bd8c95e92755a65806@wordpress.org> #21077: Add support for custom ports in multisite site addresses ----------------------------------------+----------------------------- Reporter: djzone | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Future Release Component: Bootstrap/Load | Version: 3.4 Severity: normal | Resolution: Keywords: needs-unit-tests has-patch | Focuses: multisite ----------------------------------------+----------------------------- Comment (by Clorith): I'll add a note that multisite with custom ports appear to work out of the box, but requires you to edit the `wp_sites` database entry, and add the `:` your self. This is because the sanitize on save function in multisite strips out `:`, leaving you with a `url` instead of `url:` db entry if using the interface. I'm not sure if there's any other issue besides this one, if there's any concerns beyond back-compat then this is the place to outline them, but from some preliminary testing it would appear that updating the filters to allow a format of `:[0-9]+` to pass through the sanitizer on save shouldn't break anything, and open things up for custom ports to the users hearts desire 🤔 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:42:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:42:56 -0000 Subject: [wp-trac] [WordPress Trac] #54924: [video] shortcode with vimeo url In-Reply-To: <049.db37046112dcb75b85eda256e8d811c7@wordpress.org> References: <049.db37046112dcb75b85eda256e8d811c7@wordpress.org> Message-ID: <064.68356afd90ec1faeee1c570c54ca75ce@wordpress.org> #54924: [video] shortcode with vimeo url ------------------------------------------------+-------------------------- Reporter: elpix | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Embeds | Version: 5.9 Severity: critical | Resolution: Keywords: has-testing-info reporter-feedback | Focuses: ui ------------------------------------------------+-------------------------- Comment (by vijayhardaha): after 4.8 or 4.9 changes were made due to some issue with ME.js, details are available here https://core.trac.wordpress.org/ticket/40866 {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 21:59:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 21:59:44 -0000 Subject: [wp-trac] [WordPress Trac] #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." In-Reply-To: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> References: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> Message-ID: <069.3b9f2761e232a037a9508afa92b31921@wordpress.org> #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." --------------------------+----------------------- Reporter: webtechIMT | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Taxonomy | Version: 5.6 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+----------------------- Comment (by vijayhardaha): Try this solution on a staging website https://stackoverflow.com/a/44175853/11848895 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:13:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:13:42 -0000 Subject: [wp-trac] [WordPress Trac] #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 In-Reply-To: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> References: <049.2c16ca488f09279f482af9c6a35d7dfb@wordpress.org> Message-ID: <064.951d1dd3c324d75b9c1bb48b1b3e80b2@wordpress.org> #46297: Unable to edit specific terms : rest_cannot_assign_term OR 403 --------------------------+---------------------------------- Reporter: enps5 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.1 Severity: major | Resolution: Keywords: | Focuses: multisite, rest-api --------------------------+---------------------------------- Description changed by SergeyBiryukov: Old description: > This bug seems to be related to this changeset : > https://core.trac.wordpress.org/changeset/30056 > > When i try create a new post with gutenberg and categorize the post > taxonomy "bibliografía" i've this error : > > {{{ > Updating failed > }}} > > The request body is : > > {{{ > {"status":"draft","title":"test","excerpt":"","categories":[4092],"content":"\n

test

\n","id":1552} > }}} > > Response from wordpress : > > {{{ > {"code":"rest_cannot_assign_term","message":"Sorry, you are not allowed > to assign the provided terms.","data":{"status":403}} > }}} > > On a WordPress network, when i attempt to edit the category as a > wordpress super-user (this time i use the term.php's file) : > https://DOMAIN.TLD/wp- > admin/term.php?taxonomy=category&tag_ID=4092&post_type=post&wp_http_referer > =%2Fwp-admin%2Fedit- > tags.php%3Ftaxonomy%3Dcategory%26post_type%3Dpost%26s%3Dbibliograf%25C3%25ADa > Wordpress return : > > {{{ > You need a higher level of permission. > > Sorry, you are not allowed to edit this item. > }}} > > A further look inside MySQL shows : > > {{{ > SELECT * FROM wp_2635_terms where term_id = 4092 ; > +---------+---------------+--------------+------------+ > | term_id | name | slug | term_group | > +---------+---------------+--------------+------------+ > | 4092 | bibliografía | bibliografia | 0 | > +---------+---------------+--------------+------------+ > > SELECT * FROM wp_2635_term_taxonomy where term_id = 4092 ; > +------------------+---------+----------+-------------+--------+-------+ > | term_taxonomy_id | term_id | taxonomy | description | parent | count | > +------------------+---------+----------+-------------+--------+-------+ > | 254 | 4092 | category | | 0 | 1 | > | 197 | 4092 | post_tag | | 0 | 1 | > +------------------+---------+----------+-------------+--------+-------+ > > SELECT * FROM wp_2635_term_taxonomy GROUP BY term_id HAVING > COUNT(term_id) > 1; > +------------------+---------+----------+-------------+--------+-------+ > | term_taxonomy_id | term_id | taxonomy | description | parent | count | > +------------------+---------+----------+-------------+--------+-------+ > | 254 | 4092 | category | | 0 | 1 | > | 205 | 4191 | category | | 0 | 7 | > | 357 | 52788 | category | | 0 | 1 | > | 196 | 57611 | category | | 0 | 4 | > | 354 | 226144 | category | | 0 | 6 | > | 355 | 955714 | category | | 0 | 2 | > | 298 | 1595453 | category | | 0 | 2 | > | 313 | 1595513 | category | | 0 | 8 | > | 177 | 1595576 | category | | 0 | 12 | > | 379 | 1939409 | category | | 0 | 6 | > | 329 | 1939420 | category | | 0 | 4 | > | 312 | 1939471 | category | | 0 | 2 | > | 314 | 1939479 | category | | 0 | 4 | > | 359 | 2399420 | category | | 0 | 1 | > | 438 | 2454276 | category | | 0 | 1 | > +------------------+---------+----------+-------------+--------+-------+ > 15 rows in set (0.00 sec) > > select term_id,slug,COUNT(slug) from wp_2635_terms group by slug having > count(slug) > 1; > +---------+------------------------------+-------------+ > | term_id | slug | COUNT(slug) | > +---------+------------------------------+-------------+ > | 4191 | antropologia | 4 | > | 1595576 | antropologia-linguistica | 2 | > | 1595401 | audios | 3 | > | 4092 | bibliografia | 2 | > | 809963 | canal-uned | 3 | > | 52788 | cervantes | 2 | > | 2454276 | coelei | 2 | > | 1595453 | curso-de-verano | 2 | > | 1939479 | edicion-de-textos | 2 | > | 1595578 | etnografia-del-habla | 3 | > | 1595478 | etnolinguistica | 3 | > | 1939420 | eugenio-de-salazar | 2 | > | 1939409 | glosonimia | 2 | > | 465167 | jornadas | 3 | > | 1595513 | lexicografia | 2 | > | 1595414 | metodologia-docente | 3 | > | 1595416 | nuevas-propuestas-didacticas | 3 | > | 1595417 | paper-li | 3 | > | 200504 | proyectos | 3 | > | 57611 | publicaciones | 2 | > | 2399420 | tecnolecto-marinero | 2 | > | 226144 | uned | 2 | > | 1939471 | universidad-del-pacifico | 2 | > | 955714 | vocabulario | 2 | > +---------+------------------------------+-------------+ > > desc wp_2635_terms ; > +------------+---------------------+------+-----+---------+----------------+ > | Field | Type | Null | Key | Default | Extra > | > +------------+---------------------+------+-----+---------+----------------+ > | term_id | bigint(20) unsigned | NO | PRI | NULL | > auto_increment | > | name | varchar(200) | NO | MUL | | > | > | slug | varchar(200) | NO | MUL | | > | > | term_group | bigint(10) | NO | | 0 | > | > +------------+---------------------+------+-----+---------+----------------+ > 4 rows in set (0.01 sec) > > desc wp_2635_term_taxonomy ; > +------------------+---------------------+------+-----+---------+----------------+ > | Field | Type | Null | Key | Default | Extra > | > +------------------+---------------------+------+-----+---------+----------------+ > | term_taxonomy_id | bigint(20) unsigned | NO | PRI | NULL | > auto_increment | > | term_id | bigint(20) unsigned | NO | MUL | 0 | > | > | taxonomy | varchar(32) | NO | MUL | | > | > | description | longtext | NO | | NULL | > | > | parent | bigint(20) unsigned | NO | | 0 | > | > | count | bigint(20) | NO | | 0 | > | > +------------------+---------------------+------+-----+---------+----------------+ > > show create table wp_2635_terms \G > *************************** 1. row *************************** > Table: wp_2635_terms > Create Table: CREATE TABLE `wp_2635_terms` ( > `term_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, > `name` varchar(200) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `slug` varchar(200) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `term_group` bigint(10) NOT NULL DEFAULT '0', > PRIMARY KEY (`term_id`), > KEY `slug` (`slug`(191)), > KEY `name` (`name`(191)) > ) ENGINE=InnoDB AUTO_INCREMENT=2454306 DEFAULT CHARSET=utf8mb4 > COLLATE=utf8mb4_unicode_ci > 1 row in set (0.00 sec) > > show create table wp_2635_term_taxonomy \G > *************************** 1. row *************************** > Table: wp_2635_term_taxonomy > Create Table: CREATE TABLE `wp_2635_term_taxonomy` ( > `term_taxonomy_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, > `term_id` bigint(20) unsigned NOT NULL DEFAULT '0', > `taxonomy` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `description` longtext COLLATE utf8mb4_unicode_ci NOT NULL, > `parent` bigint(20) unsigned NOT NULL DEFAULT '0', > `count` bigint(20) NOT NULL DEFAULT '0', > PRIMARY KEY (`term_taxonomy_id`), > UNIQUE KEY `term_id_taxonomy` (`term_id`,`taxonomy`), > KEY `taxonomy` (`taxonomy`) > ) ENGINE=InnoDB AUTO_INCREMENT=462 DEFAULT CHARSET=utf8mb4 > COLLATE=utf8mb4_unicode_ci > 1 row in set (0.00 sec) > > }}} > > If i delete (via MySQL delete statement) the post_tag with the term_id > 4092, i can edit again the category. I had trouble reproducing the bug or > to simply to identify the cause of the problem. > > We're running a WordPress Network with ~5000blogs, i've identified this > problem on 1300 sites. > We work with MySQL "classic replication" (master / slave), we already had > a master x3 configuration with Galera Cluster. This can be an interesting > element. > > I remain available for aby further information. New description: This bug seems to be related to this changeset : [30056] When i try create a new post with gutenberg and categorize the post taxonomy "bibliografía" i've this error : {{{ Updating failed }}} The request body is : {{{ {"status":"draft","title":"test","excerpt":"","categories":[4092],"content":"\n

test

\n","id":1552} }}} Response from wordpress : {{{ {"code":"rest_cannot_assign_term","message":"Sorry, you are not allowed to assign the provided terms.","data":{"status":403}} }}} On a WordPress network, when i attempt to edit the category as a wordpress super-user (this time i use the term.php's file) : https://DOMAIN.TLD/wp- admin/term.php?taxonomy=category&tag_ID=4092&post_type=post&wp_http_referer =%2Fwp-admin%2Fedit- tags.php%3Ftaxonomy%3Dcategory%26post_type%3Dpost%26s%3Dbibliograf%25C3%25ADa Wordpress return : {{{ You need a higher level of permission. Sorry, you are not allowed to edit this item. }}} A further look inside MySQL shows : {{{ SELECT * FROM wp_2635_terms where term_id = 4092 ; +---------+---------------+--------------+------------+ | term_id | name | slug | term_group | +---------+---------------+--------------+------------+ | 4092 | bibliografía | bibliografia | 0 | +---------+---------------+--------------+------------+ SELECT * FROM wp_2635_term_taxonomy where term_id = 4092 ; +------------------+---------+----------+-------------+--------+-------+ | term_taxonomy_id | term_id | taxonomy | description | parent | count | +------------------+---------+----------+-------------+--------+-------+ | 254 | 4092 | category | | 0 | 1 | | 197 | 4092 | post_tag | | 0 | 1 | +------------------+---------+----------+-------------+--------+-------+ SELECT * FROM wp_2635_term_taxonomy GROUP BY term_id HAVING COUNT(term_id) > 1; +------------------+---------+----------+-------------+--------+-------+ | term_taxonomy_id | term_id | taxonomy | description | parent | count | +------------------+---------+----------+-------------+--------+-------+ | 254 | 4092 | category | | 0 | 1 | | 205 | 4191 | category | | 0 | 7 | | 357 | 52788 | category | | 0 | 1 | | 196 | 57611 | category | | 0 | 4 | | 354 | 226144 | category | | 0 | 6 | | 355 | 955714 | category | | 0 | 2 | | 298 | 1595453 | category | | 0 | 2 | | 313 | 1595513 | category | | 0 | 8 | | 177 | 1595576 | category | | 0 | 12 | | 379 | 1939409 | category | | 0 | 6 | | 329 | 1939420 | category | | 0 | 4 | | 312 | 1939471 | category | | 0 | 2 | | 314 | 1939479 | category | | 0 | 4 | | 359 | 2399420 | category | | 0 | 1 | | 438 | 2454276 | category | | 0 | 1 | +------------------+---------+----------+-------------+--------+-------+ 15 rows in set (0.00 sec) select term_id,slug,COUNT(slug) from wp_2635_terms group by slug having count(slug) > 1; +---------+------------------------------+-------------+ | term_id | slug | COUNT(slug) | +---------+------------------------------+-------------+ | 4191 | antropologia | 4 | | 1595576 | antropologia-linguistica | 2 | | 1595401 | audios | 3 | | 4092 | bibliografia | 2 | | 809963 | canal-uned | 3 | | 52788 | cervantes | 2 | | 2454276 | coelei | 2 | | 1595453 | curso-de-verano | 2 | | 1939479 | edicion-de-textos | 2 | | 1595578 | etnografia-del-habla | 3 | | 1595478 | etnolinguistica | 3 | | 1939420 | eugenio-de-salazar | 2 | | 1939409 | glosonimia | 2 | | 465167 | jornadas | 3 | | 1595513 | lexicografia | 2 | | 1595414 | metodologia-docente | 3 | | 1595416 | nuevas-propuestas-didacticas | 3 | | 1595417 | paper-li | 3 | | 200504 | proyectos | 3 | | 57611 | publicaciones | 2 | | 2399420 | tecnolecto-marinero | 2 | | 226144 | uned | 2 | | 1939471 | universidad-del-pacifico | 2 | | 955714 | vocabulario | 2 | +---------+------------------------------+-------------+ desc wp_2635_terms ; +------------+---------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +------------+---------------------+------+-----+---------+----------------+ | term_id | bigint(20) unsigned | NO | PRI | NULL | auto_increment | | name | varchar(200) | NO | MUL | | | | slug | varchar(200) | NO | MUL | | | | term_group | bigint(10) | NO | | 0 | | +------------+---------------------+------+-----+---------+----------------+ 4 rows in set (0.01 sec) desc wp_2635_term_taxonomy ; +------------------+---------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +------------------+---------------------+------+-----+---------+----------------+ | term_taxonomy_id | bigint(20) unsigned | NO | PRI | NULL | auto_increment | | term_id | bigint(20) unsigned | NO | MUL | 0 | | | taxonomy | varchar(32) | NO | MUL | | | | description | longtext | NO | | NULL | | | parent | bigint(20) unsigned | NO | | 0 | | | count | bigint(20) | NO | | 0 | | +------------------+---------------------+------+-----+---------+----------------+ show create table wp_2635_terms \G *************************** 1. row *************************** Table: wp_2635_terms Create Table: CREATE TABLE `wp_2635_terms` ( `term_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `name` varchar(200) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', `slug` varchar(200) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', `term_group` bigint(10) NOT NULL DEFAULT '0', PRIMARY KEY (`term_id`), KEY `slug` (`slug`(191)), KEY `name` (`name`(191)) ) ENGINE=InnoDB AUTO_INCREMENT=2454306 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.00 sec) show create table wp_2635_term_taxonomy \G *************************** 1. row *************************** Table: wp_2635_term_taxonomy Create Table: CREATE TABLE `wp_2635_term_taxonomy` ( `term_taxonomy_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `term_id` bigint(20) unsigned NOT NULL DEFAULT '0', `taxonomy` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', `description` longtext COLLATE utf8mb4_unicode_ci NOT NULL, `parent` bigint(20) unsigned NOT NULL DEFAULT '0', `count` bigint(20) NOT NULL DEFAULT '0', PRIMARY KEY (`term_taxonomy_id`), UNIQUE KEY `term_id_taxonomy` (`term_id`,`taxonomy`), KEY `taxonomy` (`taxonomy`) ) ENGINE=InnoDB AUTO_INCREMENT=462 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.00 sec) }}} If i delete (via MySQL delete statement) the post_tag with the term_id 4092, i can edit again the category. I had trouble reproducing the bug or to simply to identify the cause of the problem. We're running a WordPress Network with ~5000blogs, i've identified this problem on 1300 sites. We work with MySQL "classic replication" (master / slave), we already had a master x3 configuration with Galera Cluster. This can be an interesting element. I remain available for aby further information. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:14:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:14:09 -0000 Subject: [wp-trac] [WordPress Trac] #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." In-Reply-To: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> References: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> Message-ID: <069.3af9a24e57521c2ef76533280623b227@wordpress.org> #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." --------------------------+----------------------- Reporter: webtechIMT | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Taxonomy | Version: 5.6 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+----------------------- Description changed by SergeyBiryukov: Old description: > I'm using WordPress multi-sites and in one of the 300 sites when I want > to edit a category or a tag, I get error message "You need a higher level > of permission. Sorry, you are not allowed to edit this item." > > As I saw in the bug [https://core.trac.wordpress.org/ticket/46297], I > used the plugin wp-find-shared-terms (https://github.com/jjeaton/wp-find- > shared-terms) and click "Split shared items" button, but it splits none : > > Splitting all shared terms > Process complete! > Processed: 42 > Split: 0 > Skipped: 42 > Errors: 0 > > And the bug remains when I want to edit a category (I get the error > message "You need a higher level of permission. Sorry, you are not > allowed to edit this item."). New description: I'm using WordPress multi-sites and in one of the 300 sites when I want to edit a category or a tag, I get error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." As I saw in the bug #46297, I used the plugin wp-find-shared-terms (https://github.com/jjeaton/wp-find-shared-terms) and click "Split shared items" button, but it splits none : Splitting all shared terms Process complete! Processed: 42 Split: 0 Skipped: 42 Errors: 0 And the bug remains when I want to edit a category (I get the error message "You need a higher level of permission. Sorry, you are not allowed to edit this item."). -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:32:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:32:54 -0000 Subject: [wp-trac] [WordPress Trac] #55331: Blocks for video platforms as Bilibili.com and Nicovideo.jp Message-ID: <055.50d93a7a7ff2849614c24004c1a965d3@wordpress.org> #55331: Blocks for video platforms as Bilibili.com and Nicovideo.jp --------------------------+----------------------------- Reporter: jordiparera | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- It would be great to add Gutenberg specific blocks for video sharing on WordPress (as now with YouTube and Vimeo) for video platforms like Bilibili (www.bilibili.com) and Nico (www.nicovideo.jp). Do you think that would be possible? Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:50:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:50:36 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.2351235effa3435cd7954de4767e686d@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: accepted => closed * resolution: => fixed Comment: In [changeset:"52829" 52829]: {{{ #!CommitTicketReference repository="" revision="52829" Media: Allow `wp_check_filetype()` to support query strings in URLs. This changeset adjusts the regex in `wp_check_filetype()` to support query strings in URLs. Follow-up to [30640], [32172]. Props voldemortensen, johnbillion, layotte, dd32, atomicjack, supercleanse, spencercameron, ianmjones, audrasjb. Fixes #30377. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:56:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:56:11 -0000 Subject: [wp-trac] [WordPress Trac] #55332: problem with quick comment discarded changes Message-ID: <058.2f7bdc1f4e323213023eacb06be99d1d@wordpress.org> #55332: problem with quick comment discarded changes -------------------------------+----------------------------- Reporter: LinuxArchitect | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: minor | Keywords: Focuses: javascript | -------------------------------+----------------------------- The function discardCommentChanges in js/edit-comments.js does not seem to be working as intended. When using the quick comment editor, the function is called when an edit is started, and it does nothing at that point as expected. But if you click away from the form, nothing stops you and you lose your comment changes. On the other hand, if a plugin enqueues edit-comment.js, buddyboss- platform does (I don't know how/why), and you are editing a post (my attached example is an event venue), the function is triggered on update. With no comments involved, the original content is an empty string and the editied comment is undefined and that triggers the popup warning that changes might be lost. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:57:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:57:10 -0000 Subject: [wp-trac] [WordPress Trac] #55332: problem with quick comment discarded changes In-Reply-To: <058.2f7bdc1f4e323213023eacb06be99d1d@wordpress.org> References: <058.2f7bdc1f4e323213023eacb06be99d1d@wordpress.org> Message-ID: <073.9a1b1b75f4aef52c383fa704452d6f4d@wordpress.org> #55332: problem with quick comment discarded changes -------------------------------+------------------------------ Reporter: LinuxArchitect | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: minor | Resolution: Keywords: | Focuses: javascript -------------------------------+------------------------------ Changes (by LinuxArchitect): * Attachment "quick comment error.png" added. screenshot of popup warning while editing a post type unrelated to comments -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 22:58:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 22:58:50 -0000 Subject: [wp-trac] [WordPress Trac] #55332: problem with quick comment discarded changes In-Reply-To: <058.2f7bdc1f4e323213023eacb06be99d1d@wordpress.org> References: <058.2f7bdc1f4e323213023eacb06be99d1d@wordpress.org> Message-ID: <073.41d45c28b26e5ffb6b9746b092dc90d4@wordpress.org> #55332: problem with quick comment discarded changes -------------------------------+------------------------------ Reporter: LinuxArchitect | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.1 Severity: minor | Resolution: Keywords: | Focuses: javascript -------------------------------+------------------------------ Changes (by LinuxArchitect): * Attachment "edit-comments.js.patch" added. a quick hack patch that prevents the popup when not editing comments -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Mar 7 23:57:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 07 Mar 2022 23:57:05 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.160febf3cb8d51539c1fcd7a0c86b951@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: needs-patch | Focuses: administration, performance --------------------------+------------------------------------------ Changes (by mitogh): * Attachment "image-edits.patch" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:02:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:02:27 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.d8b240c147d61f7c4902cacc9167573a@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, performance --------------------------+------------------------------------------ Changes (by mitogh): * keywords: needs-patch => has-patch Comment: I've added a patch with a suggested fix. The suggested fix follows the same approach as WordPress follows when the image is uploaded for the first time, this approach is basically that when an uploaded image is smaller in dimensions than an image size the image size is not created for the image, which was the case for this image when the image Was rotated it was smaller in dimensions that the failed size creating an error and not saving the edit. As described this approach would not save any image that was errored out by the editors, images would remain in the backup sizes and can be restored at any point in time, by rolling back an existing size. The function `wp_get_additional_image_sizes` was replaced with `wp_get_registered_image_subsizes` in order to have a more accurate access to the defined image sizes by the user. Cast of values to `int` was introduced as well in order to make sure settings (as strings) were converted to integers. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:30:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:30:23 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.3a625060fa4e20877bdd91f64ef418d5@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note commit | -------------------------------------------------+------------------------- Changes (by dd32): * status: closed => reopened * resolution: fixed => Comment: @audrasjb Unfortunately this causes a PHP Fatal error for `ms-files.php`: {{{ Uncaught Error: Call to undefined function strip_fragment_from_url() in wp-includes/functions.php:3009 Stack trace: #0 wp-includes/ms-files.php(32): wp_check_filetype('wp-include...') #1 {main} thrown Source: GET https://make.wordpress.org/core/files/2022/01/list-view- keyboard-focus-1.mp4 Timestamp: Tue, 08 Mar 2022 00:28:30 +0000 (1646699310) File: wp-includes/functions.php Line: 3009 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:47:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:47:57 -0000 Subject: [wp-trac] [WordPress Trac] #55290: Not all image edits are applied to all subsizes In-Reply-To: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> References: <050.be681f53cfaf80199513d03ac9b6588a@wordpress.org> Message-ID: <065.f7b846094d93900f2a79e20a8392fc0b@wordpress.org> #55290: Not all image edits are applied to all subsizes --------------------------+------------------------------------------ Reporter: mitogh | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: administration, performance --------------------------+------------------------------------------ Changes (by SergeyBiryukov): * milestone: Future Release => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:49:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:49:34 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.aa9f7b0be44fb8fd02c56e286e18a822@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-dev-note commit => has-unit- tests needs-dev-note needs-patch Comment: I am being a little tedious to keep the milestone report keywords clean. I think we'd need e2e tests to test this use case as I don't think phpunit's ms-files tests use `SHORTINIT`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:56:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:56:21 -0000 Subject: [wp-trac] [WordPress Trac] #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed Message-ID: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed --------------------------+----------------------------- Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Canonical | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Related to [52829] is this PHP Notice that seems to be triggering on a `the_content` filter after that change: {{{ GET https://wordpress.org/news/2014/04/smith/ E_NOTICE: Undefined index: scheme in wp-includes/canonical.php:854 Undefined index: scheme }}} The input in this case is a URL such as `//wordpress.org/news/files/2014/04/widgets.mp4`. I also note that `strip_fragment_from_url()` doesn't use `wp_parse_url()` but uses `parse_url()` directly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 00:58:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 00:58:22 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.2adea71fe5f2ae92877d1766743df591@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by dd32): #55333 is a php notice that this change started triggering on WordPress.org, but is 'unrelated'. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 01:15:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 01:15:03 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation In-Reply-To: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> References: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> Message-ID: <070.a27885c697d1d39f7009cb6d8cf57f6f@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------+--------------------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: critical | Resolution: Keywords: | Focuses: administration, template --------------------------+--------------------------------------- Changes (by Enchiridion): * severity: major => critical Comment: I'm also getting this error. My stack trace is a little different, probably because I'm using Firefox. Like others in the linked forum thread, I'm using WordPress in a subdirectory. What's odd is both 5.9 and 5.9.1 make an XHR request to `/wp?_wp-find-template=true`, which 404s but also returns the requested JSON data. Seems only 5.9.1 actually fails because of this. On 5.9.1 I can't edit any templates the site editor just crashes unless I have an direct link to the template to edit `/wp/wp-admin/site- editor.php?postId=site%2F%2F404&postType=wp_template` I've had to roll back to 5.9 in order to keep site dev going. Error from the Copy Error button: {{{ IqXm/zr/r<@https://example.com/wp/wp-includes/js/dist/edit- site.min.js?ver=403e01f2b098b6a656118a51787581cb:2:121078 promise callback*IqXm/zr/t<@https://example.com/wp/wp-includes/js/dist /edit-site.min.js?ver=403e01f2b098b6a656118a51787581cb:2:121054 async*zr at https://example.com/wp/wp-includes/js/dist/edit- site.min.js?ver=403e01f2b098b6a656118a51787581cb:2:121424 qr at https://example.com/wp/wp-includes/js/dist/edit- site.min.js?ver=403e01f2b098b6a656118a51787581cb:2:121896 $r at https://example.com/wp/wp-includes/js/dist/edit- site.min.js?ver=403e01f2b098b6a656118a51787581cb:2:122936 @https://example.com/wp/wp-admin/site-editor.php:2201:16 EventListener.handleEvent*r at https://example.com/wp/wp-includes/js/dist /dom-ready.min.js?ver=ecda74de0221e1c2ce5c57cbb5af09d5:2:1121 @https://example.com/wp/wp-admin/site-editor.php:2200:4 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 01:31:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 01:31:01 -0000 Subject: [wp-trac] [WordPress Trac] #22176: Cache the results of the posts_request_ids query In-Reply-To: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> References: <048.5df67ddca93554b06d2a0f4b237307c0@wordpress.org> Message-ID: <063.0acf92801ad6b6a44e3502e365d3f713@wordpress.org> #22176: Cache the results of the posts_request_ids query -------------------------------------------------+------------------------- Reporter: ryan | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Future | Release Component: Query | Version: 3.4.2 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests early | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch 2nd-opinion has-unit-tests => has-patch 2nd-opinion has-unit-tests early Comment: This sprung to mind as there are a few ''add caching to some post function'' tickets that would be covered by this. I've put the early keyword on it as it involves both caching and Query. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 01:43:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 01:43:48 -0000 Subject: [wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon In-Reply-To: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> References: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> Message-ID: <073.2dd480c8a09086c272deffc949b7aaf3@wordpress.org> #48222: "Show password" button overlaps with the LastPass icon -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | sabernhardt Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.3 Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: ui design-feedback needs-testing early | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * Attachment "48222.10.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 01:47:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 01:47:16 -0000 Subject: [wp-trac] [WordPress Trac] #48222: "Show password" button overlaps with the LastPass icon In-Reply-To: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> References: <058.0d699b3273d056c061d95a9b99cee6c0@wordpress.org> Message-ID: <073.6ef8c0dc00f91fa5a3bff0f4c4d6f7db@wordpress.org> #48222: "Show password" button overlaps with the LastPass icon -------------------------------------------------+------------------------- Reporter: SergeyBiryukov | Owner: | sabernhardt Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Login and Registration | Version: 5.3 Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: ui design-feedback needs-testing early | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): [attachment:"48222.10.diff"] is [attachment:"48222.9.diff"] but refreshed against trunk to remove offsets, clean up line ending types. @sabernhardt do you need anything other than design feedback to take this forward? While testing, the screenshots @poena uploaded a few months ago appear to still be representative. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 03:21:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 03:21:43 -0000 Subject: [wp-trac] [WordPress Trac] #44591: PHP notice if optional argument isn't passed to map_meta_cap() In-Reply-To: <056.313e6e825d638ddee4053b7cd5f8819f@wordpress.org> References: <056.313e6e825d638ddee4053b7cd5f8819f@wordpress.org> Message-ID: <071.342bb0f75eb95b951b98da5761a28ffc@wordpress.org> #44591: PHP notice if optional argument isn't passed to map_meta_cap() --------------------------------------+----------------------------- Reporter: henry.wright | Owner: SergeyBiryukov Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+----------------------------- Comment (by peterwilsoncc): In the [https://github.com/WordPress/wordpress-develop/pull/2386 linked pull request]: [attachment:"44591-3.diff"] with the following changes: * version updated to 6.0.0 * removed escaping of translations, core trusts translations * added unit tests to ensure the affected caps contain `do_not_allow` and throw a doing it wrong * fixed `test_taxonomy_meta_capabilities_with_non_existent_terms` to expect the error > I'll just suggest that as the guard's code is repetitive if we can wrap it into a function to respect DRY principe it will be good. @azouamauriac you're right, it's repetitious. For now I think it's fine to keep the repetition rather than set up a specific function to wrap `_doing_it_wrong()`. It's a borderline call, so please feel free to push back on this if you wish. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 03:42:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 03:42:26 -0000 Subject: [wp-trac] [WordPress Trac] #55334: Attempt to read property "term_id" on null in "mywordpress/wp-includes/deprecated.php" on line 87 Message-ID: <051.d11fddf68aaa8c704930464151e2973a@wordpress.org> #55334: Attempt to read property "term_id" on null in "mywordpress/wp- includes/deprecated.php" on line 87 --------------------------+----------------------------- Reporter: bcue015 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: minor | Keywords: Focuses: | --------------------------+----------------------------- Title says it all. Error occurs whenever I uploaded "guppy.jpg" image. And I have a Guppy Categories with guppy slug. I also have a category- guppy.php in my template file. And heres the line 87 pointing out [[Image(https://i.ibb.co/K5Nmvy3/line87.png)]] And the result whenever I went to my guppy category link is this [[Image(https://i.ibb.co/LQfZ71Q/Untitled.png)]] It'll try to pull in my single.php cause thats what my single.php looks like. And I had no idea why the error was in my metabox so I'll just have to show you the code anyway. Here it is [[Image(https://i.ibb.co/XtyqQtx/theline.png)]] I think categories had something to do with this. And by the way Im using the latest wordpress 5.9.1 version with the following updated and activated plugins: Advanced Custom Fields All-in-One WP Migration Crop Thumbnails Regenerate Thumbnails Manual Image Crop WP Migrate DB I already resolve this by changing the name of my image as long as it is not guppy. You can close this ticket cause I just want to let you guys know. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 03:54:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 03:54:39 -0000 Subject: [wp-trac] [WordPress Trac] #43706: Email with link to change admin email does not include proposed new email address. In-Reply-To: <051.e8674074507faa5f4788d57d47e5a1c5@wordpress.org> References: <051.e8674074507faa5f4788d57d47e5a1c5@wordpress.org> Message-ID: <066.14f4d3ec1c571294212b7f2c1a8823ac@wordpress.org> #43706: Email with link to change admin email does not include proposed new email address. -------------------------------------------------+------------------------- Reporter: sshanky | Owner: | SergeyBiryukov Type: enhancement | Status: reviewing Priority: normal | Milestone: Future | Release Component: Users | Version: 4.9.5 Severity: normal | Resolution: Keywords: good-first-bug has-patch needs- | Focuses: refresh | -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: good-first-bug has-patch => good-first-bug has-patch needs- refresh Comment: Thanks for the patch @tremidkhar! While changing the `###EMAIL###` placeholder to `###NEW_EMAIL###` makes sense, you'll need to include a little bit of work to make sure that the code doesn't break for developers using the `new_admin_email_content` filter. I suggest `###EMAIL###` be considered deprecated in favour of `###NEW_EMAIL###`. Immediately following the filter a new line of code can be added to replace the old with the new, for example: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 03:56:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 03:56:54 -0000 Subject: [wp-trac] [WordPress Trac] #55335: $user_login double escaped with incorrect/empty password in wp-login.php Message-ID: <059.17cf1f26b07863758356afb40a2d904d@wordpress.org> #55335: $user_login double escaped with incorrect/empty password in wp-login.php ------------------------------------+----------------------------- Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Keywords: Focuses: | ------------------------------------+----------------------------- First: {{{ if ( isset( $_POST['log'] ) ) { $user_login = ( 'incorrect_password' === $errors->get_error_code() || 'empty_password' === $errors->get_error_code() ) ? esc_attr( wp_unslash( $_POST['log'] ) ) : ''; } }}} Then: {{{ class="input" value="" size="20" autocapitalize="off" /> }}} Fix is to late escape only, and remove the top one. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 04:00:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 04:00:35 -0000 Subject: [wp-trac] [WordPress Trac] #55335: $user_login double escaped with incorrect/empty password in wp-login.php In-Reply-To: <059.17cf1f26b07863758356afb40a2d904d@wordpress.org> References: <059.17cf1f26b07863758356afb40a2d904d@wordpress.org> Message-ID: <074.1d7d14cfb831e9a7a6a373a59b0448d8@wordpress.org> #55335: $user_login double escaped with incorrect/empty password in wp-login.php ------------------------------------+------------------------------ Reporter: johnjamesjacoby | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: | Focuses: ------------------------------------+------------------------------ Comment (by johnjamesjacoby): Relatedly, `'register'` action is double `wp_unslash()`ing `$user_email` and `$user_login`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 04:21:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 04:21:10 -0000 Subject: [wp-trac] [WordPress Trac] #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches In-Reply-To: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> References: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> Message-ID: <070.baa60409c8114c32ae3935a8c4925151@wordpress.org> #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches -----------------------------------+--------------------- Reporter: david.binda | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion | Focuses: -----------------------------------+--------------------- Comment (by peterwilsoncc): Replying to [comment:2 azouamauriac]: > Also it seems like ''_prime_term_caches'' is the only function which uses ''update_term_cache'' with the second parameter, so I think we can remove safely its second parameter "$taxonomy" in > ''update_term_cache''. WordPress tends to keep the deprecated parameters listed to future proof against any upcoming changes: `fn( $string, $object, $array )` might have the final argument deprecated `fn( $string, $object, $deprecated )`. The deprecated parameter needs to be keep as a placeholder in case a new parameter is added at a later date, eg `fn( $string, $object, $deprecated, $boolean )` There's a little judgement involved each time. However, it doesn't look like the `$taxonomy` argument was formally deprecated in `update_term_cache()` so perhaps you could look at that on another ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 04:23:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 04:23:48 -0000 Subject: [wp-trac] [WordPress Trac] #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches In-Reply-To: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> References: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> Message-ID: <070.0be4433ff53975234f57c2769f785203@wordpress.org> #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches -----------------------------------+---------------------------- Reporter: david.binda | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch 2nd-opinion | Focuses: -----------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"52830" 52830]: {{{ #!CommitTicketReference repository="" revision="52830" Taxonomy: Improve code quality within `_prime_term_caches()`. Remove the second parameter on the call to `update_term_cache()` from within the function `_prime_term_caches()`. The since deprecated parameter of the former was at one point a string, never a boolean. Props david.binda, SergeyBiryukov, azouamauriac. Fixes #55162. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 05:57:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 05:57:09 -0000 Subject: [wp-trac] [WordPress Trac] #55207: WP_Query returns published sticky posts when post_status is set to draft In-Reply-To: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> References: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> Message-ID: <067.eb2b6c363fcd6df6269549f3e2f3a0a8@wordpress.org> #55207: WP_Query returns published sticky posts when post_status is set to draft --------------------------+--------------------- Reporter: NomNom99 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Query | Version: Severity: normal | Resolution: Keywords: early | Focuses: --------------------------+--------------------- Changes (by peterwilsoncc): * keywords: => early * version: 5.9 => * milestone: Awaiting Review => 6.0 Comment: Replying to [comment:2 azouamauriac]: > After some search, the code was introduced here [8546]/#7457, originally called ''caller_get_posts'' and renamed ''ignore_sticky_posts'' here [15589]/#14624 Thanks for digging in to the history. The version tag applies to when the bug was introduced, as it looks like this bug has been around prior to WP 5.9 I'll remove the version and update it once I have done some additional checking. Moving on to the 6.0 milestone for visibility. As this involves the `WP_Query` class, I've also added the early keyword so any bug fix can be well tested prior to release. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 06:49:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 06:49:38 -0000 Subject: [wp-trac] [WordPress Trac] #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode In-Reply-To: <060.aaacdb7d2decfa020f9284bbed451de7@wordpress.org> References: <060.aaacdb7d2decfa020f9284bbed451de7@wordpress.org> Message-ID: <075.60d77640ce9b2292af553dcc251b361f@wordpress.org> #55330: Set global_styles_svg_filters transient to return true causing symbol `1` to be appeared on the screen in a production mode ------------------------------+------------------------------ Reporter: aliakseyenkaihar | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: trivial | Resolution: Keywords: | Focuses: ------------------------------+------------------------------ Comment (by aliakseyenkaihar): Hey @vijayhardaha I'm actually need anything but false to satisfy `false !== $pre` condition. See [here](https://github.com/WordPress/WordPress/blob/master /wp-includes/option.php#L847). I tested with null - `1` is NOT appearing but the call to update transient is present - and my personal goal is to prevent it -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 07:19:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 07:19:09 -0000 Subject: [wp-trac] [WordPress Trac] #55207: WP_Query returns published sticky posts when post_status is set to draft In-Reply-To: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> References: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> Message-ID: <067.bffd4989de683cea7244d6ce46dd7cc3@wordpress.org> #55207: WP_Query returns published sticky posts when post_status is set to draft --------------------------+--------------------- Reporter: NomNom99 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Query | Version: Severity: normal | Resolution: Keywords: early | Focuses: --------------------------+--------------------- Comment (by NomNom99): Thanks @peterwilsoncc I created a patch. It doesn't have any tests for now, figured it'll be better to move ahead once the issue is confirmed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 07:19:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 07:19:42 -0000 Subject: [wp-trac] [WordPress Trac] #55207: WP_Query returns published sticky posts when post_status is set to draft In-Reply-To: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> References: <052.c676576c2767ef4d8d1a735f953c8fae@wordpress.org> Message-ID: <067.a7f1d287bb0d8e283ed9c43ebdeb2394@wordpress.org> #55207: WP_Query returns published sticky posts when post_status is set to draft --------------------------+--------------------- Reporter: NomNom99 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Query | Version: Severity: normal | Resolution: Keywords: early | Focuses: --------------------------+--------------------- Changes (by NomNom99): * Attachment "patch-1.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 09:18:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 09:18:23 -0000 Subject: [wp-trac] [WordPress Trac] #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. Message-ID: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. --------------------------+----------------------------- Reporter: madstegge | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- The asterisk ("*", ASCII 2A hex) and exclamation mark ("!" , ASCII 21 hex) are reserved for use as having special significance within specific schemes. Source: https://www.w3.org/Addressing/URL/4_URI_Recommentations.html More here: https://developers.google.com/maps/url-encoding WordPress however, redirects to a URI encoded variant when the query string at the root level contains these reserved characters. So, https://wordpress.org/plugins/?test=123*456 doesn't redirect. While https://wordpress.org/?test=123*456 redirects to https://wordpress.org/?test=123%2A456. This is quite problematic for all WordPress sites that use for example Google Analytics 4 (GA4) cross-domain tracking. GA4 relies on a query string containing asterisks. Source: https://support.google.com/analytics/answer/10071811?hl=en -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 10:17:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 10:17:36 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.c9d4438b74b4858d0353c8c4d0eef36e@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by audrasjb): @dd32 I'm trying to reproduce the issue but I'm struggling a bit with ms- files.php, it's pretty hard to reproduce on a new install. Do you have an easy to reproduce use case (I mean outside w.org)? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 10:49:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 10:49:43 -0000 Subject: [wp-trac] [WordPress Trac] #55337: Optimize preload paths for post and site editors Message-ID: <051.3cc270bd638cb2ab0bbe4aa5931f6c80@wordpress.org> #55337: Optimize preload paths for post and site editors --------------------------+----------------------------- Reporter: jsnajdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: trunk Severity: normal | Keywords: has-patch Focuses: | --------------------------+----------------------------- The preloaded REST responses (api-fetch preloading middleware) are a bit out of sync with the real requests that the post and site editors are sending, and they should be optimized them. See the description of the attached PR, and also of this Gutenberg PR (https://github.com/WordPress/gutenberg/pull/39256), for more details. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 10:50:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 10:50:26 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Invalid use of display and float together in style.css file Message-ID: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> #55338: Invalid use of display and float together in style.css file -------------------------+----------------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: needs-patch Focuses: | -------------------------+----------------------------- In the theme Twenty Eleven, there is an invalid use of float and display inline-block together in the CSS style sheet. {{{ .indexed.format-image div.entry-meta { display: inline-block; float: left; width: 35%; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 10:53:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 10:53:30 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.077f93ff3263b16651d976a32181b985@wordpress.org> #55338: Invalid use of display and float together in style.css file -------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+------------------------------ Changes (by kajalgohel): * Attachment "#55338.patch" added. display: inline-block property is removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 10:54:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 10:54:09 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.51bc15861a48438eb1efce53e7ff690e@wordpress.org> #55338: Invalid use of display and float together in style.css file -------------------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+------------------------------ Changes (by kajalgohel): * keywords: needs-patch => has-patch needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:36:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:36:25 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.8a734d88aff9eae8cf59e6057219ac59@wordpress.org> #49412: Store filesize media metadata --------------------------------------+----------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+----------------------------- Changes (by spacedmonkey): * owner: johnwatkins0 => spacedmonkey -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:38:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:38:20 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.f393101ee3bd37a60d354c215647186d@wordpress.org> #49412: Store filesize media metadata --------------------------------------+----------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: assigned Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+----------------------------- Comment (by spacedmonkey): I spent some time on this ticket today. Updated the patch [https://github.com/WordPress/wordpress-develop/pull/2367 #2367]. I think the patch is good to merge. I will wait a day for feedback, other, I will merged. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:46:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:46:59 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.f7b3d29bb8ee3e73a54111549330a7f3@wordpress.org> #49412: Store filesize media metadata --------------------------------------+--------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+--------------------------- Changes (by spacedmonkey): * milestone: Future Release => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:54:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:54:11 -0000 Subject: [wp-trac] [WordPress Trac] #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line Message-ID: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line --------------------------+----------------------------- Reporter: jhn11 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hi, I have found that when I write a date (e.g. "5. dubna 2022" that is 5th of April, but in Czech format) at the beginning of line in post that WordPress renders it to default 1.1. at frontend. Text remains the same at backend but generated post at frontend: - changes to 1. 1. 2022 - and in html code there is ordered list When any characters are before the date on that line, nothing changes at frontend. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:55:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:55:12 -0000 Subject: [wp-trac] [WordPress Trac] #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line In-Reply-To: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> References: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> Message-ID: <064.f35df198928065060b7b9f3040ca7055@wordpress.org> #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line --------------------------+------------------------------ Reporter: jhn11 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by jhn11): * Attachment "Screenshot 2022-03-08 at 12-44-55 6x jarní ArcGIS Jak udělat mapu hezčí, Map Viewer, hostované vrstvy prvků, instantní appk[...].png" added. frontend - rendered post -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:55:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:55:44 -0000 Subject: [wp-trac] [WordPress Trac] #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line In-Reply-To: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> References: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> Message-ID: <064.443f63b41e8df8f991d12faf93eebb76@wordpress.org> #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line --------------------------+------------------------------ Reporter: jhn11 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by jhn11): * Attachment "Screenshot 2022-03-08 at 12-45-51 Upravit příspěvek “6x jarní ArcGIS Jak udělat mapu hezčí, Map Viewer, hostované vrstvy pr[...].png" added. backend - text in editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 11:56:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 11:56:15 -0000 Subject: [wp-trac] [WordPress Trac] #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line In-Reply-To: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> References: <049.a7717b1de6318d538ffff53fa5cfcb21@wordpress.org> Message-ID: <064.737644b5f6bb00020d619ac5462ab900@wordpress.org> #55339: Date changes to ordered list (and default 1. 1.) when at beginning of line --------------------------+------------------------------ Reporter: jhn11 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by jhn11): * Attachment "code.jpg" added. frontend - html code of post -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 12:25:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 12:25:05 -0000 Subject: [wp-trac] [WordPress Trac] #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches In-Reply-To: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> References: <055.1c067dc2bc1f79347ffb1d64d38e4564@wordpress.org> Message-ID: <070.af20e55280747b13a2a3066c2e3b00cf@wordpress.org> #55162: Incorrect parameter passed to update_term_cache from _prime_term_caches --------------------------+---------------------------- Reporter: david.binda | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+---------------------------- Changes (by azouamauriac): * keywords: has-patch 2nd-opinion => has-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 13:22:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 13:22:46 -0000 Subject: [wp-trac] [WordPress Trac] #55221: Feature image does not load media library in correct view. In-Reply-To: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> References: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> Message-ID: <068.48dab0d662f3193ba34275cb87f22600@wordpress.org> #55221: Feature image does not load media library in correct view. ---------------------------+------------------------------ Reporter: jhall_3rd | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.8.2 Severity: normal | Resolution: Keywords: needs-testing | Focuses: ---------------------------+------------------------------ Changes (by hellofromTonya): * keywords: => needs-testing * component: Editor => Media Comment: Hello @jhall_3rd 👋, Welcome to WordPress Core's Trac! Thank you for the ticket and providing steps to reproduce and a video showing the issue you are reporting - well done 👏⭐ The Test Team is currently testing to attempt to reproduce the reported issue. Test Reports will follow. I've also adjusted some info in the ticket for better discoverable. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 13:38:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 13:38:19 -0000 Subject: [wp-trac] [WordPress Trac] #55221: Feature image does not load media library in correct view. In-Reply-To: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> References: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> Message-ID: <068.48b3900df753c85aa27c316683082d8d@wordpress.org> #55221: Feature image does not load media library in correct view. ---------------------------+------------------------------ Reporter: jhall_3rd | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.8.2 Severity: normal | Resolution: Keywords: needs-testing | Focuses: ---------------------------+------------------------------ Comment (by Boniu91): Not able to reproduce it on the newest version. == Test Report === Env * WordPress 5.9.1 * Chrome 99.0.4844.51 * Windows 10 * Theme: Twenty Twenty One === Steps to test 1. Add new post with featured image using Classic Editor 2. Click on the Featured Image in order to edit it 3. Correct view with all uploaded media is displayed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 13:57:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 13:57:49 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.eef1e47c86e5b30ea5552e9313c01d06@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): As noted in comment:10, this was previously attempted in [30640] and reverted in [32171] as a security fix for [https://wordpress.org/news/2015/04/wordpress-4-1-2/ WordPress 4.1.2]. It would be great to confirm with the Security Team that [52829] does not reintroduce any issues. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:02:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:02:00 -0000 Subject: [wp-trac] [WordPress Trac] #55271: Featured Image Section Disappears In Block Editor In-Reply-To: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> References: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> Message-ID: <067.744fba9e7e1012759638d8051c31ddc8@wordpress.org> #55271: Featured Image Section Disappears In Block Editor -------------------------------------------------+------------------------- Reporter: zennie62 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-testing-info reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * keywords: => needs-testing-info reporter-feedback * component: General => Editor Comment: Hello @zennie62 Welcome to WordPress Core's Trac. Thank you for the ticket. During today's testing session, the Test Team was unable to reproduce the reported issue (test report to follow) when using Twenty Twenty-Two theme and no plugins activated. The featured image area in the sidebar of the `Posts` editor displays with a block theme activated and using 5.9 and 5.9.1. Can you provide step-by-step instructions including the theme and plugins you're using? Also a video, gif, and/or screenshots are helpful. The more information you can provide, the more this helps testers in their effort to reproduce and contributors to diagnose. What happens when you deactivate all of the plugins? Does the problem go away? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:04:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:04:53 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file (was: Invalid use of display and float together in style.css file) In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.84bdf7fc6907ef22f0b181a95ab130f4@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by SergeyBiryukov): * component: Themes => Bundled Theme * milestone: Awaiting Review => 6.0 Comment: Hi there, welcome back to WordPress Trac! Thanks for the patch. Introduced in [17776] / #17198. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:06:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:06:33 -0000 Subject: [wp-trac] [WordPress Trac] #55244: Non-editable title. In-Reply-To: <051.8532326a37a4edd0a95abd16ccccf792@wordpress.org> References: <051.8532326a37a4edd0a95abd16ccccf792@wordpress.org> Message-ID: <066.3ebf0665130b17142715f5994ad1f1e4@wordpress.org> #55244: Non-editable title. --------------------------+---------------------------------------- Reporter: krilike | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript --------------------------+---------------------------------------- Comment (by juhise): Hey @krilike Thanks for reporting the issue We tried to reproduce this issue on WP 5.9.1 and 5.8.2 but couldn't reproduce == Test Report === Env * WordPress 5.8.2 and 5.9.1 * Chrome 98.0.4758.109 * macOS Monterey * Theme: Twenty Twenty One * Gutenberg Editor * Plugin: WP Downgrade === Steps to test 1. Opened the post 2. Clicked on title and press CTRL+A 3. Was able to edit the title -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:09:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:09:36 -0000 Subject: [wp-trac] [WordPress Trac] #55271: Featured Image Section Disappears In Block Editor In-Reply-To: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> References: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> Message-ID: <067.dbc96b5b5a4bb0b91962778fbbf6fd69@wordpress.org> #55271: Featured Image Section Disappears In Block Editor -------------------------------------------------+------------------------- Reporter: zennie62 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-testing-info reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by juhise): Hey @zennie62 Thanks for reporting the issue We tried to reproduce this issue on WP 5.9.1 and 5.8.2 but couldn't reproduce == Test Report === Env * WordPress 5.8.2 and 5.9.1 * Chrome 98.0.4758.109 * macOS Monterey * Theme: Twenty Twenty One * Gutenberg Editor * Plugin: WP Downgrade === Steps to test 1. Added the `Post Featured Image` block 2. Featured image appears as expected Screenshot: https://nimb.ws/ANTcas -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:16:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:16:16 -0000 Subject: [wp-trac] [WordPress Trac] #55271: Featured Image Section Disappears In Block Editor In-Reply-To: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> References: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> Message-ID: <067.a3b7bafaf867cd7ec54cbe8cd998ba2c@wordpress.org> #55271: Featured Image Section Disappears In Block Editor -------------------------------------------------+------------------------- Reporter: zennie62 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-testing-info reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Changes (by hellofromTonya): * Attachment "55271-cant-reproduce-test-report1.png" added. Test Report: can't reproduce - results shown in Chrome, Edge, Firefox, and Safari. Works for me -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:18:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:18:33 -0000 Subject: [wp-trac] [WordPress Trac] #55271: Featured Image Section Disappears In Block Editor In-Reply-To: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> References: <052.3ab4cf29bbac4776757c20c1fed09569@wordpress.org> Message-ID: <067.0fd75cf3b2121cc16d922dc69bb8dd4b@wordpress.org> #55271: Featured Image Section Disappears In Block Editor -------------------------------------------------+------------------------- Reporter: zennie62 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Editor | Version: Severity: normal | Resolution: Keywords: needs-testing-info reporter- | Focuses: feedback | -------------------------------------------------+------------------------- Comment (by hellofromTonya): == Test Report === Env * OS: macOS Big Sur * WordPress: 5.9 and 5.9.1 * Localhost: wp-env and Local * Browsers: Chrome, Edge, Firefox, Safari * Theme: Twenty Twenty-Two (TT2) * Plugins: none activated === Steps to Test 1. Navigate to Posts > Add New 2. In the `Post` tab of the right sidebar, the Feature image area should be there. === Results I can't reproduce the reported issue. It works for me. The Feature image area is present in the Post editor with a block theme activated. See [attachment:"55271-cant-reproduce-test-report1.png"] for test results in 4 different browsers. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:20:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:20:53 -0000 Subject: [wp-trac] [WordPress Trac] #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. In-Reply-To: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> References: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> Message-ID: <068.239dbc75b21dcd72062f7655b4765b1e@wordpress.org> #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. --------------------------+------------------------------ Reporter: madstegge | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by SergeyBiryukov): Hi there, welcome to WordPress Trac! Thanks for the report. Replying to [ticket:55336 madstegge]: > WordPress however, redirects to a URI encoded variant when the query string at the root level contains these reserved characters. > > So, https://wordpress.org/plugins/?test=123*456 doesn't redirect. > > While https://wordpress.org/?test=123*456 redirects to https://wordpress.org/?test=123%2A456. I could not reproduce the issue on a clean install. Testing with some other sites like https://ma.tt/?test=123*456, they don't redirect either. WordPress.org does indeed redirect as noted, but I think that might be something specific to that particular network. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:21:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:21:07 -0000 Subject: [wp-trac] [WordPress Trac] #55340: Bad wording in translation string Message-ID: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> #55340: Bad wording in translation string ---------------------------+----------------------------- Reporter: pedromendonca | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: I18N | Version: trunk Severity: normal | Keywords: Focuses: | ---------------------------+----------------------------- The below string needs improvement: ''Whether to make the post type ~~is~~ available for selection in navigation menus.'' Suggestion: ''Whether to make the post type available for selection in navigation menus. '' Source: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes /rest-api/endpoints/class-wp-rest-post-types-controller.php#L371 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:48:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:48:06 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.d1c721b128d3dfb80731eaca001061c5@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-03-08 at 14.46.00.png" added. Before patch applied -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:48:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:48:20 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.9eee273a8018a7299a392144088c2acd@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * Attachment "Screenshot 2022-03-08 at 14.46.37.png" added. After patch was applied -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:48:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:48:55 -0000 Subject: [wp-trac] [WordPress Trac] #55340: Bad wording in translation string In-Reply-To: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> References: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> Message-ID: <072.0a4978bd0e6619be19c1afa09fc4c516@wordpress.org> #55340: Bad wording in translation string ---------------------------+--------------------- Reporter: pedromendonca | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: I18N | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:49:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:49:57 -0000 Subject: [wp-trac] [WordPress Trac] #55340: Bad wording in translation string In-Reply-To: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> References: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> Message-ID: <072.29b0a8b060286a2338f11645cf37b4e6@wordpress.org> #55340: Bad wording in translation string ---------------------------+----------------------------- Reporter: pedromendonca | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: I18N | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ---------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52831" 52831]: {{{ #!CommitTicketReference repository="" revision="52831" REST API: Correct the wording for `show_in_nav_menus` property description in post type visibility settings. Follow-up to [51959]. Props pedromendonca. Fixes #55340. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:53:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:53:11 -0000 Subject: [wp-trac] [WordPress Trac] #55341: Auto update bundled core themes by default Message-ID: <054.e2ce5cbf96e7fbed423e1b0676cd0590@wordpress.org> #55341: Auto update bundled core themes by default -----------------------------+----------------------------- Reporter: JosVelasco | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- After a core auto update runs and a new theme is installed it won't auto update by default. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:55:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:55:08 -0000 Subject: [wp-trac] [WordPress Trac] #55340: Bad wording in translation string In-Reply-To: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> References: <057.c93becc09b6c5313400771d2ab426527@wordpress.org> Message-ID: <072.9f54065f2bbc8ca89d6d76934eca5511@wordpress.org> #55340: Bad wording in translation string ---------------------------+----------------------------- Reporter: pedromendonca | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: I18N | Version: trunk Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: ---------------------------+----------------------------- Comment (by pedromendonca): Thanks @SergeyBiryukov! :-) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 14:55:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 14:55:40 -0000 Subject: [wp-trac] [WordPress Trac] #55221: Feature image does not load media library in correct view. In-Reply-To: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> References: <053.98376a7f1298436d309ce5717cb6aa0e@wordpress.org> Message-ID: <068.4a615821a0fddb0231e02b17047e8631@wordpress.org> #55221: Feature image does not load media library in correct view. --------------------------+------------------------ Reporter: jhall_3rd | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.8.2 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Changes (by hellofromTonya): * keywords: needs-testing => * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Following up: This issue was reported in #53765 and a fix shipped in 5.9 with [52384] changeset. I'll close this ticket as a duplicate. @jhall_3rd upgrading to 5.9.1 should resolve the issue you're experiencing. If no, please re-open the ticket for further investigation. Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:05:52 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:05:52 -0000 Subject: [wp-trac] [WordPress Trac] #55245: All images not showing since Update to WP 5.9.1 In-Reply-To: <056.ef03e33ec49f0e88be8ebbb10a80a9c6@wordpress.org> References: <056.ef03e33ec49f0e88be8ebbb10a80a9c6@wordpress.org> Message-ID: <071.588b938c48b13f65fc940f693d19dc5c@wordpress.org> #55245: All images not showing since Update to WP 5.9.1 -------------------------------+------------------------------ Reporter: cswebdesigns | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.9.1 Severity: trivial | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by hellofromTonya): * keywords: => reporter-feedback * component: General => Media Comment: Hello @cswebdesigns, Welcome to WordPress Core's Trac. Thank you for the ticket. I'm sorry you're site is having issues after upgrading to 5.9.1. During today's triage session, the Test Team was unable to reproduce this issue using a default setup of no plugins activated and a default bundled theme like Twenty Twenty-Two or Twenty Twenty-One. Wondering if this issue is caused by either an incomplete upgrade or a conflict from a plugin or theme. Some things to try: * Reinstall 5.9.1. Does the problem resolve? * Deactivate all plugins. Does the problem resolve? * Try to switch to a bundled theme. Does the problem resolve? * Are there any errors in your browser's console tab (in Dev tools)? If yes, please share a screenshot. How did you manually change each image? Can you share the steps you did? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:12:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:12:44 -0000 Subject: [wp-trac] [WordPress Trac] #55296: Issue with Images In-Reply-To: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> References: <053.7360aba65b1e779496171c1e9ef6b671@wordpress.org> Message-ID: <068.9f336ae772887dd12599f1e12da6459c@wordpress.org> #55296: Issue with Images --------------------------+------------------------- Reporter: lyntreeio | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Media | Version: 5.9.1 Severity: critical | Resolution: worksforme Keywords: close | Focuses: --------------------------+------------------------- Changes (by SergeyBiryukov): * component: General => Media * milestone: Awaiting Review => Comment: Thanks for the follow-up! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:16:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:16:34 -0000 Subject: [wp-trac] [WordPress Trac] #55341: Auto update bundled core themes by default In-Reply-To: <054.e2ce5cbf96e7fbed423e1b0676cd0590@wordpress.org> References: <054.e2ce5cbf96e7fbed423e1b0676cd0590@wordpress.org> Message-ID: <069.22e08870c5de024813b0efbd5b3665bf@wordpress.org> #55341: Auto update bundled core themes by default -----------------------------+------------------------ Reporter: JosVelasco | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket, we're already tracking this enhancement in #55321. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:24:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:24:47 -0000 Subject: [wp-trac] [WordPress Trac] #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. In-Reply-To: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> References: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> Message-ID: <068.1ac22fe8b050eecbda3dafe272a8fdf0@wordpress.org> #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. --------------------------+------------------------------ Reporter: madstegge | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by madstegge): Replying to [comment:1 SergeyBiryukov]: > I could not reproduce the issue on a clean install. Testing with some other sites like https://ma.tt/?test=123*456, they don't redirect either. > > WordPress.org does indeed redirect as noted, but I think that might be something specific to that particular network. That's interesting. All WordPress sites that I know of present this behavior. But it might be caused by a widespread plugin then. I'm not a developer, so can't give any more details about the affected configurations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:27:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:27:11 -0000 Subject: [wp-trac] [WordPress Trac] #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. In-Reply-To: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> References: <053.11d5ce4bde2445cb0e260ad0a7f506a9@wordpress.org> Message-ID: <068.ad8ab2b7de7d19395b39343a6abfe911@wordpress.org> #55336: Query strings with reserved characters get wrongly redirected to encoded variant at the root level. --------------------------+------------------------------ Reporter: madstegge | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: trunk Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by madstegge): The good news is that Google Analytics seems to handle the encoded query string correctly after all. But it might cause difficulties for other applications... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:48:30 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:48:30 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.1bf00740d2c8d51388d2196d6b40d975@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future Release Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute needs-patch | javascript -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "35483.2.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:50:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:50:57 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.3349d681018ca18fb6e7b09a3b29cb82@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch needs-testing | javascript -------------------------------------+------------------------------------- Changes (by afercia): * keywords: has-screenshots title-attribute needs-patch => has-screenshots title-attribute has-patch needs-testing * owner: (none) => afercia * milestone: Future Release => 6.0 Comment: Looking back at this ticket, the list of posts to be bulk-edited is still not operable with a keyboard. This needs to be fixed. The two remaining points that still need to be solved are: 1. Initial focus when opening Bulk Edit. 2. Escaping of emojis and special characters in the post title. In [attachment:"35483.2.diff"] - Both Bulk Edit and Quick Edit are now wrapped within a new `
` element with class `inline-edit-wrapper`. - This new `
` element: - Has a `role="region"` attribute. - It's labelled with and `aria-labelledby` attribute that points to the visible first fieldset legend e.g. 'BULK EDIT'. - Thanks to these two attributes, it becomes an ARIA landmark, which is an added bonus as landmarks can be easily found by assistive technology users. - Initial focus for Bulk Edit: - As pointed out in the previous comments, there's no clear 'default action' where to move focus to. - Therefore, the new patch sets initial focus on the ARIA region that wraps Bulk Edit. - When the ARIA region receives focus, screen readers will announce the region role and label. - The ARIA region will also show a clear focus style. - Initial focus for Quick Edit: - No change: the post title field will receive initial focus. - I'd recommend to consider to set initial focus to the ARIA region also in this case, for consistency. - Escaping of emojis and special characters: - The remove buttons don't use an `aria-label` attribute any longer so there's no need to escape the post title for use in a HTML attribute. - Instead, the buttons now use visually hidden text: this is content, no different from the visible post title, and can contain emojis and special characters. Some code review and testing would be greatly appreciated. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:51:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:51:44 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.774105d53e6ccee1b4c61fadcc9b001c@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch needs-testing | javascript -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "before.png" added. Before the patch. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 15:52:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 15:52:25 -0000 Subject: [wp-trac] [WordPress Trac] #35483: Accessibility improvements for the Bulk Edit form In-Reply-To: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> References: <051.87a7aaace03b7b3e0228eb25eaedecae@wordpress.org> Message-ID: <066.02322df18148e431dbd53fa095cab2b7@wordpress.org> #35483: Accessibility improvements for the Bulk Edit form -------------------------------------+------------------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: has-screenshots title- | Focuses: ui, accessibility, attribute has-patch needs-testing | javascript -------------------------------------+------------------------------------- Changes (by afercia): * Attachment "after.png" added. After the patch, with visible focus on the new ARIA region. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 16:04:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 16:04:51 -0000 Subject: [wp-trac] [WordPress Trac] #55342: If the contextual help panel is open and then I scroll, I have to click on help twice to close the panel Message-ID: <051.2181a15c6ebcad26d40e92f871666359@wordpress.org> #55342: If the contextual help panel is open and then I scroll, I have to click on help twice to close the panel --------------------------+----------------------------- Reporter: mikecho | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Help/About | Version: 5.9.1 Severity: minor | Keywords: Focuses: ui | --------------------------+----------------------------- Steps to reproduce: 1. click "Help" to open a contextual help panel 2. scroll 3. click "Help" to close the panel; note that it does not close 4. click "Help" again; note that it does close this time This is annoying for the user--can this be solved so that it only takes one click to close the contextual help after scrolling? In our plugin, we are using enough contextual help on one page that you have to scroll to reach the "Help" button (#contextual-help-link") to close it again. Further notes: I have a live expression for document.activeElement in the console. On the first attempt to close the section, the document.activeElement shows: {{{ button#contextual-help-link.button.show-settings.screen-meta-active }}} on the second, click it shows: {{{ button#contextual-help-link.button.show-settings }}} More info: happens in several tested themes (2022, 2021, 2020) happens when all plugins are deactivated Chrome/Edge/Firefox, Windows 10, Ubuntu 20.04 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 16:33:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 16:33:44 -0000 Subject: [wp-trac] [WordPress Trac] #55343: Add Tooltip to "Remember Me" (WP Login Form) Message-ID: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> #55343: Add Tooltip to "Remember Me" (WP Login Form) -------------------------+------------------------------------------------- Reporter: generosus | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 5.9.1 Severity: normal | Keywords: dev-feedback 2nd-opinion needs-docs Focuses: | needs-codex -------------------------+------------------------------------------------- Currently, WordPress' login form has a checkbox labeled "Remember Me." Over the years, there's been some debate over the verbiage used for "Remember Me" (say, versus "Stay Logged In" or "Keep Me Logged In") and what it really means. To eliminate any confusion, this is to request the [https://ibb.co/fkqN7Vz /addition of a tooltip] next to "Remember Me" in the form of a question (?) mark. Further, the tooltip can offer a security warning to all users. The content (text) for the tooltip could be: "**Selecting Remember Me reduces the number of times you’ll be asked to log in using this device. To keep your account secure, use this option only on your personal devices.**" Also, in anticipation that this enhancement request will be approved, I would like to recommend updating the [https://developer.wordpress.org/reference/functions/wp_login_form /affected codex page] for the login form to add a code snippet that will allow developers to change the content (text) of the tooltip to suit their needs. The above would be a nice addition or update to WordPress' login form. Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 16:36:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 16:36:49 -0000 Subject: [wp-trac] [WordPress Trac] #55343: Add Tooltip to "Remember Me" (WP Login Form) In-Reply-To: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> References: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> Message-ID: <068.4375c4005e545ae885cbf4761347b398@wordpress.org> #55343: Add Tooltip to "Remember Me" (WP Login Form) --------------------------+------------------------------ Reporter: generosus | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 5.9.1 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Changes (by generosus): * keywords: dev-feedback 2nd-opinion needs-docs needs-codex => dev- feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 16:59:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 16:59:05 -0000 Subject: [wp-trac] [WordPress Trac] #55343: Add Tooltip to "Remember Me" (WP Login Form) In-Reply-To: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> References: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> Message-ID: <068.c2a70f6f6febde590fe3c1388fa5375c@wordpress.org> #55343: Add Tooltip to "Remember Me" (WP Login Form) --------------------------+------------------------------ Reporter: generosus | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 5.9.1 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: --------------------------+------------------------------ Comment (by generosus): **Correction:** If approved, these are the affected WordPress documents: [https://developer.wordpress.org/reference/functions/wp_login_form /Code Reference Page] [https://codex.wordpress.org/Customizing_the_Login_Form /Codex Page] Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:10:45 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:10:45 -0000 Subject: [wp-trac] [WordPress Trac] #54423: Add Site Health test for full page caching (advanced cache) In-Reply-To: <055.1a40931285f63f7119be6a62995a057e@wordpress.org> References: <055.1a40931285f63f7119be6a62995a057e@wordpress.org> Message-ID: <070.9bf41e783d23216ac93e18c8fa54614f@wordpress.org> #54423: Add Site Health test for full page caching (advanced cache) -------------------------+------------------------------ Reporter: westonruter | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Site Health | Version: Severity: normal | Resolution: Keywords: needs-docs | Focuses: performance -------------------------+------------------------------ Comment (by westonruter): Cross-posted in [https://github.com/WordPress/performance/issues/220 WordPress/performance#220]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:29:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:29:04 -0000 Subject: [wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter. In-Reply-To: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> References: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> Message-ID: <074.9212e153ababb7136ad3db3312a955f5@wordpress.org> #54476: Improve image engine detection when output format adjusted with filter. -------------------------------------+--------------------- Reporter: adamsilverstein | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+--------------------- Changes (by adamsilverstein): * keywords: has-patch => has-patch needs-refresh * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:29:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:29:07 -0000 Subject: [wp-trac] [WordPress Trac] #54476: Improve image engine detection when output format adjusted with filter. In-Reply-To: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> References: <059.dd466e6070f6af55c5f5b41615375d51@wordpress.org> Message-ID: <074.d8cb1e5b01e3e65f4e1306f2034708ba@wordpress.org> #54476: Improve image engine detection when output format adjusted with filter. -------------------------------------+------------------------------ Reporter: adamsilverstein | Owner: adamsilverstein Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: Media | Version: 5.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: -------------------------------------+------------------------------ Changes (by adamsilverstein): * owner: (none) => adamsilverstein * status: new => assigned -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:39:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:39:03 -0000 Subject: [wp-trac] [WordPress Trac] #55344: Resources for hidden widgets are loaded on WP dashboard Message-ID: <053.4ed27fa406a39cbf13813ae1048c8a9f@wordpress.org> #55344: Resources for hidden widgets are loaded on WP dashboard ----------------------------+----------------------------- Reporter: josklever | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Keywords: Focuses: performance | ----------------------------+----------------------------- When plugins are placing widgets on the WordPress dashboard and these are hidden via the Screen Options the resources of those widgets are still loaded. In the Sources tab of the browser console this can easily be checked. I've noticed this with multiple plugins, so it looks like a core bug. It would save resources and increase performance of the dashboard if hidden items are not loaded. I've asked in the #performance Slack channel, where I was asked to create a ticket to report this as a bug. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:45:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:45:56 -0000 Subject: [wp-trac] [WordPress Trac] #55345: When uploading image through featured image section, the image item count is wrong. Message-ID: <059.ca1c40cbbd8bb6a42956106d68a510e2@wordpress.org> #55345: When uploading image through featured image section, the image item count is wrong. -----------------------------+----------------------------------------- Reporter: alanjacobmathew | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Keywords: has-screenshots needs-patch Focuses: | -----------------------------+----------------------------------------- When uploading image through featured image section, the image item count is wrong. === Env * 5.9.1 * Brave, Chromium * Win 10 * Theme : TT2 * Plugins: None === Test Instruction * Open Post Editor and click on 'Set featured image' option. * Notice the total number of existing images * Upload a new image into the featured image section. * Now notice the number of images (+2) * Reload the page, and now the count corrects itself. When uploading image directly to the featured image section of the post editor, the media item count works correctly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 17:46:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 17:46:36 -0000 Subject: [wp-trac] [WordPress Trac] #55345: When uploading image through featured image section, the image item count is wrong. In-Reply-To: <059.ca1c40cbbd8bb6a42956106d68a510e2@wordpress.org> References: <059.ca1c40cbbd8bb6a42956106d68a510e2@wordpress.org> Message-ID: <074.7c97a152b80d74a5791fade9893570fc@wordpress.org> #55345: When uploading image through featured image section, the image item count is wrong. -----------------------------------------+------------------------------ Reporter: alanjacobmathew | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: has-screenshots needs-patch | Focuses: -----------------------------------------+------------------------------ Changes (by alanjacobmathew): * Attachment "Media item count.gif" added. Featured image wrong image count -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 18:20:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 18:20:14 -0000 Subject: [wp-trac] [WordPress Trac] #55278: Fix Support for embed.ly with Odysee.com (half working) In-Reply-To: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> References: <055.2409d41840aec0bf605a5521f83257c2@wordpress.org> Message-ID: <070.958b4fa6a764a7f2f7d6f40898335b9b@wordpress.org> #55278: Fix Support for embed.ly with Odysee.com (half working) -------------------------+------------------------------ Reporter: tomatodysee | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui -------------------------+------------------------------ Comment (by tomatodysee): @peterwilsoncc answering the questions as you asked, let me know if this works: Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?” Odysee has been around for 1.5 years now and evolved from lbry.tv (~2019, now sunset) and a LBRY Desktop application in 2016. Today, Odysee.com has over 32M+ monthly unique visitors and is used by prominent content creators, many of which have millions of youtube subscribers. If similar services are already supported, how does this service compare in terms of size, features, and backing? No, this is new. Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified? Twitter account is verified and has over 55K followers: https://twitter.com/OdyseeTeam . This is our main social media platform, and on our own site, we have over 1.3M followers: https://odysee.com/@Odysee:8 Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.) Oembed implementation can be found here: https://github.com/OdyseeTeam /odysee-frontend/blob/master/web/src/oEmbed.js We are also supported on embed.ly, and you can validate our URLs here: http://debug.iframely.com/?uri=https%3A%2F%2Fodysee.com%2F%40veritasium%3Af%2Fwe %27re-building-computers-wrong-%28for%3Af Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being added to the allow-list? No, only works via paid wordpress accounts + via our embed code. Our iframes use cookies, and require the same-site origin flag which, as discussed above, is not secure enough based on WordPress standards. Does the service make an effort to build relationships with developers, such as through robust APIs? Majority of our code is open source, and we work with outside contributors all the time! How old is the service? 1.5+ years, but LBRY has been around since 2016. Does it have a well-established Wikipedia article? (Seriously.) Right now it’s under LBRY, but we hope someone will correct that. Odysee is now a separate company outside of LBRY Inc (for the past ~6 months). https://en.wikipedia.org/wiki/LBRY Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand? There’s a wordpress plugin for LBRY: https://github.com/lbryio/lbrypress, but it didn’t get much traction. LBRY Inc is revamping it to make it easier to use/integrate. Is the provider frequently proposed? We get many requests from users and creators to support Odysee links on WordPress! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 19:08:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 19:08:18 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress Message-ID: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------+---------------------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Privacy | Version: 5.9 Severity: major | Keywords: needs-privacy-review Focuses: | --------------------------+---------------------------------- Hi, We, a group of researchers from University of virginia and John hopkins university are investigating the GDPR compliance issue for wordpress plugins. During the investigation, I have installed wordpresss 5.9 in my local machine. Later, I created one root and one regular user account in my local machine. After that, I installed profilepress (https://wordpress.org/plugins/wp-user-avatar/) plugin and activated it. By this time, I have some information (personal information) stored in the database. These days, to comply with GDPR, wordpress comes with data deletion and data access feature. So, to test that, I have made a request to delete my regular user from the database and approved it. In the request table, it showed the status to “completed”. But later when I select the data access, it exported that user’s data. I checked the database, I can still see all the information related to that user. Note that, I haven’t modified my code from the wordpress core, other than the configuration file. Can you please take a look at this issue? I can also share the screenshot of the whole process if needed. Please let me know if any other information needed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 19:11:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 19:11:32 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.8169a62d791dcb837ba0de827feab8a2@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------+------------------------------ Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Privacy | Version: 5.9 Severity: normal | Resolution: Keywords: close | Focuses: --------------------------+------------------------------ Changes (by swissspidy): * keywords: needs-privacy-review => close * severity: major => normal Comment: Hi there, Thanks for opening this. Since WordPress cannot know what type of data plugins store, it's up to the plugins to hook into the data export / erasure process offered by WordPress. See https://developer.wordpress.org/plugins/privacy/ for details. So in this case, you'd want to reach out to ProfilePress so they can look into this and make any necessary changes to their plugin. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 20:29:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 20:29:32 -0000 Subject: [wp-trac] [WordPress Trac] #54926: Deprecated: WP_User_Query was called with an argument that is deprecated since version 5.9.0! In-Reply-To: <056.fa02f8e32cf7adff226e382fb685c1c7@wordpress.org> References: <056.fa02f8e32cf7adff226e382fb685c1c7@wordpress.org> Message-ID: <071.d2b066f621397c638e554123513002e5@wordpress.org> #54926: Deprecated: WP_User_Query was called with an argument that is deprecated since version 5.9.0! --------------------------+---------------------- Reporter: sonjaysarker | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Users | Version: 5.9 Severity: normal | Resolution: invalid Keywords: has-patch | Focuses: --------------------------+---------------------- Comment (by iandunn): I'm also seeing this intermittently, and it looks like [https://github.com/WordPress/gutenberg/search?q=who:authors Gutenberg may still have several `who:author` queries]. I haven't had time to dig in further, though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:09:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:09:59 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure In-Reply-To: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> References: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> Message-ID: <072.aa788ef700e15cec323154da48348e23@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure -------------------------------+----------------------- Reporter: bertvandepoel | Owner: pbiron Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+----------------------- Changes (by pbiron): * owner: (none) => pbiron * status: new => assigned * component: Themes => Upgrade/Install * milestone: Awaiting Review => 6.0 Comment: Hi @bertvandepoel, this ticket was discussed during the [https://wordpress.slack.com/archives/CULBN711P/p1646760805500679 Upgrade/Install component meeting] earlier today. We decided to try to get a solution to this in the next major version of WP, no promises, but we'll try. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:26:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:26:08 -0000 Subject: [wp-trac] [WordPress Trac] #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) In-Reply-To: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> References: <056.dd52dedca2457b5bc3a0cb986370b731@wordpress.org> Message-ID: <071.25e65103116a1177e2bf6bfe965cd3c9@wordpress.org> #22316: Plugin Dependencies (Yet Another Plugin Dependencies Ticket) ------------------------------------------+----------------------------- Reporter: Viper007Bond | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Upgrade/Install | Version: 3.4.2 Severity: normal | Resolution: Keywords: dev-feedback has-patch early | Focuses: ------------------------------------------+----------------------------- Changes (by afragen): * milestone: 6.0 => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:28:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:28:41 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.2033040e69100380e3fb3c0b6d6dbc8d@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by audrasjb): Hello and thank you for opening this ticket and for the patch! However, I reproduced the context (image post format and blog/archive page) and it looks like we shouldn't remove this since it applies to both `.entry-meta` divs. Removing this CSS declaration breaks the design of the meta box on my side. See the animated screenshot below -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:29:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:29:09 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.15c21b92ebbc5d7f9b5f7ffd824b66d5@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by audrasjb): * Attachment "16c4d8dd4b8e6390250e32311204a1fb.gif" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:32:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:32:46 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.3f73e72416e2c5b394ceb264dba80981@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------+---------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: normal | Resolution: invalid Keywords: close | Focuses: --------------------------+---------------------- Changes (by johnbillion): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: @fs5ve Please note that you received the same response for your previous report at #52024. Please ensure you direct your reports to the affected plugins instead. Thank you. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:34:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:34:24 -0000 Subject: [wp-trac] [WordPress Trac] #55347: they should be filter for image tag in wp_filter_content_tags() Message-ID: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> #55347: they should be filter for image tag in wp_filter_content_tags() -------------------------+----------------------------- Reporter: pbearne | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 22:34:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 22:34:43 -0000 Subject: [wp-trac] [WordPress Trac] #55347: There should be filter for image tag in wp_filter_content_tags() (was: they should be filter for image tag in wp_filter_content_tags()) In-Reply-To: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> References: <051.4c28ae614b265b131f10f373a6050f15@wordpress.org> Message-ID: <066.c580c052038318849674cdffbd3cf587@wordpress.org> #55347: There should be filter for image tag in wp_filter_content_tags() -------------------------+------------------------------ Reporter: pbearne | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Mar 8 23:07:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 08 Mar 2022 23:07:53 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2355348=3A_Deneme_?= =?utf-8?b?w7bEn3Jlbm1leWUgw6dhbMSxxZ/EsXlvcnVt?= Message-ID: <054.9903837a707caa0eebd6977eca7337f7@wordpress.org> #55348: Deneme öğrenmeye çalışıyorum -----------------------------+----------------------------- Reporter: volkan7934 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Administration | Version: 5.9.1 Severity: normal | Keywords: has-patch Focuses: | -----------------------------+----------------------------- Kusura bakmayin iyi çalışmalar -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 00:46:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 00:46:38 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.d4545c8a5b06f73b18981ef9df9b3325@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by peterwilsoncc): In [changeset:"52832" 52832]: {{{ #!CommitTicketReference repository="" revision="52832" Media: Revert query string support for `wp_check_filetype()`. Revert [52829] due to fatal errors in some Multisite configurations. Props dd32, SergeyBiryukov, audrasjb. See #30377. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 01:08:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 01:08:39 -0000 Subject: [wp-trac] [WordPress Trac] #55341: Auto update bundled core themes by default In-Reply-To: <054.e2ce5cbf96e7fbed423e1b0676cd0590@wordpress.org> References: <054.e2ce5cbf96e7fbed423e1b0676cd0590@wordpress.org> Message-ID: <069.4de38d094d8e9b29ceaaf39a0c628a76@wordpress.org> #55341: Auto update bundled core themes by default -----------------------------+------------------------ Reporter: JosVelasco | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Upgrade/Install | Version: Severity: normal | Resolution: duplicate Keywords: | Focuses: -----------------------------+------------------------ Comment (by Otto42): We have never turned on auto-updates for any theme. Ever. It seems way too dangerous. People modify their themes. Plugins tend to not be directly changed. This is just my opinion, updating themes directly loses any customizations they may have made to files in the theme folder. It's risky. Very, very risky. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 01:17:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 01:17:13 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure In-Reply-To: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> References: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> Message-ID: <072.778a65b7217d20a24a1bc14d8f74fc77@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure -------------------------------+----------------------- Reporter: bertvandepoel | Owner: pbiron Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+----------------------- Comment (by Otto42): We have never turned on auto-updates for any theme. Ever. It seems way too dangerous. People modify their themes. Plugins tend to not be directly changed. This is just my opinion, updating themes directly loses any customizations they may have made to files in the theme folder. It's risky. Very, very risky. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 01:21:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 01:21:48 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.6a6f6a70f18a052a2723f2558f1e4344@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by dd32): Replying to [comment:58 audrasjb]: > @dd32 I'm trying to reproduce the issue but I'm struggling a bit with ms-files.php, it's pretty hard to reproduce on a new install. Unfortunately I'm not aware of how to setup Multisite using ms-files.php, You probably need to manually flip the `ms_files_rewriting` site option, or perhaps even just request `ms- files.php?file=relative/path/to/file.ext`. I can say that `strip_fragment_from_url` is in canonical and not loaded in multisite SHORTINIT though. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 04:20:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 04:20:28 -0000 Subject: [wp-trac] [WordPress Trac] #55349: Not able to embed videos Message-ID: <052.fa9fd9c46f123877f72c619166e3398c@wordpress.org> #55349: Not able to embed videos --------------------------+----------------------------- Reporter: nm977890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 5.8.3 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- When I attempt to embed a video, all that shows up is a small 20 x 20px square with no functionality and does not show up when previewing the post. I am not an admin. When attempting to embed the video all I do is copy the embed text, switch from visual to text, paste the embed text, and switch back to visual. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 04:21:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 04:21:02 -0000 Subject: [wp-trac] [WordPress Trac] #55349: Not able to embed videos In-Reply-To: <052.fa9fd9c46f123877f72c619166e3398c@wordpress.org> References: <052.fa9fd9c46f123877f72c619166e3398c@wordpress.org> Message-ID: <067.37d932369032631e73f03eb21c176645@wordpress.org> #55349: Not able to embed videos --------------------------+------------------------------ Reporter: nm977890 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Embeds | Version: 5.8.3 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by nm977890): * Attachment "Screen Shot 2022-03-08 at 11.01.28 PM.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 06:42:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 06:42:01 -0000 Subject: [wp-trac] [WordPress Trac] #55351: The New Layout Fix For Plugin Install Page Message-ID: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> #55351: The New Layout Fix For Plugin Install Page ------------------------------+----------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: has-screenshots Focuses: ui, css, ui-copy | ------------------------------+----------------------------- Hello, I have done some changes to CSS in the install-plugin.php page you can view the after before screenshot here: Before View of Install Plugin Page: https://i.snipboard.io/DMpixC.jpg After View of Install Plugin Page: https://snipboard.io/fJvOE2.jpg Basically what i have done is move the Install button with a more detail button to the bottom and align all the boxes with the same height hide extra text in the plugin title and description and give some border-radius on the page. Thanks you :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 06:42:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 06:42:40 -0000 Subject: [wp-trac] [WordPress Trac] #55351: The New Layout Fix For Plugin Install Page In-Reply-To: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> References: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> Message-ID: <074.57538ab22c453959d6b000c12c24abd6@wordpress.org> #55351: The New Layout Fix For Plugin Install Page -----------------------------+------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: ui, css, ui-copy -----------------------------+------------------------------- Changes (by sharjeelkhanvmi): * Attachment "CSS.css" added. CSS FOR PLUGIN INSTALL PAGE NEW DESIGN FIX CSS 2022 FOR VERSION 5.9.1 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 07:14:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 07:14:53 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.96842b0ef02b35049286301e0a1acf28@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by kajalgohel): Hi @audrasjb Can u please provide the steps for testing ? Thanks -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 07:34:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 07:34:59 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.e8415583e2606afbf8056f3267b6c37a@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by Ruxton): With the knowledge of what @dd32 just mentioned, it seems the viable solution outside of moving strip_fragment_from_url out of canonical (which is excessive) is to strip the fragment and beyond with strpos, etc. as the query string was. {{{#!php }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 07:52:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 07:52:07 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.51fc4e78d648180a9133910d04845544@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by dd32): Replying to [comment:62 Ruxton]: > With the knowledge of what dd32 just mentioned, it seems the viable solution outside of moving strip_fragment_from_url out of canonical (which is excessive) is to strip the fragment and beyond with strpos, etc. as the query string was. Using string functions to remove parts of a URL (both `?...` and `#...`) is a potential security issue here (and why it would've been reverted prevously), as it's possible to cause it to strip more than anticipated and result in operating on the incorrect filename. You should really use `wp_parse_url()` instead too (It's kind of like parsing HTML with Regex, possible, but should be avoided). Additionally, since the parameter can be a Filename, Path, or URL, you need to restrict any URL handling to URLs only, not filenames. If a filename on disk ''looks like'' a url (You can have a filename on Linux that IS a url), you can't treat it as a URL either. If the filename came from an untrusted location, you can't treat it as a URL unless it's known to be intentionally a URL. Pulling out two comments from above: - [comment:19 Comment by me]: I'd personally prefer to add an explicit `wp_check_url_filetype()` function instead, one which extracts the actual filename from the URL and passes it along to `wp_check_filetype()` (if appropriate, or duplicates parts of it) - [comment:27 Comment by Helen]: Changing to enhancement, as `wp_check_filetype()` was never meant for URLs and the solution in this case is to introduce something else that does work for URLs. Even if the existing function is being passed URLs, it's not intentionally supposed to be used for URLs, and performing processing like this is doomed for failure. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 08:21:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 08:21:42 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.2ba5741a039c8eb458941b9443efb485@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by Ruxton): All very fair, someone actually wrote a patch with what you want and you responded to it at the time, then it somehow just drifted away from that. If patch 3 is the solution you want, should we refresh that and include the tests from John's patch? Would that get us to a better place? I'm just trying to get this across the line. It's old, annoying and a resolution is needed. Replying to [comment:63 dd32]: > > Pulling out two comments from above: > - [comment:19 Comment by me]: I'd personally prefer to add an explicit `wp_check_url_filetype()` function instead, one which extracts the actual filename from the URL and passes it along to `wp_check_filetype()` (if appropriate, or duplicates parts of it) > - [comment:27 Comment by Helen]: Changing to enhancement, as `wp_check_filetype()` was never meant for URLs and the solution in this case is to introduce something else that does work for URLs. > > Even if the existing function is being passed URLs, it's not intentionally supposed to be used for URLs, and performing processing like this is doomed for failure. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 09:35:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 09:35:06 -0000 Subject: [wp-trac] [WordPress Trac] #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." In-Reply-To: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> References: <054.830e4883156008ed2da3c0ae50db1854@wordpress.org> Message-ID: <069.ee0b2e6af64c110bc592b01776fea6e8@wordpress.org> #52423: Editing a category or a tag, and getting error message "You need a higher level of permission. Sorry, you are not allowed to edit this item." --------------------------+----------------------- Reporter: webtechIMT | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Taxonomy | Version: 5.6 Severity: critical | Resolution: Keywords: | Focuses: --------------------------+----------------------- Comment (by webtechIMT): Thank you, But when you try the solution described in [https://stackoverflow.com/a/44175853/11848895], you lose data: For example, I have the bug with a category A and a tag with the same name A and I have to choose wich one I have to deleted to solve the bug. If I choose for example to delete the tag, I lose association of all my posts with the tag A... Is there any solution without losing data ? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 09:38:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 09:38:20 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.60a5128604417904fe2a7436cb151792@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Comment (by audrasjb): 1. Use Twenty Eleven on your website 2. Publish a post with the "Image" post format 3. Go to front-end 4. Inspect the `entry-meta` zone (see animated screenshot above) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 09:52:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 09:52:07 -0000 Subject: [wp-trac] [WordPress Trac] #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ In-Reply-To: <058.57d558b174285895243858ce4a230956@wordpress.org> References: <058.57d558b174285895243858ce4a230956@wordpress.org> Message-ID: <073.d2e1fae6d1e99791c2e7803fadaba11d@wordpress.org> #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by JavierCasares): I'm having this problems with MariaDB 10.5. https://make.wordpress.org/hosting/test-results/r52797/wpsabot-r52797/ I think this may be related with {{{ @@SQL_MODE: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION }}} Mainly: STRICT_TRANS_TABLES. MariaDB 10.2.4+ has the STRICT_TRANS_TABLES by default... https://mariadb.com/kb/en/sql-mode/#strict_trans_tables Strict mode. Statements with invalid or missing data are aborted and rolled back, except that for non-transactional storage engines and statements affecting multiple rows where the invalid or missing data is not the first row, MariaDB will convert the invalid value to the closest valid value, or, if a value is missing, insert the column default value. Default since MariaDB 10.2.4. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:38:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:38:48 -0000 Subject: [wp-trac] [WordPress Trac] #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ In-Reply-To: <058.57d558b174285895243858ce4a230956@wordpress.org> References: <058.57d558b174285895243858ce4a230956@wordpress.org> Message-ID: <073.21503bc67161ddb6376f166849db703f@wordpress.org> #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by SergeyBiryukov): Replying to [comment:12 JavierCasares]: > I'm having this problems with MariaDB 10.5. > > https://make.wordpress.org/hosting/test-results/r52797/wpsabot-r52797/ > > I think this may be related with > > {{{ > @@SQL_MODE: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION > }}} > > Mainly: STRICT_TRANS_TABLES. MariaDB 10.2.4+ has the STRICT_TRANS_TABLES by default... Thanks! I'm not sure it's related to `STRICT_TRANS_TABLES` though, as WordPress specifically disables this and other incompatible modes as of [27072] / #26847. It's interesting that the failure messages are the exact opposite of what I had in the ticket description. MySQL 8.0.17 changes from `bigint(20)` to `bigint`: {{{ Tests_dbDelta::test_column_type_change Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( - 'wptests_dbdelta_test.id' => 'Changed type of wptests_dbdelta_test.id from bigint(20) to int(11)' + 'wptests_dbdelta_test.id' => 'Changed type of wptests_dbdelta_test.id from bigint to int(11)' ) }}} MariaDB 10.5.15 changes from `bigint` to `bigint(20)`: {{{ Tests_dbDelta::test_column_type_change Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ Array &0 ( - 'wptests_dbdelta_test.id' => 'Changed type of wptests_dbdelta_test.id from bigint to int(11)' + 'wptests_dbdelta_test.id' => 'Changed type of wptests_dbdelta_test.id from bigint(20) to int(11)' ) }}} It also looks like the same tests do successfully pass on another host: https://make.wordpress.org/hosting/test-results/r52797/cloudingbot-r52797/ I think the test changes in [47184] may need some adjustment, specifically this check: {{{ if ( version_compare( $db_version, '8.0.17', '<' ) ) { // Prior to MySQL 8.0.17, default width of 20 digits was used: BIGINT(20). $this->bigint_display_width = '(20)'; } }}} However, it's not quite clear to me why this works for me locally with MariaDB 10.4.12, as well as on some hosts with MariaDB 10.5.15, but not on the one with the failures. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:40:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:40:51 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query Message-ID: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> #55352: Improve cache key generation in WP_Term_Query --------------------------+---------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Taxonomy | Version: 4.7 Severity: normal | Keywords: Focuses: performance | --------------------------+---------------------------- Using the WP_Term_Query, caches are generated using the args passed to the class instance. However, there are a number of params passed, that would not affect the cache but would create a new cache key. Couple of example of these are. - pad_counts - update_term_meta_cache These params can be removed from the cache key with no affect to cache. There are other params such as slug and term_taxonomy_id, that can be both string and array. If all these were convert to arrays, it would improve the likelyhood that would be a cache hit. There are likely more wins to be had to improve caches here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:42:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:42:15 -0000 Subject: [wp-trac] [WordPress Trac] #55352: Improve cache key generation in WP_Term_Query In-Reply-To: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> References: <056.83ec256dbe1fbdf4ccbdd87da2264554@wordpress.org> Message-ID: <071.21078ae033650f3efd51538dc96a2956@wordpress.org> #55352: Improve cache key generation in WP_Term_Query ------------------------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: needs-patch needs-unit-tests | Focuses: performance ------------------------------------------+----------------------------- Changes (by spacedmonkey): * keywords: => needs-patch needs-unit-tests Comment: CC @peterwilsoncc -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:45:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:45:25 -0000 Subject: [wp-trac] [WordPress Trac] #55353: Theme Twenty-Eleven - issue in image block in styles option Message-ID: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> #55353: Theme Twenty-Eleven - issue in image block in styles option --------------------------+----------------------------------------- Reporter: kajalgohel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: needs-patch has-screenshots Focuses: | --------------------------+----------------------------------------- In twenty-eleven theme, the image size option values of Image block is overlapped, and the **Large** text is not seen properly. actually the **g** word of **Large** text is not seen proper. For better understanding I provide the screenshot of that. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:45:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:45:54 -0000 Subject: [wp-trac] [WordPress Trac] #55353: Theme Twenty-Eleven - issue in image block in styles option In-Reply-To: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> References: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> Message-ID: <069.8669124d27086c518ffb735b3ec0976c@wordpress.org> #55353: Theme Twenty-Eleven - issue in image block in styles option -----------------------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch has-screenshots | Focuses: -----------------------------------------+------------------------------ Changes (by kajalgohel): * Attachment "Screenshot 2022-03-09 at 2.03.31 PM.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:46:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:46:53 -0000 Subject: [wp-trac] [WordPress Trac] #55353: Theme Twenty-Eleven - issue in image block in styles option In-Reply-To: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> References: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> Message-ID: <069.935f051e3db3325b16bb6789b1cbd86f@wordpress.org> #55353: Theme Twenty-Eleven - issue in image block in styles option -------------------------------------------------+------------------------- Reporter: kajalgohel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch has-screenshots needs- | Focuses: design-feedback | -------------------------------------------------+------------------------- Changes (by kajalgohel): * keywords: needs-patch has-screenshots => needs-patch has-screenshots needs-design-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 10:53:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 10:53:21 -0000 Subject: [wp-trac] [WordPress Trac] #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ In-Reply-To: <058.57d558b174285895243858ce4a230956@wordpress.org> References: <058.57d558b174285895243858ce4a230956@wordpress.org> Message-ID: <073.4436f621f8deab5d5f12710485f22c50@wordpress.org> #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by JavierCasares): I can try to change the SQL_MODE in my machine (I don't have anything in this machine, is only to do tests). So I can try and check changing this option. I'll do a manual test and leave the report here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 11:12:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 11:12:50 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.f3da73a46cf9f4e5cd50dd777851f7b1@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+--------------------- Changes (by kajalgohel): * Attachment "#55338.2.patch" added. width decrease by 1% and float: left removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 11:13:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 11:13:21 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.e2555c0e67dea0cfbbe0f89c2829d6e0@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------------------+------------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: design-feedback | -------------------------------------------------+------------------------- Changes (by kajalgohel): * keywords: has-patch needs-testing => has-patch needs-testing needs- design-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 11:33:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 11:33:35 -0000 Subject: [wp-trac] [WordPress Trac] #55354: wordpress 5.9 with php 8.1 Message-ID: <061.b1f6d6c45e1f7889811f7f263e001a55@wordpress.org> #55354: wordpress 5.9 with php 8.1 -------------------------------+----------------------------- Reporter: vbss2018wordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- wordpress 5.9.1 does not work with php 8.1 php database not found -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 11:40:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 11:40:00 -0000 Subject: [wp-trac] [WordPress Trac] #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ In-Reply-To: <058.57d558b174285895243858ce4a230956@wordpress.org> References: <058.57d558b174285895243858ce4a230956@wordpress.org> Message-ID: <073.23faf643f9206894a483e18000eb9179@wordpress.org> #49364: dbDelta() should not change display width for integer data types on MySQL 8.0.17+ ----------------------------+--------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Database | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by JavierCasares): Well... after testing it without the `STRICT_TRANS_TABLES` it gave me the same errors... so, no, it seems not to be that. I'm going to do some more testing and configurations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 11:53:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 11:53:32 -0000 Subject: [wp-trac] [WordPress Trac] #55353: Theme Twenty-Eleven - issue in image block in Image size option (was: Theme Twenty-Eleven - issue in image block in styles option) In-Reply-To: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> References: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> Message-ID: <069.ba1e189cbd43e7a21607eddad77936f7@wordpress.org> #55353: Theme Twenty-Eleven - issue in image block in Image size option -------------------------------------------------+------------------------- Reporter: kajalgohel | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Themes | Version: Severity: normal | Resolution: Keywords: needs-patch has-screenshots needs- | Focuses: design-feedback | -------------------------------------------------+------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 13:36:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 13:36:51 -0000 Subject: [wp-trac] [WordPress Trac] #30377: wp_check_filetype is broken when checking urls with parameters In-Reply-To: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> References: <056.c092dedebd826c904e4a06f6059bc1b1@wordpress.org> Message-ID: <071.ad4619a869f37820aa3212a42e0d91fa@wordpress.org> #30377: wp_check_filetype is broken when checking urls with parameters -------------------------------------------------+------------------------- Reporter: supercleanse | Owner: audrasjb Type: enhancement | Status: reopened Priority: normal | Milestone: 6.0 Component: Media | Version: 4.0 Severity: normal | Resolution: Keywords: has-unit-tests needs-dev-note | Focuses: needs-patch | -------------------------------------------------+------------------------- Comment (by SergeyBiryukov): Replying to [comment:64 Ruxton]: > If patch 3 is the solution you want, should we refresh that and include the tests from John's patch? Would that get us to a better place? Yes, I think that would be the preferred direction here. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 13:51:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 13:51:48 -0000 Subject: [wp-trac] [WordPress Trac] #55354: wordpress 5.9 with php 8.1 In-Reply-To: <061.b1f6d6c45e1f7889811f7f263e001a55@wordpress.org> References: <061.b1f6d6c45e1f7889811f7f263e001a55@wordpress.org> Message-ID: <076.c8a164003dda6886ded02b887c35b441@wordpress.org> #55354: wordpress 5.9 with php 8.1 -------------------------------+------------------------ Reporter: vbss2018wordpress | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Database | Version: 5.9.1 Severity: normal | Resolution: duplicate Keywords: php81 | Focuses: -------------------------------+------------------------ Changes (by SergeyBiryukov): * keywords: => php81 * resolution: => duplicate * status: new => closed * component: General => Database * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! Thanks for the report. Looks like you've submitted a similar ticket before: #55208, let's continue there. Just to clarify, while WordPress 5.9.x is not ''fully'' compatible with PHP 8.1, it does succesfully run on that version in general, with some deprecation notices, as seen in [https://github.com/WordPress/wordpress- develop/runs/5473490381?check_suite_focus=true#step:20:1 automated test runs]. You can find more details in this post: [https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and-php-8-0-8-1/ WordPress 5.9 and PHP 8.0-8.1]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 13:57:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 13:57:55 -0000 Subject: [wp-trac] [WordPress Trac] #55208: WordPress 5.9 on PHP 8.1 In-Reply-To: <061.0ce7a45d468f27bdf6ae05f5e7849b2e@wordpress.org> References: <061.0ce7a45d468f27bdf6ae05f5e7849b2e@wordpress.org> Message-ID: <076.d7043b14b386261997aad052e80a4e34@wordpress.org> #55208: WordPress 5.9 on PHP 8.1 -------------------------------+------------------------------ Reporter: vbss2018wordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: normal | Resolution: Keywords: php81 | Focuses: -------------------------------+------------------------------ Changes (by SergeyBiryukov): * keywords: => php81 Comment: Hi there, welcome back to WordPress Trac! Thanks for the report. Just to clarify, while WordPress 5.9.x is not ''fully'' compatible with PHP 8.1, it does succesfully run on that version in general, with some deprecation notices, as seen in [https://github.com/WordPress/wordpress- develop/runs/5473490381?check_suite_focus=true#step:20:1 automated test runs]. You can find more details in this post: [https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and-php-8-0-8-1/ WordPress 5.9 and PHP 8.0-8.1]. I think the issue might be specific to your server configuration. If you need help with your site, I would suggest trying the support forums: https://wordpress.org/support/forums/. #51988 might also be related. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 14:03:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 14:03:04 -0000 Subject: [wp-trac] [WordPress Trac] #48644: Establish guidelines for button order In-Reply-To: <050.cf5f54b222bbdf09d47c69a2f77220ee@wordpress.org> References: <050.cf5f54b222bbdf09d47c69a2f77220ee@wordpress.org> Message-ID: <065.ce9dff34355f4b5c52603fdf5d6035d3@wordpress.org> #48644: Establish guidelines for button order -------------------------------------------------+------------------------- Reporter: drw158 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future | Release Component: Administration | Version: Severity: normal | Resolution: Keywords: needs-design-feedback a11y- | Focuses: ui, proximity | accessibility -------------------------------------------------+------------------------- Changes (by afercia): * keywords: needs-design-feedback => needs-design-feedback a11y-proximity -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 14:06:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 14:06:54 -0000 Subject: [wp-trac] [WordPress Trac] #55351: The New Layout Fix For Plugin Install Page In-Reply-To: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> References: <059.800b911ae628dfad4064e3217fe6242f@wordpress.org> Message-ID: <074.f08f2e24dd0b34caae84529178906a41@wordpress.org> #55351: The New Layout Fix For Plugin Install Page -----------------------------+-------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Plugins | Version: 5.9.1 Severity: normal | Resolution: duplicate Keywords: has-screenshots | Focuses: ui, css, administration -----------------------------+-------------------------------------- Changes (by SergeyBiryukov): * status: new => closed * resolution: => duplicate * focuses: ui, css, ui-copy => ui, css, administration * component: General => Plugins * milestone: Awaiting Review => Comment: Hi there, welcome back to WordPress Trac! It looks like you've submitted a similar ticket before: #55272, let's continue there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 14:07:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 14:07:11 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.186ff1c52efef49b434f1830b43ba564@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: invalid => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:01:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:01:05 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.583884b2180b9520763f003052a8ed7a@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Comment (by huskyr): I'm having the same issue without the WooCommerce plugin, with a custom theme. I don't get the issue when switching to one of the standard themes. Is there a workaround without waiting for the upgrade? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:05:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:05:48 -0000 Subject: [wp-trac] [WordPress Trac] #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed In-Reply-To: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> References: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> Message-ID: <063.a46550a99b0e8a56c11d5b764baa6f0d@wordpress.org> #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed --------------------------+--------------------- Reporter: dd32 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Canonical | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:06:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:06:23 -0000 Subject: [wp-trac] [WordPress Trac] #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed In-Reply-To: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> References: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> Message-ID: <063.a678eb24d36fddbe23c8a2bcf5aa7476@wordpress.org> #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed --------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Canonical | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52833" 52833]: {{{ #!CommitTicketReference repository="" revision="52833" Canonical: Check if the URL scheme exists in `strip_fragment_from_url()`. This avoids an "Undefined index" PHP notice when a schemeless URI is passed. Props dd32, SergeyBiryukov. Fixes #55333. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:13:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:13:31 -0000 Subject: [wp-trac] [WordPress Trac] #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure In-Reply-To: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> References: <057.da81e632b9250d96cb5eb1ff77566c9b@wordpress.org> Message-ID: <072.5939faf8492fb51b7d4a0143b03425a9@wordpress.org> #55321: Adding new themes in releases without a global theme auto-update setting renders installations insecure -------------------------------+----------------------- Reporter: bertvandepoel | Owner: pbiron Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui -------------------------------+----------------------- Comment (by JosVelasco): An alternative would be to send a reminder in the e-mail that includes an update with a new bundled theme to activate automatic updates. Also, maybe include the suggestion in the WordPress Site Health as well. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:14:28 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:14:28 -0000 Subject: [wp-trac] [WordPress Trac] #55355: Typo in wp_parse_url() description Message-ID: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> #55355: Typo in wp_parse_url() description ----------------------------+---------------------------------------- Reporter: SergeyBiryukov | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.7 Severity: trivial | Keywords: needs-patch good-first-bug Focuses: docs | ----------------------------+---------------------------------------- `wp_parse_url()` description includes this sentence: > Secondly, across various PHP versions, schemeless URLs starting containing a ":" in the query are being handled inconsistently. "starting containing" appears to be a typo, it should probably be just "containing" instead. Follow-up to [38726] / #36356. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 15:59:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 15:59:48 -0000 Subject: [wp-trac] [WordPress Trac] #55272: The New Layout Fix For Plugin Install Page In-Reply-To: <059.77915a7719fefa82183f9912ec945915@wordpress.org> References: <059.77915a7719fefa82183f9912ec945915@wordpress.org> Message-ID: <074.594f286af4c9906c1aa89f17e0dec45a@wordpress.org> #55272: The New Layout Fix For Plugin Install Page -------------------------------------+------------------------------------- Reporter: sharjeelkhanvmi | Owner: (none) Type: enhancement | Status: reopened Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: ui, css, needs-design-feedback | administration -------------------------------------+------------------------------------- Comment (by joyously): I do not agree that the actionable elements should be moved. The current way is that the title is first (clickable to get to plugin page), followed by the buttons to More Details or Install Now. This is good for visually parsing the page. If you move the buttons to the bottom, the user has more to parse to find the buttons. I think this page is fine. Don't try to fix what is not broken. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 16:58:09 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 16:58:09 -0000 Subject: [wp-trac] [WordPress Trac] #55353: issue in image block in Image size option (was: Theme Twenty-Eleven - issue in image block in Image size option) In-Reply-To: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> References: <054.ce1e9580b6a57fa37ec66387a66965a2@wordpress.org> Message-ID: <069.7a6c6aa6352fda9995bfa25523f73ee8@wordpress.org> #55353: issue in image block in Image size option -----------------------------+-------------------------------- Reporter: kajalgohel | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: Severity: normal | Resolution: reported-upstream Keywords: has-screenshots | Focuses: -----------------------------+-------------------------------- Changes (by sabernhardt): * status: new => closed * component: Themes => Editor * milestone: Awaiting Review => * keywords: needs-patch has-screenshots needs-design-feedback => has- screenshots * resolution: => reported-upstream Comment: Thanks for the report! I see the same with the lowercase ''g'' in "Large" and "Image" in Chrome/Windows. This is a problem with the block editor, not the theme. The GitHub repository already has an issue for it, and it still needs to be fixed there. If you would like to add to the conversation, see: https://github.com/WordPress/gutenberg/issues/27194 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 17:15:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 17:15:12 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.12c6dc2de1cb8a74e898eae20f19046a@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------------------+------------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing needs- | Focuses: design-feedback | -------------------------------------------------+------------------------- Changes (by sabernhardt): * Attachment "55338.3.patch" added. moving `display: inline-block` to (only) the second `.entry-meta` div -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 17:51:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 17:51:50 -0000 Subject: [wp-trac] [WordPress Trac] #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() Message-ID: <058.9be881feebf632f30b5f6d8b3964ad18@wordpress.org> #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() ----------------------------+----------------------------- Reporter: grapplerulrich | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.9 Severity: normal | Keywords: Focuses: | ----------------------------+----------------------------- Now that [https://core.trac.wordpress.org/ticket/46197 #46197] has been patched, `safecss_filter_attr()` can be used instead of `wp_strip_all_tags()`. Introduced in [https://github.com/WordPress/gutenberg/pull/33359 Gutenberg#33359]. https://github.com/WordPress/WordPress/blob/5.9-branch/wp-includes/block- supports/layout.php#L57 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 18:23:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 18:23:40 -0000 Subject: [wp-trac] [WordPress Trac] #55357: Add object_id property to WP_Term class Message-ID: <056.7fe5b6eb2da6e602c92dd9f1fec29be1@wordpress.org> #55357: Add object_id property to WP_Term class --------------------------+------------------------------------------------ Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Keywords: php81 needs-patch needs-unit-tests Focuses: | --------------------------+------------------------------------------------ When calling `get_terms` and `WP_Term_Query` with `fields` equal to `all_with_object_id`, the array of `WP_Term` objects that are returned, also have a `object_id` property set. This property is not defined as part of the class. WordPress should not be defining dynamically properties like this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 18:31:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 18:31:11 -0000 Subject: [wp-trac] [WordPress Trac] #55358: Passing int term term_exists parent param not respected Message-ID: <056.053df80178f2a2e14c198dd898dde7a0@wordpress.org> #55358: Passing int term term_exists parent param not respected -------------------------+------------------------------------------------- Reporter: | Owner: (none) spacedmonkey | Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: Severity: normal | Keywords: needs-patch needs-unit-tests good- Focuses: | first-bug -------------------------+------------------------------------------------- If a developer calls terms_exists, with an int as term and parent as an int, the parent value is not respected. So example this will not work. {{{#!php $term = term_exists( 123, 'category', 1); }}} The code will check to see if term 123 exists, but will ignore parent value. This may result in correct / unexpected results. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 18:33:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 18:33:47 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.10d19f68893854e8260960ab7c5efcd2@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-testing | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): While working on this ticket, I found a weird behaviour. If you pass an int value as the term, parent value is not respected. I have created issue for this behaviour. #55358 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 18:43:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 18:43:08 -0000 Subject: [wp-trac] [WordPress Trac] #14148: wp_get_attachment_url() is not url encoding In-Reply-To: <052.842e78081d022e44455551aa59ca71c3@wordpress.org> References: <052.842e78081d022e44455551aa59ca71c3@wordpress.org> Message-ID: <067.f420145a15716ca80b9c465cbba6fd68@wordpress.org> #14148: wp_get_attachment_url() is not url encoding -------------------------------------------------+------------------------- Reporter: danorton | Owner: | SergeyBiryukov Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Future | Release Component: Media | Version: 3.0 Severity: major | Resolution: Keywords: has-patch needs-testing dev- | Focuses: feedback has-unit-tests | -------------------------------------------------+------------------------- Comment (by Mte90): I did a PR https://github.com/WordPress/wordpress-develop/pull/2377 that include a unit test but just use `àìòù` and I am using `rawurlencode`. Probably can be improved and added more tests but is now open for feedbacks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 19:03:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 19:03:48 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.8b7ade65699487ad67b6d8432638bf92@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info | -------------------------------------------------+------------------------- Comment (by ironprogrammer): Hi, @huskyr: As this ticket addresses a PHP notice, it shouldn't impact site performance or the frontend. If the notice is visible in the admin UI, you could disable `WP_DEBUG` or `WP_DEBUG_DISPLAY` in `wp-config.php`. I'm not aware of a workaround or fix you could apply to the custom theme, but if you wanted the proposed fix sooner than it ships, then you could apply the patch directly. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 19:16:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 19:16:10 -0000 Subject: [wp-trac] [WordPress Trac] #55359: get_option return value wrong Message-ID: <052.f58357c9eaf3e06cc65da3a5859e9bba@wordpress.org> #55359: get_option return value wrong --------------------------------+----------------------------- Reporter: malthert | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Keywords: Focuses: | --------------------------------+----------------------------- https://developer.wordpress.org/reference/functions/get_option/ says it can return scalar including integer, which is false. get_option can only return: bool|null|string|array|object Need to fix in phpdoc and documentation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 19:22:51 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 19:22:51 -0000 Subject: [wp-trac] [WordPress Trac] #55359: get_option return value wrong In-Reply-To: <052.f58357c9eaf3e06cc65da3a5859e9bba@wordpress.org> References: <052.f58357c9eaf3e06cc65da3a5859e9bba@wordpress.org> Message-ID: <067.a97f3c10c8283fb2fbfeedf1b87c2891@wordpress.org> #55359: get_option return value wrong --------------------------------+------------------------------ Reporter: malthert | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------------+------------------------------ Comment (by malthert): EDIT, it's actually: bool|string|array|object -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 20:06:22 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 20:06:22 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.969c1d78b77f0df00c8fc4e03ff442df@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info has-screenshots | -------------------------------------------------+------------------------- Changes (by ironprogrammer): * keywords: has-patch needs-testing has-testing-info => has-patch needs- testing has-testing-info has-screenshots Comment: Adding screenshots that help clarify when these notices would appear. When the menus in question aren't enabled, their underlying markup is still emitted to the page, which triggers the notices. === Screenshots [[Image(https://cldup.com/dDsgVHq1mk.png, 30%)]] ''Classic theme active, with Menus and Widgets support.'' [[Image(https://cldup.com/FvnX8gxkah.png, 30%)]] ''Block theme active (or classic theme w/o Menus and/or Widgets support), which triggers notice(s).'' [[Image(https://cldup.com/E2f4skQfQR.png, 50%)]] ''Example DOM footprint of a disabled `customize-action` with PHP notice (no Customizer widgets support).'' -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 20:13:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 20:13:06 -0000 Subject: [wp-trac] [WordPress Trac] #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() In-Reply-To: <058.9be881feebf632f30b5f6d8b3964ad18@wordpress.org> References: <058.9be881feebf632f30b5f6d8b3964ad18@wordpress.org> Message-ID: <073.f614424b42a1a52bfe46edd444f4c2fb@wordpress.org> #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() ----------------------------+--------------------- Reporter: grapplerulrich | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 Old description: > Now that [https://core.trac.wordpress.org/ticket/46197 #46197] has been > patched, `safecss_filter_attr()` can be used instead of > `wp_strip_all_tags()`. > > Introduced in [https://github.com/WordPress/gutenberg/pull/33359 > Gutenberg#33359]. > > https://github.com/WordPress/WordPress/blob/5.9-branch/wp-includes/block- > supports/layout.php#L57 New description: Now that #46197 has been patched, `safecss_filter_attr()` can be used instead of `wp_strip_all_tags()`. Introduced in [https://github.com/WordPress/gutenberg/pull/33359 Gutenberg#33359]. https://github.com/WordPress/WordPress/blob/5.9-branch/wp-includes/block- supports/layout.php#L57 -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 20:18:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 20:18:04 -0000 Subject: [wp-trac] [WordPress Trac] #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed In-Reply-To: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> References: <048.25aa8f86a7de9a1a0f3e9340346a5763@wordpress.org> Message-ID: <063.f9ce959287c581d88af4c7b38f1572a8@wordpress.org> #55333: PHP Notice in strip_fragment_from_url() when schemeless URI is passed --------------------------+----------------------------- Reporter: dd32 | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Canonical | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+----------------------------- Comment (by SergeyBiryukov): For reference, `strip_fragment_from_url()` was added in [35770] / #19918. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 20:58:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 20:58:27 -0000 Subject: [wp-trac] [WordPress Trac] #55208: WordPress 5.9 on PHP 8.1 In-Reply-To: <061.0ce7a45d468f27bdf6ae05f5e7849b2e@wordpress.org> References: <061.0ce7a45d468f27bdf6ae05f5e7849b2e@wordpress.org> Message-ID: <076.74bd1f195c83fcc2211f67029d1baeb4@wordpress.org> #55208: WordPress 5.9 on PHP 8.1 -------------------------------+------------------------------ Reporter: vbss2018wordpress | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Upgrade/Install | Version: 5.9 Severity: normal | Resolution: Keywords: close | Focuses: -------------------------------+------------------------------ Changes (by jrf): * keywords: php81 => close Comment: Eh.. the MySQL extension was removed from PHP when PHP 7.0 was released. This doesn't sound like an issue with WordPress, but as an issue with a misconfigured hosting account in which the (required) `mysqli` extension has not been enabled (on PHP 8.1 or at all). You may want to have a read through the documentation on installing WordPress: https://wordpress.org/support/article/how-to-install-wordpress/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 20:59:19 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 20:59:19 -0000 Subject: [wp-trac] [WordPress Trac] #55357: Add object_id property to WP_Term class In-Reply-To: <056.7fe5b6eb2da6e602c92dd9f1fec29be1@wordpress.org> References: <056.7fe5b6eb2da6e602c92dd9f1fec29be1@wordpress.org> Message-ID: <071.d0ae095c92ded2830645322e85c79ee0@wordpress.org> #55357: Add object_id property to WP_Term class ------------------------------------------------+-------------------------- Reporter: spacedmonkey | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Taxonomy | Version: Severity: normal | Resolution: Keywords: php82 needs-patch needs-unit-tests | Focuses: ------------------------------------------------+-------------------------- Changes (by jrf): * keywords: php81 needs-patch needs-unit-tests => php82 needs-patch needs- unit-tests -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 21:33:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 21:33:37 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation In-Reply-To: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> References: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> Message-ID: <070.9d0f254da0493e6679a10cba18db16c8@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------+--------------------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: critical | Resolution: Keywords: | Focuses: administration, template --------------------------+--------------------------------------- Comment (by westonruter): I'm also seeing this issue. My WP install is in a subdirectory (using the [https://github.com/GoogleChromeLabs/wordpressdev/ GoogleChromeLabs/wordpressdev] environment). My home URL is `http://wordpressdev.lndo.site/` but my site URL is `https://wordpressdev.lndo.site/core-dev/src/`. When I open the Site Editor at `https://wordpressdev.lndo.site/core- dev/src/wp-admin/site-editor.php` the console gives an error: {{{ Mixed Content: The page at 'https://wordpressdev.lndo.site/core-dev/src /wp-admin/site-editor.php' was loaded over HTTPS, but requested an insecure resource 'http://wordpressdev.lndo.site/core-dev/src/?_wp-find- template=true'. This request has been blocked; the content must be served over HTTPS. }}} The request using HTTP instead of HTTPS is the problem for me. If I try manually going to `https://wordpressdev.lndo.site/core-dev/src/?_wp-find- template=true` then the request succeeds. I haven't been able to pinpoint where the wrong URL scheme is being supplied. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Mar 9 22:37:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 09 Mar 2022 22:37:04 -0000 Subject: [wp-trac] [WordPress Trac] #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data In-Reply-To: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> References: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> Message-ID: <065.39e442c62fce15b0d24fd16336656198@wordpress.org> #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data -------------------------------------+-------------------------- Reporter: jazbek | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 4.9.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Description changed by SergeyBiryukov: Old description: > The show_in_quick_edit property was introduced for taxonomies in 4.2 with > changeset: > > https://core.trac.wordpress.org/changeset/31307 > > This changeset removed the taxonomy from the inline edit form, but the > terms for the taxonomy are still being populated in the data for each row > via the `get_inline_data()` function, which only respects > `$taxonomy->show_ui`. > > One reason people may want to remove a taxonomy from quick edit is for > performance reasons, when the number of terms fore each post are huge. > However, the terms are still being loaded, and the page can take a huge > performance hit. > > For example, I have a custom post type where each one is assigned > thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to > false on the taxonomy, but the post listing was still loading very slow. > I looked at the source code, and saw thousands of zip codes being > rendered in a hidden div on each row. New description: The show_in_quick_edit property was introduced for taxonomies in 4.2 with changeset: [31307]. This changeset removed the taxonomy from the inline edit form, but the terms for the taxonomy are still being populated in the data for each row via the `get_inline_data()` function, which only respects `$taxonomy->show_ui`. One reason people may want to remove a taxonomy from quick edit is for performance reasons, when the number of terms fore each post are huge. However, the terms are still being loaded, and the page can take a huge performance hit. For example, I have a custom post type where each one is assigned thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to false on the taxonomy, but the post listing was still loading very slow. I looked at the source code, and saw thousands of zip codes being rendered in a hidden div on each row. -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 00:14:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 00:14:12 -0000 Subject: [wp-trac] [WordPress Trac] #55360: Add limit to query in WP_Tax_Query Message-ID: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> #55360: Add limit to query in WP_Tax_Query --------------------------+----------------------------- Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.7 Severity: normal | Keywords: Focuses: performance | --------------------------+----------------------------- The call to get_terms in WP_Tax_Query, does not currently have a limit set. This because some taxonomies are hierarchical and could have nested terms. But for none hierarchical taxonomies, a limit can and should be set. This limit will improve query performance and will improve likely of hitting an existing term query cache. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 00:14:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 00:14:14 -0000 Subject: [wp-trac] [WordPress Trac] #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation In-Reply-To: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> References: <055.066d0ca728e3fb5959c659d12bba3c2b@wordpress.org> Message-ID: <070.cdf8502e8cda28d99a1c26c5b9ee4bd7@wordpress.org> #55288: Site Editor on 5.9.1 fails to find homepage template for FSE themes, on WP subdirectory installation --------------------------+--------------------------------------- Reporter: andronocean | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: critical | Resolution: Keywords: | Focuses: administration, template --------------------------+--------------------------------------- Comment (by westonruter): I don't get this issue in Gutenberg, however. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 00:21:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 00:21:24 -0000 Subject: [wp-trac] [WordPress Trac] #55360: Add limit to query in WP_Tax_Query In-Reply-To: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> References: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> Message-ID: <071.73cc328c6b6d35a95bc2e11773318eaa@wordpress.org> #55360: Add limit to query in WP_Tax_Query --------------------------+------------------------------ Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance --------------------------+------------------------------ Changes (by spacedmonkey): * Attachment "Screenshot 2022-03-10 at 00.19.50.png" added. After patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 00:22:00 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 00:22:00 -0000 Subject: [wp-trac] [WordPress Trac] #55360: Add limit to query in WP_Tax_Query In-Reply-To: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> References: <056.8802a9742370e452f3944c3b15dd7b2a@wordpress.org> Message-ID: <071.1c82cf8145d1aba146ff216602ad083b@wordpress.org> #55360: Add limit to query in WP_Tax_Query --------------------------+------------------------------ Reporter: spacedmonkey | Owner: spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Taxonomy | Version: 4.7 Severity: normal | Resolution: Keywords: has-patch | Focuses: performance --------------------------+------------------------------ Changes (by spacedmonkey): * Attachment "Screenshot 2022-03-10 at 00.20.13.png" added. Before patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 01:16:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 01:16:03 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.6ee5d2292b66e70e17ba37a0e614af9d@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch needs-testing has-unit-tests => has-patch needs- testing has-unit-tests commit * owner: (none) => spacedmonkey * status: new => assigned * milestone: Future Release => 6.0 Comment: The [https://github.com/WordPress/wordpress-develop/pull/2367/ linked pull request] looks good for commit. I'll leave you to do the honors @spacedmonkey -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 01:27:04 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 01:27:04 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.0f033dce0f649c2061947f513a71a6c2@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-testing commit | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * keywords: has-patch has-unit-tests needs-dev-note needs-testing => has- patch has-unit-tests needs-dev-note needs-testing commit Comment: Marking this as commit ready for the [https://github.com/WordPress /wordpress-develop/pull/2318 linked pull request], @spacedmonkey are you able to do the honors? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 01:54:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 01:54:18 -0000 Subject: [wp-trac] [WordPress Trac] #53705: Plugin upgrade deletes files from other in-progress upgrades In-Reply-To: <051.3864d53d4c261f039340696626d8cf5c@wordpress.org> References: <051.3864d53d4c261f039340696626d8cf5c@wordpress.org> Message-ID: <066.8edd47fd81a5c1bf2981bbe873d2a1c0@wordpress.org> #53705: Plugin upgrade deletes files from other in-progress upgrades -----------------------------+--------------------- Reporter: bpayton | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+--------------------- Comment (by peterwilsoncc): @bpayton Have you tested the patch you supplied in production on WP.com or did you end up taking another approach/wait for the core fix? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 03:03:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 03:03:21 -0000 Subject: [wp-trac] [WordPress Trac] #54984: wp_update_user doesn't work properly with current user instance In-Reply-To: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> References: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> Message-ID: <066.d28e0f18f7f24c6df7db756ec1acb7de@wordpress.org> #54984: wp_update_user doesn't work properly with current user instance --------------------------+--------------------- Reporter: oztaser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Changes (by peterwilsoncc): * Attachment "54984.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 03:12:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 03:12:36 -0000 Subject: [wp-trac] [WordPress Trac] #54984: wp_update_user doesn't work properly with current user instance In-Reply-To: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> References: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> Message-ID: <066.d64d047be9eb40efe4d19e5cbdd09870@wordpress.org> #54984: wp_update_user doesn't work properly with current user instance --------------------------+--------------------- Reporter: oztaser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by peterwilsoncc): Thanks for providing an mu-plugin as a proof of concept, @oztaser, it was a great help. The bug seems to be caused by the combination of two things: * objects are passed by reference * since 5.8 WP has used the same user object for the current user whenever possible. The result is that in this block of code, the old user data object is no such thing: it's simply a reference to the modified object that has been passed to the function. {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 03:59:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 03:59:50 -0000 Subject: [wp-trac] [WordPress Trac] #55239: Filter hook wp_sitemaps_taxonomies_entry passes Term ID not Object In-Reply-To: <050.d931e8ac6d10c2579ccf77882f678437@wordpress.org> References: <050.d931e8ac6d10c2579ccf77882f678437@wordpress.org> Message-ID: <065.f70b6aaccd5a68c6b61ed3ff983abc9a@wordpress.org> #55239: Filter hook wp_sitemaps_taxonomies_entry passes Term ID not Object -------------------------------------+---------------------------- Reporter: RavanH | Owner: peterwilsoncc Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Sitemaps | Version: 5.9.1 Severity: minor | Resolution: fixed Keywords: has-patch needs-refresh | Focuses: docs -------------------------------------+---------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"52834" 52834]: {{{ #!CommitTicketReference repository="" revision="52834" Sitemaps: Pass term object to `wp_sitemaps_taxonomies_entry` filter. Add a forth parameter to the `wp_sitemaps_taxonomies_entry` filter to pass the entire `WP_Term` object. Correct the documentation for the second parameter of the `wp_sitemaps_taxonomies_entry` filter to indicate it is a term ID rather than term object. Props RavanH, swissspidy, audrasjb. Fixes #55239. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 04:07:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 04:07:18 -0000 Subject: [wp-trac] [WordPress Trac] #53705: Plugin upgrade deletes files from other in-progress upgrades In-Reply-To: <051.3864d53d4c261f039340696626d8cf5c@wordpress.org> References: <051.3864d53d4c261f039340696626d8cf5c@wordpress.org> Message-ID: <066.122d615cdf84c668e4e94bb7fc6e6898@wordpress.org> #53705: Plugin upgrade deletes files from other in-progress upgrades -----------------------------+--------------------- Reporter: bpayton | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Upgrade/Install | Version: 5.8 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+--------------------- Comment (by bpayton): @peterwilsoncc yes, the patch was tested in production on a kind of standalone WP.com site (separate from the large multisite instance run by WP.com). The standalone sites, basically core WP plus a number of platform mu-plugins, are where we were seeing this issue. With the patch applied, we no longer experienced this issue, but because we prefer to run unaltered WP core releases, we did not apply the patch to all sites in production. In the meantime, we were able to reduce this issue enough to live with it. It is a core issue but was greatly exacerbated by Jetpack making concurrent plugin update attempts. Those attempts could conflict with other Jetpack-driven plugin update attempts or core auto update attempts. We addressed this by updating Jetpack to share WP's `auto_updater` lock and adding some other Jetpack-specific locking to avoid conflicts. This evening, I reran [https://core.trac.wordpress.org/ticket/53705#comment:7 the repro instructions] after you messaged and still encountered the errors mentioned in this ticket. After applying the patch, repeatedly rerunning the repro instructions yielded none of the errors. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 05:20:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 05:20:06 -0000 Subject: [wp-trac] [WordPress Trac] #54174: Twenty Twenty-One: @media (prefers-reduced-motion) in sass/07-utilities/a11y.scss breaks some plugins In-Reply-To: <060.0f73c0dd7192c7bf0f4a7f6cce838ac2@wordpress.org> References: <060.0f73c0dd7192c7bf0f4a7f6cce838ac2@wordpress.org> Message-ID: <075.fc24812dc334365306339ca109dd79ad@wordpress.org> #54174: Twenty Twenty-One: @media (prefers-reduced-motion) in sass/07-utilities/a11y.scss breaks some plugins -------------------------------------+------------------------------------- Reporter: gregoiresailland | Owner: peterwilsoncc Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: 5.6 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: ui, accessibility, css -------------------------------------+------------------------------------- Changes (by peterwilsoncc): * owner: (none) => peterwilsoncc * status: new => closed * resolution: => fixed Comment: In [changeset:"52835" 52835]: {{{ #!CommitTicketReference repository="" revision="52835" Twenty Twenty-One: Reverse logic for `prefers-reduced-motion` media query. Reverse the logic of the `prefers-reduced-motion` to enable transitions based on `no-preference` rather than disable them based on the `reduce` preference. This removes the need to disable transitions with the `! important` tag and unintended interactions with plugins as a result. Props gregoiresailland, sabernhardt, ryokuhi. Fixes #54174. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 06:39:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 06:39:27 -0000 Subject: [wp-trac] [WordPress Trac] #55355: Typo in wp_parse_url() description In-Reply-To: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> References: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> Message-ID: <073.511214f154dfd47527b29c4b730eb50a@wordpress.org> #55355: Typo in wp_parse_url() description ---------------------------------------------+----------------------- Reporter: SergeyBiryukov | Owner: audrasjb Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.7 Severity: trivial | Resolution: Keywords: good-first-bug has-patch commit | Focuses: docs ---------------------------------------------+----------------------- Changes (by mukesh27): * keywords: good-first-bug has-patch => good-first-bug has-patch commit * owner: (none) => audrasjb * status: new => assigned Comment: Hi there! The patch looks fine to me and ready to marge in Core. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 06:54:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 06:54:36 -0000 Subject: [wp-trac] [WordPress Trac] #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() In-Reply-To: <058.9be881feebf632f30b5f6d8b3964ad18@wordpress.org> References: <058.9be881feebf632f30b5f6d8b3964ad18@wordpress.org> Message-ID: <073.5eb8e0fce3d80813c6f41e7ce21e0734@wordpress.org> #55356: Use safecss_filter_attr() instead of wp_strip_all_tags() in wp_get_layout_style() ------------------------------+--------------------- Reporter: grapplerulrich | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.9 Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by mukesh27): * keywords: has-patch => has-patch commit Comment: Hi there! Thanks for the ticket and patch. The patch looks good to me. Mark as `commit`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 07:36:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 07:36:34 -0000 Subject: [wp-trac] [WordPress Trac] #55361: WordPress database error Deadlock found when trying to get lock on wp_get_global_styles_svg_filters Message-ID: <051.582d560266492f6fe783d1213d401ddf@wordpress.org> #55361: WordPress database error Deadlock found when trying to get lock on wp_get_global_styles_svg_filters --------------------------+----------------------------- Reporter: BackuPs | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- I don't know where to ask this question but i have these error messages in my log file. The template just calls wp_body_open after the body tag. I can see a filter is added for body open that renders svg filters in the default_filters.php in wordpress. https://share.getcloudapp.com/5zuLpONl https://share.getcloudapp.com/6quZ7Jvz But how do i get rid of these entries in the error log and where are they coming from? It seems that wordpress is triggering these. Can you please advice on how to get rid of these messages in the error log WordPress database error Deadlock found when trying to get lock; try restarting transaction for query DELETE FROM `wp_options` WHERE `option_name` = '_transient_global_styles_svg_filters_champion' made by require('wp-blog-header.php'), require_once('wp-includes/template- loader.php'), include('/themes/champion/template_sections.php'), get_header, locate_template, load_template, require_once('/themes/champion/header.php'), wp_body_open, do_action('wp_body_open'), WP_Hook->do_action, WP_Hook->apply_filters, wp_global_styles_render_svg_filters, wp_get_global_styles_svg_filters, get_transient, delete_option -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 08:57:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 08:57:31 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file Message-ID: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file ---------------------------+--------------------------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: has-screenshots has-patch Focuses: | ---------------------------+--------------------------------------- In the theme Twenty Thirteen, there is an invalid use of float and display inline-block together in the CSS style sheet. {{{ .attachment .entry-title { display: inline-block; float: left; font: 300 italic 30px "Source Sans Pro", Helvetica, sans-serif; margin: 0; } }}} {{{ .comment-reply-title small a { color: #131310; display: inline-block; float: right; height: 16px; overflow: hidden; width: 16px; } }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 08:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 08:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.429cd40d8759ec1d0b4dc0c8225ad390@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file ---------------------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+------------------------------ Changes (by kajalgohel): * Attachment "Screenshot 2022-03-10 at 2.22.27 PM.png" added. display: inline-block property is removed, and design is not breaking. display: none override the display: inline-block property -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:00:01 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:00:01 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.c3978444bab01b22197096107f2348fa@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file ---------------------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+------------------------------ Changes (by kajalgohel): * Attachment "Screenshot 2022-03-10 at 2.19.47 PM.png" added. display: inline-block property is removed, design is not breaking. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:01:08 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:01:08 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.f367964eddef0ad38586959d92cfecd6@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file ---------------------------------------+------------------------------ Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch | Focuses: ---------------------------------------+------------------------------ Changes (by kajalgohel): * Attachment "#55362.patch" added. display: inline-block property is removed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:01:37 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:01:37 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.7a0bf00dd964649aed31c9daf25110f1@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file -------------------------------------------------+------------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by kajalgohel): * keywords: has-screenshots has-patch => has-screenshots has-patch needs- testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:43:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:43:50 -0000 Subject: [wp-trac] [WordPress Trac] #55363: Date Format for Month "F" incorrect when using Site Language of "English (South Africa)" Message-ID: <054.0e74fec27f7bc9afbc6015da8f660b1d@wordpress.org> #55363: Date Format for Month "F" incorrect when using Site Language of "English (South Africa)" --------------------------+----------------------------- Reporter: milkisgood | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- Date Format for Month "F" incorrect when using Site Language of "English (South Africa)" -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:43:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:43:54 -0000 Subject: [wp-trac] [WordPress Trac] #53218: Make apply_filters() variadic In-Reply-To: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> References: <055.a6bc37eac8878e850ce543a48e7ba79c@wordpress.org> Message-ID: <070.abfc226e721e237c7b6dd6c06aa46766@wordpress.org> #53218: Make apply_filters() variadic ------------------------------------------+--------------------- Reporter: johnbillion | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Plugins | Version: 5.3 Severity: normal | Resolution: Keywords: has-patch early dev-feedback | Focuses: ------------------------------------------+--------------------- Comment (by dingo_d): This would be a great addition, especially from the perspective of static analysis tools like PHPStan. Currently, you get tons of false positives when passing more than two arguments, and you need to ignore the rule altogether, which diminishes the use of the tool. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:44:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:44:41 -0000 Subject: [wp-trac] [WordPress Trac] #55363: Date Format for Month "F" incorrect when using Site Language of "English (South Africa)" In-Reply-To: <054.0e74fec27f7bc9afbc6015da8f660b1d@wordpress.org> References: <054.0e74fec27f7bc9afbc6015da8f660b1d@wordpress.org> Message-ID: <069.66d28d0555b37702c11a363bafcd20e1@wordpress.org> #55363: Date Format for Month "F" incorrect when using Site Language of "English (South Africa)" --------------------------+------------------------------ Reporter: milkisgood | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Date/Time | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Changes (by milkisgood): * Attachment "photo_2022-03-10_11-05-43.jpg" added. Note the Month output is incorrect -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:50:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:50:59 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.20c461c9d1c8516ca691dc5f7bc96ebe@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info has-screenshots | -------------------------------------------------+------------------------- Comment (by huskyr): Hey [comment:18 ironprogrammer], thanks for the extensive explanation and screenshots! You're right, i don't see the notice on my production server because WP_DEBUG is indeed disabled there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 09:54:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 09:54:48 -0000 Subject: [wp-trac] [WordPress Trac] #49687: wp_mail() - Why is no envelope sender defined? In-Reply-To: <048.3946f892e5f69f332e0c5196f58bf2c6@wordpress.org> References: <048.3946f892e5f69f332e0c5196f58bf2c6@wordpress.org> Message-ID: <063.6fcea71e7a17d0f564e41063a859cd2f@wordpress.org> #49687: wp_mail() - Why is no envelope sender defined? ----------------------------------------+------------------------------ Reporter: vbbp | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Mail | Version: 5.4 Severity: minor | Resolution: Keywords: dev-feedback needs-testing | Focuses: ----------------------------------------+------------------------------ Comment (by kub1x): Replying to [comment:5 SergeyBiryukov]: > Hi there, welcome to WordPress Trac! Thanks for the report. > > Replying to [ticket:49687 vbbp]: > > Unfortunately, the current implementation of wp_mail() explicitly sets that 3rd parameter to false, which prevents the envelope sender from being set (see https://core.trac.wordpress.org/browser/trunk/src/wp- includes/pluggable.php?rev=47494#L358). > > Just noting that this was an intentional change in [38286] / #37736. Without the envelope sender being set (falling back to some default value), the requests are being rejected. Namely "sezman.cz" and "ovh.net" SMTP servers do reject those messages (log line below). Gmail won't look at the envelope sender and gladly accept the header from the message header. {{{ Mar 10 10:36:52 localhost sm-mta[1763825]: 229JUjTK112345: to=, ctladdr= (33/33), delay=14:06:07, xdelay=00:00:00, mailer=esmtp, pri=7770908, relay=mx2.seznam.cz., dsn=4.0.0, stat=Deferred: 451 4.4.8 Unroutable email address. }}} To me it causes just more harm. Only harm to be correct ;) Removing the false fixes everything in my case. But still have to go with coding it into plugin using the phpmailer_init action to keep the change permanent... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:27:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:27:41 -0000 Subject: [wp-trac] [WordPress Trac] #54953: Custom css variables in theme.json have different keys in 5.9 In-Reply-To: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> References: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> Message-ID: <064.6e795bf485b94999631392dc8f5fa0c7@wordpress.org> #54953: Custom css variables in theme.json have different keys in 5.9 --------------------------+--------------------- Reporter: walbo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by oandregal): WordPress 5.8 had a bug by which front-end styles and editor styles were different. We fixed this in 5.9. See more details at https://github.com/WordPress/gutenberg/issues/39155#issuecomment-1063880553 The plan is to update the devnote for theme.json v2 including this bugfix https://make.wordpress.org/core/2022/01/08/updates-for-settings-styles- and-theme-json/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:46:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:46:18 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements Message-ID: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -----------------------------+----------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: Severity: normal | Keywords: a11y-proximity Focuses: accessibility | -----------------------------+----------------------------- See tracking ticket #40822. See also #45972. In the Quick Edit and Bulk Edit forms, the Submit and Cancel buttons are placed at the opposite sides of the form. As mentioned in the tracking ticket #40822, proximity of related information is an universal design principle which benefits everyone and it's particularly important for users with a reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close each other. For more details and related WCAG recommendations, please see the tracking ticket #40822. The primary action button should be on the left. See the detailed design feedback in https://core.trac.wordpress.org/ticket/40822#comment:9 In #45972 / [44757] the Comment form was changed to align the button on the left. See screenshots: Comment form before: [[Image(http://cldup.com/9vOa-gSotk.png)]] Comment form after: [[Image(http://cldup.com/KymCNBNbsL.png)]] The same change should be implemented for the Quick Edit and Bulk Edit forms. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:54:07 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:54:07 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements In-Reply-To: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> References: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> Message-ID: <066.a0b6b988845efec78a5cc5cec9573c73@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -----------------------------+------------------------------ Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: a11y-proximity | Focuses: accessibility -----------------------------+------------------------------ Changes (by afercia): * Attachment "55364.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:55:56 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:55:56 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements In-Reply-To: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> References: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> Message-ID: <066.893e26352391da69932f3f979285d40c@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -------------------------------------------------+------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: a11y-proximity has-patch has- | Focuses: screenshots | accessibility -------------------------------------------------+------------------------- Changes (by afercia): * keywords: a11y-proximity => a11y-proximity has-patch has-screenshots Comment: [attachment:"55364.diff"] switches the buttons order and aligns them to the left. See screenshots below. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:56:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:56:24 -0000 Subject: [wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids In-Reply-To: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> References: <056.9cb46f772aefbfd9a9c1002a26f3bac6@wordpress.org> Message-ID: <071.a8df4e0935509e81619845e69e5dc3f9@wordpress.org> #37189: In wp_term_query on cache ids -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 4.6 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing has-unit- | Focuses: tests commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"52836" 52836]: {{{ #!CommitTicketReference repository="" revision="52836" Taxonomy: Only store term_ids and object_ids in `WP_Term_Query` query caches. The query cache currently implemented in `WP_Term_Query` caches the final output of the query, depending on what fields are requested. This is wasteful, as if a user requests `fields` => `all`, then an unlimited array of `WP_Term` objects could be stored in the object cache. Instead of storing the whole WP_Term object, this change only the term_id is stored. To get an array the full WP_Term objects, the `_prime_term_caches` function is called with an array of ids. In instances where a persistent object cache is not in use, then this will result in another SQL query to be run. After `_prime_term_caches` is called if this term is requested again in the same page load, then it will already be loaded into memory. If a user runs `WP_Term_Query` with the fields param set to `all_with_object_id`, an array of objects containing both the term_id and object_ids are stored in cache. This change also improves the logic to load term meta caches. This change ensures that term meta is always primed for all terms loaded in the term query. Props Spacedmonkey, boonebgorges, jbpaul17, peterwilsoncc, flixos90, pbearne. Fixes #37189. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:56:36 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:56:36 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements In-Reply-To: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> References: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> Message-ID: <066.2181a98dc873570531d8eee29ea37bc5@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -------------------------------------------------+------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: a11y-proximity has-patch has- | Focuses: screenshots | accessibility -------------------------------------------------+------------------------- Changes (by afercia): * Attachment "quick edit.png" added. Quick edit form with the patch applied. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 10:56:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 10:56:59 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements In-Reply-To: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> References: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> Message-ID: <066.a067593412f7d45d9630ef2a5e615a97@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -------------------------------------------------+------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: a11y-proximity has-patch has- | Focuses: screenshots | accessibility -------------------------------------------------+------------------------- Changes (by afercia): * Attachment "bulk edit.png" added. Bulk edit form with the patch applied. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 11:03:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 11:03:03 -0000 Subject: [wp-trac] [WordPress Trac] #55244: Non-editable title. In-Reply-To: <051.8532326a37a4edd0a95abd16ccccf792@wordpress.org> References: <051.8532326a37a4edd0a95abd16ccccf792@wordpress.org> Message-ID: <066.1d86b9aa12b37ec298453b014833d24f@wordpress.org> #55244: Non-editable title. --------------------------+---------------------------------------- Reporter: krilike | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 5.9.1 Severity: normal | Resolution: Keywords: | Focuses: accessibility, javascript --------------------------+---------------------------------------- Comment (by krilike): Hey @juhise Please try the following steps: 1) Open the post. 2) Add a couple of paragraphs. 3) Important! Click somewhere around here https://prnt.sc/FP8tdoBgjAjc (so as not to touch the text). 4) Press CTRL+A to highlight the paragraphs, as in this screenshot https://prnt.sc/b34gZ8ISRuNG 5) Try to edit the heading. ---- Env: Wordpress 5.9.1 Firefox 97.0.2, Chrome 99.0.4844.51, Opera 84.0.4316.31, Edge 99.0.1150.36 Windows 11 Themes: Twenty Twenty-One, Twenty Twenty-Two Gutenberg Editor Plugins: --- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 11:06:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 11:06:25 -0000 Subject: [wp-trac] [WordPress Trac] #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements In-Reply-To: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> References: <051.0b3191a1c02c5f0ec134d9ee1a128932@wordpress.org> Message-ID: <066.706c29d652c5c3103db9ff5f959ad8fb@wordpress.org> #55364: Proximity of controls: Quick Edit and Bulk Edit forms improvements -------------------------------------------------+------------------------- Reporter: afercia | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Quick/Bulk Edit | Version: Severity: normal | Resolution: Keywords: a11y-proximity has-patch has- | Focuses: screenshots | accessibility -------------------------------------------------+------------------------- Comment (by afercia): Note: props should go also to @landwire who made [https://github.com/WordPress/wordpress-develop/pull/601 a PR on the GitHub repository] a while ago. See ticket:40822#comment:22 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 11:06:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 11:06:48 -0000 Subject: [wp-trac] [WordPress Trac] #55359: get_option return value wrong In-Reply-To: <052.f58357c9eaf3e06cc65da3a5859e9bba@wordpress.org> References: <052.f58357c9eaf3e06cc65da3a5859e9bba@wordpress.org> Message-ID: <067.b3c29e86a79c0081b7295bcafca3ca89@wordpress.org> #55359: get_option return value wrong --------------------------------+------------------------------ Reporter: malthert | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Options, Meta APIs | Version: Severity: normal | Resolution: Keywords: | Focuses: docs --------------------------------+------------------------------ Changes (by johnbillion): * focuses: => docs Comment: This function can return a value of any type because of the `$default` parameter: {{{#!php get_option( 'i_dont_exist', 123 ); }}} The `@return` documentation could do with improvement here but the return types look correct. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 11:25:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 11:25:38 -0000 Subject: [wp-trac] [WordPress Trac] #55355: Typo in wp_parse_url() description In-Reply-To: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> References: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> Message-ID: <073.49ab0e30eb84f59f587e5c25721f4bdf@wordpress.org> #55355: Typo in wp_parse_url() description ---------------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: hellofromTonya Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.7 Severity: trivial | Resolution: Keywords: good-first-bug has-patch commit | Focuses: docs ---------------------------------------------+----------------------------- Changes (by hellofromTonya): * owner: audrasjb => hellofromTonya * status: assigned => reviewing Comment: Hello @mehedi890, Welcome back to WordPress Core Trac. Congrats on your first contribution 🌟 🎉 . Thank you for the patching this ticket. I reviewed and approved [https://github.com/WordPress/wordpress-develop/pull/2397 PR 2397]. As @mukesh27 noted, it's ready for commit. What's the next step? I'll prepare a commit and add your change to the WordPress codebase. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 11:31:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 11:31:40 -0000 Subject: [wp-trac] [WordPress Trac] #55355: Typo in wp_parse_url() description In-Reply-To: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> References: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> Message-ID: <073.a6bacb5bfc2e1def2b44c7027ebea2f7@wordpress.org> #55355: Typo in wp_parse_url() description ---------------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: hellofromTonya Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.7 Severity: trivial | Resolution: Keywords: good-first-bug has-patch commit | Focuses: docs ---------------------------------------------+----------------------------- Comment (by mehedi890): Thank you @hellofromTonya -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 13:08:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 13:08:34 -0000 Subject: [wp-trac] [WordPress Trac] #49412: Store filesize media metadata In-Reply-To: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> References: <048.d8ea2d9b63398331a26540a3bcf35c2c@wordpress.org> Message-ID: <063.403685f6344ede04e7d1e0329ac22da5@wordpress.org> #49412: Store filesize media metadata ---------------------------------------------+--------------------------- Reporter: Cybr | Owner: spacedmonkey Type: feature request | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: performance ---------------------------------------------+--------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"52837" 52837]: {{{ #!CommitTicketReference repository="" revision="52837" Media: Store attachment’s file size in metadata. Store the file size of all newly uploaded attachments, as part of the metadata stored in post meta. Storing file size means, developers will not have to resort to doing `filesize` function calls, that can be time consuming on assets on offloaded to services like Amazon’s S3. This change also introduces a new helper function called, `wp_filesize`. This is a wrapper around the `filesize` php function, that adds some helpful filters and ensures the return value is an integer. Props Cybr, Spacedmonkey, SergeyBiryukov, johnwatkins0, swissspidy, desrosj, joemcgill, azaozz, antpb, adamsilverstein, uday17035. Fixes #49412. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 14:25:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 14:25:57 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.1930134186cc45fe0cd0d4c92ef45cfa@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file -----------------------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch needs-testing | Focuses: -----------------------------------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:39:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:39:25 -0000 Subject: [wp-trac] [WordPress Trac] #49746: Widening WordPress Limits and Compatibility In-Reply-To: <052.fef0b722c86840b055afb9451e70e166@wordpress.org> References: <052.fef0b722c86840b055afb9451e70e166@wordpress.org> Message-ID: <067.d86064f10565bab863382518f65db751@wordpress.org> #49746: Widening WordPress Limits and Compatibility -------------------------------+------------------------------ Reporter: ulike123 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 5.4 Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by antpb): * keywords: has-dev-note => reporter-feedback Comment: Hi @ulike123 ! Thanks for your ticket! We discussed this ticket in the recent media meeting and we were having some difficulty finding the issue you are facing. Which screen are you on when you are seeing the "select image" button? There are several places this may render so I want to make sure we are in alignment. Are you requesting better support of URL targets using the OS file uploader? Could you describe more about how you are using this? Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:46:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:46:55 -0000 Subject: [wp-trac] [WordPress Trac] #49729: Warning: fread() expects parameter 1 to be resource, bool given in \wp-includes\functions.php on line 5785 In-Reply-To: <054.426954a0952c78ec8a20f28e20beb2a7@wordpress.org> References: <054.426954a0952c78ec8a20f28e20beb2a7@wordpress.org> Message-ID: <069.32979b3aa8e386a2721321ac7625784c@wordpress.org> #49729: Warning: fread() expects parameter 1 to be resource, bool given in \wp- includes\functions.php on line 5785 -------------------------------+------------------------------ Reporter: DrLightman | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Plugins | Version: 5.3.2 Severity: minor | Resolution: Keywords: reporter-feedback | Focuses: administration -------------------------------+------------------------------ Changes (by azouamauriac): * keywords: => reporter-feedback Comment: Hello @DrLightman thanks for the report, are you still able to reproduce this one? could you provide the steps to reproduce it? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:48:40 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:48:40 -0000 Subject: [wp-trac] [WordPress Trac] #49779: Add a filter that controls the size of the images on the Attachment pages In-Reply-To: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> References: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> Message-ID: <070.888920c859f7e58ddc1d08700d39b6f2@wordpress.org> #49779: Add a filter that controls the size of the images on the Attachment pages -------------------------+------------------------------ Reporter: pikamander2 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: major | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by joedolson): Is there any reason you can't resolve this problem via either editing or adding an attachments template to your theme? The theme's `attachment.php` template file allows you to pass whatever size you want for the attachment page; I can't see a reason you'd ever need to edit core files for this. More details: https://developer.wordpress.org/themes/template-files- section/attachment-template-files/ If there's something special about the scenario that means you can't solve this within the theme, please provide those details. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:49:23 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:49:23 -0000 Subject: [wp-trac] [WordPress Trac] #49779: Add a filter that controls the size of the images on the Attachment pages In-Reply-To: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> References: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> Message-ID: <070.bde0ddf170df25b3e83b20d347bb3f60@wordpress.org> #49779: Add a filter that controls the size of the images on the Attachment pages -------------------------------+------------------------------ Reporter: pikamander2 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: major | Resolution: Keywords: reporter-feedback | Focuses: -------------------------------+------------------------------ Changes (by joedolson): * keywords: => reporter-feedback -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:49:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:49:32 -0000 Subject: [wp-trac] [WordPress Trac] #49779: Add a filter that controls the size of the images on the Attachment pages In-Reply-To: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> References: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> Message-ID: <070.5283e4e0103f0f8b2b3f76c38872ff30@wordpress.org> #49779: Add a filter that controls the size of the images on the Attachment pages -------------------------------+------------------------------ Reporter: pikamander2 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: major | Resolution: Keywords: reporter-feedback | Focuses: template -------------------------------+------------------------------ Changes (by joedolson): * focuses: => template -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 15:57:25 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 15:57:25 -0000 Subject: [wp-trac] [WordPress Trac] #49830: Store rotation data for uploaded videos In-Reply-To: <056.bf2dffc877d125deb9e118a781e08ecd@wordpress.org> References: <056.bf2dffc877d125deb9e118a781e08ecd@wordpress.org> Message-ID: <071.55b2cc37bdf9bf8a674c1b520115c7c0@wordpress.org> #49830: Store rotation data for uploaded videos --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Future Release Component: Media | Version: Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+----------------------------- Changes (by antpb): * keywords: needs-patch 2nd-opinion => needs-patch * type: defect (bug) => enhancement * milestone: Awaiting Review => Future Release Comment: This sounds like a great enhancement and has prior prescient with the length property in videos. I could see more available meta being super useful. Marking future release for now. If anyone wants to grab this for 6.0 feel free to ping the Media team at any time in #core-media for a review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:00:44 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:00:44 -0000 Subject: [wp-trac] [WordPress Trac] #55355: Typo in wp_parse_url() description In-Reply-To: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> References: <058.e52f7667345cd88706ac3cb46f78749b@wordpress.org> Message-ID: <073.cdaf8e1cbf142f23cf804e6a45d8bf2d@wordpress.org> #55355: Typo in wp_parse_url() description ---------------------------------------------+----------------------------- Reporter: SergeyBiryukov | Owner: hellofromTonya Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: HTTP API | Version: 4.7 Severity: trivial | Resolution: fixed Keywords: good-first-bug has-patch commit | Focuses: docs ---------------------------------------------+----------------------------- Changes (by hellofromTonya): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52838" 52838]: {{{ #!CommitTicketReference repository="" revision="52838" HTTP API: Fix typo in and improve readability of `wp_parse_url()` docblock. Removes the "starting" word from "starting containing" as this is a typo. Includes minor formatting adjustments to improve readability. Follow-up to [38726]. Props mehedi890, SergeyBiryukov, mukesh27. Fixes #55355. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:11:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:11:46 -0000 Subject: [wp-trac] [WordPress Trac] #54843: Add end to end test case for Trash a single post and restore post from trash In-Reply-To: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> References: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> Message-ID: <070.2a6d284d50d1198696a0584da76e89e4@wordpress.org> #54843: Add end to end test case for Trash a single post and restore post from trash ---------------------------------------------+----------------------------- Reporter: pavanpatil1 | Owner: hellofromTonya Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by hellofromTonya): * keywords: has-patch has-unit-tests => has-patch has-unit-tests commit * owner: (none) => hellofromTonya * status: new => reviewing Comment: [https://github.com/WordPress/wordpress-develop/pull/2186 PR 2186] has been approved by @kevin940726 (Thank you Kai!). Marking for commit. Prepping commit now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:27:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:27:11 -0000 Subject: [wp-trac] [WordPress Trac] #54843: Add end to end test case for Trash a single post and restore post from trash In-Reply-To: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> References: <055.17005acbdcc9a6c1a08cd0e490b0b9e0@wordpress.org> Message-ID: <070.e2c29ae926a4274842602d3e60ce122a@wordpress.org> #54843: Add end to end test case for Trash a single post and restore post from trash ---------------------------------------------+----------------------------- Reporter: pavanpatil1 | Owner: hellofromTonya Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests commit | Focuses: ---------------------------------------------+----------------------------- Changes (by hellofromTonya): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52839" 52839]: {{{ #!CommitTicketReference repository="" revision="52839" Build/Test Tools: Add trash and restore of a single post e2e tests. Adds an end-to-end (e2e) test case for: * Emptying a post from the trash. * Restoring a post from the trash. Props pavanpatil1, pooja1210, justinahinon, kevin940726. Fixes #54843. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:30:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:30:35 -0000 Subject: [wp-trac] [WordPress Trac] #54953: Custom css variables in theme.json have different keys in 5.9 In-Reply-To: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> References: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> Message-ID: <064.c928753e0162b4a051209fd064e01381@wordpress.org> #54953: Custom css variables in theme.json have different keys in 5.9 --------------------------+--------------------- Reporter: walbo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by oandregal): As reported upstream the devnote has been updated and this is the correct behavior. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:31:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:31:27 -0000 Subject: [wp-trac] [WordPress Trac] #54953: Custom css variables in theme.json have different keys in 5.9 In-Reply-To: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> References: <049.37a4675c319af99e56ffdbb04ed088bc@wordpress.org> Message-ID: <064.f438d964155df551e0ed7a3855a604ae@wordpress.org> #54953: Custom css variables in theme.json have different keys in 5.9 --------------------------+--------------------- Reporter: walbo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.2 Component: Themes | Version: 5.9 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by oandregal): I'm unable to close the issue. I can mark it as "wontfix" or "worksforme" labels but that feels wrong. Sharing in case anyone can close it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 16:35:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 16:35:34 -0000 Subject: [wp-trac] [WordPress Trac] #49779: Add a filter that controls the size of the images on the Attachment pages In-Reply-To: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> References: <055.52471db82a4c28b8d0e4d61896ad89af@wordpress.org> Message-ID: <070.701f63feff8842e7f92bff12e20c1737@wordpress.org> #49779: Add a filter that controls the size of the images on the Attachment pages -------------------------------+------------------------------ Reporter: pikamander2 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: Severity: major | Resolution: Keywords: reporter-feedback | Focuses: template -------------------------------+------------------------------ Comment (by pikamander2): I'm sure that it's also possible to edit the attachment file directly, but adding a filter here would create a very simple, straightforward way to edit the image sizes that's in line with many of WordPress's other filters. A common use-case is that somebody downloads a theme, generates a child theme for it, and then makes a few simple edits to the child theme's functions.php without ever needing to dig into other files. This also allows them to keep their custom code consolidated in one easy place for easier access/review later on. Not everyone's looking for a total theme overhaul with customized template files. So while it may not be strictly necessary, I do think that it would beneficial for the sake of ease-of-use. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 17:30:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 17:30:20 -0000 Subject: [wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0 In-Reply-To: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> References: <058.7a155b0f785c70523f1d802c18e37284@wordpress.org> Message-ID: <073.575bf0d2dcc1addc6dc530c4b62b1ba5@wordpress.org> #54728: Coding Standards fixes for WP 6.0 ----------------------------+------------------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by davidbaumwald): In [changeset:"52840" 52840]: {{{ #!CommitTicketReference repository="" revision="52840" Coding Standards: Fix minor alignment issue in `wp_ajax_install_theme()`. Follow-up to [52819]. See #54728. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 17:35:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 17:35:03 -0000 Subject: [wp-trac] [WordPress Trac] #54725: Test tool and unit test improvements for 6.0 In-Reply-To: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> References: <058.ef48a8e18f6094886e999723ee87a81d@wordpress.org> Message-ID: <073.1e11ea7d87c409b04745628c5e37c22f@wordpress.org> #54725: Test tool and unit test improvements for 6.0 --------------------------------------+--------------------- Reporter: hellofromTonya | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.0 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by azouamauriac): * Attachment "54725.4.diff" added. Remove some unused variables; some history: [31014]; [29422] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:19:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:19:21 -0000 Subject: [wp-trac] [WordPress Trac] #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data In-Reply-To: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> References: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> Message-ID: <065.b32808551b7ffcec4fffc4a87463d3c5@wordpress.org> #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data -------------------------------------+-------------------------- Reporter: jazbek | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 4.9.1 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+-------------------------- Comment (by SergeyBiryukov): Hi there, welcome back to WordPress Trac! Thanks for the ticket, sorry it took so long for someone to get back to you. The patch does fix the issue in my testing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:19:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:19:33 -0000 Subject: [wp-trac] [WordPress Trac] #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false In-Reply-To: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> References: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> Message-ID: <068.83864c5bde6d1128a1601992438180d7@wordpress.org> #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false -----------------------------+--------------------- Reporter: figureone | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 5.4 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+--------------------- Changes (by SergeyBiryukov): * milestone: Awaiting Review => 6.0 Old description: > Aloha, we discovered that the `show_in_quick_edit` property is not being > checked when populating a post's taxonomy terms in `/wp-admin/edit.php`. > As a consequence, if `show_in_quick_edit` is true, but `show_ui` is false > for a given taxonomy, the Quick Edit UI will not check any of the term > checkboxes, which can result in losing existing terms when a post is > updated via Quick Edit. > > Likely this was just an oversight when `show_in_quick_edit` was > introduced here: > https://core.trac.wordpress.org/changeset/31307 > > And it should be an easy fix to check `show_in_quick_edit` instead of > `show_ui` here: > https://github.com/WordPress/WordPress/blob/5.3.2/wp- > admin/includes/template.php#L343 > https://github.com/WordPress/WordPress/blob/5.3.2/wp- > admin/includes/template.php#L354 > > `show_in_quick_edit` defaults to the value of `show_ui` if it isn't > specified, so this change shouldn't introduce any issues. > https://github.com/WordPress/WordPress/blob/5.3.2/wp-includes/class-wp- > taxonomy.php#L334 > > Our use case: > We have a taxonomy and terms defined in a plugin that is not meant to be > edited in the WordPress UI. However, we do want users to be able to > assign taxonomy terms to posts in the Quick Edit UI. > > Extra details if needed: > When clicking the Quick Edit button, `inline-edit-post.js` refers to the > term divs to mark the correct checkboxes: > https://github.com/WordPress/WordPress/blob/5.3.2/wp-admin/js/inline- > edit-post.js#L305-L316 > Term divs are echoed here: > https://github.com/WordPress/WordPress/blob/5.3.2/wp- > admin/includes/template.php#L343-L364 New description: Aloha, we discovered that the `show_in_quick_edit` property is not being checked when populating a post's taxonomy terms in `/wp-admin/edit.php`. As a consequence, if `show_in_quick_edit` is true, but `show_ui` is false for a given taxonomy, the Quick Edit UI will not check any of the term checkboxes, which can result in losing existing terms when a post is updated via Quick Edit. Likely this was just an oversight when `show_in_quick_edit` was introduced here: [31307]. And it should be an easy fix to check `show_in_quick_edit` instead of `show_ui` here: https://github.com/WordPress/WordPress/blob/5.3.2/wp- admin/includes/template.php#L343 https://github.com/WordPress/WordPress/blob/5.3.2/wp- admin/includes/template.php#L354 `show_in_quick_edit` defaults to the value of `show_ui` if it isn't specified, so this change shouldn't introduce any issues. https://github.com/WordPress/WordPress/blob/5.3.2/wp-includes/class-wp- taxonomy.php#L334 Our use case: We have a taxonomy and terms defined in a plugin that is not meant to be edited in the WordPress UI. However, we do want users to be able to assign taxonomy terms to posts in the Quick Edit UI. Extra details if needed: When clicking the Quick Edit button, `inline-edit-post.js` refers to the term divs to mark the correct checkboxes: https://github.com/WordPress/WordPress/blob/5.3.2/wp-admin/js/inline-edit- post.js#L305-L316 Term divs are echoed here: https://github.com/WordPress/WordPress/blob/5.3.2/wp- admin/includes/template.php#L343-L364 -- Comment: Hi there, welcome back to WordPress Trac! Thanks for the ticket, sorry it took so long for someone to get back to you. The patch does fix the issue in my testing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:20:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:20:49 -0000 Subject: [wp-trac] [WordPress Trac] #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data In-Reply-To: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> References: <050.fc9de16bceda865d19fceb02648cc2ac@wordpress.org> Message-ID: <065.b13b5a9406128d1985c8a8943baeabe6@wordpress.org> #42916: Terms for taxonomy with show_in_quick_edit = false still load in inline data -------------------------------------+----------------------------- Reporter: jazbek | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 4.9.1 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: performance -------------------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52841" 52841]: {{{ #!CommitTicketReference repository="" revision="52841" Quick/Bulk Edit: Check the `show_in_quick_edit` taxonomy property when populating the data for the posts list table. Previously, setting the `show_in_quick_edit` property to `false` removed the taxonomy from the inline edit form, but the terms were still being populated in the data for each table row via the `get_inline_data()` function, which only checked the `$taxonomy->show_ui` property. This commit: * Improves performance by ensuring that taxonomy terms are not unnecessarily populated for each table row when `show_in_quick_edit` is `false`. * Properly populates the taxonomy terms when `show_in_quick_edit` is `true` and `show_ui` is `false`. Follow-up to [31307]. Props jazbek, figureone, sabernhardt, ovidiul, webcommsat, SergeyBiryukov. Fixes #42916, #49701. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:20:49 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:20:49 -0000 Subject: [wp-trac] [WordPress Trac] #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false In-Reply-To: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> References: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> Message-ID: <068.57a4810c85c92e440f61ee99258775bc@wordpress.org> #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false -----------------------------+----------------------------- Reporter: figureone | Owner: SergeyBiryukov Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 5.4 Severity: normal | Resolution: fixed Keywords: | Focuses: -----------------------------+----------------------------- Changes (by SergeyBiryukov): * owner: (none) => SergeyBiryukov * status: new => closed * resolution: => fixed Comment: In [changeset:"52841" 52841]: {{{ #!CommitTicketReference repository="" revision="52841" Quick/Bulk Edit: Check the `show_in_quick_edit` taxonomy property when populating the data for the posts list table. Previously, setting the `show_in_quick_edit` property to `false` removed the taxonomy from the inline edit form, but the terms were still being populated in the data for each table row via the `get_inline_data()` function, which only checked the `$taxonomy->show_ui` property. This commit: * Improves performance by ensuring that taxonomy terms are not unnecessarily populated for each table row when `show_in_quick_edit` is `false`. * Properly populates the taxonomy terms when `show_in_quick_edit` is `true` and `show_ui` is `false`. Follow-up to [31307]. Props jazbek, figureone, sabernhardt, ovidiul, webcommsat, SergeyBiryukov. Fixes #42916, #49701. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:23:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:23:13 -0000 Subject: [wp-trac] [WordPress Trac] #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen In-Reply-To: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> References: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> Message-ID: <065.3b6bca8b88e24256e2c98658452cd81d@wordpress.org> #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen -------------------------------------+------------------------------------- Reporter: pbiron | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has- | Focuses: ui, accessibility, patch needs-testing | javascript -------------------------------------+------------------------------------- Changes (by davidbaumwald): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52842" 52842]: {{{ #!CommitTicketReference repository="" revision="52842" Media: Add a "Copy URL to clipboard" function to the list table view. Previously, a button was added to the modal view for a single media item in the "grid" view to copy the file URL to the user's clipboard. This change adds a similar function to the "list" view for each media item. Follow-up to [48232]. Props pbiron, ravipatel, alexstine, afercia. Fixes #54426. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 18:42:02 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 18:42:02 -0000 Subject: [wp-trac] [WordPress Trac] #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen In-Reply-To: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> References: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> Message-ID: <065.2dcb0aac808c6c23cb5bc1170a2b8e5d@wordpress.org> #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen -------------------------------------+------------------------------------- Reporter: pbiron | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has- | Focuses: ui, accessibility, patch needs-testing | javascript -------------------------------------+------------------------------------- Comment (by davidbaumwald): In [changeset:"52843" 52843]: {{{ #!CommitTicketReference repository="" revision="52843" Media: Note `ClipboardJS` as a global in /js/_enqueues/admin/media.js. Follow-up to [52842]. See #54426. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 19:18:13 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 19:18:13 -0000 Subject: [wp-trac] [WordPress Trac] #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen In-Reply-To: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> References: <050.9285dabd471bc0880785e0ab08880a2b@wordpress.org> Message-ID: <065.aec66d370d46d099d049af55bb67d014@wordpress.org> #54426: Add a "Copy URL to clipboard" row action in Media > Library...similar to the botton on the Edit Media screen -------------------------------------+------------------------------------- Reporter: pbiron | Owner: davidbaumwald Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Media | Version: Severity: normal | Resolution: fixed Keywords: has-screenshots has- | Focuses: ui, accessibility, patch needs-testing needs-dev- | javascript note | -------------------------------------+------------------------------------- Changes (by pbiron): * keywords: has-screenshots has-patch needs-testing => has-screenshots has-patch needs-testing needs-dev-note -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 19:20:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 19:20:06 -0000 Subject: [wp-trac] [WordPress Trac] #53032: Privacy: "Retry" action link on "Export Personal Data" page does not work In-Reply-To: <057.722394d81a0a931a52db81970d332d01@wordpress.org> References: <057.722394d81a0a931a52db81970d332d01@wordpress.org> Message-ID: <072.11cf53247815059071aa64b8f5288473@wordpress.org> #53032: Privacy: "Retry" action link on "Export Personal Data" page does not work -------------------------------------+---------------------------- Reporter: davidbaumwald | Owner: davidbaumwald Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.0 Component: Privacy | Version: Severity: normal | Resolution: fixed Keywords: has-patch needs-testing | Focuses: javascript -------------------------------------+---------------------------- Changes (by davidbaumwald): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"52846" 52846]: {{{ #!CommitTicketReference repository="" revision="52846" Privacy: Fix "Retry" action after a personal data export failure. When exporting personal data for a user request, if the export fails for any reason, a "Retry" link is displayed inline. However, up to this point, clicking this link performed no action. This change adds the `export-personal-data-handle` CSS class to the link to make sure it's picked up by the same delegated listener as the initial action. Clicking this link will now retry the export. Props hellofromTonya, nomnom99, rafiahmedd, SergeyBiryukov, hasanuzzamanshamim. Fixes #53032. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 19:41:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 19:41:12 -0000 Subject: [wp-trac] [WordPress Trac] #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false In-Reply-To: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> References: <053.7075fc8321dab02b14977698926a16e8@wordpress.org> Message-ID: <068.947f17e1810414dd6022a676873b06fa@wordpress.org> #49701: Quick Edit fails to populate taxonomy terms when show_in_quick_edit = true, and show_ui = false -----------------------------+----------------------------- Reporter: figureone | Owner: SergeyBiryukov Type: defect (bug) | Status: reopened Priority: normal | Milestone: 6.0 Component: Quick/Bulk Edit | Version: 5.4 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+----------------------------- Changes (by SergeyBiryukov): * status: closed => reopened * resolution: fixed => Comment: Reopening to review and commit the unit tests from [https://github.com/WordPress/wordpress-develop/pull/205 PR #205]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 19:41:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 19:41:53 -0000 Subject: [wp-trac] [WordPress Trac] #55365: meta field in media via REST API Message-ID: <053.6519fbb86d9b032c7819cebb2bd39452@wordpress.org> #55365: meta field in media via REST API ----------------------------------------+----------------------------- Reporter: millerf01 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: Severity: normal | Keywords: Focuses: javascript, docs, rest-api | ----------------------------------------+----------------------------- Hi there, I found either a bug or a documentation issue. The codex https://developer.wordpress.org/rest-api/reference/media/ refers to a `meta` that is both editable and readable. I am writing a Gutenberg block and wanted to store data in the `meta` field. I am using: {{{ #!div style="font-size: 80%" Code highlighting: {{{#!javascript apiFetch( { path: '/wp/v2/media/' + mediaId, method: 'POST', data: { title: title, description: description, meta: { some_data: "some_value" } } } ) }}} }}} However, it always returns an empty array as `meta` [[Image(https://imgur.com/a/8XcUJ5b)]] I also tried setting some custom field {{{ #!div style="font-size: 80%" Code highlighting: {{{#!javascript register_meta( 'media', 'some_data', array( 'type' => 'string', 'description' => 'Some data', 'single' => true, 'show_in_rest' => true ) ); }}} }}} I eventually tried format the `meta` field I am sending {{{ #!div style="font-size: 80%" Code highlighting: {{{#!javascript meta: [{ some_data: "some_value" }] }}} }}} or {{{ #!div style="font-size: 80%" Code highlighting: {{{#!javascript meta: [{ key: "some_data", value: "some_value" }] }}} }}} But still nothing. Do you have any idea? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 19:43:57 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 19:43:57 -0000 Subject: [wp-trac] [WordPress Trac] #55365: meta field in media via REST API In-Reply-To: <053.6519fbb86d9b032c7819cebb2bd39452@wordpress.org> References: <053.6519fbb86d9b032c7819cebb2bd39452@wordpress.org> Message-ID: <068.3c264f1286c67aea95c60989d6258486@wordpress.org> #55365: meta field in media via REST API --------------------------+----------------------------------------- Reporter: millerf01 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: Severity: normal | Resolution: Keywords: | Focuses: javascript, docs, rest-api --------------------------+----------------------------------------- Comment (by millerf01): Sorry, here is the image I was supposed to have linked up there [[Image(https://i.imgur.com/RyO4eVo.png)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 20:39:35 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 20:39:35 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.a2ccbe29c324ad0bd99cf02a5719dc72@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by paapst): * keywords: close => has-privacy-review 2nd-opinion * status: closed => reopened * resolution: invalid => * severity: normal => major Comment: Hi @fs5ve Thank you for this report. I have reproduced this problem on a website without any additional plugins. I created a new user, with all kinds of extra personal information attached to its profile. After that, I went to "Erase personal data". I entered the username, send the request to erase the data about this user. Then it showed "Erasure completed" and it showed a notice that no personal data was found for this user. Afterwards, I went to the menu item "Export Personal Data", entered the username, and voila... all the information was still there. Conclusion: nothing about this user has been deleted or anonimyzed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 21:39:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 21:39:34 -0000 Subject: [wp-trac] [WordPress Trac] #46982: Avoid loading dot files in the mu-plugins directory. In-Reply-To: <051.62106f23ba5d0cd7316d3b91702de3a5@wordpress.org> References: <051.62106f23ba5d0cd7316d3b91702de3a5@wordpress.org> Message-ID: <066.1b0eab92cc7097747bd1ccc4849fa5e7@wordpress.org> #46982: Avoid loading dot files in the mu-plugins directory. -------------------------------------------------+------------------------- Reporter: dcavins | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Plugins | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by azouamauriac): * keywords: has-patch => has-patch needs-refresh needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 21:41:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 21:41:15 -0000 Subject: [wp-trac] [WordPress Trac] #46982: Avoid loading dot files in the mu-plugins directory. In-Reply-To: <051.62106f23ba5d0cd7316d3b91702de3a5@wordpress.org> References: <051.62106f23ba5d0cd7316d3b91702de3a5@wordpress.org> Message-ID: <066.7ccf33e5d754c44a8e5da9427c4c4f55@wordpress.org> #46982: Avoid loading dot files in the mu-plugins directory. -------------------------------------------------+------------------------- Reporter: dcavins | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Plugins | Version: 2.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by azouamauriac): May be this is related to #41638 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 22:17:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 22:17:43 -0000 Subject: [wp-trac] [WordPress Trac] #55366: WordPress auto-updated plugin with auto-updates disabled Message-ID: <052.f3fd6e11fc81b43131a305be0476583b@wordpress.org> #55366: WordPress auto-updated plugin with auto-updates disabled --------------------------+----------------------------- Reporter: vtxtools | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hello, As there are some updates that can break our site, we have automatic updates disabled for all plugins. Today, the plugin "Woocommerce" updated from version 6.3.0 to 6.3.1 automatically, causing a critical issue on our site. I looked at the changelog for this version, and it appears there was a fix for a security issue. So I am wondering if there is some criteria that would allow an automatic update of a plugin even if automatic updates are disabled. We understand the need to keep plugins up to date, I'm just curious if security was the reason for this unexpected behavior or if it's a bug. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 22:24:29 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 22:24:29 -0000 Subject: [wp-trac] [WordPress Trac] Batch modify: #52409, #54878, #54905, #54916, #54939, ... In-Reply-To: <167.4d84b76e22f33cb3f6d93fe094508063@wordpress.org> References: <167.4d84b76e22f33cb3f6d93fe094508063@wordpress.org> Message-ID: <182.8a9619e626f3d649b0cd7a5e87ea0e2f@wordpress.org> Batch modification to #52409, #54878, #54905, #54916, #54939, #54953, #55015, #55023, #55053, #55117, #55121, #55163, #55172, #55189, #55195, #55203, #55229, #55230, #55231, #55241, #55262 by audrasjb: milestone to 5.9.3 Comment: Moving to milestone 5.9.3 since we're about to release 5.9.2. -- Tickets URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 22:36:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 22:36:50 -0000 Subject: [wp-trac] [WordPress Trac] #55366: WordPress auto-updated plugin with auto-updates disabled In-Reply-To: <052.f3fd6e11fc81b43131a305be0476583b@wordpress.org> References: <052.f3fd6e11fc81b43131a305be0476583b@wordpress.org> Message-ID: <067.a7dd954204b235959f82cc5ab033a44a@wordpress.org> #55366: WordPress auto-updated plugin with auto-updates disabled --------------------------+---------------------- Reporter: vtxtools | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: General | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by Otto42): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: The default setting for auto-updates is not "disabled". The default is to follow the recommendation of the WordPress.org systems. So yes, an automatic update was sent for WooCommerce starting to day for the security issue. https://developer.woocommerce.com/2022/03/10/woocommerce-3-5-10-6-3-1 -security-releases/ WordPress has had auto-updating for plugins since WordPress 3.7. You can read more about this here: https://make.wordpress.org/plugins/2015/03/14 /plugin-automatic-security-updates/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 22:45:55 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 22:45:55 -0000 Subject: [wp-trac] [WordPress Trac] #55366: WordPress auto-updated plugin with auto-updates disabled In-Reply-To: <052.f3fd6e11fc81b43131a305be0476583b@wordpress.org> References: <052.f3fd6e11fc81b43131a305be0476583b@wordpress.org> Message-ID: <067.cccf1432dca5a37497eb0c77bdba8e00@wordpress.org> #55366: WordPress auto-updated plugin with auto-updates disabled --------------------------+---------------------- Reporter: vtxtools | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Plugins | Version: Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by SergeyBiryukov): * component: General => Plugins -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 22:50:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 22:50:43 -0000 Subject: [wp-trac] [WordPress Trac] #53952: Reusable blocks - removing from a page treated as an edit of the re-usable block In-Reply-To: <052.989c7dd361ad4356d4d813c7a1740e19@wordpress.org> References: <052.989c7dd361ad4356d4d813c7a1740e19@wordpress.org> Message-ID: <067.3688bd09b3991e725fcd0ac52e4219a6@wordpress.org> #53952: Reusable blocks - removing from a page treated as an edit of the re-usable block --------------------------+------------------------------ Reporter: jonnie45 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: critical | Resolution: worksforme Keywords: | Focuses: --------------------------+------------------------------ Changes (by maxparsimony): * status: new => closed * resolution: => worksforme Comment: **SOLUTION:** == I had the same problem, it drove me crazy, and I finally found the solution. It seems this is not really a bug, it's just a little cryptic. First, you have to open relevant WordPress page in 'list view' (near top left of screen, select the menu item that looks like a 3-line outline icon). This should open a list of page elements on left of screen. In the list at left of screen, find and select the row (the outline level) that corresponds to the ENTIRE reusable block, not the elements within it (it should be pretty clearly labeled). With that line selected at left, on your content page (at right) you should now see an outline box drawn around the ENTIRE reusable block. Just move your cursor over that outlined block (don't click anything, it's already highlighted). And press your 'delete' key. Also works to click Ctrl-C or Ctrl-X etc. The result is that you still have your reusable block intact, but it is no longer SHOWN on this individual page. Sorry to shill, but I invite you to check out my project to fund a crucial bioinformatics project with NFT 'art sale.' Really cool art and science coming together with two scoops of gratitude: https://cryptosteam.org/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Thu Mar 10 23:01:53 2022 From: noreply at wordpress.org (WordPress Trac) Date: Thu, 10 Mar 2022 23:01:53 -0000 Subject: [wp-trac] [WordPress Trac] #55343: Add Tooltip to "Remember Me" (WP Login Form) In-Reply-To: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> References: <053.b5a11e22532e0c787bec386d453e28ca@wordpress.org> Message-ID: <068.4a2a597e1dbe2fa23bbb57076e8157eb@wordpress.org> #55343: Add Tooltip to "Remember Me" (WP Login Form) ------------------------------------+------------------------------ Reporter: generosus | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: 5.9.1 Severity: normal | Resolution: Keywords: dev-feedback | Focuses: ------------------------------------+------------------------------ Changes (by generosus): * component: Security => Login and Registration -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 03:30:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 03:30:38 -0000 Subject: [wp-trac] [WordPress Trac] #54984: wp_update_user doesn't work properly with current user instance In-Reply-To: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> References: <051.92bddc0d644a48440a60de1fba687faf@wordpress.org> Message-ID: <066.1b425a4b85dd8a3303c4aac6837b86dc@wordpress.org> #54984: wp_update_user doesn't work properly with current user instance --------------------------+--------------------- Reporter: oztaser | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Users | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+--------------------- Comment (by dd32): > However, I am not sure this is an ideal solution as get_userdata() and related functions are pluggable so there is no way of knowing if the data returned by new WP_User( $user_id ) is what is returned by get_userdata(). Thinking out-loud here: If we're only expecting a `WP_User` object in these places/globals, and since we've got a `WP_User::__set()` that takes care of `$user->user_pass = 12345;`, `WP_User` could create a copy of the user-data prior to altering fields values and a `WP_User::has_changed( 'user_pass' )` could be used to detect if the object has changed / what fields have changed. That doesn't take care of a situation where `$user->data->user_pass` is changed directly though. So perhaps [attachment:"54984.diff"] is indeed the ideal way forward. > However, I am not sure this is an ideal solution as get_userdata() and related functions are pluggable so there is no way of knowing if the data returned by new WP_User( $user_id ) is what is returned by get_userdata(). Correct me if I'm wrong, but in those cases, this could've previously been an issue too, right? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 04:16:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 04:16:48 -0000 Subject: [wp-trac] [WordPress Trac] #55367: Requests to the media/edit endpoint are returning a 500 status Message-ID: <053.23a7d2d0c78151cf86a973265c4df7c1@wordpress.org> #55367: Requests to the media/edit endpoint are returning a 500 status --------------------------+----------------------------- Reporter: talldanwp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- The Gutenberg e2e tests seem to have caught a bug with the `media/edit` endpoint. The endpoint is now returning a `500` status for most use cases. Creating a ticket here as I was able to ascertain that it works on a past commit of `wordpress-develop`, but is broken on the latest commit, so it's not a Gutenberg bug. To reproduce: 1. Open the browser dev tools to the network tab 2. In the post editor, add an image block and upload an image 3. Select ‘Crop’ from the toolbar and adjust the zoom on the image 4. Click ‘Apply’ 5. Observe that the request to the media endpoint returns a `500` status -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 04:17:46 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 04:17:46 -0000 Subject: [wp-trac] [WordPress Trac] #55337: Optimize preload paths for post and site editors In-Reply-To: <051.3cc270bd638cb2ab0bbe4aa5931f6c80@wordpress.org> References: <051.3cc270bd638cb2ab0bbe4aa5931f6c80@wordpress.org> Message-ID: <066.d2437a980932eb4130d78bb84b784fa8@wordpress.org> #55337: Optimize preload paths for post and site editors --------------------------+--------------------- Reporter: jsnajdr | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.3 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by noisysocks): * milestone: Awaiting Review => 5.9.3 Comment: Optimistically plopping this in 5.9.3 for if it happens but 6.0 would also be fine. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 04:23:05 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 04:23:05 -0000 Subject: [wp-trac] [WordPress Trac] #55367: Requests to the media/edit endpoint are returning a 500 status In-Reply-To: <053.23a7d2d0c78151cf86a973265c4df7c1@wordpress.org> References: <053.23a7d2d0c78151cf86a973265c4df7c1@wordpress.org> Message-ID: <068.df79d0419b4778b1d1fb8460deb4aca0@wordpress.org> #55367: Requests to the media/edit endpoint are returning a 500 status --------------------------+------------------------------ Reporter: talldanwp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+------------------------------ Comment (by talldanwp): From what I can tell, the bug was introduced with this commit - https://github.com/WordPress/wordpress- develop/commit/7fc225aa87c80680df01a0a82e6bb94b7773a34c. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 04:31:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 04:31:39 -0000 Subject: [wp-trac] [WordPress Trac] #55367: Requests to the media/edit endpoint are returning a 500 status In-Reply-To: <053.23a7d2d0c78151cf86a973265c4df7c1@wordpress.org> References: <053.23a7d2d0c78151cf86a973265c4df7c1@wordpress.org> Message-ID: <068.16d74c4a77cdeabad021384f773dad3f@wordpress.org> #55367: Requests to the media/edit endpoint are returning a 500 status --------------------------+--------------------- Reporter: talldanwp | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: needs-patch | Focuses: --------------------------+--------------------- Changes (by peterwilsoncc): * milestone: Awaiting Review => 6.0 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:02:20 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:02:20 -0000 Subject: [wp-trac] [WordPress Trac] #55362: Twenty Thirteen : Invalid use of display and float together in style.css file In-Reply-To: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> References: <054.d3f65df8f9b9f283e374f26b944ef9ed@wordpress.org> Message-ID: <069.200c9f6a4a99bd7b5254a1aa2c482c38@wordpress.org> #55362: Twenty Thirteen : Invalid use of display and float together in style.css file -----------------------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-screenshots has-patch needs-testing | Focuses: -----------------------------------------------------+--------------------- Changes (by rehanali): * Attachment "#55362.2.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:05:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:05:47 -0000 Subject: [wp-trac] [WordPress Trac] #55338: Twenty Eleven: Invalid use of display and float together in style.css file In-Reply-To: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> References: <054.52ea2b5713d909b9de0cd129fecc2569@wordpress.org> Message-ID: <069.d9d8bb11302380bbfff9e474a737abaa@wordpress.org> #55338: Twenty Eleven: Invalid use of display and float together in style.css file -------------------------------------+--------------------- Reporter: kajalgohel | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.0 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: css -------------------------------------+--------------------- Changes (by rehanali): * Attachment "#55338.4.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:11:38 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:11:38 -0000 Subject: [wp-trac] [WordPress Trac] #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ In-Reply-To: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> References: <051.b532a9e5801b9736d644eef83c48757f@wordpress.org> Message-ID: <066.816f87dc5220a699b88fb35e9cca12c0@wordpress.org> #55257: map_deep() function incompatibility with incomplete objects in PHP 8.0+ ----------------------------+--------------------- Reporter: codex-m | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.0 Component: Formatting | Version: 5.9.1 Severity: major | Resolution: Keywords: has-patch php8 | Focuses: ----------------------------+--------------------- Changes (by rehanali): * Attachment "#55257.patch" added. Added patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:30:16 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:30:16 -0000 Subject: [wp-trac] [WordPress Trac] #38913: Aggregation of contracted and not contracted verb forms (cannot, doesn't)? In-Reply-To: <053.6e82a07ce47cc4d1b857275a22c4d5e2@wordpress.org> References: <053.6e82a07ce47cc4d1b857275a22c4d5e2@wordpress.org> Message-ID: <068.1880ac97a87b39c0f7c1c81e921a18c6@wordpress.org> #38913: Aggregation of contracted and not contracted verb forms (cannot, doesn't)? -------------------------------------------------+------------------------- Reporter: Presskopp | Owner: (none) Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.0 Component: Administration | Version: 4.7 Severity: normal | Resolution: Keywords: good-first-bug has-patch has-unit- | Focuses: ui-copy tests | -------------------------------------------------+------------------------- Comment (by mirkolofio): Replying to [comment:37 azouamauriac]: > this is still good-first-bug? Nice question. I have another one for @audrasjb: Given the huge perimeter of this change, how does a new contributor (like me) know when it's time to give it a boost? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:36:32 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:36:32 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins Message-ID: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------------------------------+------------------------- Reporter: mirkolofio | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Text Changes | Version: 5.9.2 Severity: normal | Keywords: Focuses: javascript, administration, ui-copy | -------------------------------------------------+------------------------- When maintenance mode is active or the server is unresponsive for any reason, there are some ui issues in ajax-related messages like: - When trying to delete a plugin: "Deleting..." forever. No error shown. - When trying to enable auto-updates on a plugin: "Enabling..." forever. "The request could not be completed" error is shown. Same for disabling. - When trying to delete a theme: "Deletion failed: undefined" error shown. - When trying to enable a theme: "Enabling..." forever. "The request could not be completed." error shown. Same for disabling. Check the screenshots attached below. I tried to stay short in title description but I'm not sure it's 100% clear. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:37:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:37:21 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.b42e4dae4409a5a313af08e4045ae80c@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by mirkolofio): * Attachment "Screenshot 2022-03-11 at 06.02.39.png" added. Plugin delete failure -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:37:42 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:37:42 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.2792391feed5b648dcc682b8bd380df6@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by mirkolofio): * Attachment "Screenshot 2022-03-11 at 06.02.02.png" added. Plugin enable auto-updates failure -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:37:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:37:59 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.aace0a1fe7478305cb1dfe1c93704898@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by mirkolofio): * Attachment "Screenshot 2022-03-11 at 06.01.15.png" added. Theme delete failure -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:38:18 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:38:18 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.23e660aa04d5da18bf316c31c709f6c0@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by mirkolofio): * Attachment "Screenshot 2022-03-11 at 06.00.57.png" added. Theme enable failure -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:40:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:40:33 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.aee1d186f63b6999f23c28c57c03e75f@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: new (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Comment (by mirkolofio): > - When trying to delete a plugin: "Deleting..." forever. No error shown. There an error there: "Deletion failed: Briefly unavailable for scheduled maintenance. Check back in a minute." It's on the top of the page, I missed it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 05:45:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 05:45:10 -0000 Subject: [wp-trac] [WordPress Trac] #55369: Block styles preview are unstyled since 5.9 if styles are in a global editor styles css Message-ID: <051.5ede700cf0456f967f7dd00194ce2be4@wordpress.org> #55369: Block styles preview are unstyled since 5.9 if styles are in a global editor styles css --------------------------+----------------------------- Reporter: JohnDBB | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 5.9.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Hello, Block stlyes registered with {{{ wp.blocks.registerBlockStyle( 'acf/featured-news', { name: 'featured-news-black', label: 'Featured news black', isDefault: false, } ); }}} Editor stylesheet enqueued with: {{{ function legit_block_editor_styles() { wp_enqueue_style( 'legit-editor-styles', get_theme_file_uri( '/style-editor.css' ), false, '11.0', 'all' ); } add_action( 'enqueue_block_editor_assets', 'legit_block_editor_styles' ); }}} Since WordPress 5.9 the iframe that shows the block styles show them unstyled as doesn't include the style-editor.css Thank you -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 06:29:26 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 06:29:26 -0000 Subject: [wp-trac] [WordPress Trac] #55370: Enable aria-controls and aria-expanded in content Message-ID: <051.dc03991af641b6ff50232695165f265e@wordpress.org> #55370: Enable aria-controls and aria-expanded in content -----------------------------+----------------------------- Reporter: crs1138 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Role/Capability | Version: 5.8.3 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- We have created a custom collapsible block, but the Gutenberg validation fails as the `aria-controls` and `aria-expanded` attributes are stripped from the saved content if the block is used by a user with role below _super administrator_. Could these attributes be added to the list of allowed attributes? Our problem is described in more detail at https://github.com/WordPress/gutenberg/issues/39351 at @ocean90 recommended opening a ticket in Trac. Similar topic has been discussed at https://core.trac.wordpress.org/ticket/30421 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:40:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:40:06 -0000 Subject: [wp-trac] [WordPress Trac] #54905: PHP notice while accessing Customizer In-Reply-To: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> References: <051.9c2a17d74e4bb75a06812a0d838fa122@wordpress.org> Message-ID: <066.7b8652d6cc3d727c72d86ca2d9a34731@wordpress.org> #54905: PHP notice while accessing Customizer -------------------------------------------------+------------------------- Reporter: Boniu91 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 5.9.3 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch needs-testing has- | Focuses: testing-info has-screenshots | -------------------------------------------------+------------------------- Comment (by azouamauriac): Hi there, to reproduce the issue you should follow this step: ''WordPress 5.9 hides the Customize menu item, if you are using a Full Site Editing theme, so you need to then access the /wp-admin/customize.php address manually to fully test this out.'' as per this slack chat [https://wordpress.slack.com/archives/C02RQBWTW/p1645644792576189] Replying to [comment:14 rafiahmedd]: > @Boniu91 couldn't reproduce the same issue in my environment. Which version of PHP you are running? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:58:39 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:58:39 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.4ed99144b4d486dbe61661a101ae7f49@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "exported_data.png" added. Exported File -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:58:48 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:58:48 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.0b16cf64f5d636454a1c58131353cf33@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_creation.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:58:54 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:58:54 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.fe516dff348fdc08fb0fb2820dc3b609@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_creation_console.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:58:59 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:58:59 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.fea907e69db8ca07c8ccf2689f221dbe@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_creation_database.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:59:06 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:59:06 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.7d5437f7862cf48ba70be6d7af098054@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_data_export_after_deletion.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:59:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:59:14 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.4460f2a80d077598203eb6174c71320c@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_db_still_exist.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:59:24 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:59:24 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.b7caf0b91daa1a5e9f91629b1e84e224@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_deletion_console.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 07:59:33 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 07:59:33 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.59ee26101b84e814eaa7ab4cd4e1e2d1@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Changes (by fs5ve): * Attachment "user_export_data.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 08:09:50 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 08:09:50 -0000 Subject: [wp-trac] [WordPress Trac] #55346: Problem in GDPR regulations provided by core wordpress In-Reply-To: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> References: <049.4665d62de08e126c2717ba46a53dea64@wordpress.org> Message-ID: <064.1ca41d9d0b74bfa9b273d4470e5cc99b@wordpress.org> #55346: Problem in GDPR regulations provided by core wordpress --------------------------------------------+----------------------- Reporter: fs5ve | Owner: (none) Type: defect (bug) | Status: reopened Priority: normal | Milestone: Component: Privacy | Version: 5.9 Severity: major | Resolution: Keywords: has-privacy-review 2nd-opinion | Focuses: --------------------------------------------+----------------------- Comment (by fs5ve): Hi @johnbillion , @swissspidy , It actually doesn't depend on the installed plugin. Sorry I wrote the description in a way which mislead you. I have uploaded some screenshots showing the problem of data deletion and export. In summary the problem can be reproduced by following- 1. Register a new user (say it is dummyuser). I tried with subscriber role, but I believe the problem is not related to the user role. While registering I provided first name and lastname, also email and password. 2. Later from the tools -> export personal data, I have exported the data related to dummyuser. 3. Then I make a request to delete data for this user. And in the console, it says "No Personal Data is found for this user". 4. Again, I make a export request for dummyuser. 5. It generated a export.json file which contains the same data as before the deletion. To me, it seems like the data deletion in the WordPress is not working as it supposed to be. May be you can try to follow the above step to re- create the problem. If you are not able to re-produce it let me know. Note that, during the whole process, I haven't installed/activated any other plugins/themes. Hi @paapst , Thanks for letting us know that you were able to reproduce the problem. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 09:02:41 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 09:02:41 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.495c64ad159cc9e411517b9ccec40f0d@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: closed (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: invalid Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by azouamauriac): * status: new => closed * resolution: => invalid Comment: Hello there, welcome to WordPress's trac! Thanks for the report, this seems to be an expected behavior. If you think I'm wrong feel free to reopen the ticket and may be explain more deeply what's the bug. Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 09:05:10 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 09:05:10 -0000 Subject: [wp-trac] [WordPress Trac] #27316: Add search for favourite plugins In-Reply-To: <054.22ffcffc5fa2449f3964b1103c021677@wordpress.org> References: <054.22ffcffc5fa2449f3964b1103c021677@wordpress.org> Message-ID: <069.eb817cc2c0127d668ad3cacdff6f00ae@wordpress.org> #27316: Add search for favourite plugins -------------------------------------+----------------------------- Reporter: mirkolofio | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Component: Plugins | Version: 3.8 Severity: normal | Resolution: Keywords: has-patch needs-refresh | Focuses: administration -------------------------------------+----------------------------- Changes (by azouamauriac): * keywords: has-patch => has-patch needs-refresh -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 09:28:47 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 09:28:47 -0000 Subject: [wp-trac] [WordPress Trac] #55370: Enable aria-controls and aria-expanded in content In-Reply-To: <051.dc03991af641b6ff50232695165f265e@wordpress.org> References: <051.dc03991af641b6ff50232695165f265e@wordpress.org> Message-ID: <066.f9a532e154322f2c1b78a23bf5b3b6f1@wordpress.org> #55370: Enable aria-controls and aria-expanded in content -------------------------+------------------------------ Reporter: crs1138 | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: 5.8.3 Severity: normal | Resolution: Keywords: | Focuses: accessibility -------------------------+------------------------------ Changes (by sabernhardt): * focuses: => accessibility * component: Role/Capability => Formatting Old description: > We have created a custom collapsible block, but the Gutenberg validation > fails as the `aria-controls` and `aria-expanded` attributes are stripped > from the saved content if the block is used by a user with role below > _super administrator_. > > Could these attributes be added to the list of allowed attributes? > > Our problem is described in more detail at > https://github.com/WordPress/gutenberg/issues/39351 at @ocean90 > recommended opening a ticket in Trac. > > Similar topic has been discussed at > https://core.trac.wordpress.org/ticket/30421 New description: We have created a custom collapsible block, but the Gutenberg validation fails as the `aria-controls` and `aria-expanded` attributes are stripped from the saved content if the block is used by a user with role below ''super administrator''. Could these attributes be added to the list of allowed attributes? Our problem is described in more detail at [https://github.com/WordPress/gutenberg/issues/39351 Gutenberg issue 39351] and @ocean90 recommended opening a ticket in Trac. Similar topic has been discussed at Trac #30421 -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 09:53:03 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 09:53:03 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.8729dba936939baaae24205243f16548@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: reopened (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Changes (by mirkolofio): * status: closed => reopened * resolution: invalid => Comment: Reopening this. It's not expected at all, let me better explain. Example on **Plugin enable auto-updates failure** Current behaviour: - Button switched to "Deleting..." forever - Error message shown: "The request could not be completed" Expected behavior: - Button switched to "Deleting..." - Error message should be: "The request could not be completed. Please retry." - The button should be switched back to "Delete" Another example on **Theme delete failure** Current behaviour: - Error message shown "Deletion failed: undefined" Expected behaviour: - At least we don't want to show "undefined" for sure. And so on... -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 09:55:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 09:55:15 -0000 Subject: [wp-trac] [WordPress Trac] #55368: Handle ajax failure when doing actions on themes/plugins In-Reply-To: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> References: <054.f09904b6870ad85efc4f0b5be93db193@wordpress.org> Message-ID: <069.cdca182f0bc1c8612c4576c7c87d59dc@wordpress.org> #55368: Handle ajax failure when doing actions on themes/plugins -------------------------+------------------------------------------------- Reporter: mirkolofio | Owner: (none) Type: defect | Status: reopened (bug) | Priority: normal | Milestone: Awaiting Review Component: Text | Version: 5.9.2 Changes | Severity: normal | Resolution: Keywords: | Focuses: javascript, administration, ui- | copy -------------------------+------------------------------------------------- Comment (by mirkolofio): Since maintenance is frequently due because of a plugin/theme/core update in progress and it's usually a matter of seconds, the messages should be clear enough to permit the user to retry just a second later. Please not that if you click on the "Deleting..." button once again it works, it's not a matter of feature though, it's just some bad/confusing UI/UX. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 10:58:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 10:58:15 -0000 Subject: [wp-trac] [WordPress Trac] #55371: HTML code in page title causes error in Dashboard Message-ID: <052.c11ca67039be4565b142110a6999ad86@wordpress.org> #55371: HTML code in page title causes error in Dashboard -------------------------------+----------------------------- Reporter: ecparkin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Keywords: Focuses: | -------------------------------+----------------------------- Whenever I try to edit a few of my pages that have some HTML code as part of their title - in order to have an image/logo to appear with the title and change the color of one word of the title - I get the error message attached. When I remove the HTML code with a img src= from the title, the page can be edited as usual again. Any other pages where I did not place some code as part of the title work as expected. This error only started happening in the last two weeks or so, possibly related to the recent WordPress update? When I click on "Copy Error" - here is the output: TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'. at se (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:21283) at ae (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:20218) at ge (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:21723) at he (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:22161) at x (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:33710) at L (https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:34956) at https://c0.wp.com/c/5.9.1/wp-includes/js/dist/rich- text.min.js:2:36207 at https://c0.wp.com/c/5.9.1/wp-includes/js/dist/compose.min.js:2:6078 at A (https://c0.wp.com/c/5.9.1/wp- includes/js/dist/compose.min.js:2:9347) at https://c0.wp.com/c/5.9.1/wp-includes/js/dist/compose.min.js:2:9803 Thanks. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 10:58:43 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 10:58:43 -0000 Subject: [wp-trac] [WordPress Trac] #55371: HTML code in page title causes error in Dashboard In-Reply-To: <052.c11ca67039be4565b142110a6999ad86@wordpress.org> References: <052.c11ca67039be4565b142110a6999ad86@wordpress.org> Message-ID: <067.84b5accb5c68de088e5d355fd8f49873@wordpress.org> #55371: HTML code in page title causes error in Dashboard -------------------------------+------------------------------ Reporter: ecparkin | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 5.9.2 Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Changes (by ecparkin): * Attachment "Screenshot 2022-03-11 115709.jpg" added. Dashboard error when trying to edit page with HTML code in page title -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:05:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:05:17 -0000 Subject: [wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally In-Reply-To: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> References: <056.1a2e8f10898bbe1a60a5bf48d1b66f05@wordpress.org> Message-ID: <071.ea3eb26df25939454094dc7544d78c9d@wordpress.org> #36949: Term exists should use get_terms internally -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: | spacedmonkey Type: enhancement | Status: closed Priority: normal | Milestone: 6.0 Component: Taxonomy | Version: 2.3 Severity: normal | Resolution: fixed Keywords: has-patch has-unit-tests needs-dev- | Focuses: note needs-testing commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * status: assigned => closed * resolution: => fixed Comment: In [changeset:"52921" 52921]: {{{ #!CommitTicketReference repository="" revision="52921" Taxonomy: Use `get_terms` instead of a database lookup in `term_exists()`. Replace raw SQL queries to the terms table, with a call to the `get_terms` function. Using `get_terms` means that `term_exists` is now cached. For developers using `term_exists` where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached. Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc. Fixes #36949. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:10:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:10:11 -0000 Subject: [wp-trac] [WordPress Trac] #55258: No child pages indication after sorting the pages in the admin page list In-Reply-To: <055.44ad2f59a2eda190cd1ccd7f1e802803@wordpress.org> References: <055.44ad2f59a2eda190cd1ccd7f1e802803@wordpress.org> Message-ID: <070.071f42fa069dc68e1cd8cd2c9a22a762@wordpress.org> #55258: No child pages indication after sorting the pages in the admin page list -------------------------------+--------------------------------- Reporter: askaryabbas | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Posts, Post Types | Version: 5.9.1 Severity: normal | Resolution: duplicate Keywords: has-screenshots | Focuses: ui, administration -------------------------------+--------------------------------- Comment (by askaryabbas): Sure, thank you. Replying to [comment:1 SergeyBiryukov]: > Hi there, welcome back to WordPress Trac! Thanks for the ticket. > > This was previously raised in #29640, that ticket is currently closed but can be reopened if there is consensus on a path forward. Let's continue the discussion there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:30:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:30:15 -0000 Subject: [wp-trac] [WordPress Trac] #55372: Use tax_query in wp_get_nav_menu_items Message-ID: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> #55372: Use tax_query in wp_get_nav_menu_items --------------------------+----------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: 3.0 Severity: normal | Keywords: Focuses: performance | --------------------------+----------------------------- Remove usage of `get_objects_in_term` and replace with a tax_query. This adds a level of consistency and will improve caching. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:36:15 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:36:15 -0000 Subject: [wp-trac] [WordPress Trac] #55372: Use tax_query in wp_get_nav_menu_items In-Reply-To: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> References: <056.12d558db7e95d8b127f9b8e74452a479@wordpress.org> Message-ID: <071.1f63316142fd642f8d351370f5c8337d@wordpress.org> #55372: Use tax_query in wp_get_nav_menu_items -------------------------------------------------+------------------------- Reporter: spacedmonkey | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting | Review Component: Menus | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch needs-unit-tests good- | Focuses: first-bug | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: => has-patch needs-unit-tests good-first-bug Comment: Created a PR [https://github.com/WordPress/wordpress-develop/pull/2399 #2399] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:38:17 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:38:17 -0000 Subject: [wp-trac] [WordPress Trac] #55373: Attachment template: Rename from "Media" to "Attachment" Message-ID: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> #55373: Attachment template: Rename from "Media" to "Attachment" -------------------------+----------------------------- Reporter: scruffian | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- This came up in https://github.com/WordPress/gutenberg/pull/39353. Theme Authors might find the name "Attachment" easier to understand because of how it relates to the template hierarchy. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:38:34 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:38:34 -0000 Subject: [wp-trac] [WordPress Trac] #55373: Attachment template: Rename from "Media" to "Attachment" In-Reply-To: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> References: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> Message-ID: <068.e0d725d05592b29953afd0f103b2e8a5@wordpress.org> #55373: Attachment template: Rename from "Media" to "Attachment" -------------------------+------------------------------ Reporter: scruffian | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Changes (by scruffian): * Attachment "patch.diff" added. Text change -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:39:27 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:39:27 -0000 Subject: [wp-trac] [WordPress Trac] #55373: Attachment template: Rename from "Media" to "Attachment" In-Reply-To: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> References: <053.5badf15f4756f2e0685d9e3287845d07@wordpress.org> Message-ID: <068.c70c9c91e3d72709289d52bbd3e6641d@wordpress.org> #55373: Attachment template: Rename from "Media" to "Attachment" -------------------------+------------------------------ Reporter: scruffian | Owner: (none) Type: enhancement | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Changes (by scruffian): * Attachment "patch.2.diff" added. Remove unconnected changed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:41:11 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:41:11 -0000 Subject: [wp-trac] [WordPress Trac] #55374: Site Editor Templates: Fix typo Message-ID: <053.56ba7b66ce6128aee09f00202c5e4103@wordpress.org> #55374: Site Editor Templates: Fix typo --------------------------+----------------------------- Reporter: scruffian | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- There is a typo in the description of the tag template. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 11:41:21 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 11:41:21 -0000 Subject: [wp-trac] [WordPress Trac] #55374: Site Editor Templates: Fix typo In-Reply-To: <053.56ba7b66ce6128aee09f00202c5e4103@wordpress.org> References: <053.56ba7b66ce6128aee09f00202c5e4103@wordpress.org> Message-ID: <068.615f56f20d13895928b730779b87ad9d@wordpress.org> #55374: Site Editor Templates: Fix typo --------------------------+------------------------------ Reporter: scruffian | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by scruffian): * Attachment "patch.diff" added. Fixes a typo -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 13:00:31 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 13:00:31 -0000 Subject: [wp-trac] [WordPress Trac] #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 In-Reply-To: <053.464f3453501834c73527d32600b297e3@wordpress.org> References: <053.464f3453501834c73527d32600b297e3@wordpress.org> Message-ID: <068.4dd678af951d2c823074200af511418f@wordpress.org> #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 --------------------------------------+----------------------------- Reporter: javorszky | Owner: johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: Future Release Component: Database | Version: Severity: major | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+----------------------------- Comment (by johnbillion): Replying to [comment:20 xParham]: > Hey @johnbillion, can we also maybe add `count` as an option for the `fields` query parameter Interesting idea! I'll open a follow-up ticket for that so we keep this one focused. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 13:03:12 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 13:03:12 -0000 Subject: [wp-trac] [WordPress Trac] #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 In-Reply-To: <053.464f3453501834c73527d32600b297e3@wordpress.org> References: <053.464f3453501834c73527d32600b297e3@wordpress.org> Message-ID: <068.32fe70e73d0a2ad65a2b22d6b6896fa2@wordpress.org> #47280: SQL_CALC_FOUND_ROWS is deprecated as of MySQL 8.0.17 --------------------------------------+----------------------------- Reporter: javorszky | Owner: johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: Future Release Component: Database | Version: Severity: major | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+----------------------------- Comment (by johnbillion): Replying to [comment:21 misterwebdeveloper]: Thanks for the comment. I don't think any of this is relevant to this particular ticket, which is about implementing the MySQL change into the WordPress software. Cheers! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Fri Mar 11 13:16:14 2022 From: noreply at wordpress.org (WordPress Trac) Date: Fri, 11 Mar 2022 13:16:14 -0000 Subject: [wp-trac] [WordPress Trac] #55375: Element