[wp-trac] [WordPress Trac] #56095: Remove unnecessary Slack workflow runs for old branches

WordPress Trac noreply at wordpress.org
Thu Jun 30 14:05:43 UTC 2022


#56095: Remove unnecessary Slack workflow runs for old branches
------------------------------+-----------------------
 Reporter:  desrosj           |       Owner:  desrosj
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  6.1
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------

Comment (by desrosj):

 In [changeset:"53591" 53591]:
 {{{
 #!CommitTicketReference repository="" revision="53591"
 Build/Test Tools: Remove the `workflow_run` event from the Slack
 notification workflow.

 The `workflow_run` event was added to restore Slack notifications for
 older branches (5.8 and older) without having to backport any changes
 while alternate approaches were explored.

 The workflow has been tested and refined as a reusable one in `trunk`, and
 this approach is superior to the `workflow_run` event in several ways.

 Primarily, the `workflow_run` event results in a separate workflow run
 being created for sending Slack notifications after the completion of each
 workflow triggered by `push`. When called as a reusable workflow, this
 does not happen and the additional jobs are instead added to the initial
 workflow. This makes which jobs are sending notifications for the current
 workflow more clear, and reduces the amount of noise (less workflow runs
 overall).

 The `workflow_run` event also makes some data available in different ways
 than `push` events. By removing it, much of the logic within the workflow
 can be simplified.

 See #56095.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56095#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list