[wp-trac] [WordPress Trac] #56095: Remove unnecessary Slack workflow runs for old branches

WordPress Trac noreply at wordpress.org
Wed Jun 29 13:49:08 UTC 2022


#56095: Remove unnecessary Slack workflow runs for old branches
------------------------------+-----------------------
 Reporter:  desrosj           |      Owner:  desrosj
     Type:  task (blessed)    |     Status:  assigned
 Priority:  normal            |  Milestone:  6.1
Component:  Build/Test Tools  |    Version:
 Severity:  normal            |   Keywords:  has-patch
  Focuses:                    |
------------------------------+-----------------------
 In [51934], Slack notifications for GitHub Action workflows were restored
 for older branches. This was done by adding the `workflow_run` event to
 the Slack workflow in `trunk`, which restored notifications without having
 to backport anything.

 While this works, one downfall of this method is a
 [https://github.com/WordPress/wordpress-develop/actions/workflows/slack-
 notifications.yml separate workflow run is created to send notifications]
 for every qualifying workflow that completes. This means there are 2
 workflows for every one that runs instead of 1.

 It also makes it difficult to track which Slack workflow belongs to a
 normal workflow run.

 The Slack workflow is a [https://docs.github.com/en/actions/using-
 workflows/reusing-workflows reusable one] and when used this way, the
 notifications are done as a part of the original workflow. The 5.9 branch
 and newer have used it in this way instead on the `workflow_run` event,
 and it has worked well.

 Let's backport this to the older branches to help limit the noise caused
 by excessive workflow runs and to simplify the Slack notifications
 workflow by eliminating any logic specific to the `workflow_run` event
 (which has data passed in different ways).

 The original work for making the Slack notification workflow a reusable
 one was done as part of #53363, and initially introduced in [51921].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56095>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list