[wp-trac] [WordPress Trac] #56076: Incorrect Status when deactivating a site on multisite.

WordPress Trac noreply at wordpress.org
Mon Jun 27 18:10:30 UTC 2022


#56076: Incorrect Status when deactivating a site on multisite.
--------------------------------+------------------------------
 Reporter:  richardkrone        |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:  6.0
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by ideag):

 When one clicks the "Deactivate" link, two things actually happen in the
 code:
 {{{#!php
 do_action( 'deactivate_blog', $id );
 update_blog_status( $id, 'deleted', '1' );
 }}}
 So the blog is actually marked as `deleted` and thus displayed as such.

 When one clicks on the "Delete" link, `wpmu_delete_blog()` is called under
 the hood, and the site is fully deleted from the database and does not
 show up in the site list at all.

 I guess this falls under "naming things is hard" banner. Or, rather, under
 "re-naming things is even harder" banner. What used to be called 'Deleted'
 now is deactivated, but not all text strings have been updated. One part
 of this is updating the UI strings, which is easy enough, another part
 could be renaming the actual flag under the hood. That is a different can
 of worms and might not be worth the effort.

 I'll try to create a patch for the first part next week.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56076#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list